Don't kfree_skb() after submitting the repurposed SKB
authornorly <ny-git@enpas.org>
Sat, 18 Jun 2022 01:18:21 +0000 (03:18 +0200)
committernorly <ny-git@enpas.org>
Sat, 18 Jun 2022 01:19:08 +0000 (03:19 +0200)
If can327 locks up your machine, but only in very specific situations,
this is probably why. The memory leak fix went too far, and I missed
the call to can327_feed_frame_to_netdev() before a return -ENODATA.

Fixes: 37111be717212b8c7779978c0385393c2d51747d
module/can327.c

index 3572cfbeddbde30433b3f9e19c23777949d4ea4a..ae4d3c17bda1eadb541b789bcfb998c4f0b3f6b5 100644 (file)
@@ -518,7 +518,6 @@ static int can327_parse_frame(struct can327 *elm, size_t len)
                 * However, this will correctly drop the state machine back into
                 * command mode.
                 */
-               kfree_skb(skb);
                return -ENODATA;
        }