summaryrefslogtreecommitdiff
path: root/module
diff options
context:
space:
mode:
authornorly <ny-git@enpas.org>2022-06-18 03:18:21 +0200
committernorly <ny-git@enpas.org>2022-06-18 03:19:08 +0200
commite1a93edd065ef8888d3043283628bb77a06d5c96 (patch)
tree048851959518f5ee327633cbbaf5c93cbcfb7c73 /module
parent60fb3f509f29f1233bdf8c3e921875616375e340 (diff)
Don't kfree_skb() after submitting the repurposed SKB
If can327 locks up your machine, but only in very specific situations, this is probably why. The memory leak fix went too far, and I missed the call to can327_feed_frame_to_netdev() before a return -ENODATA. Fixes: 37111be717212b8c7779978c0385393c2d51747d
Diffstat (limited to 'module')
-rw-r--r--module/can327.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/module/can327.c b/module/can327.c
index 3572cfb..ae4d3c1 100644
--- a/module/can327.c
+++ b/module/can327.c
@@ -518,7 +518,6 @@ static int can327_parse_frame(struct can327 *elm, size_t len)
* However, this will correctly drop the state machine back into
* command mode.
*/
- kfree_skb(skb);
return -ENODATA;
}