Remove ELFU_BOOL

diff --git a/include/libelfu/analysis.h b/include/libelfu/analysis.h
index 80ec251e046f68ae7685a8dd364ff483b997ac2a..f3d4ddb095e102ff68ac480241ad02066031933f 100644 (file)
--- a/include/libelfu/analysis.h
+++ b/include/libelfu/analysis.h
@@ -6,6 +6,6 @@
 
 #include <libelfu/types.h>
 
-ELFU_BOOL elfu_segmentContainsSection(GElf_Phdr *phdr, Elf_Scn *scn);
+int elfu_segmentContainsSection(GElf_Phdr *phdr, GElf_Shdr *shdr);
 
 #endif

diff --git a/include/libelfu/types.h b/include/libelfu/types.h
index 6ffdd84649a152d79a97e2adef1ca74a04fe5a20..a59efca7e78ace74d7dfb139442f1d6604a262e6 100644 (file)
--- a/include/libelfu/types.h
+++ b/include/libelfu/types.h
@@ -1,10 +1,6 @@
 #ifndef __LIBELFU_TYPES_H__
 #define __LIBELFU_TYPES_H__
 
-typedef enum {
-  ELFU_ERROR = -1,
-  ELFU_FALSE = 0,
-  ELFU_TRUE = 1
-} ELFU_BOOL;
+
 
 #endif

diff --git a/src/analysis/segment-contains-section.c b/src/analysis/segment-contains-section.c
index dc3269dc19438aeb95b4c79c416cc2b3a07d9cac..298cf726477c25845880a5a4a0f5c3478a2507b5 100644 (file)
--- a/src/analysis/segment-contains-section.c
+++ b/src/analysis/segment-contains-section.c
@@ -4,23 +4,16 @@
 #include <libelfu/libelfu.h>
 
 
-ELFU_BOOL elfu_segmentContainsSection(GElf_Phdr *phdr, Elf_Scn *scn)
+int elfu_segmentContainsSection(GElf_Phdr *phdr, GElf_Shdr *shdr)
 {
-  GElf_Shdr shdr;
-
-
-  if (gelf_getshdr(scn, &shdr) != &shdr) {
-    return ELFU_ERROR;
-  }
-
-  size_t secStart = shdr.sh_offset;
-  size_t secEnd   = shdr.sh_offset + shdr.sh_size;
+  size_t secStart = shdr->sh_offset;
+  size_t secEnd   = shdr->sh_offset + shdr->sh_size;
   size_t segStart = phdr->p_offset;
   size_t segEnd   = phdr->p_offset + phdr->p_memsz;
 
   if (secStart < segStart || secEnd > segEnd) {
-    return ELFU_FALSE;
+    return 0;
   }
 
-  return ELFU_TRUE;
+  return 1;
 }

diff --git a/src/lookup/first-section-in-segment.c b/src/lookup/first-section-in-segment.c
index 833563d76964a41dbcb406f00405cb8ff5f32a61..58065a500423af43ec8dc105bcb9e1586f65da05 100644 (file)
--- a/src/lookup/first-section-in-segment.c
+++ b/src/lookup/first-section-in-segment.c
@@ -25,7 +25,7 @@ Elf_Scn* elfu_firstSectionInSegment(Elf *e, GElf_Phdr *phdr)
     }
 
     if (shdr.sh_offset == phdr->p_offset
-        && elfu_segmentContainsSection(phdr, scn) == ELFU_TRUE) {
+        && elfu_segmentContainsSection(phdr, &shdr)) {
       return scn;
     }
 

diff --git a/src/lookup/last-section-in-segment.c b/src/lookup/last-section-in-segment.c
index 964e854a678cf8db2be52b8f30eef6f46508c229..53323f66e6da9d3de64ce565c9f1e2007c6e5cd5 100644 (file)
--- a/src/lookup/last-section-in-segment.c
+++ b/src/lookup/last-section-in-segment.c
@@ -1,3 +1,4 @@
+#include <stdio.h>
 #include <stdlib.h>
 
 #include <libelf.h>
@@ -21,22 +22,24 @@ Elf_Scn* elfu_lastSectionInSegment(Elf *e, GElf_Phdr *phdr)
 
   scn = elf_getscn(e, 1);
   while (scn) {
-    if (elfu_segmentContainsSection(phdr, scn) == ELFU_TRUE) {
+    GElf_Shdr shdr;
+
+    if (gelf_getshdr(scn, &shdr) != &shdr) {
+      fprintf(stderr, "gelf_getshdr() failed: %s\n", elf_errmsg(-1));
+      continue;
+    }
+
+    if (elfu_segmentContainsSection(phdr, &shdr)) {
       if (!last) {
         last = scn;
       } else {
         GElf_Shdr shdrOld;
-        GElf_Shdr shdrNew;
 
         if (gelf_getshdr(last, &shdrOld) != &shdrOld) {
           continue;
         }
 
-        if (gelf_getshdr(scn, &shdrNew) != &shdrNew) {
-          continue;
-        }
-
-        if (shdrNew.sh_offset + shdrNew.sh_size
+        if (shdr.sh_offset + shdr.sh_size
             > shdrOld.sh_offset + shdrOld.sh_size) {
           // TODO: Check (leftover space in memory image) < (p_align)
           last = scn;

diff --git a/src/printing/sections.c b/src/printing/sections.c
index 6241a733a7b396240c0a6559b54b9672a052beb7..be7a9072ae05aa304cf6cb28b19b25a6e2cdfb32 100644 (file)
--- a/src/printing/sections.c
+++ b/src/printing/sections.c
@@ -10,25 +10,28 @@
 void printSegmentsWithSection(Elf *e, Elf_Scn *scn)
 {
   GElf_Phdr phdr;
+  GElf_Shdr shdr;
   int i;
   size_t n;
 
 
+  if (gelf_getshdr(scn, &shdr) != &shdr) {
+    fprintf(stderr, "gelf_getshdr() failed: %s\n", elf_errmsg(-1));
+    return;
+  }
+
   if (elf_getphdrnum(e, &n)) {
     fprintf(stderr, "elf_getphdrnum() failed: %s\n", elf_errmsg(-1));
     return;
   }
 
   for (i = 0; i < n; i++) {
-    ELFU_BOOL isInSeg;
-
     if (gelf_getphdr(e, i, &phdr) != &phdr) {
       fprintf(stderr, "getphdr() failed for #%d: %s\n", i, elf_errmsg(-1));
       continue;
     }
 
-    isInSeg = elfu_segmentContainsSection(&phdr, scn);
-    if (isInSeg == ELFU_TRUE) {
+    if (elfu_segmentContainsSection(&phdr, &shdr)) {
       printf("     %d %s\n", i, segmentTypeStr(phdr.p_type));
     }
   }

diff --git a/src/printing/segments.c b/src/printing/segments.c
index 6d8cac7223c6f003d73e845db781dc4520ea242a..1f431d673e85969d2c78eb31e7d9ce7ce79329b2 100644 (file)
--- a/src/printing/segments.c
+++ b/src/printing/segments.c
@@ -26,10 +26,14 @@ void printSectionsInSegment(Elf *e, GElf_Phdr *phdr)
   scn = elf_getscn(e, 0);
 
   while (scn) {
-    ELFU_BOOL isInSeg;
+    GElf_Shdr shdr;
 
-    isInSeg = elfu_segmentContainsSection(phdr, scn);
-    if (isInSeg == ELFU_TRUE) {
+    if (gelf_getshdr(scn, &shdr) != &shdr) {
+      fprintf(stderr, "gelf_getshdr() failed: %s\n", elf_errmsg(-1));
+      continue;
+    }
+
+    if (elfu_segmentContainsSection(phdr, &shdr)) {
       printf("       %10u %s\n", elf_ndxscn(scn), elfu_sectionName(e, scn));
     }