summaryrefslogtreecommitdiff
path: root/package
diff options
context:
space:
mode:
authorblogic <blogic@3c298f89-4303-0410-b956-a3cf2f4a3e73>2013-11-25 14:09:16 +0000
committerblogic <blogic@3c298f89-4303-0410-b956-a3cf2f4a3e73>2013-11-25 14:09:16 +0000
commit5e1e1087e213397f67ca3e127125b4e576b8bed4 (patch)
treee6a8dee49cc5d13934387cd1170654967459b0e4 /package
parent4565af04dc9fed01f7b2f0ab6ca00dd138d01f9f (diff)
pppd: Place plugin-specific options after `plugin name`.
Before this patch, if we specify a plugin specific option through `pppd_options` in /etc/config/network, e.g. `rp_pppoe_verbose 1`, pppd would quit with the following error in log. Wed Oct 9 09:42:58 2013 daemon.notice netifd: GORG (1689): /usr/sbin/pppd: unrecognized option 'rp_pppoe_verbose' Wed Oct 9 09:42:58 2013 daemon.err pppd[1689]: unrecognized option 'rp_pppoe_verbose' Wed Oct 9 09:42:58 2013 daemon.notice netifd: GORG (1689): pppd version 2.4.5 Wed Oct 9 09:42:58 2013 daemon.notice netifd: GORG (1689): Usage: /usr/sbin/pppd [ options ], where options are: This is due to the requirement that function add_option() should be called by the plugin_init() function first before pppd can parse those options. Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com> git-svn-id: svn://svn.openwrt.org/openwrt/trunk@38911 3c298f89-4303-0410-b956-a3cf2f4a3e73
Diffstat (limited to 'package')
-rwxr-xr-xpackage/network/services/ppp/files/ppp.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/package/network/services/ppp/files/ppp.sh b/package/network/services/ppp/files/ppp.sh
index 02b40558ca..284d44cfed 100755
--- a/package/network/services/ppp/files/ppp.sh
+++ b/package/network/services/ppp/files/ppp.sh
@@ -55,7 +55,7 @@ ppp_generic_setup() {
ip-down-script /lib/netifd/ppp-down \
ipv6-down-script /lib/netifd/ppp-down \
${mtu:+mtu $mtu mru $mtu} \
- $pppd_options "$@"
+ "$@" $pppd_options
}
ppp_generic_teardown() {