summaryrefslogtreecommitdiff
path: root/module
AgeCommit message (Collapse)Author
2019-01-31Use more netdev_err() instead of pr_err()norly
...and remove a stray comment
2019-01-31Return cleanly in functions calling elm327_hw_failure()norly
2019-01-31Don't reset on HW fault, but take the interface down.norly
There is currently no interface to try again, other than detaching and re-attaching the line discipline. It wouldn't make much sense either, unless we've run into an unexpected state in the ELM327's firmware.
2019-01-30elmcan_ldisc_ioctl(): Use elm->dev->name againnorly
We now have proper locking, so dev->name is guaranteed to exist.
2019-01-30Use netdev_* prints throughoutnorly
2019-01-30Rename elm327_panic() to elm327_hw_failure() to avoid confusionnorly
2019-01-23Handle tty->ops->write() returning errornorly
This was already the case in elmcan_ldisc_tx_worker(), but was missing in elm327_send().
2019-01-23Replace '>' with constant ELM327_READY_CHARnorly
2019-01-23Bump N_ELMCAN to avoid conflicts with future in-tree line disciplines.norly
We can't go higher than 29 because of NR_LDISCS == 30 in Linux 5.0. We can't go lower than 28 because of N_NULL == 27 in Linux 5.0.
2019-01-23Fix race between ldisc_close() and ldisc_*()norly
There was a chance that something needed the elm object after it was freed. Proper locking stops this.
2019-01-23Avoid ldisc_ioctl() racing unregister_candev()norly
When getting the CAN interface's name via the SIOCGIFNAME ioctl, elm->dev->name may no longer exist because the interface is being shut down. Also, print the name of the interface to dmesg.
2019-01-19Commentsnorly
2018-11-13Import first public commitnorly