Merge 0.10->trunk
authorKim Alvefur <zash@zash.se>
Sun, 3 Apr 2016 13:53:00 +0000 (15:53 +0200)
committerKim Alvefur <zash@zash.se>
Sun, 3 Apr 2016 13:53:00 +0000 (15:53 +0200)
41 files changed:
CHANGES
core/hostmanager.lua
core/moduleapi.lua
core/sessionmanager.lua
core/storagemanager.lua
net/cqueues.lua [new file with mode: 0644]
net/server.lua
net/server_event.lua
net/server_select.lua
plugins/mod_admin_telnet.lua
plugins/mod_bosh.lua
plugins/mod_c2s.lua
plugins/mod_http.lua
plugins/mod_muc_unique.lua [new file with mode: 0644]
plugins/mod_pep_plus.lua [new file with mode: 0644]
plugins/mod_private.lua
plugins/mod_s2s/mod_s2s.lua
plugins/muc/affiliation_notify.lib.lua [new file with mode: 0644]
plugins/muc/description.lib.lua [new file with mode: 0644]
plugins/muc/hidden.lib.lua [new file with mode: 0644]
plugins/muc/history.lib.lua [new file with mode: 0644]
plugins/muc/lock.lib.lua [new file with mode: 0644]
plugins/muc/members_only.lib.lua [new file with mode: 0644]
plugins/muc/mod_muc.lua
plugins/muc/moderated.lib.lua [new file with mode: 0644]
plugins/muc/muc.lib.lua
plugins/muc/name.lib.lua [new file with mode: 0644]
plugins/muc/occupant.lib.lua [new file with mode: 0644]
plugins/muc/password.lib.lua [new file with mode: 0644]
plugins/muc/persistent.lib.lua [new file with mode: 0644]
plugins/muc/subject.lib.lua [new file with mode: 0644]
plugins/muc/util.lib.lua [new file with mode: 0644]
plugins/muc/whois.lib.lua [new file with mode: 0644]
prosodyctl
tests/test_util_xml.lua
util/async.lua [new file with mode: 0644]
util/indexedbheap.lua [new file with mode: 0644]
util/stanza.lua
util/timer.lua
util/vcard.lua [new file with mode: 0644]
util/xml.lua

diff --git a/CHANGES b/CHANGES
index 725e10d7740a93ec8c6e684acbda9b6b6e4dd3ac..899716be33022cd7d691483c3cfab7ef354c2274 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,15 @@
+trunk
+=====
+
+**YYYY-MM-DD**
+
+New features
+------------
+
+-   Rewritten more extensible MUC module
+-   mod\_pep\_plus
+-   Asynchronous operations
+
 0.10.not-released-yet
 =====================
 
index 53c1cd4eeaa4cd72b54507952ad1401738f60553..d7a585f9b01db5a2b4201dc8c95be0a7f74e962f 100644 (file)
@@ -12,8 +12,6 @@ local events_new = require "util.events".new;
 local disco_items = require "util.multitable".new();
 local NULL = {};
 
-local jid_split = require "util.jid".split;
-
 local log = require "util.logger".init("hostmanager");
 
 local hosts = prosody.hosts;
@@ -24,7 +22,7 @@ end
 local incoming_s2s = _G.prosody.incoming_s2s;
 local core_route_stanza = _G.prosody.core_route_stanza;
 
-local pairs, select, rawget = pairs, select, rawget;
+local pairs, rawget = pairs, rawget;
 local tostring, type = tostring, type;
 local setmetatable = setmetatable;
 
@@ -71,13 +69,6 @@ end
 prosody_events.add_handler("server-starting", load_enabled_hosts);
 
 local function host_send(stanza)
-       local name, stanza_type = stanza.name, stanza.attr.type;
-       if stanza_type == "error" or (name == "iq" and stanza_type == "result") then
-               local dest_host_name = select(2, jid_split(stanza.attr.to));
-               local dest_host = hosts[dest_host_name] or { type = "unknown" };
-               log("warn", "Unhandled response sent to %s host %s: %s", dest_host.type, dest_host_name, tostring(stanza));
-               return;
-       end
        core_route_stanza(nil, stanza);
 end
 
index 402c79275fe0456f2004c2b7aece035329d21dcc..8db5c2180757794cd9a77f3e5f5b5522c16756f6 100644 (file)
@@ -20,9 +20,10 @@ local st = require "util.stanza";
 local t_insert, t_remove, t_concat = table.insert, table.remove, table.concat;
 local error, setmetatable, type = error, setmetatable, type;
 local ipairs, pairs, select = ipairs, pairs, select;
-local unpack = table.unpack or unpack; --luacheck: ignore 113
 local tonumber, tostring = tonumber, tostring;
 local require = require;
+local pack = table.pack or function(...) return {n=select("#",...), ...}; end -- table.pack is only in 5.2
+local unpack = table.unpack or unpack; --luacheck: ignore 113 -- renamed in 5.2
 
 local prosody = prosody;
 local hosts = prosody.hosts;
@@ -386,11 +387,29 @@ function api:broadcast(jids, stanza, iter)
        end
 end
 
-function api:add_timer(delay, callback)
-       return timer.add_task(delay, function (t)
-               if self.loaded == false then return; end
-               return callback(t);
-       end);
+local timer_methods = { }
+local timer_mt = {
+       __index = timer_methods;
+}
+function timer_methods:stop( )
+       timer.stop(self.id);
+end
+timer_methods.disarm = timer_methods.stop
+function timer_methods:reschedule(delay)
+       timer.reschedule(self.id, delay)
+end
+
+local function timer_callback(now, id, t) --luacheck: ignore 212/id
+       if t.module_env.loaded == false then return; end
+       return t.callback(now, unpack(t, 1, t.n));
+end
+
+function api:add_timer(delay, callback, ...)
+       local t = pack(...)
+       t.module_env = self;
+       t.callback = callback;
+       t.id = timer.add_task(delay, timer_callback, t);
+       return setmetatable(t, timer_mt);
 end
 
 local path_sep = package.config:sub(1,1);
index c8856634205ddcd108ba8af7e508489bd3b35b84..6aa0a4f0f17d147a0b6d2930436ec3b5508084c8 100644 (file)
@@ -72,6 +72,7 @@ local function retire_session(session)
 
        function session.send(data) log("debug", "Discarding data sent to resting session: %s", tostring(data)); return false; end
        function session.data(data) log("debug", "Discarding data received from resting session: %s", tostring(data)); end
+       session.thread = { run = function (_, data) return session.data(data) end };
        return setmetatable(session, resting_session);
 end
 
index 8d83f677db81104b8690577a4d1cf8668baae72b..cadae0ed13aac80e518f5f3976ceb1d686694af8 100644 (file)
@@ -136,7 +136,7 @@ local map_shim_mt = {
        };
 }
 
-local open;
+local open; -- forward declaration
 
 local function create_map_shim(host, store)
        local keyval_store, err = open(host, store, "keyval");
diff --git a/net/cqueues.lua b/net/cqueues.lua
new file mode 100644 (file)
index 0000000..8c4c756
--- /dev/null
@@ -0,0 +1,74 @@
+-- Prosody IM
+-- Copyright (C) 2014 Daurnimator
+--
+-- This project is MIT/X11 licensed. Please see the
+-- COPYING file in the source package for more information.
+--
+-- This module allows you to use cqueues with a net.server mainloop
+--
+
+local server = require "net.server";
+local cqueues = require "cqueues";
+assert(cqueues.VERSION >= 20150113, "cqueues newer than 20150113 required")
+
+-- Create a single top level cqueue
+local cq;
+
+if server.cq then -- server provides cqueues object
+       cq = server.cq;
+elseif server.get_backend() == "select" and server._addtimer then -- server_select
+       cq = cqueues.new();
+       local function step()
+               assert(cq:loop(0));
+       end
+
+       -- Use wrapclient (as wrapconnection isn't exported) to get server_select to watch cq fd
+       local handler = server.wrapclient({
+               getfd = function() return cq:pollfd(); end;
+               settimeout = function() end; -- Method just needs to exist
+               close = function() end; -- Need close method for 'closeall'
+       }, nil, nil, {});
+
+       -- Only need to listen for readable; cqueues handles everything under the hood
+       -- readbuffer is called when `select` notes an fd as readable
+       handler.readbuffer = step;
+
+       -- Use server_select low lever timer facility,
+       -- this callback gets called *every* time there is a timeout in the main loop
+       server._addtimer(function(current_time)
+               -- This may end up in extra step()'s, but cqueues handles it for us.
+               step();
+               return cq:timeout();
+       end);
+elseif server.event and server.base then -- server_event
+       cq = cqueues.new();
+       -- Only need to listen for readable; cqueues handles everything under the hood
+       local EV_READ = server.event.EV_READ;
+       -- Convert a cqueues timeout to an acceptable timeout for luaevent
+       local function luaevent_safe_timeout(cq)
+               local t = cq:timeout();
+               -- if you give luaevent 0 or nil, it re-uses the previous timeout.
+               if t == 0 then
+                       t = 0.000001; -- 1 microsecond is the smallest that works (goes into a `struct timeval`)
+               elseif t == nil then -- pick something big if we don't have one
+                       t = 0x7FFFFFFF; -- largest 32bit int
+               end
+               return t
+       end
+       local event_handle;
+       event_handle = server.base:addevent(cq:pollfd(), EV_READ, function(e)
+                       -- Need to reference event_handle or this callback will get collected
+                       -- This creates a circular reference that can only be broken if event_handle is manually :close()'d
+                       local _ = event_handle;
+                       -- Run as many cqueues things as possible (with a timeout of 0)
+                       -- If an error is thrown, it will break the libevent loop; but prosody resumes after logging a top level error
+                       assert(cq:loop(0));
+                       return EV_READ, luaevent_safe_timeout(cq);
+               end, luaevent_safe_timeout(cq));
+else
+       error "NYI"
+end
+
+return {
+       cq = cq;
+}
index 41e180faa6ce9cd5cee9518b89c0671d9a0be8ae..0e13399d28e9e331a38b392579ff79b680dab14a 100644 (file)
@@ -6,49 +6,28 @@
 -- COPYING file in the source package for more information.
 --
 
-local use_luaevent = prosody and require "core.configmanager".get("*", "use_libevent");
+local server_type = prosody and require "core.configmanager".get("*", "network_backend") or "select";
+if prosody and require "core.configmanager".get("*", "use_libevent") then
+       server_type = "event";
+end
 
-if use_luaevent then
-       use_luaevent = pcall(require, "luaevent.core");
-       if not use_luaevent then
+if server_type == "event" then
+       if not pcall(require, "luaevent.core") then
                log("error", "libevent not found, falling back to select()");
+               server_type = "select"
        end
 end
 
 local server;
-
-if use_luaevent then
+local set_config;
+if server_type == "event" then
        server = require "net.server_event";
 
-       -- Overwrite signal.signal() because we need to ask libevent to
-       -- handle them instead
-       local ok, signal = pcall(require, "util.signal");
-       if ok and signal then
-               local _signal_signal = signal.signal;
-               function signal.signal(signal_id, handler)
-                       if type(signal_id) == "string" then
-                               signal_id = signal[signal_id:upper()];
-                       end
-                       if type(signal_id) ~= "number" then
-                               return false, "invalid-signal";
-                       end
-                       return server.hook_signal(signal_id, handler);
-               end
-       end
-else
-       use_luaevent = false;
-       server = require "net.server_select";
-end
-
-if prosody then
-       local config_get = require "core.configmanager".get;
        local defaults = {};
-       for k,v in pairs(server.cfg or server.getsettings()) do
+       for k,v in pairs(server.cfg) do
                defaults[k] = v;
        end
-       local function load_config()
-               local settings = config_get("*", "network_settings") or {};
-               if use_luaevent then
+       function set_config(settings)
                        local event_settings = {
                                ACCEPT_DELAY = settings.accept_retry_interval;
                                ACCEPT_QUEUE = settings.tcp_backlog;
@@ -67,13 +46,54 @@ if prosody then
                        for k,default in pairs(defaults) do
                                server.cfg[k] = event_settings[k] or default;
                        end
-               else
+       end
+elseif server_type == "select" then
+       server = require "net.server_select";
+
+       local defaults = {};
+       for k,v in pairs(server.getsettings()) do
+               defaults[k] = v;
+       end
+       function set_config(settings)
                        local select_settings = {};
                        for k,default in pairs(defaults) do
                                select_settings[k] = settings[k] or default;
                        end
                        server.changesettings(select_settings);
                end
+else
+       error("Unsupported server type")
+end
+
+-- If server.hook_signal exists, replace signal.signal()
+local has_signal, signal = pcall(require, "util.signal");
+if has_signal then
+       if server.hook_signal then
+               function signal.signal(signal_id, handler)
+                       if type(signal_id) == "string" then
+                               signal_id = signal[signal_id:upper()];
+                       end
+                       if type(signal_id) ~= "number" then
+                               return false, "invalid-signal";
+                       end
+                       return server.hook_signal(signal_id, handler);
+               end
+       else
+               server.hook_signal = signal.signal;
+       end
+else
+       if not server.hook_signal then
+               server.hook_signal = function()
+                       return false, "signal hooking not supported"
+               end
+       end
+end
+
+if prosody then
+       local config_get = require "core.configmanager".get;
+       local function load_config()
+               local settings = config_get("*", "network_settings") or {};
+               return set_config(settings);
        end
        load_config();
        prosody.events.add_handler("config-reloaded", load_config);
index 70a6dc37881af22fd246201c959ae486b2c84642..7940a1b831e1c4c11c0dcd6a9dc66af5e5db2260 100644 (file)
@@ -92,648 +92,647 @@ local interfacelist = { }
 -- Client interface methods
 local interface_mt = {}; interface_mt.__index = interface_mt;
 
-       -- Private methods
-       function interface_mt:_close()
-               return self:_destroy();
-       end
-
-       function interface_mt:_start_connection(plainssl) -- should be called from addclient
-                       local callback = function( event )
-                               if EV_TIMEOUT == event then  -- timeout during connection
-                                       self.fatalerror = "connection timeout"
-                                       self:ontimeout()  -- call timeout listener
-                                       self:_close()
-                                       debug( "new connection failed. id:", self.id, "error:", self.fatalerror )
-                               else
+-- Private methods
+function interface_mt:_close()
+       return self:_destroy();
+end
+
+function interface_mt:_start_connection(plainssl) -- called from wrapclient
+       local callback = function( event )
+               if EV_TIMEOUT == event then  -- timeout during connection
+                       self.fatalerror = "connection timeout"
+                       self:ontimeout()  -- call timeout listener
+                       self:_close()
+                       debug( "new connection failed. id:", self.id, "error:", self.fatalerror )
+               else
                        if plainssl and has_luasec then  -- start ssl session
-                                               self:starttls(self._sslctx, true)
-                                       else  -- normal connection
-                                               self:_start_session(true)
-                                       end
-                                       debug( "new connection established. id:", self.id )
-                               end
-                               self.eventconnect = nil
-                               return -1
+                               self:starttls(self._sslctx, true)
+                       else  -- normal connection
+                               self:_start_session(true)
                        end
-                       self.eventconnect = addevent( base, self.conn, EV_WRITE, callback, cfg.CONNECT_TIMEOUT )
-                       return true
+                       debug( "new connection established. id:", self.id )
+               end
+               self.eventconnect = nil
+               return -1
        end
-       function interface_mt:_start_session(call_onconnect) -- new session, for example after startssl
-               if self.type == "client" then
-                       local callback = function( )
-                               self:_lock( false,  false, false )
-                               --vdebug( "start listening on client socket with id:", self.id )
-                               self.eventread = addevent( base, self.conn, EV_READ, self.readcallback, cfg.READ_TIMEOUT );  -- register callback
-                               if call_onconnect then
-                                       self:onconnect()
-                               end
-                               self.eventsession = nil
-                               return -1
+       self.eventconnect = addevent( base, self.conn, EV_WRITE, callback, cfg.CONNECT_TIMEOUT )
+       return true
+end
+function interface_mt:_start_session(call_onconnect) -- new session, for example after startssl
+       if self.type == "client" then
+               local callback = function( )
+                       self:_lock( false,  false, false )
+                       --vdebug( "start listening on client socket with id:", self.id )
+                       self.eventread = addevent( base, self.conn, EV_READ, self.readcallback, cfg.READ_TIMEOUT );  -- register callback
+                       if call_onconnect then
+                               self:onconnect()
                        end
-                       self.eventsession = addevent( base, nil, EV_TIMEOUT, callback, 0 )
-               else
-                       self:_lock( false )
-                       --vdebug( "start listening on server socket with id:", self.id )
-                       self.eventread = addevent( base, self.conn, EV_READ, self.readcallback )  -- register callback
+                       self.eventsession = nil
+                       return -1
                end
-               return true
+               self.eventsession = addevent( base, nil, EV_TIMEOUT, callback, 0 )
+       else
+               self:_lock( false )
+               --vdebug( "start listening on server socket with id:", self.id )
+               self.eventread = addevent( base, self.conn, EV_READ, self.readcallback )  -- register callback
+       end
+       return true
+end
+function interface_mt:_start_ssl(call_onconnect) -- old socket will be destroyed, therefore we have to close read/write events first
+       --vdebug( "starting ssl session with client id:", self.id )
+       local _
+       _ = self.eventread and self.eventread:close( )  -- close events; this must be called outside of the event callbacks!
+       _ = self.eventwrite and self.eventwrite:close( )
+       self.eventread, self.eventwrite = nil, nil
+       local err
+       self.conn, err = ssl.wrap( self.conn, self._sslctx )
+       if err then
+               self.fatalerror = err
+               self.conn = nil  -- cannot be used anymore
+               if call_onconnect then
+                       self.ondisconnect = nil  -- dont call this when client isnt really connected
+               end
+               self:_close()
+               debug( "fatal error while ssl wrapping:", err )
+               return false
        end
-       function interface_mt:_start_ssl(call_onconnect) -- old socket will be destroyed, therefore we have to close read/write events first
-                       --vdebug( "starting ssl session with client id:", self.id )
-                       local _
-                       _ = self.eventread and self.eventread:close( )  -- close events; this must be called outside of the event callbacks!
-                       _ = self.eventwrite and self.eventwrite:close( )
-                       self.eventread, self.eventwrite = nil, nil
-                       local err
-                       self.conn, err = ssl.wrap( self.conn, self._sslctx )
-                       if err then
-                               self.fatalerror = err
-                               self.conn = nil  -- cannot be used anymore
+       self.conn:settimeout( 0 )  -- set non blocking
+       local handshakecallback = coroutine_wrap(function( event )
+               local _, err
+               local attempt = 0
+               local maxattempt = cfg.MAX_HANDSHAKE_ATTEMPTS
+               while attempt < maxattempt do  -- no endless loop
+                       attempt = attempt + 1
+                       debug( "ssl handshake of client with id:"..tostring(self)..", attempt:"..attempt )
+                       if attempt > maxattempt then
+                               self.fatalerror = "max handshake attempts exceeded"
+                       elseif EV_TIMEOUT == event then
+                               self.fatalerror = "timeout during handshake"
+                       else
+                               _, err = self.conn:dohandshake( )
+                               if not err then
+                                       self:_lock( false, false, false )  -- unlock the interface; sending, closing etc allowed
+                                       self.send = self.conn.send  -- caching table lookups with new client object
+                                       self.receive = self.conn.receive
+                                       if not call_onconnect then  -- trigger listener
+                                               self:onstatus("ssl-handshake-complete");
+                                       end
+                                       self:_start_session( call_onconnect )
+                                       debug( "ssl handshake done" )
+                                       self.eventhandshake = nil
+                                       return -1
+                               end
+                               if err == "wantwrite" then
+                                       event = EV_WRITE
+                               elseif err == "wantread" then
+                                       event = EV_READ
+                               else
+                                       debug( "ssl handshake error:", err )
+                                       self.fatalerror = err
+                               end
+                       end
+                       if self.fatalerror then
                                if call_onconnect then
                                        self.ondisconnect = nil  -- dont call this when client isnt really connected
                                end
                                self:_close()
-                               debug( "fatal error while ssl wrapping:", err )
-                               return false
+                               debug( "handshake failed because:", self.fatalerror )
+                               self.eventhandshake = nil
+                               return -1
                        end
-                       self.conn:settimeout( 0 )  -- set non blocking
-       local handshakecallback = coroutine_wrap(function( event )
-                                       local _, err
-                                       local attempt = 0
-                                       local maxattempt = cfg.MAX_HANDSHAKE_ATTEMPTS
-                                       while attempt < maxattempt do  -- no endless loop
-                                               attempt = attempt + 1
-                                               debug( "ssl handshake of client with id:"..tostring(self)..", attempt:"..attempt )
-                                               if attempt > maxattempt then
-                                                       self.fatalerror = "max handshake attempts exceeded"
-                                               elseif EV_TIMEOUT == event then
-                                                       self.fatalerror = "timeout during handshake"
-                                               else
-                                                       _, err = self.conn:dohandshake( )
-                                                       if not err then
-                                                               self:_lock( false, false, false )  -- unlock the interface; sending, closing etc allowed
-                                                               self.send = self.conn.send  -- caching table lookups with new client object
-                                                               self.receive = self.conn.receive
-                                                               if not call_onconnect then  -- trigger listener
-                                                                       self:onstatus("ssl-handshake-complete");
-                                                               end
-                                                               self:_start_session( call_onconnect )
-                                                               debug( "ssl handshake done" )
-                                                               self.eventhandshake = nil
-                                                               return -1
-                                                       end
-                                                       if err == "wantwrite" then
-                                                               event = EV_WRITE
-                                                       elseif err == "wantread" then
-                                                               event = EV_READ
-                                                       else
-                                                               debug( "ssl handshake error:", err )
-                                                               self.fatalerror = err
-                                                       end
-                                               end
-                                               if self.fatalerror then
-                                                       if call_onconnect then
-                                                               self.ondisconnect = nil  -- dont call this when client isnt really connected
-                                                       end
-                                                       self:_close()
-                                                       debug( "handshake failed because:", self.fatalerror )
-                                                       self.eventhandshake = nil
-                                                       return -1
-                                               end
-                                               event = coroutine_yield( event, cfg.HANDSHAKE_TIMEOUT )  -- yield this monster...
-                                       end
-                               end
-                       )
-                       debug "starting handshake..."
-                       self:_lock( false, true, true )  -- unlock read/write events, but keep interface locked
-                       self.eventhandshake = addevent( base, self.conn, EV_READWRITE, handshakecallback, cfg.HANDSHAKE_TIMEOUT )
-                       return true
+                       event = coroutine_yield( event, cfg.HANDSHAKE_TIMEOUT )  -- yield this monster...
+               end
        end
-       function interface_mt:_destroy()  -- close this interface + events and call last listener
-                       debug( "closing client with id:", self.id, self.fatalerror )
-                       self:_lock( true, true, true )  -- first of all, lock the interface to avoid further actions
-                       local _
-                       _ = self.eventread and self.eventread:close( )
-                       if self.type == "client" then
-                               _ = self.eventwrite and self.eventwrite:close( )
-                               _ = self.eventhandshake and self.eventhandshake:close( )
-                               _ = self.eventstarthandshake and self.eventstarthandshake:close( )
-                               _ = self.eventconnect and self.eventconnect:close( )
-                               _ = self.eventsession and self.eventsession:close( )
-                               _ = self.eventwritetimeout and self.eventwritetimeout:close( )
-                               _ = self.eventreadtimeout and self.eventreadtimeout:close( )
-                               _ = self.ondisconnect and self:ondisconnect( self.fatalerror ~= "client to close" and self.fatalerror)  -- call ondisconnect listener (wont be the case if handshake failed on connect)
-                               _ = self.conn and self.conn:close( ) -- close connection
-                               _ = self._server and self._server:counter(-1);
-                               self.eventread, self.eventwrite = nil, nil
-                               self.eventstarthandshake, self.eventhandshake, self.eventclose = nil, nil, nil
-                               self.readcallback, self.writecallback = nil, nil
-                       else
-                               self.conn:close( )
-                               self.eventread, self.eventclose = nil, nil
-                               self.interface, self.readcallback = nil, nil
-                       end
-       interfacelist[ self ] = nil
-                       return true
+       )
+       debug "starting handshake..."
+       self:_lock( false, true, true )  -- unlock read/write events, but keep interface locked
+       self.eventhandshake = addevent( base, self.conn, EV_READWRITE, handshakecallback, cfg.HANDSHAKE_TIMEOUT )
+       return true
+end
+function interface_mt:_destroy()  -- close this interface + events and call last listener
+       debug( "closing client with id:", self.id, self.fatalerror )
+       self:_lock( true, true, true )  -- first of all, lock the interface to avoid further actions
+       local _
+       _ = self.eventread and self.eventread:close( )
+       if self.type == "client" then
+               _ = self.eventwrite and self.eventwrite:close( )
+               _ = self.eventhandshake and self.eventhandshake:close( )
+               _ = self.eventstarthandshake and self.eventstarthandshake:close( )
+               _ = self.eventconnect and self.eventconnect:close( )
+               _ = self.eventsession and self.eventsession:close( )
+               _ = self.eventwritetimeout and self.eventwritetimeout:close( )
+               _ = self.eventreadtimeout and self.eventreadtimeout:close( )
+               _ = self.ondisconnect and self:ondisconnect( self.fatalerror ~= "client to close" and self.fatalerror)  -- call ondisconnect listener (wont be the case if handshake failed on connect)
+               _ = self.conn and self.conn:close( ) -- close connection
+               _ = self._server and self._server:counter(-1);
+               self.eventread, self.eventwrite = nil, nil
+               self.eventstarthandshake, self.eventhandshake, self.eventclose = nil, nil, nil
+               self.readcallback, self.writecallback = nil, nil
+       else
+               self.conn:close( )
+               self.eventread, self.eventclose = nil, nil
+               self.interface, self.readcallback = nil, nil
        end
+       interfacelist[ self ] = nil
+       return true
+end
 
-       function interface_mt:_lock(nointerface, noreading, nowriting)  -- lock or unlock this interface or events
-                       self.nointerface, self.noreading, self.nowriting = nointerface, noreading, nowriting
-                       return nointerface, noreading, nowriting
-       end
+function interface_mt:_lock(nointerface, noreading, nowriting)  -- lock or unlock this interface or events
+       self.nointerface, self.noreading, self.nowriting = nointerface, noreading, nowriting
+       return nointerface, noreading, nowriting
+end
 
-       --TODO: Deprecate
-       function interface_mt:lock_read(switch)
-               if switch then
-                       return self:pause();
-               else
-                       return self:resume();
-               end
+--TODO: Deprecate
+function interface_mt:lock_read(switch)
+       if switch then
+               return self:pause();
+       else
+               return self:resume();
        end
+end
 
-       function interface_mt:pause()
-               return self:_lock(self.nointerface, true, self.nowriting);
-       end
+function interface_mt:pause()
+       return self:_lock(self.nointerface, true, self.nowriting);
+end
 
-       function interface_mt:resume()
-               self:_lock(self.nointerface, false, self.nowriting);
+function interface_mt:resume()
+       self:_lock(self.nointerface, false, self.nowriting);
                if self.readcallback and not self.eventread then
-                       self.eventread = addevent( base, self.conn, EV_READ, self.readcallback, cfg.READ_TIMEOUT );  -- register callback
+               self.eventread = addevent( base, self.conn, EV_READ, self.readcallback, cfg.READ_TIMEOUT );  -- register callback
                        return true;
-               end
        end
+end
 
-       function interface_mt:counter(c)
-               if c then
-                       self._connections = self._connections + c
-               end
-               return self._connections
-       end
-
-       -- Public methods
-       function interface_mt:write(data)
-               if self.nowriting then return nil, "locked" end
-               --vdebug( "try to send data to client, id/data:", self.id, data )
-               data = tostring( data )
-               local len = #data
-               local total = len + self.writebufferlen
-               if total > cfg.MAX_SEND_LENGTH then  -- check buffer length
-                       local err = "send buffer exceeded"
-                       debug( "error:", err )  -- to much, check your app
-                       return nil, err
-               end
-               t_insert(self.writebuffer, data) -- new buffer
-               self.writebufferlen = total
-               if not self.eventwrite then  -- register new write event
-                       --vdebug( "register new write event" )
-                       self.eventwrite = addevent( base, self.conn, EV_WRITE, self.writecallback, cfg.WRITE_TIMEOUT )
-               end
-               return true
+function interface_mt:counter(c)
+       if c then
+               self._connections = self._connections + c
        end
-       function interface_mt:close()
-               if self.nointerface then return nil, "locked"; end
-               debug( "try to close client connection with id:", self.id )
-               if self.type == "client" then
-                       self.fatalerror = "client to close"
-                       if self.eventwrite then -- wait for incomplete write request
-                               self:_lock( true, true, false )
-                               debug "closing delayed until writebuffer is empty"
-                               return nil, "writebuffer not empty, waiting"
-                       else -- close now
-                               self:_lock( true, true, true )
-                               self:_close()
-                               return true
-                       end
-               else
-                       debug( "try to close server with id:", tostring(self.id))
-                       self.fatalerror = "server to close"
-                       self:_lock( true )
-                       self:_close( 0 )
+       return self._connections
+end
+
+-- Public methods
+function interface_mt:write(data)
+       if self.nowriting then return nil, "locked" end
+       --vdebug( "try to send data to client, id/data:", self.id, data )
+       data = tostring( data )
+       local len = #data
+       local total = len + self.writebufferlen
+       if total > cfg.MAX_SEND_LENGTH then  -- check buffer length
+               local err = "send buffer exceeded"
+               debug( "error:", err )  -- to much, check your app
+               return nil, err
+       end
+       t_insert(self.writebuffer, data) -- new buffer
+       self.writebufferlen = total
+       if not self.eventwrite then  -- register new write event
+               --vdebug( "register new write event" )
+               self.eventwrite = addevent( base, self.conn, EV_WRITE, self.writecallback, cfg.WRITE_TIMEOUT )
+       end
+       return true
+end
+function interface_mt:close()
+       if self.nointerface then return nil, "locked"; end
+       debug( "try to close client connection with id:", self.id )
+       if self.type == "client" then
+               self.fatalerror = "client to close"
+               if self.eventwrite then -- wait for incomplete write request
+                       self:_lock( true, true, false )
+                       debug "closing delayed until writebuffer is empty"
+                       return nil, "writebuffer not empty, waiting"
+               else -- close now
+                       self:_lock( true, true, true )
+                       self:_close()
                        return true
                end
+       else
+               debug( "try to close server with id:", tostring(self.id))
+               self.fatalerror = "server to close"
+               self:_lock( true )
+               self:_close( 0 )
+               return true
        end
+end
 
-       function interface_mt:socket()
-               return self.conn
-       end
+function interface_mt:socket()
+       return self.conn
+end
 
-       function interface_mt:server()
-               return self._server or self;
-       end
+function interface_mt:server()
+       return self._server or self;
+end
 
-       function interface_mt:port()
-               return self._port
-       end
+function interface_mt:port()
+       return self._port
+end
 
-       function interface_mt:serverport()
-               return self._serverport
-       end
+function interface_mt:serverport()
+       return self._serverport
+end
 
-       function interface_mt:ip()
-               return self._ip
-       end
+function interface_mt:ip()
+       return self._ip
+end
 
-       function interface_mt:ssl()
-               return self._usingssl
-       end
-       interface_mt.clientport = interface_mt.port -- COMPAT server_select
+function interface_mt:ssl()
+       return self._usingssl
+end
+interface_mt.clientport = interface_mt.port -- COMPAT server_select
 
-       function interface_mt:type()
-               return self._type or "client"
-       end
+function interface_mt:type()
+       return self._type or "client"
+end
 
-       function interface_mt:connections()
-               return self._connections
-       end
+function interface_mt:connections()
+       return self._connections
+end
 
-       function interface_mt:address()
-               return self.addr
-       end
+function interface_mt:address()
+       return self.addr
+end
 
-       function interface_mt:set_sslctx(sslctx)
-               self._sslctx = sslctx;
-               if sslctx then
-                       self.starttls = nil; -- use starttls() of interface_mt
-               else
-                       self.starttls = false; -- prevent starttls()
-               end
+function interface_mt:set_sslctx(sslctx)
+       self._sslctx = sslctx;
+       if sslctx then
+               self.starttls = nil; -- use starttls() of interface_mt
+       else
+               self.starttls = false; -- prevent starttls()
        end
+end
 
-       function interface_mt:set_mode(pattern)
-               if pattern then
-                       self._pattern = pattern;
-               end
-               return self._pattern;
+function interface_mt:set_mode(pattern)
+       if pattern then
+               self._pattern = pattern;
        end
+       return self._pattern;
+end
 
 function interface_mt:set_send(new_send) -- luacheck: ignore 212
-               -- No-op, we always use the underlying connection's send
-       end
+       -- No-op, we always use the underlying connection's send
+end
 
-       function interface_mt:starttls(sslctx, call_onconnect)
-               debug( "try to start ssl at client id:", self.id )
-               local err
-               self._sslctx = sslctx;
-               if self._usingssl then  -- startssl was already called
-                       err = "ssl already active"
-               end
-               if err then
-                       debug( "error:", err )
-                       return nil, err
-               end
-               self._usingssl = true
-               self.startsslcallback = function( )  -- we have to start the handshake outside of a read/write event
-                       self.startsslcallback = nil
-                       self:_start_ssl(call_onconnect);
-                       self.eventstarthandshake = nil
-                       return -1
-               end
-               if not self.eventwrite then
-                       self:_lock( true, true, true )  -- lock the interface, to not disturb the handshake
-                       self.eventstarthandshake = addevent( base, nil, EV_TIMEOUT, self.startsslcallback, 0 )  -- add event to start handshake
-               else  -- wait until writebuffer is empty
-                       self:_lock( true, true, false )
-                       debug "ssl session delayed until writebuffer is empty..."
-               end
-               self.starttls = false;
-               return true
-       end
+function interface_mt:starttls(sslctx, call_onconnect)
+       debug( "try to start ssl at client id:", self.id )
+       local err
+       self._sslctx = sslctx;
+       if self._usingssl then  -- startssl was already called
+               err = "ssl already active"
+       end
+       if err then
+               debug( "error:", err )
+               return nil, err
+       end
+       self._usingssl = true
+       self.startsslcallback = function( )  -- we have to start the handshake outside of a read/write event
+               self.startsslcallback = nil
+               self:_start_ssl(call_onconnect);
+               self.eventstarthandshake = nil
+               return -1
+       end
+       if not self.eventwrite then
+               self:_lock( true, true, true )  -- lock the interface, to not disturb the handshake
+               self.eventstarthandshake = addevent( base, nil, EV_TIMEOUT, self.startsslcallback, 0 )  -- add event to start handshake
+       else  -- wait until writebuffer is empty
+               self:_lock( true, true, false )
+               debug "ssl session delayed until writebuffer is empty..."
+       end
+       self.starttls = false;
+       return true
+end
 
-       function interface_mt:setoption(option, value)
-               if self.conn.setoption then
-                       return self.conn:setoption(option, value);
-               end
-               return false, "setoption not implemented";
+function interface_mt:setoption(option, value)
+       if self.conn.setoption then
+               return self.conn:setoption(option, value);
        end
+       return false, "setoption not implemented";
+end
 
-       function interface_mt:setlistener(listener)
-               self:ondetach(); -- Notify listener that it is no longer responsible for this connection
+function interface_mt:setlistener(listener)
+       self:ondetach(); -- Notify listener that it is no longer responsible for this connection
        self.onconnect, self.ondisconnect, self.onincoming, self.ontimeout,
        self.onreadtimeout, self.onstatus, self.ondetach
                = listener.onconnect, listener.ondisconnect, listener.onincoming, listener.ontimeout,
                  listener.onreadtimeout, listener.onstatus, listener.ondetach;
-       end
+end
 
-       -- Stub handlers
-       function interface_mt:onconnect()
-       end
-       function interface_mt:onincoming()
-       end
-       function interface_mt:ondisconnect()
-       end
-       function interface_mt:ontimeout()
-       end
+-- Stub handlers
+function interface_mt:onconnect()
+end
+function interface_mt:onincoming()
+end
+function interface_mt:ondisconnect()
+end
+function interface_mt:ontimeout()
+end
 function interface_mt:onreadtimeout()
        self.fatalerror = "timeout during receiving"
        debug( "connection failed:", self.fatalerror )
        self:_close()
        self.eventread = nil
 end
-       function interface_mt:ondrain()
-       end
-       function interface_mt:ondetach()
-       end
-       function interface_mt:onstatus()
-       end
+function interface_mt:ondrain()
+end
+function interface_mt:ondetach()
+end
+function interface_mt:onstatus()
+end
 
 -- End of client interface methods
 
 local function handleclient( client, ip, port, server, pattern, listener, sslctx )  -- creates an client interface
-               --vdebug("creating client interfacce...")
-               local interface = {
-                       type = "client";
-                       conn = client;
-                       currenttime = socket_gettime( );  -- safe the origin
-                       writebuffer = {};  -- writebuffer
-                       writebufferlen = 0;  -- length of writebuffer
-                       send = client.send;  -- caching table lookups
-                       receive = client.receive;
-                       onconnect = listener.onconnect;  -- will be called when client disconnects
-                       ondisconnect = listener.ondisconnect;  -- will be called when client disconnects
-                       onincoming = listener.onincoming;  -- will be called when client sends data
-                       ontimeout = listener.ontimeout; -- called when fatal socket timeout occurs
+       --vdebug("creating client interfacce...")
+       local interface = {
+               type = "client";
+               conn = client;
+               currenttime = socket_gettime( );  -- safe the origin
+               writebuffer = {};  -- writebuffer
+               writebufferlen = 0;  -- length of writebuffer
+               send = client.send;  -- caching table lookups
+               receive = client.receive;
+               onconnect = listener.onconnect;  -- will be called when client disconnects
+               ondisconnect = listener.ondisconnect;  -- will be called when client disconnects
+               onincoming = listener.onincoming;  -- will be called when client sends data
+               ontimeout = listener.ontimeout; -- called when fatal socket timeout occurs
                onreadtimeout = listener.onreadtimeout; -- called when socket inactivity timeout occurs
-                       ondrain = listener.ondrain; -- called when writebuffer is empty
-                       ondetach = listener.ondetach; -- called when disassociating this listener from this connection
-                       onstatus = listener.onstatus; -- called for status changes (e.g. of SSL/TLS)
-                       eventread = false, eventwrite = false, eventclose = false,
-                       eventhandshake = false, eventstarthandshake = false;  -- event handler
-                       eventconnect = false, eventsession = false;  -- more event handler...
-                       eventwritetimeout = false;  -- even more event handler...
-                       eventreadtimeout = false;
-                       fatalerror = false;  -- error message
-                       writecallback = false;  -- will be called on write events
-                       readcallback = false;  -- will be called on read events
-                       nointerface = true;  -- lock/unlock parameter of this interface
-                       noreading = false, nowriting = false;  -- locks of the read/writecallback
-                       startsslcallback = false;  -- starting handshake callback
-                       position = false;  -- position of client in interfacelist
-
-                       -- Properties
-                       _ip = ip, _port = port, _server = server, _pattern = pattern,
-                       _serverport = (server and server:port() or nil),
-                       _sslctx = sslctx; -- parameters
-                       _usingssl = false;  -- client is using ssl;
-               }
+               ondrain = listener.ondrain; -- called when writebuffer is empty
+               ondetach = listener.ondetach; -- called when disassociating this listener from this connection
+               onstatus = listener.onstatus; -- called for status changes (e.g. of SSL/TLS)
+               eventread = false, eventwrite = false, eventclose = false,
+               eventhandshake = false, eventstarthandshake = false;  -- event handler
+               eventconnect = false, eventsession = false;  -- more event handler...
+               eventwritetimeout = false;  -- even more event handler...
+               eventreadtimeout = false;
+               fatalerror = false;  -- error message
+               writecallback = false;  -- will be called on write events
+               readcallback = false;  -- will be called on read events
+               nointerface = true;  -- lock/unlock parameter of this interface
+               noreading = false, nowriting = false;  -- locks of the read/writecallback
+               startsslcallback = false;  -- starting handshake callback
+               position = false;  -- position of client in interfacelist
+
+               -- Properties
+               _ip = ip, _port = port, _server = server, _pattern = pattern,
+               _serverport = (server and server:port() or nil),
+               _sslctx = sslctx; -- parameters
+               _usingssl = false;  -- client is using ssl;
+       }
        if not has_luasec then interface.starttls = false; end
-               interface.id = tostring(interface):match("%x+$");
-               interface.writecallback = function( event )  -- called on write events
-                       --vdebug( "new client write event, id/ip/port:", interface, ip, port )
-                       if interface.nowriting or ( interface.fatalerror and ( "client to close" ~= interface.fatalerror ) ) then  -- leave this event
-                               --vdebug( "leaving this event because:", interface.nowriting or interface.fatalerror )
-                               interface.eventwrite = false
-                               return -1
+       interface.id = tostring(interface):match("%x+$");
+       interface.writecallback = function( event )  -- called on write events
+               --vdebug( "new client write event, id/ip/port:", interface, ip, port )
+               if interface.nowriting or ( interface.fatalerror and ( "client to close" ~= interface.fatalerror ) ) then  -- leave this event
+                       --vdebug( "leaving this event because:", interface.nowriting or interface.fatalerror )
+                       interface.eventwrite = false
+                       return -1
+               end
+               if EV_TIMEOUT == event then  -- took too long to write some data to socket -> disconnect
+                       interface.fatalerror = "timeout during writing"
+                       debug( "writing failed:", interface.fatalerror )
+                       interface:_close()
+                       interface.eventwrite = false
+                       return -1
+               else  -- can write :)
+                       if interface._usingssl then  -- handle luasec
+                               if interface.eventreadtimeout then  -- we have to read first
+                                       local ret = interface.readcallback( )  -- call readcallback
+                                       --vdebug( "tried to read in writecallback, result:", ret )
+                               end
+                               if interface.eventwritetimeout then  -- luasec only
+                                       interface.eventwritetimeout:close( )  -- first we have to close timeout event which where regged after a wantread error
+                                       interface.eventwritetimeout = false
+                               end
                        end
-                       if EV_TIMEOUT == event then  -- took too long to write some data to socket -> disconnect
-                               interface.fatalerror = "timeout during writing"
-                               debug( "writing failed:", interface.fatalerror )
-                               interface:_close()
-                               interface.eventwrite = false
-                               return -1
-                       else  -- can write :)
-                               if interface._usingssl then  -- handle luasec
-                                       if interface.eventreadtimeout then  -- we have to read first
-                                               local ret = interface.readcallback( )  -- call readcallback
-                                               --vdebug( "tried to read in writecallback, result:", ret )
-                                       end
-                                       if interface.eventwritetimeout then  -- luasec only
-                                               interface.eventwritetimeout:close( )  -- first we have to close timeout event which where regged after a wantread error
-                                               interface.eventwritetimeout = false
-                                       end
+                       interface.writebuffer = { t_concat(interface.writebuffer) }
+                       local succ, err, byte = interface.conn:send( interface.writebuffer[1], 1, interface.writebufferlen )
+                       --vdebug( "write data:", interface.writebuffer, "error:", err, "part:", byte )
+                       if succ then  -- writing succesful
+                               interface.writebuffer[1] = nil
+                               interface.writebufferlen = 0
+                               interface:ondrain();
+                               if interface.fatalerror then
+                                       debug "closing client after writing"
+                                       interface:_close()  -- close interface if needed
+                               elseif interface.startsslcallback then  -- start ssl connection if needed
+                                       debug "starting ssl handshake after writing"
+                                       interface.eventstarthandshake = addevent( base, nil, EV_TIMEOUT, interface.startsslcallback, 0 )
+                               elseif interface.eventreadtimeout then
+                                       return EV_WRITE, EV_TIMEOUT
                                end
-                               interface.writebuffer = { t_concat(interface.writebuffer) }
-                               local succ, err, byte = interface.conn:send( interface.writebuffer[1], 1, interface.writebufferlen )
-                               --vdebug( "write data:", interface.writebuffer, "error:", err, "part:", byte )
-                               if succ then  -- writing succesful
-                                       interface.writebuffer[1] = nil
-                                       interface.writebufferlen = 0
-                                       interface:ondrain();
-                                       if interface.fatalerror then
-                                               debug "closing client after writing"
-                                               interface:_close()  -- close interface if needed
-                                       elseif interface.startsslcallback then  -- start ssl connection if needed
-                                               debug "starting ssl handshake after writing"
-                                               interface.eventstarthandshake = addevent( base, nil, EV_TIMEOUT, interface.startsslcallback, 0 )
-                                       elseif interface.eventreadtimeout then
-                                               return EV_WRITE, EV_TIMEOUT
-                                       end
-                                       interface.eventwrite = nil
-                                       return -1
-                               elseif byte and (err == "timeout" or err == "wantwrite") then  -- want write again
-                                       --vdebug( "writebuffer is not empty:", err )
+                               interface.eventwrite = nil
+                               return -1
+                       elseif byte and (err == "timeout" or err == "wantwrite") then  -- want write again
+                               --vdebug( "writebuffer is not empty:", err )
                                interface.writebuffer[1] = s_sub( interface.writebuffer[1], byte + 1, interface.writebufferlen )  -- new buffer
-                                       interface.writebufferlen = interface.writebufferlen - byte
-                                       if "wantread" == err then  -- happens only with luasec
-                                               local callback = function( )
-                                                       interface:_close()
-                                                       interface.eventwritetimeout = nil
-                                                       return -1;
-                                               end
-                                               interface.eventwritetimeout = addevent( base, nil, EV_TIMEOUT, callback, cfg.WRITE_TIMEOUT )  -- reg a new timeout event
-                                               debug( "wantread during write attempt, reg it in readcallback but dont know what really happens next..." )
-                                               -- hopefully this works with luasec; its simply not possible to use 2 different write events on a socket in luaevent
-                                               return -1
+                               interface.writebufferlen = interface.writebufferlen - byte
+                               if "wantread" == err then  -- happens only with luasec
+                                       local callback = function( )
+                                               interface:_close()
+                                               interface.eventwritetimeout = nil
+                                               return -1;
                                        end
-                                       return EV_WRITE, cfg.WRITE_TIMEOUT
-                               else  -- connection was closed during writing or fatal error
-                                       interface.fatalerror = err or "fatal error"
-                                       debug( "connection failed in write event:", interface.fatalerror )
-                                       interface:_close()
-                                       interface.eventwrite = nil
+                                       interface.eventwritetimeout = addevent( base, nil, EV_TIMEOUT, callback, cfg.WRITE_TIMEOUT )  -- reg a new timeout event
+                                       debug( "wantread during write attempt, reg it in readcallback but dont know what really happens next..." )
+                                       -- hopefully this works with luasec; its simply not possible to use 2 different write events on a socket in luaevent
                                        return -1
                                end
+                               return EV_WRITE, cfg.WRITE_TIMEOUT
+                       else  -- connection was closed during writing or fatal error
+                               interface.fatalerror = err or "fatal error"
+                               debug( "connection failed in write event:", interface.fatalerror )
+                               interface:_close()
+                               interface.eventwrite = nil
+                               return -1
                        end
                end
+       end
 
-               interface.readcallback = function( event )  -- called on read events
-                       --vdebug( "new client read event, id/ip/port:", tostring(interface.id), tostring(ip), tostring(port) )
-                       if interface.noreading or interface.fatalerror then  -- leave this event
-                               --vdebug( "leaving this event because:", tostring(interface.noreading or interface.fatalerror) )
-                               interface.eventread = nil
-                               return -1
-                       end
+       interface.readcallback = function( event )  -- called on read events
+               --vdebug( "new client read event, id/ip/port:", tostring(interface.id), tostring(ip), tostring(port) )
+               if interface.noreading or interface.fatalerror then  -- leave this event
+                       --vdebug( "leaving this event because:", tostring(interface.noreading or interface.fatalerror) )
+                       interface.eventread = nil
+                       return -1
+               end
                if EV_TIMEOUT == event and interface:onreadtimeout() ~= true then
                        return -1 -- took too long to get some data from client -> disconnect
                end
-                               if interface._usingssl then  -- handle luasec
-                                       if interface.eventwritetimeout then  -- ok, in the past writecallback was regged
-                                               local ret = interface.writecallback( )  -- call it
-                                               --vdebug( "tried to write in readcallback, result:", tostring(ret) )
-                                       end
-                                       if interface.eventreadtimeout then
-                                               interface.eventreadtimeout:close( )
-                                               interface.eventreadtimeout = nil
-                                       end
-                               end
-                               local buffer, err, part = interface.conn:receive( interface._pattern )  -- receive buffer with "pattern"
-                               --vdebug( "read data:", tostring(buffer), "error:", tostring(err), "part:", tostring(part) )
-                               buffer = buffer or part
-                               if buffer and #buffer > cfg.MAX_READ_LENGTH then  -- check buffer length
-                                       interface.fatalerror = "receive buffer exceeded"
-                                       debug( "fatal error:", interface.fatalerror )
-                                       interface:_close()
-                                       interface.eventread = nil
-                                       return -1
+               if interface._usingssl then  -- handle luasec
+                       if interface.eventwritetimeout then  -- ok, in the past writecallback was regged
+                               local ret = interface.writecallback( )  -- call it
+                               --vdebug( "tried to write in readcallback, result:", tostring(ret) )
+                       end
+                       if interface.eventreadtimeout then
+                               interface.eventreadtimeout:close( )
+                               interface.eventreadtimeout = nil
+                       end
+               end
+               local buffer, err, part = interface.conn:receive( interface._pattern )  -- receive buffer with "pattern"
+               --vdebug( "read data:", tostring(buffer), "error:", tostring(err), "part:", tostring(part) )
+               buffer = buffer or part
+               if buffer and #buffer > cfg.MAX_READ_LENGTH then  -- check buffer length
+                       interface.fatalerror = "receive buffer exceeded"
+                       debug( "fatal error:", interface.fatalerror )
+                       interface:_close()
+                       interface.eventread = nil
+                       return -1
+               end
+               if err and ( err ~= "timeout" and err ~= "wantread" ) then
+                       if "wantwrite" == err then -- need to read on write event
+                               if not interface.eventwrite then  -- register new write event if needed
+                                       interface.eventwrite = addevent( base, interface.conn, EV_WRITE, interface.writecallback, cfg.WRITE_TIMEOUT )
                                end
-                               if err and ( err ~= "timeout" and err ~= "wantread" ) then
-                                       if "wantwrite" == err then -- need to read on write event
-                                               if not interface.eventwrite then  -- register new write event if needed
-                                                       interface.eventwrite = addevent( base, interface.conn, EV_WRITE, interface.writecallback, cfg.WRITE_TIMEOUT )
-                                               end
-                                               interface.eventreadtimeout = addevent( base, nil, EV_TIMEOUT,
-                                                       function( )
-                                                               interface:_close()
-                                                       end, cfg.READ_TIMEOUT
-                                               )
-                                               debug( "wantwrite during read attempt, reg it in writecallback but dont know what really happens next..." )
-                                               -- to be honest i dont know what happens next, if it is allowed to first read, the write etc...
-                                       else  -- connection was closed or fatal error
-                                               interface.fatalerror = err
-                                               debug( "connection failed in read event:", interface.fatalerror )
+                               interface.eventreadtimeout = addevent( base, nil, EV_TIMEOUT,
+                                       function( )
                                                interface:_close()
-                                               interface.eventread = nil
-                                               return -1
-                                       end
-                               else
-                                       interface.onincoming( interface, buffer, err )  -- send new data to listener
-                               end
-                               if interface.noreading then
-                                       interface.eventread = nil;
-                                       return -1;
-                               end
-                               return EV_READ, cfg.READ_TIMEOUT
+                                       end, cfg.READ_TIMEOUT
+                               )
+                               debug( "wantwrite during read attempt, reg it in writecallback but dont know what really happens next..." )
+                               -- to be honest i dont know what happens next, if it is allowed to first read, the write etc...
+                       else  -- connection was closed or fatal error
+                               interface.fatalerror = err
+                               debug( "connection failed in read event:", interface.fatalerror )
+                               interface:_close()
+                               interface.eventread = nil
+                               return -1
                        end
+               else
+                       interface.onincoming( interface, buffer, err )  -- send new data to listener
+               end
+               if interface.noreading then
+                       interface.eventread = nil;
+                       return -1;
+               end
+               return EV_READ, cfg.READ_TIMEOUT
+       end
 
-               client:settimeout( 0 )  -- set non blocking
-               setmetatable(interface, interface_mt)
+       client:settimeout( 0 )  -- set non blocking
+       setmetatable(interface, interface_mt)
        interfacelist[ interface ] = true  -- add to interfacelist
-               return interface
-       end
+       return interface
+end
 
 local function handleserver( server, addr, port, pattern, listener, sslctx )  -- creates an server interface
-               debug "creating server interface..."
-               local interface = {
-                       _connections = 0;
+       debug "creating server interface..."
+       local interface = {
+               _connections = 0;
 
                type = "server";
-                       conn = server;
-                       onconnect = listener.onconnect;  -- will be called when new client connected
-                       eventread = false;  -- read event handler
-                       eventclose = false; -- close event handler
-                       readcallback = false; -- read event callback
-                       fatalerror = false; -- error message
-                       nointerface = true;  -- lock/unlock parameter
-
-                       _ip = addr, _port = port, _pattern = pattern,
-                       _sslctx = sslctx;
-               }
-               interface.id = tostring(interface):match("%x+$");
-               interface.readcallback = function( event )  -- server handler, called on incoming connections
-                       --vdebug( "server can accept, id/addr/port:", interface, addr, port )
-                       if interface.fatalerror then
-                               --vdebug( "leaving this event because:", self.fatalerror )
-                               interface.eventread = nil
-                               return -1
+               conn = server;
+               onconnect = listener.onconnect;  -- will be called when new client connected
+               eventread = false;  -- read event handler
+               eventclose = false; -- close event handler
+               readcallback = false; -- read event callback
+               fatalerror = false; -- error message
+               nointerface = true;  -- lock/unlock parameter
+
+               _ip = addr, _port = port, _pattern = pattern,
+               _sslctx = sslctx;
+       }
+       interface.id = tostring(interface):match("%x+$");
+       interface.readcallback = function( event )  -- server handler, called on incoming connections
+               --vdebug( "server can accept, id/addr/port:", interface, addr, port )
+               if interface.fatalerror then
+                       --vdebug( "leaving this event because:", self.fatalerror )
+                       interface.eventread = nil
+                       return -1
+               end
+               local delay = cfg.ACCEPT_DELAY
+               if EV_TIMEOUT == event then
+                       if interface._connections >= cfg.MAX_CONNECTIONS then  -- check connection count
+                               debug( "to many connections, seconds to wait for next accept:", delay )
+                               return EV_TIMEOUT, delay  -- timeout...
+                       else
+                               return EV_READ  -- accept again
                        end
-                       local delay = cfg.ACCEPT_DELAY
-                       if EV_TIMEOUT == event then
-                               if interface._connections >= cfg.MAX_CONNECTIONS then  -- check connection count
-                                       debug( "to many connections, seconds to wait for next accept:", delay )
-                                       return EV_TIMEOUT, delay  -- timeout...
-                               else
-                                       return EV_READ  -- accept again
-                               end
+               end
+               --vdebug("max connection check ok, accepting...")
+               local client, err = server:accept()    -- try to accept; TODO: check err
+               while client do
+                       if interface._connections >= cfg.MAX_CONNECTIONS then
+                               client:close( )  -- refuse connection
+                               debug( "maximal connections reached, refuse client connection; accept delay:", delay )
+                               return EV_TIMEOUT, delay  -- delay for next accept attempt
                        end
-                       --vdebug("max connection check ok, accepting...")
-                       local client, err = server:accept()    -- try to accept; TODO: check err
-                       while client do
-                               if interface._connections >= cfg.MAX_CONNECTIONS then
-                                       client:close( )  -- refuse connection
-                                       debug( "maximal connections reached, refuse client connection; accept delay:", delay )
-                                       return EV_TIMEOUT, delay  -- delay for next accept attempt
-                               end
-                               local client_ip, client_port = client:getpeername( )
-                               interface._connections = interface._connections + 1  -- increase connection count
-                               local clientinterface = handleclient( client, client_ip, client_port, interface, pattern, listener, sslctx )
-                               --vdebug( "client id:", clientinterface, "startssl:", startssl )
+                       local client_ip, client_port = client:getpeername( )
+                       interface._connections = interface._connections + 1  -- increase connection count
+                       local clientinterface = handleclient( client, client_ip, client_port, interface, pattern, listener, sslctx )
+                       --vdebug( "client id:", clientinterface, "startssl:", startssl )
                        if has_luasec and sslctx then
-                                       clientinterface:starttls(sslctx, true)
-                               else
-                                       clientinterface:_start_session( true )
-                               end
-                               debug( "accepted incoming client connection from:", client_ip or "<unknown IP>", client_port or "<unknown port>", "to", port or "<unknown port>");
-
-                               client, err = server:accept()    -- try to accept again
+                               clientinterface:starttls(sslctx, true)
+                       else
+                               clientinterface:_start_session( true )
                        end
-                       return EV_READ
+                       debug( "accepted incoming client connection from:", client_ip or "<unknown IP>", client_port or "<unknown port>", "to", port or "<unknown port>");
+
+                       client, err = server:accept()    -- try to accept again
                end
+               return EV_READ
+       end
 
-               server:settimeout( 0 )
-               setmetatable(interface, interface_mt)
+       server:settimeout( 0 )
+       setmetatable(interface, interface_mt)
        interfacelist[ interface ] = true
-               interface:_start_session()
-               return interface
-       end
+       interface:_start_session()
+       return interface
+end
 
 local function addserver( addr, port, listener, pattern, sslctx, startssl )  -- TODO: check arguments
        --vdebug( "creating new tcp server with following parameters:", addr or "nil", port or "nil", sslctx or "nil", startssl or "nil")
        if sslctx and not has_luasec then
                debug "fatal error: luasec not found"
                return nil, "luasec not found"
-end
-               local server, err = socket.bind( addr, port, cfg.ACCEPT_QUEUE )  -- create server socket
-               if not server then
-                       debug( "creating server socket on "..addr.." port "..port.." failed:", err )
-                       return nil, err
-               end
-               local interface = handleserver( server, addr, port, pattern, listener, sslctx, startssl )  -- new server handler
-               debug( "new server created with id:", tostring(interface))
-               return interface
        end
+       local server, err = socket.bind( addr, port, cfg.ACCEPT_QUEUE )  -- create server socket
+       if not server then
+               debug( "creating server socket on "..addr.." port "..port.." failed:", err )
+               return nil, err
+       end
+       local interface = handleserver( server, addr, port, pattern, listener, sslctx, startssl )  -- new server handler
+       debug( "new server created with id:", tostring(interface))
+       return interface
+end
 
 local function wrapclient( client, ip, port, listeners, pattern, sslctx )
-               local interface = handleclient( client, ip, port, nil, pattern, listeners, sslctx )
-               interface:_start_connection(sslctx)
-               return interface, client
-               --function handleclient( client, ip, port, server, pattern, listener, _, sslctx )  -- creates an client interface
-       end
+       local interface = handleclient( client, ip, port, nil, pattern, listeners, sslctx )
+       interface:_start_connection(sslctx)
+       return interface, client
+       --function handleclient( client, ip, port, server, pattern, listener, _, sslctx )  -- creates an client interface
+end
 
 local function addclient( addr, serverport, listener, pattern, sslctx, typ )
        if sslctx and not has_luasec then
                debug "need luasec, but not available"
                return nil, "luasec not found"
-               end
-       if not typ then
+       end
+       if getaddrinfo and not typ then
                local addrinfo, err = getaddrinfo(addr)
                if not addrinfo then return nil, err end
                if addrinfo[1] and addrinfo[1].family == "inet6" then
                        typ = "tcp6"
-               else
-                       typ = "tcp"
-                       end
                end
-       local create = socket[typ]
+       end
+       local create = socket[typ or "tcp"]
        if type( create ) ~= "function"  then
                return nil, "invalid socket type"
-                       end
+       end
        local client, err = create()  -- creating new socket
        if not client then
                debug( "cannot create socket:", err )
-                               return nil, err
-                       end
+               return nil, err
+       end
        client:settimeout( 0 )  -- set nonblocking
-               local res, err = client:connect( addr, serverport )  -- connect
-               if res or ( err == "timeout" ) then
-                       local ip, port = client:getsockname( )
-               local interface = wrapclient( client, ip, serverport, listener, pattern, sslctx )
-               interface:_start_connection( sslctx )
-                       debug( "new connection id:", interface.id )
-                       return interface, err
-               else
-                       debug( "new connection failed:", err )
-                       return nil, err
+       local res, err = client:connect( addr, serverport )  -- connect
+       if res or ( err == "timeout" or err == "Operation already in progress" ) then
+               if client.getsockname then
+                       addr = client:getsockname( )
                end
+               local interface = wrapclient( client, addr, serverport, listener, pattern, sslctx )
+               debug( "new connection id:", interface.id )
+               return interface, err
+       else
+               debug( "new connection failed:", err )
+               return nil, err
        end
+end
 
 local function loop( )  -- starts the event loop
        base:loop( )
@@ -742,7 +741,7 @@ end
 
 local function newevent( ... )
        return addevent( base, ... )
-       end
+end
 
 local function closeallservers ( arg )
        for item in pairs( interfacelist ) do
@@ -754,9 +753,9 @@ end
 
 local function setquitting(yes)
        if yes then
-                -- Quit now
-                closeallservers();
-                base:loopexit();
+               -- Quit now
+               closeallservers();
+               base:loopexit();
        end
 end
 
@@ -799,6 +798,20 @@ local function link(sender, receiver, buffersize)
        sender:set_mode("*a");
 end
 
+local function add_task(delay, callback)
+       local event_handle;
+       event_handle = base:addevent(nil, 0, function ()
+               local ret = callback(socket_gettime());
+               if ret then
+                       return 0, ret;
+               elseif event_handle then
+                       return -1;
+               end
+       end
+       , delay);
+       return event_handle;
+end
+
 return {
        cfg = cfg,
        base = base,
@@ -814,6 +827,7 @@ return {
        closeall = closeallservers,
        get_backend = get_backend,
        hook_signal = hook_signal,
+       add_task = add_task,
 
        __NAME = SCRIPT_NAME,
        __DATE = LAST_MODIFIED,
index 3503c30d0079bd2f50daa04e89867b091efeefb2..37d57d29ae4afd5ffeab9960c5686d60f3c1700d 100644 (file)
@@ -31,7 +31,6 @@ local tostring = use "tostring"
 
 --// lua libs //--
 
-local os = use "os"
 local table = use "table"
 local string = use "string"
 local coroutine = use "coroutine"
@@ -41,6 +40,7 @@ local coroutine = use "coroutine"
 local math_min = math.min
 local math_huge = math.huge
 local table_concat = table.concat
+local table_insert = table.insert
 local string_sub = string.sub
 local coroutine_wrap = coroutine.wrap
 local coroutine_yield = coroutine.yield
@@ -56,7 +56,6 @@ local getaddrinfo = luasocket.dns.getaddrinfo
 
 local ssl_wrap = ( has_luasec and luasec.wrap )
 local socket_bind = luasocket.bind
-local socket_sleep = luasocket.sleep
 local socket_select = luasocket.select
 
 --// functions //--
@@ -101,7 +100,6 @@ local _sendtraffic
 local _readtraffic
 
 local _selecttimeout
-local _sleeptime
 local _tcpbacklog
 local _accepretry
 
@@ -115,8 +113,6 @@ local _checkinterval
 local _sendtimeout
 local _readtimeout
 
-local _timer
-
 local _maxselectlen
 local _maxfd
 
@@ -142,7 +138,6 @@ _sendtraffic = 0 -- some stats
 _readtraffic = 0
 
 _selecttimeout = 1 -- timeout of socket.select
-_sleeptime = 0 -- time to wait at the end of every loop
 _tcpbacklog = 128 -- some kind of hint to the OS
 _accepretry = 10 -- seconds to wait until the next attempt of a full server to accept
 
@@ -302,7 +297,6 @@ wrapconnection = function( server, listeners, socket, ip, serverport, clientport
        local bufferqueuelen = 0        -- end of buffer array
 
        local toclose
-       local fatalerror
        local needtls
 
        local bufferlen = 0
@@ -517,7 +511,6 @@ wrapconnection = function( server, listeners, socket, ip, serverport, clientport
                        return dispatch( handler, buffer, err )
                else    -- connections was closed or fatal error
                        out_put( "server.lua: client ", tostring(ip), ":", tostring(clientport), " read error: ", tostring(err) )
-                       fatalerror = true
                        _ = handler and handler:force_close( err )
                        return false
                end
@@ -557,7 +550,6 @@ wrapconnection = function( server, listeners, socket, ip, serverport, clientport
                        return true
                else    -- connection was closed during sending or fatal error
                        out_put( "server.lua: client ", tostring(ip), ":", tostring(clientport), " write error: ", tostring(err) )
-                       fatalerror = true
                        _ = handler and handler:force_close( err )
                        return false
                end
@@ -806,7 +798,6 @@ end
 getsettings = function( )
        return {
                select_timeout = _selecttimeout;
-               select_sleep_time = _sleeptime;
                tcp_backlog = _tcpbacklog;
                max_send_buffer_size = _maxsendlen;
                max_receive_buffer_size = _maxreadlen;
@@ -825,7 +816,6 @@ changesettings = function( new )
                return nil, "invalid settings table"
        end
        _selecttimeout = tonumber( new.select_timeout ) or _selecttimeout
-       _sleeptime = tonumber( new.select_sleep_time ) or _sleeptime
        _maxsendlen = tonumber( new.max_send_buffer_size ) or _maxsendlen
        _maxreadlen = tonumber( new.max_receive_buffer_size ) or _maxreadlen
        _checkinterval = tonumber( new.select_idle_check_interval ) or _checkinterval
@@ -848,6 +838,49 @@ addtimer = function( listener )
        return true
 end
 
+local add_task do
+       local data = {};
+       local new_data = {};
+
+       function add_task(delay, callback)
+               local current_time = luasocket_gettime();
+               delay = delay + current_time;
+               if delay >= current_time then
+                       table_insert(new_data, {delay, callback});
+               else
+                       local r = callback(current_time);
+                       if r and type(r) == "number" then
+                               return add_task(r, callback);
+                       end
+               end
+       end
+
+       addtimer(function(current_time)
+               if #new_data > 0 then
+                       for _, d in pairs(new_data) do
+                               table_insert(data, d);
+                       end
+                       new_data = {};
+               end
+
+               local next_time = math_huge;
+               for i, d in pairs(data) do
+                       local t, callback = d[1], d[2];
+                       if t <= current_time then
+                               data[i] = nil;
+                               local r = callback(current_time);
+                               if type(r) == "number" then
+                                       add_task(r, callback);
+                                       next_time = math_min(next_time, r);
+                               end
+                       else
+                               next_time = math_min(next_time, t - current_time);
+                       end
+               end
+               return next_time;
+       end);
+end
+
 stats = function( )
        return _readtraffic, _sendtraffic, _readlistlen, _sendlistlen, _timerlistlen
 end
@@ -861,8 +894,15 @@ end
 loop = function(once) -- this is the main loop of the program
        if quitting then return "quitting"; end
        if once then quitting = "once"; end
-       local next_timer_time = math_huge;
+       _currenttime = luasocket_gettime( )
        repeat
+               -- Fire timers
+       local next_timer_time = math_huge;
+               for i = 1, _timerlistlen do
+                       local t = _timerlist[ i ]( _currenttime ) -- fire timers
+                       if t then next_timer_time = math_min(next_timer_time, t); end
+               end
+
                local read, write, err = socket_select( _readlist, _sendlist, math_min(_selecttimeout, next_timer_time) )
                for i, socket in ipairs( write ) do -- send data waiting in writequeues
                        local handler = _socketlist[ socket ]
@@ -910,27 +950,12 @@ loop = function(once) -- this is the main loop of the program
                        end
                end
 
-               -- Fire timers
-               if _currenttime - _timer >= math_min(next_timer_time, 1) then
-                       next_timer_time = math_huge;
-                       for i = 1, _timerlistlen do
-                               local t = _timerlist[ i ]( _currenttime ) -- fire timers
-                               if t then next_timer_time = math_min(next_timer_time, t); end
-                       end
-                       _timer = _currenttime
-               else
-                       next_timer_time = next_timer_time - (_currenttime - _timer);
-               end
-
                for server, paused_time in pairs( _fullservers ) do
                        if _currenttime - paused_time > _accepretry then
                                _fullservers[ server ] = nil;
                                server.resume();
                        end
                end
-
-               -- wait some time (0 by default)
-               socket_sleep( _sleeptime )
        until quitting;
        if once and quitting == "once" then quitting = nil; return; end
        closeall();
@@ -977,16 +1002,14 @@ local addclient = function( address, port, listeners, pattern, sslctx, typ )
        elseif sslctx and not has_luasec then
                err = "luasec not found"
        end
-       if not typ then
+       if getaddrinfo and not typ then
                local addrinfo, err = getaddrinfo(address)
                if not addrinfo then return nil, err end
                if addrinfo[1] and addrinfo[1].family == "inet6" then
                        typ = "tcp6"
-               else
-                       typ = "tcp"
                end
        end
-       local create = luasocket[typ]
+       local create = luasocket[typ or "tcp"]
        if type( create ) ~= "function"  then
                err = "invalid socket type"
        end
@@ -1002,22 +1025,19 @@ local addclient = function( address, port, listeners, pattern, sslctx, typ )
        end
        client:settimeout( 0 )
        local ok, err = client:connect( address, port )
-       if ok or err == "timeout" then
+       if ok or err == "timeout" or err == "Operation already in progress" then
                return wrapclient( client, address, port, listeners, pattern, sslctx )
        else
                return nil, err
        end
 end
 
---// EXPERIMENTAL //--
-
 ----------------------------------// BEGIN //--
 
 use "setmetatable" ( _socketlist, { __mode = "k" } )
 use "setmetatable" ( _readtimes, { __mode = "k" } )
 use "setmetatable" ( _writetimes, { __mode = "k" } )
 
-_timer = luasocket_gettime( )
 _starttime = luasocket_gettime( )
 
 local function setlogger(new_logger)
@@ -1032,6 +1052,7 @@ end
 
 return {
        _addtimer = addtimer,
+       add_task = add_task;
 
        addclient = addclient,
        wrapclient = wrapclient,
index 9dfbbc7a379c524ad1dcdc79381a6ce2123014e9..916b29a3d4c669f133be75ce52e5e139b2321d02 100644 (file)
@@ -336,6 +336,43 @@ function def_env.server:memory()
        return true, "OK";
 end
 
+def_env.timer = {};
+
+function def_env.timer:info()
+       local socket = require "socket";
+       local print = self.session.print;
+       local add_task = require"util.timer".add_task;
+       local h, params = add_task.h, add_task.params;
+       if h then
+               print("-- util.timer");
+               for i, id in ipairs(h.ids) do
+                       if not params[id] then
+                               print(os.date("%F %T", h.priorities[i]), h.items[id]);
+                       elseif not params[id].callback then
+                               print(os.date("%F %T", h.priorities[i]), h.items[id], unpack(params[id]));
+                       else
+                               print(os.date("%F %T", h.priorities[i]), params[id].callback, unpack(params[id]));
+                       end
+               end
+       end
+       if server.event_base then
+               local count = 0;
+               for k, v in pairs(debug.getregistry()) do
+                       if type(v) == "function" and v.callback and v.callback == add_task._on_timer then
+                               count = count + 1;
+                       end
+               end
+               print(count .. " libevent callbacks");
+       end
+       if h then
+               local next_time = h:peek();
+               if next_time then
+                       return true, os.date("Next event at %F %T (in %%.6fs)", next_time):format(next_time - socket.gettime());
+               end
+       end
+       return true;
+end
+
 def_env.module = {};
 
 local function get_hosts_set(hosts, module)
@@ -971,7 +1008,7 @@ function def_env.muc:room(room_jid)
        if not room_name then
                return room_name, host;
        end
-       local room_obj = hosts[host].modules.muc.rooms[room_jid];
+       local room_obj = hosts[host].modules.muc.get_room_from_jid(room_jid);
        if not room_obj then
                return nil, "No such room: "..room_jid;
        end
@@ -985,8 +1022,8 @@ function def_env.muc:list(host)
        end
        local print = self.session.print;
        local c = 0;
-       for name in keys(host_session.modules.muc.rooms) do
-               print(name);
+       for room in host_session.modules.muc.each_room() do
+               print(room.jid);
                c = c + 1;
        end
        return true, c.." rooms";
index 032b20a82fe2c426289a71a25841cd83401c7b9d..a567c605f8e0feb207a7876bdc7ebc95f5afa6e4 100644 (file)
@@ -22,6 +22,7 @@ local initialize_filters = require "util.filters".initialize;
 local math_min = math.min;
 local xpcall, tostring, type = xpcall, tostring, type;
 local traceback = debug.traceback;
+local runner = require"util.async".runner;
 
 local xmlns_streams = "http://etherx.jabber.org/streams";
 local xmlns_xmpp_streams = "urn:ietf:params:xml:ns:xmpp-streams";
@@ -62,13 +63,11 @@ local t_insert, t_remove, t_concat = table.insert, table.remove, table.concat;
 local os_time = os.time;
 
 -- All sessions, and sessions that have no requests open
-local sessions, inactive_sessions = module:shared("sessions", "inactive_sessions");
+local sessions = module:shared("sessions");
 
 -- Used to respond to idle sessions (those with waiting requests)
-local waiting_requests = module:shared("waiting_requests");
 function on_destroy_request(request)
        log("debug", "Request destroyed: %s", tostring(request));
-       waiting_requests[request] = nil;
        local session = sessions[request.context.sid];
        if session then
                local requests = session.requests;
@@ -82,9 +81,24 @@ function on_destroy_request(request)
                -- If this session now has no requests open, mark it as inactive
                local max_inactive = session.bosh_max_inactive;
                if max_inactive and #requests == 0 then
-                       inactive_sessions[session] = os_time() + max_inactive;
+                       if session.inactive_timer then
+                               session.inactive_timer:stop();
+                       end
+                       session.inactive_timer = module:add_timer(max_inactive, check_inactive, session, request.context,
+                               "BOSH client silent for over "..max_inactive.." seconds");
                        (session.log or log)("debug", "BOSH session marked as inactive (for %ds)", max_inactive);
                end
+               if session.bosh_wait_timer then
+                       session.bosh_wait_timer:stop();
+                       session.bosh_wait_timer = nil;
+               end
+       end
+end
+
+function check_inactive(now, session, context, reason)
+       if not sessions.destroyed then
+               sessions[context.sid] = nil;
+               sm_destroy_session(session, reason);
        end
 end
 
@@ -118,7 +132,7 @@ function handle_POST(event)
        local headers = response.headers;
        headers.content_type = "text/xml; charset=utf-8";
 
-       if cross_domain and event.request.headers.origin then
+       if cross_domain and request.headers.origin then
                set_cross_domain_headers(response);
        end
 
@@ -139,8 +153,14 @@ function handle_POST(event)
        if session then
                -- Session was marked as inactive, since we have
                -- a request open now, unmark it
-               if inactive_sessions[session] and #session.requests > 0 then
-                       inactive_sessions[session] = nil;
+               if session.inactive_timer and #session.requests > 0 then
+                       session.inactive_timer:stop();
+                       session.inactive_timer = nil;
+               end
+
+               if session.bosh_wait_timer then
+                       session.bosh_wait_timer:stop();
+                       session.bosh_wait_timer = nil;
                end
 
                local r = session.requests;
@@ -169,7 +189,7 @@ function handle_POST(event)
                        -- We're keeping this request open, to respond later
                        log("debug", "Have nothing to say, so leaving request unanswered for now");
                        if session.bosh_wait then
-                               waiting_requests[response] = os_time() + session.bosh_wait;
+                               session.bosh_wait_timer = module:add_timer(session.bosh_wait, after_bosh_wait, request, session)
                        end
                end
 
@@ -185,6 +205,11 @@ function handle_POST(event)
        return 400;
 end
 
+function after_bosh_wait(now, request, session)
+       if request.conn then
+               session.send("");
+       end
+end
 
 local function bosh_reset_stream(session) session.notopen = true; end
 
@@ -224,10 +249,11 @@ local function bosh_close_stream(session, reason)
                held_request:send(response_body);
        end
        sessions[session.sid] = nil;
-       inactive_sessions[session] = nil;
        sm_destroy_session(session);
 end
 
+local runner_callbacks = { };
+
 -- Handle the <body> tag in the request payload.
 function stream_callbacks.streamopened(context, attr)
        local request, response = context.request, context.response;
@@ -260,6 +286,10 @@ function stream_callbacks.streamopened(context, attr)
                };
                sessions[sid] = session;
 
+               session.thread = runner(function (stanza)
+                       session:dispatch_stanza(stanza);
+               end, runner_callbacks, session);
+
                local filter = initialize_filters(session);
 
                session.log("debug", "BOSH session created for request from %s", session.ip);
@@ -358,6 +388,11 @@ function stream_callbacks.streamopened(context, attr)
 end
 
 local function handleerr(err) log("error", "Traceback[bosh]: %s", traceback(tostring(err), 2)); end
+
+function runner_callbacks:error(err)
+       return handleerr(err);
+end
+
 function stream_callbacks.handlestanza(context, stanza)
        if context.ignore then return; end
        log("debug", "BOSH stanza received: %s\n", stanza:top_tag());
@@ -367,9 +402,7 @@ function stream_callbacks.handlestanza(context, stanza)
                        stanza.attr.xmlns = nil;
                end
                stanza = session.filter("stanzas/in", stanza);
-               if stanza then
-                       return xpcall(function () return core_process_stanza(session, stanza) end, handleerr);
-               end
+               session.thread:run(stanza);
        end
 end
 
@@ -400,44 +433,6 @@ function stream_callbacks.error(context, error)
        end
 end
 
-local dead_sessions = module:shared("dead_sessions");
-function on_timer()
-       -- log("debug", "Checking for requests soon to timeout...");
-       -- Identify requests timing out within the next few seconds
-       local now = os_time() + 3;
-       for request, reply_before in pairs(waiting_requests) do
-               if reply_before <= now then
-                       log("debug", "%s was soon to timeout (at %d, now %d), sending empty response", tostring(request), reply_before, now);
-                       -- Send empty response to let the
-                       -- client know we're still here
-                       if request.conn then
-                               sessions[request.context.sid].send("");
-                       end
-               end
-       end
-
-       now = now - 3;
-       local n_dead_sessions = 0;
-       for session, close_after in pairs(inactive_sessions) do
-               if close_after < now then
-                       (session.log or log)("debug", "BOSH client inactive too long, destroying session at %d", now);
-                       sessions[session.sid]  = nil;
-                       inactive_sessions[session] = nil;
-                       n_dead_sessions = n_dead_sessions + 1;
-                       dead_sessions[n_dead_sessions] = session;
-               end
-       end
-
-       for i=1,n_dead_sessions do
-               local session = dead_sessions[i];
-               dead_sessions[i] = nil;
-               sm_destroy_session(session, "BOSH client silent for over "..session.bosh_max_inactive.." seconds");
-       end
-       return 1;
-end
-module:add_timer(1, on_timer);
-
-
 local GET_response = {
        headers = {
                content_type = "text/html";
index 2829d5fdb61fe221d59f22d65d618abcf8c5ee68..a690e9be7f112931f5f77680d21c77de482b0884 100644 (file)
@@ -15,9 +15,10 @@ local sessionmanager = require "core.sessionmanager";
 local st = require "util.stanza";
 local sm_new_session, sm_destroy_session = sessionmanager.new_session, sessionmanager.destroy_session;
 local uuid_generate = require "util.uuid".generate;
+local runner = require "util.async".runner;
 
 local xpcall, tostring, type = xpcall, tostring, type;
-local traceback = debug.traceback;
+local t_insert, t_remove = table.insert, table.remove;
 
 local xmlns_xmpp_streams = "urn:ietf:params:xml:ns:xmpp-streams";
 
@@ -35,6 +36,7 @@ local hosts = prosody.hosts;
 
 local stream_callbacks = { default_ns = "jabber:client" };
 local listener = {};
+local runner_callbacks = {};
 
 --- Stream events handlers
 local stream_xmlns_attr = {xmlns='urn:ietf:params:xml:ns:xmpp-streams'};
@@ -121,12 +123,9 @@ function stream_callbacks.error(session, error, data)
        end
 end
 
-local function handleerr(err) log("error", "Traceback[c2s]: %s", traceback(tostring(err), 2)); end
 function stream_callbacks.handlestanza(session, stanza)
        stanza = session.filter("stanzas/in", stanza);
-       if stanza then
-               return xpcall(function () return core_process_stanza(session, stanza) end, handleerr);
-       end
+       session.thread:run(stanza);
 end
 
 --- Session methods
@@ -195,6 +194,18 @@ module:hook_global("user-deleted", function(event)
        end
 end, 200);
 
+function runner_callbacks:ready()
+       self.data.conn:resume();
+end
+
+function runner_callbacks:waiting()
+       self.data.conn:pause();
+end
+
+function runner_callbacks:error(err)
+       (self.data.log or log)("error", "Traceback[c2s]: %s", err);
+end
+
 --- Port listener
 function listener.onconnect(conn)
        measure_connections(1);
@@ -232,6 +243,10 @@ function listener.onconnect(conn)
                session.stream:reset();
        end
 
+       session.thread = runner(function (stanza)
+               core_process_stanza(session, stanza);
+       end, runner_callbacks, session);
+
        local filter = session.filter;
        function session.data(data)
                -- Parse the data, which will store stanzas in session.pending_stanzas
index 086887fbcc9a9b63ccd078c3a65804481d12a419..c8ca563760939cee015e814b471dcc2b6281002c 100644 (file)
@@ -47,6 +47,9 @@ end
 
 local function redir_handler(event)
        event.response.headers.location = event.request.path.."/";
+ if event.request.url.query then
+ event.response.headers.location = event.response.headers.location .. "?" .. event.request.url.query
+ end
        return 301;
 end
 
diff --git a/plugins/mod_muc_unique.lua b/plugins/mod_muc_unique.lua
new file mode 100644 (file)
index 0000000..0ecd0c7
--- /dev/null
@@ -0,0 +1,12 @@
+-- XEP-0307: Unique Room Names for Multi-User Chat
+local st = require "util.stanza";
+local uuid_gen = require "util.uuid".generate;
+module:add_feature "http://jabber.org/protocol/muc#unique"
+module:hook("iq-get/host/http://jabber.org/protocol/muc#unique:unique", function(event)
+       local origin, stanza = event.origin, event.stanza;
+       origin.send(st.reply(stanza)
+               :tag("unique", {xmlns = "http://jabber.org/protocol/muc#unique"})
+               :text(uuid_gen()) -- FIXME Random UUIDs can theoretically have collisions
+       );
+       return true;
+end,-1);
diff --git a/plugins/mod_pep_plus.lua b/plugins/mod_pep_plus.lua
new file mode 100644 (file)
index 0000000..f45d5ef
--- /dev/null
@@ -0,0 +1,393 @@
+local pubsub = require "util.pubsub";
+local jid_bare = require "util.jid".bare;
+local jid_split = require "util.jid".split;
+local set_new = require "util.set".new;
+local st = require "util.stanza";
+local calculate_hash = require "util.caps".calculate_hash;
+local is_contact_subscribed = require "core.rostermanager".is_contact_subscribed;
+
+local xmlns_pubsub = "http://jabber.org/protocol/pubsub";
+local xmlns_pubsub_event = "http://jabber.org/protocol/pubsub#event";
+local xmlns_pubsub_owner = "http://jabber.org/protocol/pubsub#owner";
+
+local lib_pubsub = module:require "pubsub";
+local handlers = lib_pubsub.handlers;
+local pubsub_error_reply = lib_pubsub.pubsub_error_reply;
+
+local empty_set = set_new();
+
+local services = {};
+local recipients = {};
+local hash_map = {};
+
+function module.save()
+       return { services = services };
+end
+
+function module.restore(data)
+       services = data.services;
+end
+
+local function subscription_presence(user_bare, recipient)
+       local recipient_bare = jid_bare(recipient);
+       if (recipient_bare == user_bare) then return true; end
+       local username, host = jid_split(user_bare);
+       return is_contact_subscribed(username, host, recipient_bare);
+end
+
+local function get_broadcaster(name)
+       local function simple_broadcast(kind, node, jids, item)
+               if item then
+                       item = st.clone(item);
+                       item.attr.xmlns = nil; -- Clear the pubsub namespace
+               end
+               local message = st.message({ from = name, type = "headline" })
+                       :tag("event", { xmlns = xmlns_pubsub_event })
+                               :tag(kind, { node = node })
+                                       :add_child(item);
+               for jid in pairs(jids) do
+                       module:log("debug", "Sending notification to %s from %s: %s", jid, name, tostring(item));
+                       message.attr.to = jid;
+                       module:send(message);
+               end
+       end
+       return simple_broadcast;
+end
+
+function get_pep_service(name)
+       local service = services[name];
+       if service then
+               return service;
+       end
+       service = pubsub.new({
+               capabilities = {
+                       none = {
+                               create = false;
+                               publish = false;
+                               retract = false;
+                               get_nodes = false;
+
+                               subscribe = false;
+                               unsubscribe = false;
+                               get_subscription = false;
+                               get_subscriptions = false;
+                               get_items = false;
+
+                               subscribe_other = false;
+                               unsubscribe_other = false;
+                               get_subscription_other = false;
+                               get_subscriptions_other = false;
+
+                               be_subscribed = true;
+                               be_unsubscribed = true;
+
+                               set_affiliation = false;
+                       };
+                       subscriber = {
+                               create = false;
+                               publish = false;
+                               retract = false;
+                               get_nodes = true;
+
+                               subscribe = true;
+                               unsubscribe = true;
+                               get_subscription = true;
+                               get_subscriptions = true;
+                               get_items = true;
+
+                               subscribe_other = false;
+                               unsubscribe_other = false;
+                               get_subscription_other = false;
+                               get_subscriptions_other = false;
+
+                               be_subscribed = true;
+                               be_unsubscribed = true;
+
+                               set_affiliation = false;
+                       };
+                       publisher = {
+                               create = false;
+                               publish = true;
+                               retract = true;
+                               get_nodes = true;
+
+                               subscribe = true;
+                               unsubscribe = true;
+                               get_subscription = true;
+                               get_subscriptions = true;
+                               get_items = true;
+
+                               subscribe_other = false;
+                               unsubscribe_other = false;
+                               get_subscription_other = false;
+                               get_subscriptions_other = false;
+
+                               be_subscribed = true;
+                               be_unsubscribed = true;
+
+                               set_affiliation = false;
+                       };
+                       owner = {
+                               create = true;
+                               publish = true;
+                               retract = true;
+                               delete = true;
+                               get_nodes = true;
+                               configure = true;
+
+                               subscribe = true;
+                               unsubscribe = true;
+                               get_subscription = true;
+                               get_subscriptions = true;
+                               get_items = true;
+
+
+                               subscribe_other = true;
+                               unsubscribe_other = true;
+                               get_subscription_other = true;
+                               get_subscriptions_other = true;
+
+                               be_subscribed = true;
+                               be_unsubscribed = true;
+
+                               set_affiliation = true;
+                       };
+               };
+
+               node_defaults = {
+                       ["pubsub#max_items"] = "1";
+               };
+
+               autocreate_on_publish = true;
+               autocreate_on_subscribe = true;
+
+               broadcaster = get_broadcaster(name);
+               get_affiliation = function (jid)
+                       if jid_bare(jid) == name then
+                               return "owner";
+                       elseif subscription_presence(name, jid) then
+                               return "subscriber";
+                       end
+               end;
+
+               normalize_jid = jid_bare;
+       });
+       services[name] = service;
+       module:add_item("pep-service", { service = service, jid = name });
+       return service;
+end
+
+function handle_pubsub_iq(event)
+       local origin, stanza = event.origin, event.stanza;
+       local pubsub = stanza.tags[1];
+       local action = pubsub.tags[1];
+       if not action then
+               return origin.send(st.error_reply(stanza, "cancel", "bad-request"));
+       end
+       local service_name = stanza.attr.to or origin.username.."@"..origin.host
+       local service = get_pep_service(service_name);
+       local handler = handlers[stanza.attr.type.."_"..action.name];
+       if handler then
+               handler(origin, stanza, action, service);
+               return true;
+       end
+end
+
+module:hook("iq/bare/"..xmlns_pubsub..":pubsub", handle_pubsub_iq);
+module:hook("iq/bare/"..xmlns_pubsub_owner..":pubsub", handle_pubsub_iq);
+
+module:add_identity("pubsub", "pep", module:get_option_string("name", "Prosody"));
+module:add_feature("http://jabber.org/protocol/pubsub#publish");
+
+local function get_caps_hash_from_presence(stanza, current)
+       local t = stanza.attr.type;
+       if not t then
+               local child = stanza:get_child("c", "http://jabber.org/protocol/caps");
+               if child then
+                       local attr = child.attr;
+                       if attr.hash then -- new caps
+                               if attr.hash == 'sha-1' and attr.node and attr.ver then
+                                       return attr.ver, attr.node.."#"..attr.ver;
+                               end
+                       else -- legacy caps
+                               if attr.node and attr.ver then
+                                       return attr.node.."#"..attr.ver.."#"..(attr.ext or ""), attr.node.."#"..attr.ver;
+                               end
+                       end
+               end
+               return; -- no or bad caps
+       elseif t == "unavailable" or t == "error" then
+               return;
+       end
+       return current; -- no caps, could mean caps optimization, so return current
+end
+
+local function resend_last_item(jid, node, service)
+       local ok, items = service:get_items(node, jid);
+       if not ok then return; end
+       for i, id in ipairs(items) do
+               service.config.broadcaster("items", node, { [jid] = true }, items[id]);
+       end
+end
+
+local function update_subscriptions(recipient, service_name, nodes)
+       local service = get_pep_service(service_name);
+       nodes = nodes or empty_set;
+
+       local service_recipients = recipients[service_name];
+       if not service_recipients then
+               service_recipients = {};
+               recipients[service_name] = service_recipients;
+       end
+
+       local current = service_recipients[recipient];
+       if not current or type(current) ~= "table" then
+               current = empty_set;
+       end
+
+       if (current == empty_set or current:empty()) and (nodes == empty_set or nodes:empty()) then
+               return;
+       end
+
+       for node in current - nodes do
+               service:remove_subscription(node, recipient, recipient);
+       end
+
+       for node in nodes - current do
+               service:add_subscription(node, recipient, recipient);
+               resend_last_item(recipient, node, service);
+       end
+
+       if nodes == empty_set or nodes:empty() then
+               nodes = nil;
+       end
+
+       service_recipients[recipient] = nodes;
+end
+
+module:hook("presence/bare", function(event)
+       -- inbound presence to bare JID recieved
+       local origin, stanza = event.origin, event.stanza;
+       local user = stanza.attr.to or (origin.username..'@'..origin.host);
+       local t = stanza.attr.type;
+       local self = not stanza.attr.to;
+       local service = get_pep_service(user);
+
+       if not t then -- available presence
+               if self or subscription_presence(user, stanza.attr.from) then
+                       local recipient = stanza.attr.from;
+                       local current = recipients[user] and recipients[user][recipient];
+                       local hash, query_node = get_caps_hash_from_presence(stanza, current);
+                       if current == hash or (current and current == hash_map[hash]) then return; end
+                       if not hash then
+                               update_subscriptions(recipient, user);
+                       else
+                               recipients[user] = recipients[user] or {};
+                               if hash_map[hash] then
+                                       update_subscriptions(recipient, user, hash_map[hash]);
+                               else
+                                       recipients[user][recipient] = hash;
+                                       local from_bare = origin.type == "c2s" and origin.username.."@"..origin.host;
+                                       if self or origin.type ~= "c2s" or (recipients[from_bare] and recipients[from_bare][origin.full_jid]) ~= hash then
+                                               -- COMPAT from ~= stanza.attr.to because OneTeam can't deal with missing from attribute
+                                               origin.send(
+                                                       st.stanza("iq", {from=user, to=stanza.attr.from, id="disco", type="get"})
+                                                               :tag("query", {xmlns = "http://jabber.org/protocol/disco#info", node = query_node})
+                                               );
+                                       end
+                               end
+                       end
+               end
+       elseif t == "unavailable" then
+               update_subscriptions(stanza.attr.from, user);
+       elseif not self and t == "unsubscribe" then
+               local from = jid_bare(stanza.attr.from);
+               local subscriptions = recipients[user];
+               if subscriptions then
+                       for subscriber in pairs(subscriptions) do
+                               if jid_bare(subscriber) == from then
+                                       update_subscriptions(subscriber, user);
+                               end
+                       end
+               end
+       end
+end, 10);
+
+module:hook("iq-result/bare/disco", function(event)
+       local origin, stanza = event.origin, event.stanza;
+       local disco = stanza:get_child("query", "http://jabber.org/protocol/disco#info");
+       if not disco then
+               return;
+       end
+
+       -- Process disco response
+       local self = not stanza.attr.to;
+       local user = stanza.attr.to or (origin.username..'@'..origin.host);
+       local contact = stanza.attr.from;
+       local current = recipients[user] and recipients[user][contact];
+       if type(current) ~= "string" then return; end -- check if waiting for recipient's response
+       local ver = current;
+       if not string.find(current, "#") then
+               ver = calculate_hash(disco.tags); -- calculate hash
+       end
+       local notify = set_new();
+       for _, feature in pairs(disco.tags) do
+               if feature.name == "feature" and feature.attr.var then
+                       local nfeature = feature.attr.var:match("^(.*)%+notify$");
+                       if nfeature then notify:add(nfeature); end
+               end
+       end
+       hash_map[ver] = notify; -- update hash map
+       if self then
+               for jid, item in pairs(origin.roster) do -- for all interested contacts
+                       if item.subscription == "both" or item.subscription == "from" then
+                               if not recipients[jid] then recipients[jid] = {}; end
+                               update_subscriptions(contact, jid, notify);
+                       end
+               end
+       end
+       update_subscriptions(contact, user, notify);
+end);
+
+module:hook("account-disco-info-node", function(event)
+       local reply, stanza, origin = event.reply, event.stanza, event.origin;
+       local service_name = stanza.attr.to or origin.username.."@"..origin.host
+       local service = get_pep_service(service_name);
+       local node = event.node;
+       local ok = service:get_items(node, jid_bare(stanza.attr.from) or true);
+       if not ok then return; end
+       event.exists = true;
+       reply:tag('identity', {category='pubsub', type='leaf'}):up();
+end);
+
+module:hook("account-disco-info", function(event)
+       local reply = event.reply;
+       reply:tag('identity', {category='pubsub', type='pep'}):up();
+       reply:tag('feature', {var='http://jabber.org/protocol/pubsub#publish'}):up();
+end);
+
+module:hook("account-disco-items-node", function(event)
+       local reply, stanza, origin = event.reply, event.stanza, event.origin;
+       local node = event.node;
+       local service_name = stanza.attr.to or origin.username.."@"..origin.host
+       local service = get_pep_service(service_name);
+       local ok, ret = service:get_items(node, jid_bare(stanza.attr.from) or true);
+       if not ok then return; end
+       event.exists = true;
+       for _, id in ipairs(ret) do
+               reply:tag("item", { jid = service_name, name = id }):up();
+       end
+end);
+
+module:hook("account-disco-items", function(event)
+       local reply, stanza, origin = event.reply, event.stanza, event.origin;
+
+       local service_name = reply.attr.from or origin.username.."@"..origin.host
+       local service = get_pep_service(service_name);
+       local ok, ret = service:get_nodes(jid_bare(stanza.attr.from));
+       if not ok then return; end
+
+       for node, node_obj in pairs(ret) do
+               reply:tag("item", { jid = service_name, node = node, name = node_obj.config.name }):up();
+       end
+end);
index c01053d509b8effaed36d55572d44ffa2e96be43..9375cf80d9bd4d759c859cb8b222a0fc8ec04eec 100644 (file)
@@ -9,7 +9,7 @@
 
 local st = require "util.stanza"
 
-local private_storage = module:open_store();
+local private_storage = module:open_store("private", "map");
 
 module:add_feature("jabber:iq:private");
 
@@ -22,28 +22,23 @@ module:hook("iq/self/jabber:iq:private:query", function(event)
        end
        local tag = query.tags[1];
        local key = tag.name..":"..tag.attr.xmlns;
-       local data, err = private_storage:get(origin.username);
-       if err then
-               origin.send(st.error_reply(stanza, "wait", "internal-server-error", err));
-               return true;
-       end
        if stanza.attr.type == "get" then
-               if data and data[key] then
-                       origin.send(st.reply(stanza):query("jabber:iq:private"):add_child(st.deserialize(data[key])));
-                       return true;
+               local data, err = private_storage:get(origin.username, key);
+               if data then
+                       origin.send(st.reply(stanza):query("jabber:iq:private"):add_child(st.deserialize(data)));
+               elseif err then
+                       origin.send(st.error_reply(stanza, "wait", "internal-server-error", err));
                else
                        origin.send(st.reply(stanza):add_child(query));
-                       return true;
                end
+               return true;
        else -- type == set
-               if not data then data = {}; end;
-               if #tag == 0 then
-                       data[key] = nil;
-               else
-                       data[key] = st.preserialize(tag);
+               local data;
+               if #tag ~= 0 then
+                       data = st.preserialize(tag);
                end
                -- TODO delete datastore if empty
-               local ok, err = private_storage:set(origin.username, data);
+               local ok, err = private_storage:set(origin.username, key, data);
                if not ok then
                        origin.send(st.error_reply(stanza, "wait", "internal-server-error", err));
                        return true;
index 16320ad169afd651a081daaa4d05f23556aead9a..431e712c94b5bd3279cba8cc0f547b019e13c9f7 100644 (file)
@@ -56,6 +56,9 @@ local function bounce_sendq(session, reason)
                        (session.log or log)("error", "Replying to to an s2s error reply, please report this! Traceback: %s", traceback());
                end;
                dummy = true;
+               close = function ()
+                       (session.log or log)("error", "Attempting to close the dummy origin of s2s error replies, please report this! Traceback: %s", traceback());
+               end;
        };
        for i, data in ipairs(sendq) do
                local reply = data[2];
diff --git a/plugins/muc/affiliation_notify.lib.lua b/plugins/muc/affiliation_notify.lib.lua
new file mode 100644 (file)
index 0000000..0b9ab32
--- /dev/null
@@ -0,0 +1,65 @@
+-- Prosody IM
+-- Copyright (C) 2014 Daurnimator
+--
+-- This project is MIT/X11 licensed. Please see the
+-- COPYING file in the source package for more information.
+--
+
+--[[
+Out of courtesy, a MUC service MAY send an out-of-room <message/>
+if a user's affiliation changes while the user is not in the room;
+the message SHOULD be sent from the room to the user's bare JID,
+MAY contain a <body/> element describing the affiliation change,
+and MUST contain a status code of 101.
+]]
+
+
+local st = require "util.stanza";
+
+local function get_affiliation_notify(room)
+       return room._data.affiliation_notify;
+end
+
+local function set_affiliation_notify(room, affiliation_notify)
+       affiliation_notify = affiliation_notify and true or nil;
+       if room._data.affiliation_notify == affiliation_notify then return false; end
+       room._data.affiliation_notify = affiliation_notify;
+       if room.save then room:save(true); end
+       return true;
+end
+
+module:hook("muc-config-form", function(event)
+       table.insert(event.form, {
+               name = "muc#roomconfig_affiliationnotify";
+               type = "boolean";
+               label = "Notify users when their affiliation changes when they are not in the room?";
+               value = get_affiliation_notify(event.room);
+       });
+end);
+
+module:hook("muc-config-submitted/muc#roomconfig_affiliationnotify", function(event)
+       if set_affiliation_notify(event.room, event.value) then
+               event.status_codes["104"] = true;
+       end
+end);
+
+module:hook("muc-set-affiliation", function(event)
+       local room = event.room;
+       if not event.in_room and get_affiliation_notify(room) then
+               local body = string.format("Your affiliation in room %s is now %s.", room.jid, event.affiliation);
+               local stanza = st.message({
+                               type = "headline";
+                               from = room.jid;
+                               to = event.jid;
+                       }, body)
+                       :tag("x", {xmlns = "http://jabber.org/protocol/muc#user"})
+                               :tag("status", {code="101"}):up()
+                       :up();
+               room:route_stanza(stanza);
+       end
+end);
+
+return {
+       get = get_affiliation_notify;
+       set = set_affiliation_notify;
+};
diff --git a/plugins/muc/description.lib.lua b/plugins/muc/description.lib.lua
new file mode 100644 (file)
index 0000000..c4b1bd0
--- /dev/null
@@ -0,0 +1,42 @@
+-- Prosody IM
+-- Copyright (C) 2008-2010 Matthew Wild
+-- Copyright (C) 2008-2010 Waqas Hussain
+-- Copyright (C) 2014 Daurnimator
+--
+-- This project is MIT/X11 licensed. Please see the
+-- COPYING file in the source package for more information.
+--
+
+local function get_description(room)
+       return room._data.description;
+end
+
+local function set_description(room, description)
+       if description == "" then description = nil; end
+       if get_description(room) == description then return false; end
+       room._data.description = description;
+       if room.save then room:save(true); end
+       return true;
+end
+
+local function add_form_option(event)
+       table.insert(event.form, {
+               name = "muc#roomconfig_roomdesc";
+               type = "text-single";
+               label = "Description";
+               value = get_description(event.room) or "";
+       });
+end
+module:hook("muc-disco#info", add_form_option);
+module:hook("muc-config-form", add_form_option);
+
+module:hook("muc-config-submitted/muc#roomconfig_roomdesc", function(event)
+       if set_description(event.room, event.value) then
+               event.status_codes["104"] = true;
+       end
+end);
+
+return {
+       get = get_description;
+       set = set_description;
+};
diff --git a/plugins/muc/hidden.lib.lua b/plugins/muc/hidden.lib.lua
new file mode 100644 (file)
index 0000000..35ca302
--- /dev/null
@@ -0,0 +1,44 @@
+-- Prosody IM
+-- Copyright (C) 2008-2010 Matthew Wild
+-- Copyright (C) 2008-2010 Waqas Hussain
+-- Copyright (C) 2014 Daurnimator
+--
+-- This project is MIT/X11 licensed. Please see the
+-- COPYING file in the source package for more information.
+--
+
+local function get_hidden(room)
+       return room._data.hidden;
+end
+
+local function set_hidden(room, hidden)
+       hidden = hidden and true or nil;
+       if get_hidden(room) == hidden then return false; end
+       room._data.hidden = hidden;
+       if room.save then room:save(true); end
+       return true;
+end
+
+module:hook("muc-config-form", function(event)
+       table.insert(event.form, {
+               name = "muc#roomconfig_publicroom";
+               type = "boolean";
+               label = "Make Room Publicly Searchable?";
+               value = not get_hidden(event.room);
+       });
+end);
+
+module:hook("muc-config-submitted/muc#roomconfig_publicroom", function(event)
+       if set_hidden(event.room, not event.value) then
+               event.status_codes["104"] = true;
+       end
+end);
+
+module:hook("muc-disco#info", function(event)
+       event.reply:tag("feature", {var = get_hidden(event.room) and "muc_hidden" or "muc_public"}):up();
+end);
+
+return {
+       get = get_hidden;
+       set = set_hidden;
+};
diff --git a/plugins/muc/history.lib.lua b/plugins/muc/history.lib.lua
new file mode 100644 (file)
index 0000000..6fdef96
--- /dev/null
@@ -0,0 +1,170 @@
+-- Prosody IM
+-- Copyright (C) 2008-2010 Matthew Wild
+-- Copyright (C) 2008-2010 Waqas Hussain
+-- Copyright (C) 2014 Daurnimator
+--
+-- This project is MIT/X11 licensed. Please see the
+-- COPYING file in the source package for more information.
+--
+
+local gettime = os.time;
+local datetime = require "util.datetime";
+local st = require "util.stanza";
+
+local default_history_length = 20;
+local max_history_length = module:get_option_number("max_history_messages", math.huge);
+
+local function set_max_history_length(_max_history_length)
+       max_history_length = _max_history_length or math.huge;
+end
+
+local function get_historylength(room)
+       return math.min(room._data.history_length or default_history_length, max_history_length);
+end
+
+local function set_historylength(room, length)
+       if length then
+               length = assert(tonumber(length), "Length not a valid number");
+       end
+       if length == default_history_length then length = nil; end
+       room._data.history_length = length;
+       return true;
+end
+
+module:hook("muc-config-form", function(event)
+       table.insert(event.form, {
+               name = "muc#roomconfig_historylength";
+               type = "text-single";
+               label = "Maximum Number of History Messages Returned by Room";
+               value = tostring(get_historylength(event.room));
+       });
+end);
+
+module:hook("muc-config-submitted/muc#roomconfig_historylength", function(event)
+       if set_historylength(event.room, event.value) then
+               event.status_codes["104"] = true;
+       end
+end);
+
+local function parse_history(stanza)
+       local x_tag = stanza:get_child("x", "http://jabber.org/protocol/muc");
+       local history_tag = x_tag and x_tag:get_child("history", "http://jabber.org/protocol/muc");
+       if not history_tag then
+               return nil, default_history_length, nil;
+       end
+
+       local maxchars = tonumber(history_tag.attr.maxchars);
+
+       local maxstanzas = tonumber(history_tag.attr.maxstanzas);
+
+       -- messages received since the UTC datetime specified
+       local since = history_tag.attr.since;
+       if since then
+               since = datetime.parse(since);
+       end
+
+       -- messages received in the last "X" seconds.
+       local seconds = tonumber(history_tag.attr.seconds);
+       if seconds then
+               seconds = gettime() - seconds;
+               if since then
+                       since = math.max(since, seconds);
+               else
+                       since = seconds;
+               end
+       end
+
+       return maxchars, maxstanzas, since;
+end
+
+module:hook("muc-get-history", function(event)
+       local room = event.room;
+       local history = room._data["history"]; -- send discussion history
+       if not history then return nil end
+       local history_len = #history;
+
+       local to = event.to;
+       local maxchars = event.maxchars;
+       local maxstanzas = event.maxstanzas or history_len;
+       local since = event.since;
+       local n = 0;
+       local charcount = 0;
+       for i=history_len,1,-1 do
+               local entry = history[i];
+               if maxchars then
+                       if not entry.chars then
+                               entry.stanza.attr.to = "";
+                               entry.chars = #tostring(entry.stanza);
+                       end
+                       charcount = charcount + entry.chars + #to;
+                       if charcount > maxchars then break; end
+               end
+               if since and since > entry.timestamp then break; end
+               if n + 1 > maxstanzas then break; end
+               n = n + 1;
+       end
+
+       local i = history_len-n+1
+       function event.next_stanza()
+               if i > history_len then return nil end
+               local entry = history[i];
+               local msg = entry.stanza;
+               msg.attr.to = to;
+               i = i + 1;
+               return msg;
+       end
+       return true;
+end);
+
+local function send_history(room, stanza)
+       local maxchars, maxstanzas, since = parse_history(stanza);
+       local event = {
+               room = room;
+               to = stanza.attr.from; -- `to` is required to calculate the character count for `maxchars`
+               maxchars = maxchars, maxstanzas = maxstanzas, since = since;
+               next_stanza = function() end; -- events should define this iterator
+       };
+       module:fire_event("muc-get-history", event);
+       for msg in event.next_stanza, event do
+               room:route_stanza(msg);
+       end
+end
+
+-- Send history on join
+module:hook("muc-occupant-session-new", function(event)
+       send_history(event.room, event.stanza);
+end, 50); -- Before subject(20)
+
+-- add to history
+module:hook("muc-add-history", function(event)
+       local historic = event.stanza:get_child("body");
+       if historic then
+               local room = event.room
+               local history = room._data["history"];
+               if not history then history = {}; room._data["history"] = history; end
+               local stanza = st.clone(event.stanza);
+               stanza.attr.to = "";
+               local ts = gettime();
+               local stamp = datetime.datetime(ts);
+               stanza:tag("delay", {xmlns = "urn:xmpp:delay", from = module.host, stamp = stamp}):up(); -- XEP-0203
+               stanza:tag("x", {xmlns = "jabber:x:delay", from = module.host, stamp = datetime.legacy()}):up(); -- XEP-0091 (deprecated)
+               local entry = { stanza = stanza, timestamp = ts };
+               table.insert(history, entry);
+               while #history > get_historylength(room) do table.remove(history, 1) end
+       end
+       return true;
+end, -1);
+
+-- Have a single muc-add-history event, so that plugins can mark it
+-- as handled without stopping other muc-broadcast-message handlers
+module:hook("muc-broadcast-message", function(event)
+       module:fire_event("muc-add-history", event);
+end);
+
+return {
+       set_max_length = set_max_history_length;
+       parse_history = parse_history;
+       send = send_history;
+       get_length = get_historylength;
+       set_length = set_historylength;
+};
diff --git a/plugins/muc/lock.lib.lua b/plugins/muc/lock.lib.lua
new file mode 100644 (file)
index 0000000..82f0dc3
--- /dev/null
@@ -0,0 +1,63 @@
+-- Prosody IM
+-- Copyright (C) 2008-2010 Matthew Wild
+-- Copyright (C) 2008-2010 Waqas Hussain
+-- Copyright (C) 2014 Daurnimator
+--
+-- This project is MIT/X11 licensed. Please see the
+-- COPYING file in the source package for more information.
+--
+
+local st = require "util.stanza";
+
+local lock_rooms = module:get_option_boolean("muc_room_locking", false);
+local lock_room_timeout = module:get_option_number("muc_room_lock_timeout", 300);
+
+local function lock(room)
+       module:fire_event("muc-room-locked", {room = room;});
+       room.locked = true;
+end
+local function unlock(room)
+       module:fire_event("muc-room-unlocked", {room = room;});
+       room.locked = nil;
+end
+local function is_locked(room)
+       return not not room.locked;
+end
+
+if lock_rooms then
+       module:hook("muc-room-pre-create", function(event)
+               -- Older groupchat protocol doesn't lock
+               if not event.stanza:get_child("x", "http://jabber.org/protocol/muc") then return end
+               -- Lock room at creation
+               local room = event.room;
+               lock(room);
+               if lock_room_timeout and lock_room_timeout > 0 then
+                       module:add_timer(lock_room_timeout, function ()
+                               if is_locked(room) then
+                                       room:destroy(); -- Not unlocked in time
+                               end
+                       end);
+               end
+       end, 10);
+end
+
+-- Don't let users into room while it is locked
+module:hook("muc-occupant-pre-join", function(event)
+       if not event.is_new_room and is_locked(event.room) then -- Deny entry
+               event.origin.send(st.error_reply(event.stanza, "cancel", "item-not-found"));
+               return true;
+       end
+end, -30);
+
+-- When config is submitted; unlock the room
+module:hook("muc-config-submitted", function(event)
+       if is_locked(event.room) then
+               unlock(event.room);
+       end
+end, -1);
+
+return {
+       lock = lock;
+       unlock = unlock;
+       is_locked = is_locked;
+};
diff --git a/plugins/muc/members_only.lib.lua b/plugins/muc/members_only.lib.lua
new file mode 100644 (file)
index 0000000..d6388fc
--- /dev/null
@@ -0,0 +1,128 @@
+-- Prosody IM
+-- Copyright (C) 2008-2010 Matthew Wild
+-- Copyright (C) 2008-2010 Waqas Hussain
+-- Copyright (C) 2014 Daurnimator
+--
+-- This project is MIT/X11 licensed. Please see the
+-- COPYING file in the source package for more information.
+--
+
+local st = require "util.stanza";
+
+local muc_util = module:require "muc/util";
+local valid_affiliations = muc_util.valid_affiliations;
+
+local function get_members_only(room)
+       return room._data.members_only;
+end
+
+local function set_members_only(room, members_only)
+       members_only = members_only and true or nil;
+       if room._data.members_only == members_only then return false; end
+       room._data.members_only = members_only;
+       if members_only then
+               --[[
+               If as a result of a change in the room configuration the room type is
+               changed to members-only but there are non-members in the room,
+               the service MUST remove any non-members from the room and include a
+               status code of 322 in the presence unavailable stanzas sent to those users
+               as well as any remaining occupants.
+               ]]
+               local occupants_changed = {};
+               for _, occupant in room:each_occupant() do
+                       local affiliation = room:get_affiliation(occupant.bare_jid);
+                       if valid_affiliations[affiliation or "none"] <= valid_affiliations.none then
+                               occupant.role = nil;
+                               room:save_occupant(occupant);
+                               occupants_changed[occupant] = true;
+                       end
+               end
+               local x = st.stanza("x", {xmlns = "http://jabber.org/protocol/muc#user"})
+                       :tag("status", {code="322"}):up();
+               for occupant in pairs(occupants_changed) do
+                       room:publicise_occupant_status(occupant, x);
+                       module:fire_event("muc-occupant-left", {room = room; nick = occupant.nick; occupant = occupant;});
+               end
+       end
+       if room.save then room:save(true); end
+       return true;
+end
+
+module:hook("muc-disco#info", function(event)
+       event.reply:tag("feature", {var = get_members_only(event.room) and "muc_membersonly" or "muc_open"}):up();
+end);
+
+module:hook("muc-config-form", function(event)
+       table.insert(event.form, {
+               name = "muc#roomconfig_membersonly";
+               type = "boolean";
+               label = "Make Room Members-Only?";
+               value = get_members_only(event.room);
+       });
+end);
+
+module:hook("muc-config-submitted/muc#roomconfig_membersonly", function(event)
+       if set_members_only(event.room, event.value) then
+               event.status_codes["104"] = true;
+       end
+end);
+
+-- No affiliation => role of "none"
+module:hook("muc-get-default-role", function(event)
+       if not event.affiliation and get_members_only(event.room) then
+               return false;
+       end
+end);
+
+-- registration required for entering members-only room
+module:hook("muc-occupant-pre-join", function(event)
+       local room = event.room;
+       if get_members_only(room) then
+               local stanza = event.stanza;
+               local affiliation = room:get_affiliation(stanza.attr.from);
+               if valid_affiliations[affiliation or "none"] <= valid_affiliations.none then
+                       local reply = st.error_reply(stanza, "auth", "registration-required"):up();
+                       reply.tags[1].attr.code = "407";
+                       event.origin.send(reply:tag("x", {xmlns = "http://jabber.org/protocol/muc"}));
+                       return true;
+               end
+       end
+end, -5);
+
+-- Invitation privileges in members-only rooms SHOULD be restricted to room admins;
+-- if a member without privileges to edit the member list attempts to invite another user
+-- the service SHOULD return a <forbidden/> error to the occupant
+module:hook("muc-pre-invite", function(event)
+       local room = event.room;
+       if get_members_only(room) then
+               local stanza = event.stanza;
+               local affiliation = room:get_affiliation(stanza.attr.from);
+               if valid_affiliations[affiliation or "none"] < valid_affiliations.admin then
+                       event.origin.send(st.error_reply(stanza, "auth", "forbidden"));
+                       return true;
+               end
+       end
+end);
+
+-- When an invite is sent; add an affiliation for the invitee
+module:hook("muc-invite", function(event)
+       local room = event.room;
+       if get_members_only(room) then
+               local stanza = event.stanza;
+               local invitee = stanza.attr.to;
+               local affiliation = room:get_affiliation(invitee);
+               if valid_affiliations[affiliation or "none"] <= valid_affiliations.none then
+                       local from = stanza:get_child("x", "http://jabber.org/protocol/muc#user")
+                               :get_child("invite").attr.from;
+                       module:log("debug", "%s invited %s into members only room %s, granting membership",
+                               from, invitee, room.jid);
+                       -- This might fail; ignore for now
+                       room:set_affiliation(from, invitee, "member", "Invited by " .. from);
+               end
+       end
+end);
+
+return {
+       get = get_members_only;
+       set = set_members_only;
+};
index ee90d5527bffca841c46480f1c3303376f3d98c0..74909d9b7f19193fbf3a29df1cf7d8f14d4cef3f 100644 (file)
 -- COPYING file in the source package for more information.
 --
 
-local array = require "util.array";
-
 if module:get_host_type() ~= "component" then
        error("MUC should be loaded as a component, please see http://prosody.im/doc/components", 0);
 end
 
-local muc_host = module:get_host();
-local muc_name = module:get_option_string("name", "Prosody Chatrooms");
-local restrict_room_creation = module:get_option("restrict_room_creation");
-if restrict_room_creation then
-       if restrict_room_creation == true then
-               restrict_room_creation = "admin";
-       elseif restrict_room_creation ~= "admin" and restrict_room_creation ~= "local" then
-               restrict_room_creation = nil;
-       end
+local muclib = module:require "muc";
+room_mt = muclib.room_mt; -- Yes, global.
+
+local affiliation_notify = module:require "muc/affiliation_notify"; -- luacheck: ignore 211
+
+local name = module:require "muc/name";
+room_mt.get_name = name.get;
+room_mt.set_name = name.set;
+
+local description = module:require "muc/description";
+room_mt.get_description = description.get;
+room_mt.set_description = description.set;
+
+local hidden = module:require "muc/hidden";
+room_mt.get_hidden = hidden.get;
+room_mt.set_hidden = hidden.set;
+function room_mt:get_public()
+       return not self:get_hidden();
+end
+function room_mt:set_public(public)
+       return self:set_hidden(not public);
 end
-local lock_rooms = module:get_option_boolean("muc_room_locking", false);
-local lock_room_timeout = module:get_option_number("muc_room_lock_timeout", 300);
 
-local muclib = module:require "muc";
-local muc_new_room = muclib.new_room;
+local password = module:require "muc/password";
+room_mt.get_password = password.get;
+room_mt.set_password = password.set;
+
+local members_only = module:require "muc/members_only";
+room_mt.get_members_only = members_only.get;
+room_mt.set_members_only = members_only.set;
+
+local moderated = module:require "muc/moderated";
+room_mt.get_moderated = moderated.get;
+room_mt.set_moderated = moderated.set;
+
+local persistent = module:require "muc/persistent";
+room_mt.get_persistent = persistent.get;
+room_mt.set_persistent = persistent.set;
+
+local subject = module:require "muc/subject";
+room_mt.get_changesubject = subject.get_changesubject;
+room_mt.set_changesubject = subject.set_changesubject;
+room_mt.get_subject = subject.get;
+room_mt.set_subject = subject.set;
+room_mt.send_subject = subject.send;
+
+local history = module:require "muc/history";
+room_mt.send_history = history.send;
+room_mt.get_historylength = history.get_length;
+room_mt.set_historylength = history.set_length;
+
+local iterators = require "util.iterators";
 local jid_split = require "util.jid".split;
 local jid_bare = require "util.jid".bare;
 local st = require "util.stanza";
-local uuid_gen = require "util.uuid".generate;
 local um_is_admin = require "core.usermanager".is_admin;
-local hosts = prosody.hosts;
 
-rooms = {};
-local rooms = rooms;
-local persistent_rooms_storage = module:open_store("persistent");
-local persistent_rooms = persistent_rooms_storage:get() or {};
-local room_configs = module:open_store("config");
-
--- Configurable options
-muclib.set_max_history_length(module:get_option_number("max_history_messages"));
+local rooms = module:shared "rooms";
 
 module:depends("disco");
-module:add_identity("conference", "text", muc_name);
+module:add_identity("conference", "text", module:get_option_string("name", "Prosody Chatrooms"));
 module:add_feature("http://jabber.org/protocol/muc");
+module:depends "muc_unique"
+module:require "muc/lock";
 
 local function is_admin(jid)
        return um_is_admin(jid, module.host);
 end
 
-room_mt = muclib.room_mt; -- Yes, global.
-local _set_affiliation = room_mt.set_affiliation;
-local _get_affiliation = room_mt.get_affiliation;
-function muclib.room_mt:get_affiliation(jid)
-       if is_admin(jid) then return "owner"; end
-       return _get_affiliation(self, jid);
-end
-function muclib.room_mt:set_affiliation(actor, jid, affiliation, callback, reason)
-       if affiliation ~= "owner" and is_admin(jid) then return nil, "modify", "not-acceptable"; end
-       return _set_affiliation(self, actor, jid, affiliation, callback, reason);
+do -- Monkey patch to make server admins room owners
+       local _get_affiliation = room_mt.get_affiliation;
+       function room_mt:get_affiliation(jid)
+               if is_admin(jid) then return "owner"; end
+               return _get_affiliation(self, jid);
+       end
+
+       local _set_affiliation = room_mt.set_affiliation;
+       function room_mt:set_affiliation(actor, jid, affiliation, reason)
+               if affiliation ~= "owner" and is_admin(jid) then return nil, "modify", "not-acceptable"; end
+               return _set_affiliation(self, actor, jid, affiliation, reason);
+       end
 end
 
-local function room_route_stanza(room, stanza) module:send(stanza); end
+local persistent_rooms_storage = module:open_store("persistent");
+local persistent_rooms = module:open_store("persistent", "map");
+local room_configs = module:open_store("config");
+
 local function room_save(room, forced)
        local node = jid_split(room.jid);
-       persistent_rooms[room.jid] = room._data.persistent;
-       if room._data.persistent then
-               local history = room._data.history;
+       local is_persistent = persistent.get(room);
+       persistent_rooms:set(nil, room.jid, is_persistent);
+       if is_persistent then
+               local room_history = room._data.history;
                room._data.history = nil;
                local data = {
                        jid = room.jid;
@@ -76,202 +110,203 @@ local function room_save(room, forced)
                        _affiliations = room._affiliations;
                };
                room_configs:set(node, data);
-               room._data.history = history;
+               room._data.history = room_history;
        elseif forced then
                room_configs:set(node, nil);
                if not next(room._occupants) then -- Room empty
                        rooms[room.jid] = nil;
                end
        end
-       if forced then persistent_rooms_storage:set(nil, persistent_rooms); end
 end
 
-function create_room(jid)
-       local room = muc_new_room(jid);
-       room.route_stanza = room_route_stanza;
-       room.save = room_save;
-       rooms[jid] = room;
-       if lock_rooms then
-               room.locked = true;
-               if lock_room_timeout and lock_room_timeout > 0 then
-                       module:add_timer(lock_room_timeout, function ()
-                               if room.locked then
-                                       room:destroy(); -- Not unlocked in time
-                               end
-                       end);
-               end
+-- Automatically destroy empty non-persistent rooms
+module:hook("muc-occupant-left",function(event)
+       local room = event.room
+       if not room:has_occupant() and not persistent.get(room) then -- empty, non-persistent room
+               module:fire_event("muc-room-destroyed", { room = room });
        end
-       module:fire_event("muc-room-created", { room = room });
-       return room;
+end);
+
+function track_room(room)
+       rooms[room.jid] = room;
+       -- When room is created, over-ride 'save' method
+       room.save = room_save;
 end
 
-local persistent_errors = false;
-for jid in pairs(persistent_rooms) do
+local function restore_room(jid)
        local node = jid_split(jid);
        local data = room_configs:get(node);
        if data then
-               local room = create_room(jid);
+               local room = muclib.new_room(jid);
                room._data = data._data;
                room._affiliations = data._affiliations;
-       else -- missing room data
-               persistent_rooms[jid] = nil;
-               module:log("error", "Missing data for room '%s', removing from persistent room list", jid);
-               persistent_errors = true;
+               track_room(room);
+               return room;
        end
 end
-if persistent_errors then persistent_rooms_storage:set(nil, persistent_rooms); end
-
-local host_room = muc_new_room(muc_host);
-host_room.route_stanza = room_route_stanza;
-host_room.save = room_save;
 
-module:hook("host-disco-items", function(event)
-       local reply = event.reply;
-       module:log("debug", "host-disco-items called");
-       for jid, room in pairs(rooms) do
-               if not room:get_hidden() then
-                       reply:tag("item", {jid=jid, name=room:get_name()}):up();
-               end
+function forget_room(room)
+       local room_jid = room.jid;
+       local node = jid_split(room.jid);
+       rooms[room_jid] = nil;
+       room_configs:set(node, nil);
+       if persistent.get(room) then
+               persistent_rooms:set(nil, room_jid, nil);
        end
-end);
+end
 
-local function handle_to_domain(event)
-       local origin, stanza = event.origin, event.stanza;
-       local type = stanza.attr.type;
-       if type == "error" or type == "result" then return; end
-       if stanza.name == "iq" and type == "get" then
-               local xmlns = stanza.tags[1].attr.xmlns;
-               local node = stanza.tags[1].attr.node;
-               if xmlns == "http://jabber.org/protocol/muc#unique" then
-                       origin.send(st.reply(stanza):tag("unique", {xmlns = xmlns}):text(uuid_gen())); -- FIXME Random UUIDs can theoretically have collisions
-               else
-                       origin.send(st.error_reply(stanza, "cancel", "service-unavailable")); -- TODO disco/etc
+function get_room_from_jid(room_jid)
+       local room = rooms[room_jid];
+       if room == nil then
+               -- Check if in persistent storage
+               if persistent_rooms:get(nil, room_jid) then
+                       room = restore_room(room_jid);
+                       if room == nil then
+                               module:log("error", "Missing data for room '%s', removing from persistent room list", room_jid);
+                               persistent_rooms:set(nil, room_jid, nil);
+                       end
                end
-       else
-               host_room:handle_stanza(origin, stanza);
-               --origin.send(st.error_reply(stanza, "cancel", "service-unavailable", "The muc server doesn't deal with messages and presence directed at it"));
        end
-       return true;
+       return room
 end
 
-function stanza_handler(event)
-       local origin, stanza = event.origin, event.stanza;
-       local bare = jid_bare(stanza.attr.to);
-       local room = rooms[bare];
-       if not room then
-               if stanza.name ~= "presence" then
-                       origin.send(st.error_reply(stanza, "cancel", "item-not-found"));
-                       return true;
-               end
-               if not(restrict_room_creation) or
-                 is_admin(stanza.attr.from) or
-                 (restrict_room_creation == "local" and select(2, jid_split(stanza.attr.from)) == module.host:gsub("^[^%.]+%.", "")) then
-                       room = create_room(bare);
+function each_room(local_only)
+       if not local_only then
+               for room_jid in pairs(persistent_rooms_storage:get(nil) or {}) do
+                       if rooms[room_jid] == nil then -- Don't restore rooms that already exist
+                               local room = restore_room(room_jid);
+                               if room == nil then
+                                       module:log("error", "Missing data for room '%s', omitting from iteration", room_jid);
+                               end
+                       end
                end
        end
-       if room then
-               room:handle_stanza(origin, stanza);
-               if not next(room._occupants) and not persistent_rooms[room.jid] then -- empty, non-persistent room
-                       module:fire_event("muc-room-destroyed", { room = room });
-                       rooms[bare] = nil; -- discard room
+       return iterators.values(rooms);
+end
+
+module:hook("host-disco-items", function(event)
+       local reply = event.reply;
+       module:log("debug", "host-disco-items called");
+       for room in each_room() do
+               if not room:get_hidden() then
+                       reply:tag("item", {jid=room.jid, name=room:get_name()}):up();
                end
-       else
-               origin.send(st.error_reply(stanza, "cancel", "not-allowed"));
        end
-       return true;
-end
-module:hook("iq/bare", stanza_handler, -1);
-module:hook("message/bare", stanza_handler, -1);
-module:hook("presence/bare", stanza_handler, -1);
-module:hook("iq/full", stanza_handler, -1);
-module:hook("message/full", stanza_handler, -1);
-module:hook("presence/full", stanza_handler, -1);
-module:hook("iq/host", handle_to_domain, -1);
-module:hook("message/host", handle_to_domain, -1);
-module:hook("presence/host", handle_to_domain, -1);
-
-hosts[module.host].send = function(stanza) -- FIXME do a generic fix
-       if stanza.attr.type == "result" or stanza.attr.type == "error" then
-               module:send(stanza);
-       else error("component.send only supports result and error stanzas at the moment"); end
-end
+end);
 
-hosts[module:get_host()].muc = { rooms = rooms };
+module:hook("muc-room-pre-create", function(event)
+       track_room(event.room);
+end, -1000);
 
-local saved = false;
-module.save = function()
-       saved = true;
-       return {rooms = rooms};
-end
-module.restore = function(data)
-       for jid, oldroom in pairs(data.rooms or {}) do
-               local room = create_room(jid);
-               room._jid_nick = oldroom._jid_nick;
-               room._occupants = oldroom._occupants;
-               room._data = oldroom._data;
-               room._affiliations = oldroom._affiliations;
+module:hook("muc-room-destroyed",function(event)
+       return forget_room(event.room);
+end)
+
+do
+       local restrict_room_creation = module:get_option("restrict_room_creation");
+       if restrict_room_creation == true then
+               restrict_room_creation = "admin";
+       end
+       if restrict_room_creation then
+               local host_suffix = module.host:gsub("^[^%.]+%.", "");
+               module:hook("muc-room-pre-create", function(event)
+                       local origin, stanza = event.origin, event.stanza;
+                       local user_jid = stanza.attr.from;
+                       if not is_admin(user_jid) and not (
+                               restrict_room_creation == "local" and
+                               select(2, jid_split(user_jid)) == host_suffix
+                       ) then
+                               origin.send(st.error_reply(stanza, "cancel", "not-allowed"));
+                               return true;
+                       end
+               end);
        end
-       hosts[module:get_host()].muc = { rooms = rooms };
 end
 
-function shutdown_room(room, stanza)
-       for nick, occupant in pairs(room._occupants) do
-               stanza.attr.from = nick;
-               for jid in pairs(occupant.sessions) do
-                       stanza.attr.to = jid;
-                       room:_route_stanza(stanza);
-                       room._jid_nick[jid] = nil;
+for event_name, method in pairs {
+       -- Normal room interactions
+       ["iq-get/bare/http://jabber.org/protocol/disco#info:query"] = "handle_disco_info_get_query" ;
+       ["iq-get/bare/http://jabber.org/protocol/disco#items:query"] = "handle_disco_items_get_query" ;
+       ["iq-set/bare/http://jabber.org/protocol/muc#admin:query"] = "handle_admin_query_set_command" ;
+       ["iq-get/bare/http://jabber.org/protocol/muc#admin:query"] = "handle_admin_query_get_command" ;
+       ["iq-set/bare/http://jabber.org/protocol/muc#owner:query"] = "handle_owner_query_set_to_room" ;
+       ["iq-get/bare/http://jabber.org/protocol/muc#owner:query"] = "handle_owner_query_get_to_room" ;
+       ["message/bare"] = "handle_message_to_room" ;
+       ["presence/bare"] = "handle_presence_to_room" ;
+       -- Host room
+       ["iq-get/host/http://jabber.org/protocol/disco#info:query"] = "handle_disco_info_get_query" ;
+       ["iq-get/host/http://jabber.org/protocol/disco#items:query"] = "handle_disco_items_get_query" ;
+       ["iq-set/host/http://jabber.org/protocol/muc#admin:query"] = "handle_admin_query_set_command" ;
+       ["iq-get/host/http://jabber.org/protocol/muc#admin:query"] = "handle_admin_query_get_command" ;
+       ["iq-set/host/http://jabber.org/protocol/muc#owner:query"] = "handle_owner_query_set_to_room" ;
+       ["iq-get/host/http://jabber.org/protocol/muc#owner:query"] = "handle_owner_query_get_to_room" ;
+       ["message/host"] = "handle_message_to_room" ;
+       ["presence/host"] = "handle_presence_to_room" ;
+       -- Direct to occupant (normal rooms and host room)
+       ["presence/full"] = "handle_presence_to_occupant" ;
+       ["iq/full"] = "handle_iq_to_occupant" ;
+       ["message/full"] = "handle_message_to_occupant" ;
+} do
+       module:hook(event_name, function (event)
+               local origin, stanza = event.origin, event.stanza;
+               local room_jid = jid_bare(stanza.attr.to);
+               local room = get_room_from_jid(room_jid);
+               if room == nil then
+                       -- Watch presence to create rooms
+                       if stanza.attr.type == nil and stanza.name == "presence" then
+                               room = muclib.new_room(room_jid);
+                       elseif stanza.attr.type ~= "error" then
+                               origin.send(st.error_reply(stanza, "cancel", "not-allowed"));
+                               return true;
+                       else
+                               return;
+                       end
                end
-               room._occupants[nick] = nil;
-       end
+               return room[method](room, origin, stanza);
+       end, -2)
 end
+
 function shutdown_component()
-       if not saved then
-               local stanza = st.presence({type = "unavailable"})
-                       :tag("x", {xmlns = "http://jabber.org/protocol/muc#user"})
-                               :tag("item", { affiliation='none', role='none' }):up()
-                               :tag("status", { code = "332"}):up();
-               for roomjid, room in pairs(rooms) do
-                       shutdown_room(room, stanza);
-               end
-               shutdown_room(host_room, stanza);
+       local x = st.stanza("x", {xmlns = "http://jabber.org/protocol/muc#user"})
+               :tag("status", { code = "332"}):up();
+       for room in each_room(true) do
+               room:clear(x);
        end
 end
-module.unload = shutdown_component;
 module:hook_global("server-stopping", shutdown_component);
 
--- Ad-hoc commands
-module:depends("adhoc")
-local t_concat = table.concat;
-local keys = require "util.iterators".keys;
-local adhoc_new = module:require "adhoc".new;
-local adhoc_initial = require "util.adhoc".new_initial_data_form;
-local dataforms_new = require "util.dataforms".new;
-
-local destroy_rooms_layout = dataforms_new {
-       title = "Destroy rooms";
-       instructions = "Select the rooms to destroy";
-
-       { name = "FORM_TYPE", type = "hidden", value = "http://prosody.im/protocol/muc#destroy" };
-       { name = "rooms", type = "list-multi", required = true, label = "Rooms to destroy:"};
-};
-
-local destroy_rooms_handler = adhoc_initial(destroy_rooms_layout, function()
-       return { rooms = array.collect(keys(rooms)):sort() };
-end, function(fields, errors)
-       if errors then
-               local errmsg = {};
-               for name, err in pairs(errors) do
-                       errmsg[#errmsg + 1] = name .. ": " .. err;
+do -- Ad-hoc commands
+       module:depends "adhoc";
+       local t_concat = table.concat;
+       local adhoc_new = module:require "adhoc".new;
+       local adhoc_initial = require "util.adhoc".new_initial_data_form;
+       local array = require "util.array";
+       local dataforms_new = require "util.dataforms".new;
+
+       local destroy_rooms_layout = dataforms_new {
+               title = "Destroy rooms";
+               instructions = "Select the rooms to destroy";
+
+               { name = "FORM_TYPE", type = "hidden", value = "http://prosody.im/protocol/muc#destroy" };
+               { name = "rooms", type = "list-multi", required = true, label = "Rooms to destroy:"};
+       };
+
+       local destroy_rooms_handler = adhoc_initial(destroy_rooms_layout, function()
+               return { rooms = array.collect(each_room()):pluck("jid"):sort(); };
+       end, function(fields, errors)
+               if errors then
+                       local errmsg = {};
+                       for field, err in pairs(errors) do
+                               errmsg[#errmsg + 1] = field .. ": " .. err;
+                       end
+                       return { status = "completed", error = { message = t_concat(errmsg, "\n") } };
                end
-               return { status = "completed", error = { message = t_concat(errmsg, "\n") } };
-       end
-       for _, room in ipairs(fields.rooms) do
-               rooms[room]:destroy();
-               rooms[room] = nil;
-       end
-       return { status = "completed", info = "The following rooms were destroyed:\n"..t_concat(fields.rooms, "\n") };
-end);
-local destroy_rooms_desc = adhoc_new("Destroy Rooms", "http://prosody.im/protocol/muc#destroy", destroy_rooms_handler, "admin");
+               for _, room in ipairs(fields.rooms) do
+                       get_room_from_jid(room):destroy();
+               end
+               return { status = "completed", info = "The following rooms were destroyed:\n"..t_concat(fields.rooms, "\n") };
+       end);
+       local destroy_rooms_desc = adhoc_new("Destroy Rooms", "http://prosody.im/protocol/muc#destroy", destroy_rooms_handler, "admin");
 
-module:provides("adhoc", destroy_rooms_desc);
+       module:provides("adhoc", destroy_rooms_desc);
+end
diff --git a/plugins/muc/moderated.lib.lua b/plugins/muc/moderated.lib.lua
new file mode 100644 (file)
index 0000000..26dcb05
--- /dev/null
@@ -0,0 +1,52 @@
+-- Prosody IM
+-- Copyright (C) 2008-2010 Matthew Wild
+-- Copyright (C) 2008-2010 Waqas Hussain
+-- Copyright (C) 2014 Daurnimator
+--
+-- This project is MIT/X11 licensed. Please see the
+-- COPYING file in the source package for more information.
+--
+
+local function get_moderated(room)
+       return room._data.moderated;
+end
+
+local function set_moderated(room, moderated)
+       moderated = moderated and true or nil;
+       if get_moderated(room) == moderated then return false; end
+       room._data.moderated = moderated;
+       if room.save then room:save(true); end
+       return true;
+end
+
+module:hook("muc-disco#info", function(event)
+       event.reply:tag("feature", {var = get_moderated(event.room) and "muc_moderated" or "muc_unmoderated"}):up();
+end);
+
+module:hook("muc-config-form", function(event)
+       table.insert(event.form, {
+               name = "muc#roomconfig_moderatedroom";
+               type = "boolean";
+               label = "Make Room Moderated?";
+               value = get_moderated(event.room);
+       });
+end);
+
+module:hook("muc-config-submitted/muc#roomconfig_moderatedroom", function(event)
+       if set_moderated(event.room, event.value) then
+               event.status_codes["104"] = true;
+       end
+end);
+
+module:hook("muc-get-default-role", function(event)
+       if event.affiliation == nil then
+               if get_moderated(event.room) then
+                       return "visitor"
+               end
+       end
+end, 1);
+
+return {
+       get = get_moderated;
+       set = set_moderated;
+};
index 552b9e49970a5e6e5f950d6b598316d6d65008dc..69d34e75415e22cb964ec4450ffca10eec5c53ac 100644 (file)
@@ -1,66 +1,33 @@
 -- Prosody IM
 -- Copyright (C) 2008-2010 Matthew Wild
 -- Copyright (C) 2008-2010 Waqas Hussain
+-- Copyright (C) 2014 Daurnimator
 --
 -- This project is MIT/X11 licensed. Please see the
 -- COPYING file in the source package for more information.
 --
 
 local select = select;
-local pairs, ipairs = pairs, ipairs;
-
-local datetime = require "util.datetime";
+local pairs = pairs;
+local next = next;
+local setmetatable = setmetatable;
 
 local dataform = require "util.dataforms";
-
+local iterators = require "util.iterators";
 local jid_split = require "util.jid".split;
 local jid_bare = require "util.jid".bare;
 local jid_prep = require "util.jid".prep;
+local jid_join = require "util.jid".join;
 local st = require "util.stanza";
-local log = require "util.logger".init("mod_muc");
-local t_insert, t_remove = table.insert, table.remove;
-local setmetatable = setmetatable;
 local base64 = require "util.encodings".base64;
 local md5 = require "util.hashes".md5;
 
-local muc_domain = nil; --module:get_host();
-local default_history_length, max_history_length = 20, math.huge;
-
-------------
-local presence_filters = {["http://jabber.org/protocol/muc"]=true;["http://jabber.org/protocol/muc#user"]=true};
-local function presence_filter(tag)
-       if presence_filters[tag.attr.xmlns] then
-               return nil;
-       end
-       return tag;
-end
-
-local function get_filtered_presence(stanza)
-       return st.clone(stanza):maptags(presence_filter);
-end
-local kickable_error_conditions = {
-       ["gone"] = true;
-       ["internal-server-error"] = true;
-       ["item-not-found"] = true;
-       ["jid-malformed"] = true;
-       ["recipient-unavailable"] = true;
-       ["redirect"] = true;
-       ["remote-server-not-found"] = true;
-       ["remote-server-timeout"] = true;
-       ["service-unavailable"] = true;
-       ["malformed error"] = true;
-};
-
-local function get_error_condition(stanza)
-       local _, condition = stanza:get_error();
-       return condition or "malformed error";
-end
+local log = module._log;
 
-local function is_kickable_error(stanza)
-       local cond = get_error_condition(stanza);
-       return kickable_error_conditions[cond] and cond;
-end
------------
+local occupant_lib = module:require "muc/occupant"
+local muc_util = module:require "muc/util";
+local is_kickable_error = muc_util.is_kickable_error;
+local valid_roles, valid_affiliations = muc_util.valid_roles, muc_util.valid_affiliations;
 
 local room_mt = {};
 room_mt.__index = room_mt;
@@ -69,528 +36,594 @@ function room_mt:__tostring()
        return "MUC room ("..self.jid..")";
 end
 
+function room_mt:get_occupant_jid(real_jid)
+       return self._jid_nick[real_jid]
+end
+
 function room_mt:get_default_role(affiliation)
-       if affiliation == "owner" or affiliation == "admin" then
+       local role = module:fire_event("muc-get-default-role", {
+               room = self;
+               affiliation = affiliation;
+               affiliation_rank = valid_affiliations[affiliation or "none"];
+       });
+       return role, valid_roles[role or "none"];
+end
+module:hook("muc-get-default-role", function(event)
+       if event.affiliation_rank >= valid_affiliations.admin then
                return "moderator";
-       elseif affiliation == "member" then
+       elseif event.affiliation_rank >= valid_affiliations.none then
                return "participant";
-       elseif not affiliation then
-               if not self:get_members_only() then
-                       return self:get_moderated() and "visitor" or "participant";
-               end
        end
+end);
+
+--- Occupant functions
+function room_mt:new_occupant(bare_real_jid, nick)
+       local occupant = occupant_lib.new(bare_real_jid, nick);
+       local affiliation = self:get_affiliation(bare_real_jid);
+       occupant.role = self:get_default_role(affiliation);
+       return occupant;
 end
 
-function room_mt:broadcast_presence(stanza, sid, code, nick)
-       stanza = get_filtered_presence(stanza);
-       local occupant = self._occupants[stanza.attr.from];
-       stanza:tag("x", {xmlns='http://jabber.org/protocol/muc#user'})
-               :tag("item", {affiliation=occupant.affiliation or "none", role=occupant.role or "none", nick=nick}):up();
-       if code then
-               stanza:tag("status", {code=code}):up();
-       end
-       self:broadcast_except_nick(stanza, stanza.attr.from);
-       local me = self._occupants[stanza.attr.from];
-       if me then
-               stanza:tag("status", {code='110'}):up();
-               stanza.attr.to = sid;
-               self:_route_stanza(stanza);
-       end
+function room_mt:get_occupant_by_nick(nick)
+       local occupant = self._occupants[nick];
+       if occupant == nil then return nil end
+       return occupant_lib.copy(occupant);
 end
-function room_mt:broadcast_message(stanza, historic)
-       local to = stanza.attr.to;
-       for occupant, o_data in pairs(self._occupants) do
-               for jid in pairs(o_data.sessions) do
-                       stanza.attr.to = jid;
-                       self:_route_stanza(stanza);
-               end
+
+do
+       local function next_copied_occupant(occupants, occupant_jid)
+               local next_occupant_jid, raw_occupant = next(occupants, occupant_jid);
+               if next_occupant_jid == nil then return nil end
+               return next_occupant_jid, occupant_lib.copy(raw_occupant);
        end
-       stanza.attr.to = to;
-       if historic then -- add to history
-               return self:save_to_history(stanza)
+       -- FIXME Explain what 'read_only' is supposed to be
+       function room_mt:each_occupant(read_only) -- luacheck: ignore 212
+               return next_copied_occupant, self._occupants, nil;
        end
 end
-function room_mt:save_to_history(stanza)
-       local history = self._data['history'];
-       if not history then history = {}; self._data['history'] = history; end
-       stanza = st.clone(stanza);
-       stanza.attr.to = "";
-       local stamp = datetime.datetime();
-       stanza:tag("delay", {xmlns = "urn:xmpp:delay", from = muc_domain, stamp = stamp}):up(); -- XEP-0203
-       stanza:tag("x", {xmlns = "jabber:x:delay", from = muc_domain, stamp = datetime.legacy()}):up(); -- XEP-0091 (deprecated)
-       local entry = { stanza = stanza, stamp = stamp };
-       t_insert(history, entry);
-       while #history > (self._data.history_length or default_history_length) do t_remove(history, 1) end
+
+function room_mt:has_occupant()
+       return next(self._occupants, nil) ~= nil
 end
-function room_mt:broadcast_except_nick(stanza, nick)
-       for rnick, occupant in pairs(self._occupants) do
-               if rnick ~= nick then
-                       for jid in pairs(occupant.sessions) do
-                               stanza.attr.to = jid;
-                               self:_route_stanza(stanza);
-                       end
-               end
-       end
+
+function room_mt:get_occupant_by_real_jid(real_jid)
+       local occupant_jid = self:get_occupant_jid(real_jid);
+       if occupant_jid == nil then return nil end
+       return self:get_occupant_by_nick(occupant_jid);
 end
 
-function room_mt:send_occupant_list(to)
-       local current_nick = self._jid_nick[to];
-       for occupant, o_data in pairs(self._occupants) do
-               if occupant ~= current_nick then
-                       local pres = get_filtered_presence(o_data.sessions[o_data.jid]);
-                       pres.attr.to, pres.attr.from = to, occupant;
-                       pres:tag("x", {xmlns='http://jabber.org/protocol/muc#user'})
-                               :tag("item", {affiliation=o_data.affiliation or "none", role=o_data.role or "none"}):up();
-                       self:_route_stanza(pres);
+function room_mt:save_occupant(occupant)
+       occupant = occupant_lib.copy(occupant); -- So that occupant can be modified more
+       local id = occupant.nick
+
+       -- Need to maintain _jid_nick secondary index
+       local old_occupant = self._occupants[id];
+       if old_occupant then
+               for real_jid in old_occupant:each_session() do
+                       self._jid_nick[real_jid] = nil;
                end
        end
-end
-function room_mt:send_history(to, stanza)
-       local history = self._data['history']; -- send discussion history
-       if history then
-               local x_tag = stanza and stanza:get_child("x", "http://jabber.org/protocol/muc");
-               local history_tag = x_tag and x_tag:get_child("history", "http://jabber.org/protocol/muc");
-
-               local maxchars = history_tag and tonumber(history_tag.attr.maxchars);
-               if maxchars then maxchars = math.floor(maxchars); end
-
-               local maxstanzas = math.floor(history_tag and tonumber(history_tag.attr.maxstanzas) or #history);
-               if not history_tag then maxstanzas = 20; end
-
-               local seconds = history_tag and tonumber(history_tag.attr.seconds);
-               if seconds then seconds = datetime.datetime(os.time() - math.floor(seconds)); end
-
-               local since = history_tag and history_tag.attr.since;
-               if since then since = datetime.parse(since); since = since and datetime.datetime(since); end
-               if seconds and (not since or since < seconds) then since = seconds; end
-
-               local n = 0;
-               local charcount = 0;
-
-               for i=#history,1,-1 do
-                       local entry = history[i];
-                       if maxchars then
-                               if not entry.chars then
-                                       entry.stanza.attr.to = "";
-                                       entry.chars = #tostring(entry.stanza);
-                               end
-                               charcount = charcount + entry.chars + #to;
-                               if charcount > maxchars then break; end
+
+       local has_live_session = false
+       if occupant.role ~= nil then
+               for real_jid, presence in occupant:each_session() do
+                       if presence.attr.type == nil then
+                               has_live_session = true
+                               self._jid_nick[real_jid] = occupant.nick;
                        end
-                       if since and since > entry.stamp then break; end
-                       if n + 1 > maxstanzas then break; end
-                       n = n + 1;
                end
-               for i=#history-n+1,#history do
-                       local msg = history[i].stanza;
-                       msg.attr.to = to;
-                       self:_route_stanza(msg);
+               if not has_live_session then
+                       -- Has no live sessions left; they have left the room.
+                       occupant.role = nil
                end
        end
-end
-function room_mt:send_subject(to)
-       if self._data['subject'] then
-               self:_route_stanza(st.message({type='groupchat', from=self._data['subject_from'] or self.jid, to=to}):tag("subject"):text(self._data['subject']));
+       if not has_live_session then
+               occupant = nil
        end
+       self._occupants[id] = occupant
 end
 
-function room_mt:get_disco_info(stanza)
-       local count = 0; for _ in pairs(self._occupants) do count = count + 1; end
-       local reply = st.reply(stanza):query("http://jabber.org/protocol/disco#info")
-               :tag("identity", {category="conference", type="text", name=self:get_name()}):up()
-               :tag("feature", {var="http://jabber.org/protocol/muc"}):up()
-               :tag("feature", {var=self:get_password() and "muc_passwordprotected" or "muc_unsecured"}):up()
-               :tag("feature", {var=self:get_moderated() and "muc_moderated" or "muc_unmoderated"}):up()
-               :tag("feature", {var=self:get_members_only() and "muc_membersonly" or "muc_open"}):up()
-               :tag("feature", {var=self:get_persistent() and "muc_persistent" or "muc_temporary"}):up()
-               :tag("feature", {var=self:get_hidden() and "muc_hidden" or "muc_public"}):up()
-               :tag("feature", {var=self._data.whois ~= "anyone" and "muc_semianonymous" or "muc_nonanonymous"}):up()
-       ;
-       local dataform = dataform.new({
-               { name = "FORM_TYPE", type = "hidden", value = "http://jabber.org/protocol/muc#roominfo" },
-               { name = "muc#roominfo_description", label = "Description", value = "" },
-               { name = "muc#roominfo_occupants", label = "Number of occupants", value = "" }
-       });
-       local formdata = {
-               ["muc#roominfo_description"] = self:get_description(),
-               ["muc#roominfo_occupants"] = tostring(count),
-       };
-       module:fire_event("muc-disco#info", { room = self, reply = reply, form = dataform, formdata = formdata });
-       reply:add_child(dataform:form(formdata, 'result'))
-       return reply;
-end
-function room_mt:get_disco_items(stanza)
-       local reply = st.reply(stanza):query("http://jabber.org/protocol/disco#items");
-       for room_jid in pairs(self._occupants) do
-               reply:tag("item", {jid = room_jid, name = room_jid:match("/(.*)")}):up();
+function room_mt:route_to_occupant(occupant, stanza)
+       local to = stanza.attr.to;
+       for jid in occupant:each_session() do
+               stanza.attr.to = jid;
+               self:route_stanza(stanza);
        end
-       return reply;
-end
-function room_mt:set_subject(current_nick, subject)
-       if subject == "" then subject = nil; end
-       self._data['subject'] = subject;
-       self._data['subject_from'] = current_nick;
-       if self.save then self:save(); end
-       local msg = st.message({type='groupchat', from=current_nick})
-               :tag('subject'):text(subject):up();
-       self:broadcast_message(msg, false);
-       return true;
+       stanza.attr.to = to;
 end
 
-local function build_unavailable_presence_from_error(stanza)
-       local type, condition, text = stanza:get_error();
-       local error_message = "Kicked: "..(condition and condition:gsub("%-", " ") or "presence error");
-       if text then
-               error_message = error_message..": "..text;
+-- actor is the attribute table
+local function add_item(x, affiliation, role, jid, nick, actor_nick, actor_jid, reason)
+       x:tag("item", {affiliation = affiliation; role = role; jid = jid; nick = nick;})
+       if actor_nick or actor_jid then
+               x:tag("actor", {nick = actor_nick; jid = actor_jid;}):up()
        end
-       return st.presence({type='unavailable', from=stanza.attr.from, to=stanza.attr.to})
-               :tag('status'):text(error_message);
-end
-
-function room_mt:set_name(name)
-       if name == "" or type(name) ~= "string" or name == (jid_split(self.jid)) then name = nil; end
-       if self._data.name ~= name then
-               self._data.name = name;
-               if self.save then self:save(true); end
+       if reason then
+               x:tag("reason"):text(reason):up()
        end
+       x:up();
+       return x
 end
-function room_mt:get_name()
-       return self._data.name or jid_split(self.jid);
-end
-function room_mt:set_description(description)
-       if description == "" or type(description) ~= "string" then description = nil; end
-       if self._data.description ~= description then
-               self._data.description = description;
-               if self.save then self:save(true); end
+
+-- actor is (real) jid
+function room_mt:build_item_list(occupant, x, is_anonymous, nick, actor_nick, actor_jid, reason)
+       local affiliation = self:get_affiliation(occupant.bare_jid) or "none";
+       local role = occupant.role or "none";
+       if is_anonymous then
+               add_item(x, affiliation, role, nil, nick, actor_nick, actor_jid, reason);
+       else
+               for real_jid in occupant:each_session() do
+                       add_item(x, affiliation, role, real_jid, nick, actor_nick, actor_jid, reason);
+               end
        end
+       return x
 end
-function room_mt:get_description()
-       return self._data.description;
-end
-function room_mt:set_password(password)
-       if password == "" or type(password) ~= "string" then password = nil; end
-       if self._data.password ~= password then
-               self._data.password = password;
-               if self.save then self:save(true); end
+
+function room_mt:broadcast_message(stanza)
+       if module:fire_event("muc-broadcast-message", {room = self, stanza = stanza}) then
+               return true;
        end
+       self:broadcast(stanza);
+       return true;
 end
-function room_mt:get_password()
-       return self._data.password;
-end
-function room_mt:set_moderated(moderated)
-       moderated = moderated and true or nil;
-       if self._data.moderated ~= moderated then
-               self._data.moderated = moderated;
-               if self.save then self:save(true); end
+
+-- Broadcast a stanza to all occupants in the room.
+-- optionally checks conditional called with (nick, occupant)
+function room_mt:broadcast(stanza, cond_func)
+       for nick, occupant in self:each_occupant() do
+               if cond_func == nil or cond_func(nick, occupant) then
+                       self:route_to_occupant(occupant, stanza)
+               end
        end
 end
-function room_mt:get_moderated()
-       return self._data.moderated;
-end
-function room_mt:set_members_only(members_only)
-       members_only = members_only and true or nil;
-       if self._data.members_only ~= members_only then
-               self._data.members_only = members_only;
-               if self.save then self:save(true); end
+
+local function can_see_real_jids(whois, occupant)
+       if whois == "anyone" then
+               return true;
+       elseif whois == "moderators" then
+               return valid_roles[occupant.role or "none"] >= valid_roles.moderator;
        end
 end
-function room_mt:get_members_only()
-       return self._data.members_only;
-end
-function room_mt:set_persistent(persistent)
-       persistent = persistent and true or nil;
-       if self._data.persistent ~= persistent then
-               self._data.persistent = persistent;
-               if self.save then self:save(true); end
+
+-- Broadcasts an occupant's presence to the whole room
+-- Takes the x element that goes into the stanzas
+function room_mt:publicise_occupant_status(occupant, base_x, nick, actor, reason)
+       -- Build real jid and (optionally) occupant jid template presences
+       local base_presence do
+               -- Try to use main jid's presence
+               local pr = occupant:get_presence();
+               if pr and (pr.attr.type ~= "unavailable" or occupant.role == nil) then
+                       base_presence = st.clone(pr);
+               else -- user is leaving but didn't send a leave presence. make one for them
+                       base_presence = st.presence {from = occupant.nick; type = "unavailable";};
+               end
        end
-end
-function room_mt:get_persistent()
-       return self._data.persistent;
-end
-function room_mt:set_hidden(hidden)
-       hidden = hidden and true or nil;
-       if self._data.hidden ~= hidden then
-               self._data.hidden = hidden;
-               if self.save then self:save(true); end
+
+       -- Fire event (before full_p and anon_p are created)
+       local event = {
+               room = self; stanza = base_presence; x = base_x;
+               occupant = occupant; nick = nick; actor = actor;
+               reason = reason;
+       }
+       module:fire_event("muc-broadcast-presence", event);
+
+       -- Allow muc-broadcast-presence listeners to change things
+       nick = event.nick;
+       actor = event.actor;
+       reason = event.reason;
+
+       local whois = self:get_whois();
+
+       local actor_nick;
+       if actor then
+               actor_nick = select(3, jid_split(self:get_occupant_jid(actor)));
        end
-end
-function room_mt:get_hidden()
-       return self._data.hidden;
-end
-function room_mt:get_public()
-       return not self:get_hidden();
-end
-function room_mt:set_public(public)
-       return self:set_hidden(not public);
-end
-function room_mt:set_changesubject(changesubject)
-       changesubject = changesubject and true or nil;
-       if self._data.changesubject ~= changesubject then
-               self._data.changesubject = changesubject;
-               if self.save then self:save(true); end
+
+       local full_p, full_x;
+       local function get_full_p()
+               if full_p == nil then
+                       full_x = st.clone(base_x);
+                       self:build_item_list(occupant, full_x, false, nick, actor_nick, actor, reason);
+                       full_p = st.clone(base_presence):add_child(full_x);
+               end
+               return full_p, full_x;
        end
-end
-function room_mt:get_changesubject()
-       return self._data.changesubject;
-end
-function room_mt:get_historylength()
-       return self._data.history_length or default_history_length;
-end
-function room_mt:set_historylength(length)
-       length = math.min(tonumber(length) or default_history_length, max_history_length or math.huge);
-       if length == default_history_length then
-               length = nil;
+
+       local anon_p, anon_x;
+       local function get_anon_p()
+               if anon_p == nil then
+                       anon_x = st.clone(base_x);
+                       self:build_item_list(occupant, anon_x, true, nick, actor_nick, nil, reason);
+                       anon_p = st.clone(base_presence):add_child(anon_x);
+               end
+               return anon_p, anon_x;
        end
-       self._data.history_length = length;
-end
 
+       local self_p, self_x;
+       if can_see_real_jids(whois, occupant) then
+               self_p, self_x = get_full_p();
+       else
+               -- Can always see your own full jids
+               -- But not allowed to see actor's
+               self_x = st.clone(base_x);
+               self:build_item_list(occupant, self_x, false, nick, actor_nick, nil, reason);
+               self_p = st.clone(base_presence):add_child(self_x);
+       end
 
-local valid_whois = { moderators = true, anyone = true };
+       -- General populance
+       for occupant_nick, n_occupant in self:each_occupant() do
+               if occupant_nick ~= occupant.nick then
+                       local pr;
+                       if can_see_real_jids(whois, n_occupant) then
+                               pr = get_full_p();
+                       elseif occupant.bare_jid == n_occupant.bare_jid then
+                               pr = self_p;
+                       else
+                               pr = get_anon_p();
+                       end
+                       self:route_to_occupant(n_occupant, pr);
+               end
+       end
 
-function room_mt:set_whois(whois)
-       if valid_whois[whois] and self._data.whois ~= whois then
-               self._data.whois = whois;
-               if self.save then self:save(true); end
+       -- Presences for occupant itself
+       self_x:tag("status", {code = "110";}):up();
+       if occupant.role == nil then
+               -- They get an unavailable
+               self:route_to_occupant(occupant, self_p);
+       else
+               -- use their own presences as templates
+               for full_jid, pr in occupant:each_session() do
+                       pr = st.clone(pr);
+                       pr.attr.to = full_jid;
+                       pr:add_child(self_x);
+                       self:route_stanza(pr);
+               end
        end
 end
 
-function room_mt:get_whois()
-       return self._data.whois;
+function room_mt:send_occupant_list(to, filter)
+       local to_bare = jid_bare(to);
+       local is_anonymous = false;
+       local whois = self:get_whois();
+       if whois ~= "anyone" then
+               local affiliation = self:get_affiliation(to);
+               if affiliation ~= "admin" and affiliation ~= "owner" then
+                       local occupant = self:get_occupant_by_real_jid(to);
+                       if not (occupant and can_see_real_jids(whois, occupant)) then
+                               is_anonymous = true;
+                       end
+               end
+       end
+       for occupant_jid, occupant in self:each_occupant() do
+               if filter == nil or filter(occupant_jid, occupant) then
+                       local x = st.stanza("x", {xmlns='http://jabber.org/protocol/muc#user'});
+                       self:build_item_list(occupant, x, is_anonymous and to_bare ~= occupant.bare_jid); -- can always see your own jids
+                       local pres = st.clone(occupant:get_presence());
+                       pres.attr.to = to;
+                       pres:add_child(x);
+                       self:route_stanza(pres);
+               end
+       end
 end
 
-local function construct_stanza_id(room, stanza)
-       local from_jid, to_nick = stanza.attr.from, stanza.attr.to;
-       local from_nick = room._jid_nick[from_jid];
-       local occupant = room._occupants[to_nick];
-       local to_jid = occupant.jid;
+function room_mt:get_disco_info(stanza)
+       local reply = st.reply(stanza):query("http://jabber.org/protocol/disco#info");
+       local form = dataform.new {
+               { name = "FORM_TYPE", type = "hidden", value = "http://jabber.org/protocol/muc#roominfo" };
+       };
+       local formdata = {};
+       module:fire_event("muc-disco#info", {room = self; reply = reply; form = form, formdata = formdata ;});
+       reply:add_child(form:form(formdata, "result"));
+       return reply;
+end
+module:hook("muc-disco#info", function(event)
+       event.reply:tag("feature", {var = "http://jabber.org/protocol/muc"}):up();
+end);
+module:hook("muc-disco#info", function(event)
+       table.insert(event.form, { name = "muc#roominfo_occupants", label = "Number of occupants" });
+       event.formdata["muc#roominfo_occupants"] = tostring(iterators.count(event.room:each_occupant()));
+end);
 
-       return from_nick, to_jid, base64.encode(to_jid.."\0"..stanza.attr.id.."\0"..md5(from_jid));
+function room_mt:get_disco_items(stanza)
+       local reply = st.reply(stanza):query("http://jabber.org/protocol/disco#items");
+       for room_jid in self:each_occupant() do
+               reply:tag("item", {jid = room_jid, name = room_jid:match("/(.*)")}):up();
+       end
+       return reply;
 end
-local function deconstruct_stanza_id(room, stanza)
-       local from_jid_possiblybare, to_nick = stanza.attr.from, stanza.attr.to;
-       local from_jid, id, to_jid_hash = (base64.decode(stanza.attr.id) or ""):match("^(%Z+)%z(%Z*)%z(.+)$");
-       local from_nick = room._jid_nick[from_jid];
-
-       if not(from_nick) then return; end
-       if not(from_jid_possiblybare == from_jid or from_jid_possiblybare == jid_bare(from_jid)) then return; end
-
-       local occupant = room._occupants[to_nick];
-       for to_jid in pairs(occupant and occupant.sessions or {}) do
-               if md5(to_jid) == to_jid_hash then
-                       return from_nick, to_jid, id;
-               end
+
+function room_mt:handle_kickable(origin, stanza) -- luacheck: ignore 212
+       local real_jid = stanza.attr.from;
+       local occupant = self:get_occupant_by_real_jid(real_jid);
+       if occupant == nil then return nil; end
+       local type, condition, text = stanza:get_error();
+       local error_message = "Kicked: "..(condition and condition:gsub("%-", " ") or "presence error");
+       if text then
+               error_message = error_message..": "..text;
+       end
+       occupant:set_session(real_jid, st.presence({type="unavailable"})
+               :tag('status'):text(error_message));
+       self:save_occupant(occupant);
+       local x = st.stanza("x", {xmlns = "http://jabber.org/protocol/muc#user";})
+               :tag("status", {code = "307"})
+       self:publicise_occupant_status(occupant, x);
+       if occupant.jid == real_jid then -- Was last session
+               module:fire_event("muc-occupant-left", {room = self; nick = occupant.nick; occupant = occupant;});
        end
+       return true;
 end
 
+-- Give the room creator owner affiliation
+module:hook("muc-room-pre-create", function(event)
+       event.room:set_affiliation(true, jid_bare(event.stanza.attr.from), "owner");
+end, -1);
 
-function room_mt:handle_to_occupant(origin, stanza) -- PM, vCards, etc
-       local from, to = stanza.attr.from, stanza.attr.to;
-       local room = jid_bare(to);
-       local current_nick = self._jid_nick[from];
+-- check if user is banned
+module:hook("muc-occupant-pre-join", function(event)
+       local room, stanza = event.room, event.stanza;
+       local affiliation = room:get_affiliation(stanza.attr.from);
+       if affiliation == "outcast" then
+               local reply = st.error_reply(stanza, "auth", "forbidden"):up();
+               reply.tags[1].attr.code = "403";
+               event.origin.send(reply:tag("x", {xmlns = "http://jabber.org/protocol/muc"}));
+               return true;
+       end
+end, -10);
+
+function room_mt:handle_presence_to_occupant(origin, stanza)
        local type = stanza.attr.type;
-       log("debug", "room: %s, current_nick: %s, stanza: %s", room or "nil", current_nick or "nil", stanza:top_tag());
-       if (select(2, jid_split(from)) == muc_domain) then error("Presence from the MUC itself!!!"); end
-       if stanza.name == "presence" then
-               local pr = get_filtered_presence(stanza);
-               pr.attr.from = current_nick;
-               if type == "error" then -- error, kick em out!
-                       if current_nick then
-                               log("debug", "kicking %s from %s", current_nick, room);
-                               self:handle_to_occupant(origin, build_unavailable_presence_from_error(stanza));
+       if type == "error" then -- error, kick em out!
+               return self:handle_kickable(origin, stanza)
+       elseif type == nil or type == "unavailable" then
+               local real_jid = stanza.attr.from;
+               local bare_jid = jid_bare(real_jid);
+               local orig_occupant, dest_occupant;
+               local is_new_room = next(self._affiliations) == nil;
+               if is_new_room then
+                       if type == "unavailable" then return true; end -- Unavailable from someone not in the room
+                       if module:fire_event("muc-room-pre-create", {
+                                       room = self;
+                                       origin = origin;
+                                       stanza = stanza;
+                               }) then return true; end
+               else
+                       orig_occupant = self:get_occupant_by_real_jid(real_jid);
+                       if type == "unavailable" and orig_occupant == nil then return true; end -- Unavailable from someone not in the room
+               end
+               local is_first_dest_session;
+               if type == "unavailable" then -- luacheck: ignore 542
+                       -- FIXME Why the empty if branch?
+                       -- dest_occupant = nil
+               elseif orig_occupant and orig_occupant.nick == stanza.attr.to then -- Just a presence update
+                       log("debug", "presence update for %s from session %s", orig_occupant.nick, real_jid);
+                       dest_occupant = orig_occupant;
+               else
+                       local dest_jid = stanza.attr.to;
+                       dest_occupant = self:get_occupant_by_nick(dest_jid);
+                       if dest_occupant == nil then
+                               log("debug", "no occupant found for %s; creating new occupant object for %s", dest_jid, real_jid);
+                               is_first_dest_session = true;
+                               dest_occupant = self:new_occupant(bare_jid, dest_jid);
+                       else
+                               is_first_dest_session = false;
                        end
-               elseif type == "unavailable" then -- unavailable
-                       if current_nick then
-                               log("debug", "%s leaving %s", current_nick, room);
-                               self._jid_nick[from] = nil;
-                               local occupant = self._occupants[current_nick];
-                               local new_jid = next(occupant.sessions);
-                               if new_jid == from then new_jid = next(occupant.sessions, new_jid); end
-                               if new_jid then
-                                       local jid = occupant.jid;
-                                       occupant.jid = new_jid;
-                                       occupant.sessions[from] = nil;
-                                       pr.attr.to = from;
-                                       pr:tag("x", {xmlns='http://jabber.org/protocol/muc#user'})
-                                               :tag("item", {affiliation=occupant.affiliation or "none", role='none'}):up()
-                                               :tag("status", {code='110'}):up();
-                                       self:_route_stanza(pr);
-                                       if jid ~= new_jid then
-                                               pr = st.clone(occupant.sessions[new_jid])
-                                                       :tag("x", {xmlns='http://jabber.org/protocol/muc#user'})
-                                                       :tag("item", {affiliation=occupant.affiliation or "none", role=occupant.role or "none"});
-                                               pr.attr.from = current_nick;
-                                               self:broadcast_except_nick(pr, current_nick);
-                                       end
-                               else
-                                       occupant.role = 'none';
-                                       self:broadcast_presence(pr, from);
-                                       self._occupants[current_nick] = nil;
+               end
+               local is_last_orig_session;
+               if orig_occupant ~= nil then
+                       -- Is there are least 2 sessions?
+                       local iter, ob, last = orig_occupant:each_session();
+                       is_last_orig_session = iter(ob, iter(ob, last)) == nil;
+               end
+
+               local event, event_name = {
+                       room = self;
+                       origin = origin;
+                       stanza = stanza;
+                       is_first_session = is_first_dest_session;
+                       is_last_session = is_last_orig_session;
+               };
+               if orig_occupant == nil then
+                       event_name = "muc-occupant-pre-join";
+                       event.is_new_room = is_new_room;
+                       event.occupant = dest_occupant;
+               elseif dest_occupant == nil then
+                       event_name = "muc-occupant-pre-leave";
+                       event.occupant = orig_occupant;
+               else
+                       event_name = "muc-occupant-pre-change";
+                       event.orig_occupant = orig_occupant;
+                       event.dest_occupant = dest_occupant;
+               end
+               if module:fire_event(event_name, event) then return true; end
+
+               -- Check for nick conflicts
+               if dest_occupant ~= nil and not is_first_dest_session and bare_jid ~= jid_bare(dest_occupant.bare_jid) then -- new nick or has different bare real jid
+                       log("debug", "%s couldn't join due to nick conflict: %s", real_jid, dest_occupant.nick);
+                       local reply = st.error_reply(stanza, "cancel", "conflict"):up();
+                       reply.tags[1].attr.code = "409";
+                       origin.send(reply:tag("x", {xmlns = "http://jabber.org/protocol/muc"}));
+                       return true;
+               end
+
+               -- Send presence stanza about original occupant
+               if orig_occupant ~= nil and orig_occupant ~= dest_occupant then
+                       local orig_x = st.stanza("x", {xmlns = "http://jabber.org/protocol/muc#user";});
+                       local dest_nick;
+                       if dest_occupant == nil then -- Session is leaving
+                               log("debug", "session %s is leaving occupant %s", real_jid, orig_occupant.nick);
+                               if is_last_orig_session then
+                                       orig_occupant.role = nil;
                                end
-                       end
-               elseif not type then -- available
-                       if current_nick then
-                               --if #pr == #stanza or current_nick ~= to then -- commented because google keeps resending directed presence
-                                       if current_nick == to then -- simple presence
-                                               log("debug", "%s broadcasted presence", current_nick);
-                                               self._occupants[current_nick].sessions[from] = pr;
-                                               self:broadcast_presence(pr, from);
-                                       else -- change nick
-                                               local occupant = self._occupants[current_nick];
-                                               local is_multisession = next(occupant.sessions, next(occupant.sessions));
-                                               if self._occupants[to] or is_multisession then
-                                                       log("debug", "%s couldn't change nick", current_nick);
-                                                       local reply = st.error_reply(stanza, "cancel", "conflict"):up();
-                                                       reply.tags[1].attr.code = "409";
-                                                       origin.send(reply:tag("x", {xmlns = "http://jabber.org/protocol/muc"}));
-                                               else
-                                                       local data = self._occupants[current_nick];
-                                                       local to_nick = select(3, jid_split(to));
-                                                       if to_nick then
-                                                               log("debug", "%s (%s) changing nick to %s", current_nick, data.jid, to);
-                                                               local p = st.presence({type='unavailable', from=current_nick});
-                                                               self:broadcast_presence(p, from, '303', to_nick);
-                                                               self._occupants[current_nick] = nil;
-                                                               self._occupants[to] = data;
-                                                               self._jid_nick[from] = to;
-                                                               pr.attr.from = to;
-                                                               self._occupants[to].sessions[from] = pr;
-                                                               self:broadcast_presence(pr, from);
-                                                       else
-                                                               --TODO malformed-jid
-                                                       end
-                                               end
-                                       end
-                               --else -- possible rejoin
-                               --      log("debug", "%s had connection replaced", current_nick);
-                               --      self:handle_to_occupant(origin, st.presence({type='unavailable', from=from, to=to})
-                               --              :tag('status'):text('Replaced by new connection'):up()); -- send unavailable
-                               --      self:handle_to_occupant(origin, stanza); -- resend available
-                               --end
-                       else -- enter room
-                               local new_nick = to;
-                               local is_merge;
-                               if self._occupants[to] then
-                                       if jid_bare(from) ~= jid_bare(self._occupants[to].jid) then
-                                               new_nick = nil;
-                                       end
-                                       is_merge = true;
+                               orig_occupant:set_session(real_jid, stanza);
+                       else
+                               log("debug", "session %s is changing from occupant %s to %s", real_jid, orig_occupant.nick, dest_occupant.nick);
+                               local generated_unavail = st.presence {from = orig_occupant.nick, to = real_jid, type = "unavailable"};
+                               orig_occupant:set_session(real_jid, generated_unavail);
+                               dest_nick = select(3, jid_split(dest_occupant.nick));
+                               if not is_first_dest_session then -- User is swapping into another pre-existing session
+                                       log("debug", "session %s is swapping into multisession %s, showing it leave.", real_jid, dest_occupant.nick);
+                                       -- Show the other session leaving
+                                       local x = st.stanza("x", {xmlns = "http://jabber.org/protocol/muc#user";})
+                                               :tag("status"):text("you are joining pre-existing session " .. dest_nick):up();
+                                       add_item(x, self:get_affiliation(bare_jid), "none");
+                                       local pr = st.presence{from = dest_occupant.nick, to = real_jid, type = "unavailable"}
+                                               :add_child(x);
+                                       self:route_stanza(pr);
                                end
-                               local password = stanza:get_child("x", "http://jabber.org/protocol/muc");
-                               password = password and password:get_child("password", "http://jabber.org/protocol/muc");
-                               password = password and password[1] ~= "" and password[1];
-                               if self:get_password() and self:get_password() ~= password then
-                                       log("debug", "%s couldn't join due to invalid password: %s", from, to);
-                                       local reply = st.error_reply(stanza, "auth", "not-authorized"):up();
-                                       reply.tags[1].attr.code = "401";
-                                       origin.send(reply:tag("x", {xmlns = "http://jabber.org/protocol/muc"}));
-                               elseif not new_nick then
-                                       log("debug", "%s couldn't join due to nick conflict: %s", from, to);
-                                       local reply = st.error_reply(stanza, "cancel", "conflict"):up();
-                                       reply.tags[1].attr.code = "409";
-                                       origin.send(reply:tag("x", {xmlns = "http://jabber.org/protocol/muc"}));
-                               else
-                                       log("debug", "%s joining as %s", from, to);
-                                       if not next(self._affiliations) then -- new room, no owners
-                                               self._affiliations[jid_bare(from)] = "owner";
-                                               if self.locked and not stanza:get_child("x", "http://jabber.org/protocol/muc") then
-                                                       self.locked = nil; -- Older groupchat protocol doesn't lock
-                                               end
-                                       elseif self.locked then -- Deny entry
-                                               origin.send(st.error_reply(stanza, "cancel", "item-not-found"));
-                                               return;
-                                       end
-                                       local affiliation = self:get_affiliation(from);
-                                       local role = self:get_default_role(affiliation)
-                                       if role then -- new occupant
-                                               if not is_merge then
-                                                       self._occupants[to] = {affiliation=affiliation, role=role, jid=from, sessions={[from]=get_filtered_presence(stanza)}};
-                                               else
-                                                       self._occupants[to].sessions[from] = get_filtered_presence(stanza);
-                                               end
-                                               self._jid_nick[from] = to;
-                                               self:send_occupant_list(from);
-                                               pr.attr.from = to;
-                                               pr:tag("x", {xmlns='http://jabber.org/protocol/muc#user'})
-                                                       :tag("item", {affiliation=affiliation or "none", role=role or "none"}):up();
-                                               if not is_merge then
-                                                       self:broadcast_except_nick(pr, to);
-                                               end
-                                               pr:tag("status", {code='110'}):up();
-                                               if self._data.whois == 'anyone' then
-                                                       pr:tag("status", {code='100'}):up();
-                                               end
-                                               if self.locked then
-                                                       pr:tag("status", {code='201'}):up();
-                                               end
-                                               pr.attr.to = from;
-                                               self:_route_stanza(pr);
-                                               self:send_history(from, stanza);
-                                               self:send_subject(from);
-                                       elseif not affiliation then -- registration required for entering members-only room
-                                               local reply = st.error_reply(stanza, "auth", "registration-required"):up();
-                                               reply.tags[1].attr.code = "407";
-                                               origin.send(reply:tag("x", {xmlns = "http://jabber.org/protocol/muc"}));
-                                       else -- banned
-                                               local reply = st.error_reply(stanza, "auth", "forbidden"):up();
-                                               reply.tags[1].attr.code = "403";
-                                               origin.send(reply:tag("x", {xmlns = "http://jabber.org/protocol/muc"}));
-                                       end
+                               if is_first_dest_session and is_last_orig_session then -- Normal nick change
+                                       log("debug", "no sessions in %s left; publically marking as nick change", orig_occupant.nick);
+                                       orig_x:tag("status", {code = "303";}):up();
+                               else -- The session itself always needs to see a nick change
+                                       -- don't want to get our old nick's available presence,
+                                       -- so remove our session from there, and manually generate an unavailable
+                                       orig_occupant:remove_session(real_jid);
+                                       log("debug", "generating nick change for %s", real_jid);
+                                       local x = st.stanza("x", {xmlns = "http://jabber.org/protocol/muc#user";});
+                                       -- self:build_item_list(orig_occupant, x, false, dest_nick); -- COMPAT: clients get confused if they see other items besides their own
+                                       add_item(x, self:get_affiliation(bare_jid), orig_occupant.role, real_jid, dest_nick);
+                                       x:tag("status", {code = "303";}):up();
+                                       x:tag("status", {code = "110";}):up();
+                                       self:route_stanza(generated_unavail:add_child(x));
+                                       dest_nick = nil; -- set dest_nick to nil; so general populance doesn't see it for whole orig_occupant
                                end
                        end
-               elseif type ~= 'result' then -- bad type
-                       if type ~= 'visible' and type ~= 'invisible' then -- COMPAT ejabberd can broadcast or forward XEP-0018 presences
-                               origin.send(st.error_reply(stanza, "modify", "bad-request")); -- FIXME correct error?
+                       self:save_occupant(orig_occupant);
+                       self:publicise_occupant_status(orig_occupant, orig_x, dest_nick);
+
+                       if is_last_orig_session then
+                               module:fire_event("muc-occupant-left", {room = self; nick = orig_occupant.nick; occupant = orig_occupant;});
                        end
                end
-       elseif not current_nick then -- not in room
-               if (type == "error" or type == "result") and stanza.name == "iq" then
-                       local id = stanza.attr.id;
-                       stanza.attr.from, stanza.attr.to, stanza.attr.id = deconstruct_stanza_id(self, stanza);
-                       if stanza.attr.id then
-                               self:_route_stanza(stanza);
+
+               if dest_occupant ~= nil then
+                       dest_occupant:set_session(real_jid, stanza);
+                       local dest_x = st.stanza("x", {xmlns = "http://jabber.org/protocol/muc#user";});
+                       if is_new_room then
+                               dest_x:tag("status", {code = "201"}):up();
                        end
-                       stanza.attr.from, stanza.attr.to, stanza.attr.id = from, to, id;
-               elseif type ~= "error" then
-                       origin.send(st.error_reply(stanza, "cancel", "not-acceptable"));
-               end
-       elseif stanza.name == "message" and type == "groupchat" then -- groupchat messages not allowed in PM
-               origin.send(st.error_reply(stanza, "modify", "bad-request"));
-       elseif current_nick and stanza.name == "message" and type == "error" and is_kickable_error(stanza) then
-               log("debug", "%s kicked from %s for sending an error message", current_nick, self.jid);
-               self:handle_to_occupant(origin, build_unavailable_presence_from_error(stanza)); -- send unavailable
-       else -- private stanza
-               local o_data = self._occupants[to];
-               if o_data then
-                       log("debug", "%s sent private stanza to %s (%s)", from, to, o_data.jid);
-                       if stanza.name == "iq" then
-                               local id = stanza.attr.id;
-                               if stanza.attr.type == "get" or stanza.attr.type == "set" then
-                                       stanza.attr.from, stanza.attr.to, stanza.attr.id = construct_stanza_id(self, stanza);
-                               else
-                                       stanza.attr.from, stanza.attr.to, stanza.attr.id = deconstruct_stanza_id(self, stanza);
-                               end
-                               if type == 'get' and stanza.tags[1].attr.xmlns == 'vcard-temp' then
-                                       stanza.attr.to = jid_bare(stanza.attr.to);
-                               end
-                               if stanza.attr.id then
-                                       self:_route_stanza(stanza);
+                       if orig_occupant == nil and self:get_whois() == "anyone" then
+                               dest_x:tag("status", {code = "100"}):up();
+                       end
+                       self:save_occupant(dest_occupant);
+
+                       if orig_occupant == nil then
+                               -- Send occupant list to newly joined user
+                               self:send_occupant_list(real_jid, function(nick, occupant) -- luacheck: ignore 212
+                                       -- Don't include self
+                                       return occupant:get_presence(real_jid) == nil;
+                               end)
+                       end
+                       self:publicise_occupant_status(dest_occupant, dest_x);
+
+                       if orig_occupant ~= nil and orig_occupant ~= dest_occupant and not is_last_orig_session then -- If user is swapping and wasn't last original session
+                               log("debug", "session %s split nicks; showing %s rejoining", real_jid, orig_occupant.nick);
+                               -- Show the original nick joining again
+                               local pr = st.clone(orig_occupant:get_presence());
+                               pr.attr.to = real_jid;
+                               local x = st.stanza("x", {xmlns = "http://jabber.org/protocol/muc#user";});
+                               self:build_item_list(orig_occupant, x, false);
+                               -- TODO: new status code to inform client this was the multi-session it left?
+                               pr:add_child(x);
+                               self:route_stanza(pr);
+                       end
+
+                       if orig_occupant == nil then
+                               if is_first_dest_session then
+                                       module:fire_event("muc-occupant-joined", {room = self; nick = dest_occupant.nick; occupant = dest_occupant;});
                                end
-                               stanza.attr.from, stanza.attr.to, stanza.attr.id = from, to, id;
-                       else -- message
-                               stanza:tag("x", { xmlns = "http://jabber.org/protocol/muc#user" }):up();
-                               stanza.attr.from = current_nick;
-                               for jid in pairs(o_data.sessions) do
-                                       stanza.attr.to = jid;
-                                       self:_route_stanza(stanza);
+                               module:fire_event("muc-occupant-session-new", {room = self; nick = dest_occupant.nick; occupant = dest_occupant; stanza = stanza; jid = real_jid;});
+                       end
+               end
+       elseif type ~= 'result' then -- bad type
+               if type ~= 'visible' and type ~= 'invisible' then -- COMPAT ejabberd can broadcast or forward XEP-0018 presences
+                       origin.send(st.error_reply(stanza, "modify", "bad-request")); -- FIXME correct error?
+               end
+       end
+       return true;
+end
+
+function room_mt:handle_iq_to_occupant(origin, stanza)
+       local from, to = stanza.attr.from, stanza.attr.to;
+       local type = stanza.attr.type;
+       local id = stanza.attr.id;
+       local occupant = self:get_occupant_by_nick(to);
+       if (type == "error" or type == "result") then
+               do -- deconstruct_stanza_id
+                       if not occupant then return nil; end
+                       local from_jid, orig_id, to_jid_hash = (base64.decode(id) or ""):match("^(%Z+)%z(%Z*)%z(.+)$");
+                       if not(from == from_jid or from == jid_bare(from_jid)) then return nil; end
+                       local from_occupant_jid = self:get_occupant_jid(from_jid);
+                       if from_occupant_jid == nil then return nil; end
+                       local session_jid
+                       for to_jid in occupant:each_session() do
+                               if md5(to_jid) == to_jid_hash then
+                                       session_jid = to_jid;
+                                       break;
                                end
-                               stanza.attr.from, stanza.attr.to = from, to;
                        end
-               elseif type ~= "error" and type ~= "result" then -- recipient not in room
+                       if session_jid == nil then return nil; end
+                       stanza.attr.from, stanza.attr.to, stanza.attr.id = from_occupant_jid, session_jid, orig_id;
+               end
+               log("debug", "%s sent private iq stanza to %s (%s)", from, to, stanza.attr.to);
+               self:route_stanza(stanza);
+               stanza.attr.from, stanza.attr.to, stanza.attr.id = from, to, id;
+               return true;
+       else -- Type is "get" or "set"
+               local current_nick = self:get_occupant_jid(from);
+               if not current_nick then
+                       origin.send(st.error_reply(stanza, "cancel", "not-acceptable"));
+                       return true;
+               end
+               if not occupant then -- recipient not in room
                        origin.send(st.error_reply(stanza, "cancel", "item-not-found", "Recipient not in room"));
+                       return true;
                end
+               do -- construct_stanza_id
+                       stanza.attr.id = base64.encode(occupant.jid.."\0"..stanza.attr.id.."\0"..md5(from));
+               end
+               stanza.attr.from, stanza.attr.to = current_nick, occupant.jid;
+               log("debug", "%s sent private iq stanza to %s (%s)", from, to, occupant.jid);
+               if stanza.tags[1].attr.xmlns == 'vcard-temp' then
+                       stanza.attr.to = jid_bare(stanza.attr.to);
+               end
+               self:route_stanza(stanza);
+               stanza.attr.from, stanza.attr.to, stanza.attr.id = from, to, id;
+               return true;
        end
 end
 
+function room_mt:handle_message_to_occupant(origin, stanza)
+       local from, to = stanza.attr.from, stanza.attr.to;
+       local current_nick = self:get_occupant_jid(from);
+       local type = stanza.attr.type;
+       if not current_nick then -- not in room
+               if type ~= "error" then
+                       origin.send(st.error_reply(stanza, "cancel", "not-acceptable"));
+               end
+               return true;
+       end
+       if type == "groupchat" then -- groupchat messages not allowed in PM
+               origin.send(st.error_reply(stanza, "modify", "bad-request"));
+               return true;
+       elseif type == "error" and is_kickable_error(stanza) then
+               log("debug", "%s kicked from %s for sending an error message", current_nick, self.jid);
+               return self:handle_kickable(origin, stanza); -- send unavailable
+       end
+
+       local o_data = self:get_occupant_by_nick(to);
+       if not o_data then
+               origin.send(st.error_reply(stanza, "cancel", "item-not-found", "Recipient not in room"));
+               return true;
+       end
+       log("debug", "%s sent private message stanza to %s (%s)", from, to, o_data.jid);
+       stanza:tag("x", { xmlns = "http://jabber.org/protocol/muc#user" }):up();
+       stanza.attr.from = current_nick;
+       self:route_to_occupant(o_data, stanza)
+       -- TODO: Remove x tag?
+       stanza.attr.from = from;
+       return true;
+end
+
 function room_mt:send_form(origin, stanza)
        origin.send(st.reply(stanza):query("http://jabber.org/protocol/muc#owner")
                :add_child(self:get_form_layout(stanza.attr.from):form())
@@ -605,352 +638,379 @@ function room_mt:get_form_layout(actor)
                        name = 'FORM_TYPE',
                        type = 'hidden',
                        value = 'http://jabber.org/protocol/muc#roomconfig'
-               },
-               {
-                       name = 'muc#roomconfig_roomname',
-                       type = 'text-single',
-                       label = 'Name',
-                       value = self:get_name() or "",
-               },
-               {
-                       name = 'muc#roomconfig_roomdesc',
-                       type = 'text-single',
-                       label = 'Description',
-                       value = self:get_description() or "",
-               },
-               {
-                       name = 'muc#roomconfig_persistentroom',
-                       type = 'boolean',
-                       label = 'Make Room Persistent?',
-                       value = self:get_persistent()
-               },
-               {
-                       name = 'muc#roomconfig_publicroom',
-                       type = 'boolean',
-                       label = 'Make Room Publicly Searchable?',
-                       value = not self:get_hidden()
-               },
-               {
-                       name = 'muc#roomconfig_changesubject',
-                       type = 'boolean',
-                       label = 'Allow Occupants to Change Subject?',
-                       value = self:get_changesubject()
-               },
-               {
-                       name = 'muc#roomconfig_whois',
-                       type = 'list-single',
-                       label = 'Who May Discover Real JIDs?',
-                       value = {
-                               { value = 'moderators', label = 'Moderators Only', default = self._data.whois == 'moderators' },
-                               { value = 'anyone',     label = 'Anyone',          default = self._data.whois == 'anyone' }
-                       }
-               },
-               {
-                       name = 'muc#roomconfig_roomsecret',
-                       type = 'text-private',
-                       label = 'Password',
-                       value = self:get_password() or "",
-               },
-               {
-                       name = 'muc#roomconfig_moderatedroom',
-                       type = 'boolean',
-                       label = 'Make Room Moderated?',
-                       value = self:get_moderated()
-               },
-               {
-                       name = 'muc#roomconfig_membersonly',
-                       type = 'boolean',
-                       label = 'Make Room Members-Only?',
-                       value = self:get_members_only()
-               },
-               {
-                       name = 'muc#roomconfig_historylength',
-                       type = 'text-single',
-                       label = 'Maximum Number of History Messages Returned by Room',
-                       value = tostring(self:get_historylength())
                }
        });
        return module:fire_event("muc-config-form", { room = self, actor = actor, form = form }) or form;
 end
 
 function room_mt:process_form(origin, stanza)
-       local query = stanza.tags[1];
-       local form;
-       for _, tag in ipairs(query.tags) do if tag.name == "x" and tag.attr.xmlns == "jabber:x:data" then form = tag; break; end end
-       if not form then origin.send(st.error_reply(stanza, "cancel", "service-unavailable")); return; end
-       if form.attr.type == "cancel" then origin.send(st.reply(stanza)); return; end
-       if form.attr.type ~= "submit" then origin.send(st.error_reply(stanza, "cancel", "bad-request", "Not a submitted form")); return; end
-
-       local fields, errors, present = self:get_form_layout(stanza.attr.from):data(form);
-       if fields.FORM_TYPE ~= "http://jabber.org/protocol/muc#roomconfig" then
-               origin.send(st.error_reply(stanza, "cancel", "bad-request", "Form is not of type room configuration"));
-               return;
-       end
+       local form = stanza.tags[1]:get_child("x", "jabber:x:data");
+       if form.attr.type == "cancel" then
+               origin.send(st.reply(stanza));
+       elseif form.attr.type == "submit" then
+               local fields, errors, present;
+               if form.tags[1] == nil then -- Instant room
+                       fields, present = {}, {};
+               else
+                       fields, errors, present = self:get_form_layout(stanza.attr.from):data(form);
+                       if fields.FORM_TYPE ~= "http://jabber.org/protocol/muc#roomconfig" then
+                               origin.send(st.error_reply(stanza, "cancel", "bad-request", "Form is not of type room configuration"));
+                               return true;
+                       end
+               end
+
+               local event = {room = self; origin = origin; stanza = stanza; fields = fields; status_codes = {};};
+               function event.update_option(name, field, allowed)
+                       local new = fields[field];
+                       if new == nil then return; end
+                       if allowed and not allowed[new] then return; end
+                       if new == self["get_"..name](self) then return; end
+                       event.status_codes["104"] = true;
+                       self["set_"..name](self, new);
+                       return true;
+               end
+               module:fire_event("muc-config-submitted", event);
+               for submitted_field in pairs(present) do
+                       event.field, event.value = submitted_field, fields[submitted_field];
+                       module:fire_event("muc-config-submitted/"..submitted_field, event);
+               end
+               event.field, event.value = nil, nil;
 
-       local changed = {};
+               if self.save then self:save(true); end
+               origin.send(st.reply(stanza));
 
-       local function handle_option(name, field, allowed)
-               if not present[field] then return; end
-               local new = fields[field];
-               if allowed and not allowed[new] then return; end
-               if new == self["get_"..name](self) then return; end
-               changed[name] = true;
-               self["set_"..name](self, new);
+               if next(event.status_codes) then
+                       local msg = st.message({type='groupchat', from=self.jid})
+                               :tag('x', {xmlns='http://jabber.org/protocol/muc#user'})
+                       for code in pairs(event.status_codes) do
+                               msg:tag("status", {code = code;}):up();
+                       end
+                       msg:up();
+                       self:broadcast_message(msg);
+               end
+       else
+               origin.send(st.error_reply(stanza, "cancel", "bad-request", "Not a submitted form"));
        end
+       return true;
+end
 
-       local event = { room = self, fields = fields, changed = changed, stanza = stanza, origin = origin, update_option = handle_option };
-       module:fire_event("muc-config-submitted", event);
-
-       handle_option("name", "muc#roomconfig_roomname");
-       handle_option("description", "muc#roomconfig_roomdesc");
-       handle_option("persistent", "muc#roomconfig_persistentroom");
-       handle_option("moderated", "muc#roomconfig_moderatedroom");
-       handle_option("members_only", "muc#roomconfig_membersonly");
-       handle_option("public", "muc#roomconfig_publicroom");
-       handle_option("changesubject", "muc#roomconfig_changesubject");
-       handle_option("historylength", "muc#roomconfig_historylength");
-       handle_option("whois", "muc#roomconfig_whois", valid_whois);
-       handle_option("password", "muc#roomconfig_roomsecret");
-
-       if self.save then self:save(true); end
-       if self.locked then
-               module:fire_event("muc-room-unlocked", { room = self });
-               self.locked = nil;
+-- Removes everyone from the room
+function room_mt:clear(x)
+       x = x or st.stanza("x", {xmlns='http://jabber.org/protocol/muc#user'});
+       local occupants_updated = {};
+       for nick, occupant in self:each_occupant() do -- luacheck: ignore 213
+               occupant.role = nil;
+               self:save_occupant(occupant);
+               occupants_updated[occupant] = true;
        end
-       origin.send(st.reply(stanza));
-
-       if next(changed) then
-               local msg = st.message({type='groupchat', from=self.jid})
-                       :tag('x', {xmlns='http://jabber.org/protocol/muc#user'})
-                               :tag('status', {code = '104'}):up();
-               if changed.whois then
-                       local code = (self:get_whois() == 'moderators') and "173" or "172";
-                       msg.tags[1]:tag('status', {code = code}):up();
-               end
-               self:broadcast_message(msg, false)
+       for occupant in pairs(occupants_updated) do
+               self:publicise_occupant_status(occupant, x);
+               module:fire_event("muc-occupant-left", { room = self; nick = occupant.nick; occupant = occupant;});
        end
 end
 
 function room_mt:destroy(newjid, reason, password)
-       local pr = st.presence({type = "unavailable"})
-               :tag("x", {xmlns = "http://jabber.org/protocol/muc#user"})
-                       :tag("item", { affiliation='none', role='none' }):up()
-                       :tag("destroy", {jid=newjid})
-       if reason then pr:tag("reason"):text(reason):up(); end
-       if password then pr:tag("password"):text(password):up(); end
-       for nick, occupant in pairs(self._occupants) do
-               pr.attr.from = nick;
-               for jid in pairs(occupant.sessions) do
-                       pr.attr.to = jid;
-                       self:_route_stanza(pr);
-                       self._jid_nick[jid] = nil;
+       local x = st.stanza("x", {xmlns = "http://jabber.org/protocol/muc#user"})
+               :tag("item", { affiliation='none', role='none' }):up()
+               :tag("destroy", {jid=newjid});
+       if reason then x:tag("reason"):text(reason):up(); end
+       if password then x:tag("password"):text(password):up(); end
+       x:up();
+       self:clear(x);
+       module:fire_event("muc-room-destroyed", { room = self });
+end
+
+function room_mt:handle_disco_info_get_query(origin, stanza)
+       origin.send(self:get_disco_info(stanza));
+       return true;
+end
+
+function room_mt:handle_disco_items_get_query(origin, stanza)
+       origin.send(self:get_disco_items(stanza));
+       return true;
+end
+
+function room_mt:handle_admin_query_set_command(origin, stanza)
+       local item = stanza.tags[1].tags[1];
+       if not item then
+               origin.send(st.error_reply(stanza, "cancel", "bad-request"));
+       end
+       if item.attr.jid then -- Validate provided JID
+               item.attr.jid = jid_prep(item.attr.jid);
+               if not item.attr.jid then
+                       origin.send(st.error_reply(stanza, "modify", "jid-malformed"));
+                       return true;
                end
-               self._occupants[nick] = nil;
        end
-       self:set_persistent(false);
-       module:fire_event("muc-room-destroyed", { room = self });
+       if not item.attr.jid and item.attr.nick then -- COMPAT Workaround for Miranda sending 'nick' instead of 'jid' when changing affiliation
+               local occupant = self:get_occupant_by_nick(self.jid.."/"..item.attr.nick);
+               if occupant then item.attr.jid = occupant.jid; end
+       elseif not item.attr.nick and item.attr.jid then
+               local nick = self:get_occupant_jid(item.attr.jid);
+               if nick then item.attr.nick = select(3, jid_split(nick)); end
+       end
+       local actor = stanza.attr.from;
+       local reason = item:get_child_text("reason");
+       local success, errtype, err
+       if item.attr.affiliation and item.attr.jid and not item.attr.role then
+               success, errtype, err = self:set_affiliation(actor, item.attr.jid, item.attr.affiliation, reason);
+       elseif item.attr.role and item.attr.nick and not item.attr.affiliation then
+               success, errtype, err = self:set_role(actor, self.jid.."/"..item.attr.nick, item.attr.role, reason);
+       else
+               success, errtype, err = nil, "cancel", "bad-request";
+       end
+       if not success then
+               origin.send(st.error_reply(stanza, errtype, err));
+       else
+               origin.send(st.reply(stanza));
+       end
+       return true;
 end
 
-function room_mt:handle_to_room(origin, stanza) -- presence changes and groupchat messages, along with disco/etc
-       local type = stanza.attr.type;
-       local xmlns = stanza.tags[1] and stanza.tags[1].attr.xmlns;
-       if stanza.name == "iq" then
-               if xmlns == "http://jabber.org/protocol/disco#info" and type == "get" and not stanza.tags[1].attr.node then
-                       origin.send(self:get_disco_info(stanza));
-               elseif xmlns == "http://jabber.org/protocol/disco#items" and type == "get" and not stanza.tags[1].attr.node then
-                       origin.send(self:get_disco_items(stanza));
-               elseif xmlns == "http://jabber.org/protocol/muc#admin" then
-                       local actor = stanza.attr.from;
-                       local affiliation = self:get_affiliation(actor);
-                       local current_nick = self._jid_nick[actor];
-                       local role = current_nick and self._occupants[current_nick].role or self:get_default_role(affiliation);
-                       local item = stanza.tags[1].tags[1];
-                       if item and item.name == "item" then
-                               if type == "set" then
-                                       local callback = function() origin.send(st.reply(stanza)); end
-                                       if item.attr.jid then -- Validate provided JID
-                                               item.attr.jid = jid_prep(item.attr.jid);
-                                               if not item.attr.jid then
-                                                       origin.send(st.error_reply(stanza, "modify", "jid-malformed"));
-                                                       return;
-                                               end
-                                       end
-                                       if not item.attr.jid and item.attr.nick then -- COMPAT Workaround for Miranda sending 'nick' instead of 'jid' when changing affiliation
-                                               local occupant = self._occupants[self.jid.."/"..item.attr.nick];
-                                               if occupant then item.attr.jid = occupant.jid; end
-                                       elseif not item.attr.nick and item.attr.jid then
-                                               local nick = self._jid_nick[item.attr.jid];
-                                               if nick then item.attr.nick = select(3, jid_split(nick)); end
-                                       end
-                                       local reason = item.tags[1] and item.tags[1].name == "reason" and #item.tags[1] == 1 and item.tags[1][1];
-                                       if item.attr.affiliation and item.attr.jid and not item.attr.role then
-                                               local success, errtype, err = self:set_affiliation(actor, item.attr.jid, item.attr.affiliation, callback, reason);
-                                               if not success then origin.send(st.error_reply(stanza, errtype, err)); end
-                                       elseif item.attr.role and item.attr.nick and not item.attr.affiliation then
-                                               local success, errtype, err = self:set_role(actor, self.jid.."/"..item.attr.nick, item.attr.role, callback, reason);
-                                               if not success then origin.send(st.error_reply(stanza, errtype, err)); end
-                                       else
-                                               origin.send(st.error_reply(stanza, "cancel", "bad-request"));
-                                       end
-                               elseif type == "get" then
-                                       local _aff = item.attr.affiliation;
-                                       local _rol = item.attr.role;
-                                       if _aff and not _rol then
-                                               if affiliation == "owner" or (affiliation == "admin" and _aff ~= "owner" and _aff ~= "admin") then
-                                                       local reply = st.reply(stanza):query("http://jabber.org/protocol/muc#admin");
-                                                       for jid, affiliation in pairs(self._affiliations) do
-                                                               if affiliation == _aff then
-                                                                       reply:tag("item", {affiliation = _aff, jid = jid}):up();
-                                                               end
-                                                       end
-                                                       origin.send(reply);
-                                               else
-                                                       origin.send(st.error_reply(stanza, "auth", "forbidden"));
-                                               end
-                                       elseif _rol and not _aff then
-                                               if role == "moderator" then
-                                                       -- TODO allow admins and owners not in room? Provide read-only access to everyone who can see the participants anyway?
-                                                       if _rol == "none" then _rol = nil; end
-                                                       local reply = st.reply(stanza):query("http://jabber.org/protocol/muc#admin");
-                                                       for occupant_jid, occupant in pairs(self._occupants) do
-                                                               if occupant.role == _rol then
-                                                                       reply:tag("item", {
-                                                                               nick = select(3, jid_split(occupant_jid)),
-                                                                               role = _rol or "none",
-                                                                               affiliation = occupant.affiliation or "none",
-                                                                               jid = occupant.jid
-                                                                               }):up();
-                                                               end
-                                                       end
-                                                       origin.send(reply);
-                                               else
-                                                       origin.send(st.error_reply(stanza, "auth", "forbidden"));
-                                               end
-                                       else
-                                               origin.send(st.error_reply(stanza, "cancel", "bad-request"));
-                                       end
-                               end
-                       elseif type == "set" or type == "get" then
-                               origin.send(st.error_reply(stanza, "cancel", "bad-request"));
-                       end
-               elseif xmlns == "http://jabber.org/protocol/muc#owner" and (type == "get" or type == "set") and stanza.tags[1].name == "query" then
-                       if self:get_affiliation(stanza.attr.from) ~= "owner" then
-                               origin.send(st.error_reply(stanza, "auth", "forbidden", "Only owners can configure rooms"));
-                       elseif stanza.attr.type == "get" then
-                               self:send_form(origin, stanza);
-                       elseif stanza.attr.type == "set" then
-                               local child = stanza.tags[1].tags[1];
-                               if not child then
-                                       origin.send(st.error_reply(stanza, "modify", "bad-request"));
-                               elseif child.name == "destroy" then
-                                       local newjid = child.attr.jid;
-                                       local reason, password;
-                                       for _,tag in ipairs(child.tags) do
-                                               if tag.name == "reason" then
-                                                       reason = #tag.tags == 0 and tag[1];
-                                               elseif tag.name == "password" then
-                                                       password = #tag.tags == 0 and tag[1];
-                                               end
-                                       end
-                                       self:destroy(newjid, reason, password);
-                                       origin.send(st.reply(stanza));
-                               else
-                                       self:process_form(origin, stanza);
-                               end
+function room_mt:handle_admin_query_get_command(origin, stanza)
+       local actor = stanza.attr.from;
+       local affiliation = self:get_affiliation(actor);
+       local item = stanza.tags[1].tags[1];
+       local _aff = item.attr.affiliation;
+       local _aff_rank = valid_affiliations[_aff or "none"];
+       local _rol = item.attr.role;
+       if _aff and _aff_rank and not _rol then
+               -- You need to be at least an admin, and be requesting info about your affifiliation or lower
+               -- e.g. an admin can't ask for a list of owners
+               local affiliation_rank = valid_affiliations[affiliation or "none"];
+               if affiliation_rank >= valid_affiliations.admin and affiliation_rank >= _aff_rank then
+                       local reply = st.reply(stanza):query("http://jabber.org/protocol/muc#admin");
+                       for jid in self:each_affiliation(_aff or "none") do
+                               reply:tag("item", {affiliation = _aff, jid = jid}):up();
                        end
-               elseif type == "set" or type == "get" then
-                       origin.send(st.error_reply(stanza, "cancel", "service-unavailable"));
-               end
-       elseif stanza.name == "message" and type == "groupchat" then
-               local from = stanza.attr.from;
-               local current_nick = self._jid_nick[from];
-               local occupant = self._occupants[current_nick];
-               if not occupant then -- not in room
-                       origin.send(st.error_reply(stanza, "cancel", "not-acceptable"));
-               elseif occupant.role == "visitor" then
-                       origin.send(st.error_reply(stanza, "auth", "forbidden"));
+                       origin.send(reply:up());
+                       return true;
                else
-                       local from = stanza.attr.from;
-                       stanza.attr.from = current_nick;
-                       local subject = stanza:get_child_text("subject");
-                       if subject then
-                               if occupant.role == "moderator" or
-                                       ( self._data.changesubject and occupant.role == "participant" ) then -- and participant
-                                       self:set_subject(current_nick, subject);
-                               else
-                                       stanza.attr.from = from;
-                                       origin.send(st.error_reply(stanza, "auth", "forbidden"));
-                               end
-                       else
-                               self:broadcast_message(stanza, self:get_historylength() > 0 and stanza:get_child("body"));
-                       end
-                       stanza.attr.from = from;
-               end
-       elseif stanza.name == "message" and type == "error" and is_kickable_error(stanza) then
-               local current_nick = self._jid_nick[stanza.attr.from];
-               log("debug", "%s kicked from %s for sending an error message", current_nick, self.jid);
-               self:handle_to_occupant(origin, build_unavailable_presence_from_error(stanza)); -- send unavailable
-       elseif stanza.name == "presence" then -- hack - some buggy clients send presence updates to the room rather than their nick
-               local to = stanza.attr.to;
-               local current_nick = self._jid_nick[stanza.attr.from];
-               if current_nick then
-                       stanza.attr.to = current_nick;
-                       self:handle_to_occupant(origin, stanza);
-                       stanza.attr.to = to;
-               elseif type ~= "error" and type ~= "result" then
-                       origin.send(st.error_reply(stanza, "cancel", "service-unavailable"));
+                       origin.send(st.error_reply(stanza, "auth", "forbidden"));
+                       return true;
                end
-       elseif stanza.name == "message" and not(type == "chat" or type == "error" or type == "groupchat" or type == "headline") and #stanza.tags == 1
-               and self._jid_nick[stanza.attr.from] and stanza.tags[1].name == "x" and stanza.tags[1].attr.xmlns == "http://jabber.org/protocol/muc#user" then
-               local x = stanza.tags[1];
-               local payload = (#x.tags == 1 and x.tags[1]);
-               if payload and payload.name == "invite" and payload.attr.to then
-                       local _from, _to = stanza.attr.from, stanza.attr.to;
-                       local _invitee = jid_prep(payload.attr.to);
-                       if _invitee then
-                               local _reason = payload.tags[1] and payload.tags[1].name == 'reason' and #payload.tags[1].tags == 0 and payload.tags[1][1];
-                               local invite = st.message({from = _to, to = _invitee, id = stanza.attr.id})
-                                       :tag('x', {xmlns='http://jabber.org/protocol/muc#user'})
-                                               :tag('invite', {from=_from})
-                                                       :tag('reason'):text(_reason or ""):up()
-                                               :up();
-                                               if self:get_password() then
-                                                       invite:tag("password"):text(self:get_password()):up();
-                                               end
-                                       invite:up()
-                                       :tag('x', {xmlns="jabber:x:conference", jid=_to}) -- COMPAT: Some older clients expect this
-                                               :text(_reason or "")
-                                       :up()
-                                       :tag('body') -- Add a plain message for clients which don't support invites
-                                               :text(_from..' invited you to the room '.._to..(_reason and (' ('.._reason..')') or ""))
-                                       :up();
-                               if self:get_members_only() and not self:get_affiliation(_invitee) then
-                                       log("debug", "%s invited %s into members only room %s, granting membership", _from, _invitee, _to);
-                                       self:set_affiliation(_from, _invitee, "member", nil, "Invited by " .. self._jid_nick[_from])
+       elseif _rol and valid_roles[_rol or "none"] and not _aff then
+               local role = self:get_role(self:get_occupant_jid(actor)) or self:get_default_role(affiliation);
+               if valid_roles[role or "none"] >= valid_roles.moderator then
+                       if _rol == "none" then _rol = nil; end
+                       local reply = st.reply(stanza):query("http://jabber.org/protocol/muc#admin");
+                       -- TODO: whois check here? (though fully anonymous rooms are not supported)
+                       for occupant_jid, occupant in self:each_occupant() do
+                               if occupant.role == _rol then
+                                       local nick = select(3,jid_split(occupant_jid));
+                                       self:build_item_list(occupant, reply, false, nick);
                                end
-                               self:_route_stanza(invite);
-                       else
-                               origin.send(st.error_reply(stanza, "cancel", "jid-malformed"));
                        end
+                       origin.send(reply:up());
+                       return true;
                else
-                       origin.send(st.error_reply(stanza, "cancel", "bad-request"));
+                       origin.send(st.error_reply(stanza, "auth", "forbidden"));
+                       return true;
                end
        else
-               if type == "error" or type == "result" then return; end
-               origin.send(st.error_reply(stanza, "cancel", "service-unavailable"));
+               origin.send(st.error_reply(stanza, "cancel", "bad-request"));
+               return true;
        end
 end
 
-function room_mt:handle_stanza(origin, stanza)
-       local to_node, to_host, to_resource = jid_split(stanza.attr.to);
-       if to_resource then
-               self:handle_to_occupant(origin, stanza);
+function room_mt:handle_owner_query_get_to_room(origin, stanza)
+       if self:get_affiliation(stanza.attr.from) ~= "owner" then
+               origin.send(st.error_reply(stanza, "auth", "forbidden", "Only owners can configure rooms"));
+               return true;
+       end
+
+       self:send_form(origin, stanza);
+       return true;
+end
+function room_mt:handle_owner_query_set_to_room(origin, stanza)
+       if self:get_affiliation(stanza.attr.from) ~= "owner" then
+               origin.send(st.error_reply(stanza, "auth", "forbidden", "Only owners can configure rooms"));
+               return true;
+       end
+
+       local child = stanza.tags[1].tags[1];
+       if not child then
+               origin.send(st.error_reply(stanza, "modify", "bad-request"));
+               return true;
+       elseif child.name == "destroy" then
+               local newjid = child.attr.jid;
+               local reason = child:get_child_text("reason");
+               local password = child:get_child_text("password");
+               self:destroy(newjid, reason, password);
+               origin.send(st.reply(stanza));
+               return true;
+       elseif child.name == "x" and child.attr.xmlns == "jabber:x:data" then
+               return self:process_form(origin, stanza);
        else
-               self:handle_to_room(origin, stanza);
+               origin.send(st.error_reply(stanza, "cancel", "service-unavailable"));
+               return true;
+       end
+end
+
+function room_mt:handle_groupchat_to_room(origin, stanza)
+       local from = stanza.attr.from;
+       local occupant = self:get_occupant_by_real_jid(from);
+       if module:fire_event("muc-occupant-groupchat", {
+               room = self; origin = origin; stanza = stanza; from = from; occupant = occupant;
+       }) then return true; end
+       stanza.attr.from = occupant.nick;
+       self:broadcast_message(stanza);
+       stanza.attr.from = from;
+       return true;
+end
+
+-- Role check
+module:hook("muc-occupant-groupchat", function(event)
+       local role_rank = valid_roles[event.occupant and event.occupant.role or "none"];
+       if role_rank <= valid_roles.none then
+               event.origin.send(st.error_reply(event.stanza, "cancel", "not-acceptable"));
+               return true;
+       elseif role_rank <= valid_roles.visitor then
+               event.origin.send(st.error_reply(event.stanza, "auth", "forbidden"));
+               return true;
+       end
+end, 50);
+
+-- hack - some buggy clients send presence updates to the room rather than their nick
+function room_mt:handle_presence_to_room(origin, stanza)
+       local current_nick = self:get_occupant_jid(stanza.attr.from);
+       local handled
+       if current_nick then
+               local to = stanza.attr.to;
+               stanza.attr.to = current_nick;
+               handled = self:handle_presence_to_occupant(origin, stanza);
+               stanza.attr.to = to;
+       end
+       return handled;
+end
+
+-- Need visitor role or higher to invite
+module:hook("muc-pre-invite", function(event)
+       local room, stanza = event.room, event.stanza;
+       local _from = stanza.attr.from;
+       local inviter = room:get_occupant_by_real_jid(_from);
+       local role = inviter and inviter.role or room:get_default_role(room:get_affiliation(_from));
+       if valid_roles[role or "none"] <= valid_roles.visitor then
+               event.origin.send(st.error_reply(stanza, "auth", "forbidden"));
+               return true;
+       end
+end);
+
+function room_mt:handle_mediated_invite(origin, stanza)
+       local payload = stanza:get_child("x", "http://jabber.org/protocol/muc#user"):get_child("invite");
+       local invitee = jid_prep(payload.attr.to);
+       if not invitee then
+               origin.send(st.error_reply(stanza, "cancel", "jid-malformed"));
+               return true;
+       elseif module:fire_event("muc-pre-invite", {room = self, origin = origin, stanza = stanza}) then
+               return true;
+       end
+       local invite = muc_util.filter_muc_x(st.clone(stanza));
+       invite.attr.from = self.jid;
+       invite.attr.to = invitee;
+       invite:tag('x', {xmlns='http://jabber.org/protocol/muc#user'})
+                       :tag('invite', {from = stanza.attr.from;})
+                               :tag('reason'):text(payload:get_child_text("reason")):up()
+                       :up()
+               :up();
+       if not module:fire_event("muc-invite", {room = self, stanza = invite, origin = origin, incoming = stanza}) then
+               self:route_stanza(invite);
+       end
+       return true;
+end
+
+-- COMPAT: Some older clients expect this
+module:hook("muc-invite", function(event)
+       local room, stanza = event.room, event.stanza;
+       local invite = stanza:get_child("x", "http://jabber.org/protocol/muc#user"):get_child("invite");
+       local reason = invite:get_child_text("reason");
+       stanza:tag('x', {xmlns = "jabber:x:conference"; jid = room.jid;})
+               :text(reason or "")
+       :up();
+end);
+
+-- Add a plain message for clients which don't support invites
+module:hook("muc-invite", function(event)
+       local room, stanza = event.room, event.stanza;
+       if not stanza:get_child("body") then
+               local invite = stanza:get_child("x", "http://jabber.org/protocol/muc#user"):get_child("invite");
+               local reason = invite:get_child_text("reason") or "";
+               stanza:tag("body")
+                       :text(invite.attr.from.." invited you to the room "..room.jid..(reason == "" and (" ("..reason..")") or ""))
+               :up();
+       end
+end);
+
+function room_mt:handle_mediated_decline(origin, stanza)
+       local payload = stanza:get_child("x", "http://jabber.org/protocol/muc#user"):get_child("decline");
+       local declinee = jid_prep(payload.attr.to);
+       if not declinee then
+               origin.send(st.error_reply(stanza, "cancel", "jid-malformed"));
+               return true;
+       elseif module:fire_event("muc-pre-decline", {room = self, origin = origin, stanza = stanza}) then
+               return true;
+       end
+       local decline = muc_util.filter_muc_x(st.clone(stanza));
+       decline.attr.from = self.jid;
+       decline.attr.to = declinee;
+       decline:tag("x", {xmlns = "http://jabber.org/protocol/muc#user"})
+                       :tag("decline", {from = stanza.attr.from})
+                               :tag("reason"):text(payload:get_child_text("reason")):up()
+                       :up()
+               :up();
+       if not module:fire_event("muc-decline", {room = self, stanza = decline, origin = origin, incoming = stanza}) then
+               declinee = decline.attr.to; -- re-fetch, in case event modified it
+               local occupant
+               if jid_bare(declinee) == self.jid then -- declinee jid is already an in-room jid
+                       occupant = self:get_occupant_by_nick(declinee);
+               end
+               if occupant then
+                       self:route_to_occupant(occupant, decline);
+               else
+                       self:route_stanza(decline);
+               end
+       end
+       return true;
+end
+
+-- Add a plain message for clients which don't support declines
+module:hook("muc-decline", function(event)
+       local room, stanza = event.room, event.stanza;
+       if not stanza:get_child("body") then
+               local decline = stanza:get_child("x", "http://jabber.org/protocol/muc#user"):get_child("decline");
+               local reason = decline:get_child_text("reason") or "";
+               stanza:tag("body")
+                       :text(decline.attr.from.." declined your invite to the room "..room.jid..(reason == "" and (" ("..reason..")") or ""))
+               :up();
+       end
+end);
+
+function room_mt:handle_message_to_room(origin, stanza)
+       local type = stanza.attr.type;
+       if type == "groupchat" then
+               return self:handle_groupchat_to_room(origin, stanza)
+       elseif type == "error" and is_kickable_error(stanza) then
+               return self:handle_kickable(origin, stanza)
+       elseif type == nil then
+               local x = stanza:get_child("x", "http://jabber.org/protocol/muc#user");
+               if x then
+                       local payload = x.tags[1];
+                       if payload == nil then --luacheck: ignore 542
+                               -- fallthrough
+                       elseif payload.name == "invite" and payload.attr.to then
+                               return self:handle_mediated_invite(origin, stanza)
+                       elseif payload.name == "decline" and payload.attr.to then
+                               return self:handle_mediated_decline(origin, stanza)
+                       end
+                       origin.send(st.error_reply(stanza, "cancel", "bad-request"));
+                       return true;
+               end
        end
 end
 
-function room_mt:route_stanza(stanza) end -- Replace with a routing function, e.g., function(room, stanza) core_route_stanza(origin, stanza); end
+function room_mt:route_stanza(stanza) -- luacheck: ignore 212
+       module:send(stanza);
+end
 
 function room_mt:get_affiliation(jid)
        local node, host, resource = jid_split(jid);
@@ -959,195 +1019,198 @@ function room_mt:get_affiliation(jid)
        if not result and self._affiliations[host] == "outcast" then result = "outcast"; end -- host banned
        return result;
 end
-function room_mt:set_affiliation(actor, jid, affiliation, callback, reason)
-       jid = jid_bare(jid);
-       if affiliation == "none" then affiliation = nil; end
-       if affiliation and affiliation ~= "outcast" and affiliation ~= "owner" and affiliation ~= "admin" and affiliation ~= "member" then
+
+-- Iterates over jid, affiliation pairs
+function room_mt:each_affiliation(with_affiliation)
+       if not with_affiliation then
+               return pairs(self._affiliations);
+       else
+               return function(_affiliations, jid)
+                       local affiliation;
+                       repeat -- Iterate until we get a match
+                               jid, affiliation = next(_affiliations, jid);
+                       until jid == nil or affiliation == with_affiliation
+                       return jid, affiliation;
+               end, self._affiliations, nil
+       end
+end
+
+function room_mt:set_affiliation(actor, jid, affiliation, reason)
+       if not actor then return nil, "modify", "not-acceptable"; end;
+
+       local node, host, resource = jid_split(jid);
+       if not host then return nil, "modify", "not-acceptable"; end
+       jid = jid_join(node, host); -- Bare
+       local is_host_only = node == nil;
+
+       if valid_affiliations[affiliation or "none"] == nil then
                return nil, "modify", "not-acceptable";
        end
-       if actor ~= true then
+       affiliation = affiliation ~= "none" and affiliation or nil; -- coerces `affiliation == false` to `nil`
+
+       local target_affiliation = self._affiliations[jid]; -- Raw; don't want to check against host
+       local is_downgrade = valid_affiliations[target_affiliation or "none"] > valid_affiliations[affiliation or "none"];
+
+       if actor == true then
+               actor = nil -- So we can pass it safely to 'publicise_occupant_status' below
+       else
                local actor_affiliation = self:get_affiliation(actor);
-               local target_affiliation = self:get_affiliation(jid);
-               if target_affiliation == affiliation then -- no change, shortcut
-                       if callback then callback(); end
-                       return true;
-               end
-               if actor_affiliation ~= "owner" then
-                       if affiliation == "owner" or affiliation == "admin" or actor_affiliation ~= "admin" or target_affiliation == "owner" or target_affiliation == "admin" then
-                               return nil, "cancel", "not-allowed";
-                       end
-               elseif target_affiliation == "owner" and jid_bare(actor) == jid then -- self change
-                       local is_last = true;
-                       for j, aff in pairs(self._affiliations) do if j ~= jid and aff == "owner" then is_last = false; break; end end
-                       if is_last then
-                               return nil, "cancel", "conflict";
+               if actor_affiliation == "owner" then
+                       if jid_bare(actor) == jid then -- self change
+                               -- need at least one owner
+                               local is_last = true;
+                               for j in self:each_affiliation("owner") do
+                                       if j ~= jid then is_last = false; break; end
+                               end
+                               if is_last then
+                                       return nil, "cancel", "conflict";
+                               end
                        end
+                       -- owners can do anything else
+               elseif affiliation == "owner" or affiliation == "admin"
+                       or actor_affiliation ~= "admin"
+                       or target_affiliation == "owner" or target_affiliation == "admin" then
+                       -- Can't demote owners or other admins
+                       return nil, "cancel", "not-allowed";
                end
        end
+
+       -- Set in 'database'
        self._affiliations[jid] = affiliation;
+
+       -- Update roles
        local role = self:get_default_role(affiliation);
-       local x = st.stanza("x", {xmlns = "http://jabber.org/protocol/muc#user"})
-                       :tag("item", {affiliation=affiliation or "none", role=role or "none"})
-                               :tag("reason"):text(reason or ""):up()
-                       :up();
-       local presence_type = nil;
+       local role_rank = valid_roles[role or "none"];
+       local occupants_updated = {}; -- Filled with old roles
+       for nick, occupant in self:each_occupant() do -- luacheck: ignore 213
+               if occupant.bare_jid == jid or (
+                       -- Outcast can be by host.
+                       is_host_only and affiliation == "outcast" and select(2, jid_split(occupant.bare_jid)) == host
+               ) then
+                       -- need to publcize in all cases; as affiliation in <item/> has changed.
+                       occupants_updated[occupant] = occupant.role;
+                       if occupant.role ~= role and (
+                               is_downgrade or
+                               valid_roles[occupant.role or "none"] < role_rank -- upgrade
+                       ) then
+                               occupant.role = role;
+                               self:save_occupant(occupant);
+                       end
+               end
+       end
+
+       -- Tell the room of the new occupant affiliations+roles
+       local x = st.stanza("x", {xmlns = "http://jabber.org/protocol/muc#user"});
        if not role then -- getting kicked
-               presence_type = "unavailable";
                if affiliation == "outcast" then
                        x:tag("status", {code="301"}):up(); -- banned
                else
                        x:tag("status", {code="321"}):up(); -- affiliation change
                end
        end
-       local modified_nicks = {};
-       for nick, occupant in pairs(self._occupants) do
-               if jid_bare(occupant.jid) == jid then
-                       if not role then -- getting kicked
-                               self._occupants[nick] = nil;
-                       else
-                               occupant.affiliation, occupant.role = affiliation, role;
-                       end
-                       for jid,pres in pairs(occupant.sessions) do -- remove for all sessions of the nick
-                               if not role then self._jid_nick[jid] = nil; end
-                               local p = st.clone(pres);
-                               p.attr.from = nick;
-                               p.attr.type = presence_type;
-                               p.attr.to = jid;
-                               p:add_child(x);
-                               self:_route_stanza(p);
-                               if occupant.jid == jid then
-                                       modified_nicks[nick] = p;
-                               end
+       local is_semi_anonymous = self:get_whois() == "moderators";
+       for occupant, old_role in pairs(occupants_updated) do
+               self:publicise_occupant_status(occupant, x, nil, actor, reason);
+               if occupant.role == nil then
+                       module:fire_event("muc-occupant-left", {room = self; nick = occupant.nick; occupant = occupant;});
+               elseif is_semi_anonymous and
+                       (old_role == "moderator" and occupant.role ~= "moderator") or
+                       (old_role ~= "moderator" and occupant.role == "moderator") then -- Has gained or lost moderator status
+                       -- Send everyone else's presences (as jid visibility has changed)
+                       for real_jid in occupant:each_session() do
+                               self:send_occupant_list(real_jid, function(occupant_jid, occupant) --luacheck: ignore 212 433
+                                       return occupant.bare_jid ~= jid;
+                               end);
                        end
                end
        end
+
        if self.save then self:save(); end
-       if callback then callback(); end
-       for nick,p in pairs(modified_nicks) do
-               p.attr.from = nick;
-               self:broadcast_except_nick(p, nick);
-       end
+
+       module:fire_event("muc-set-affiliation", {
+               room = self;
+               actor = actor;
+               jid = jid;
+               affiliation = affiliation or "none";
+               reason = reason;
+               previous_affiliation = target_affiliation;
+               in_room = next(occupants_updated) ~= nil;
+       });
+
        return true;
 end
 
 function room_mt:get_role(nick)
-       local session = self._occupants[nick];
-       return session and session.role or nil;
+       local occupant = self:get_occupant_by_nick(nick);
+       return occupant and occupant.role or nil;
 end
-function room_mt:can_set_role(actor_jid, occupant_jid, role)
-       local occupant = self._occupants[occupant_jid];
-       if not occupant or not actor_jid then return nil, "modify", "not-acceptable"; end
 
-       if actor_jid == true then return true; end
+function room_mt:set_role(actor, occupant_jid, role, reason)
+       if not actor then return nil, "modify", "not-acceptable"; end
 
-       local actor = self._occupants[self._jid_nick[actor_jid]];
-       if actor and actor.role == "moderator" then
-               if occupant.affiliation ~= "owner" and occupant.affiliation ~= "admin" then
-                       if actor.affiliation == "owner" or actor.affiliation == "admin" then
-                               return true;
-                       elseif occupant.role ~= "moderator" and role ~= "moderator" then
-                               return true;
-                       end
-               end
+       local occupant = self:get_occupant_by_nick(occupant_jid);
+       if not occupant then return nil, "modify", "not-acceptable"; end
+
+       if valid_roles[role or "none"] == nil then
+               return nil, "modify", "not-acceptable";
        end
-       return nil, "cancel", "not-allowed";
-end
-function room_mt:set_role(actor, occupant_jid, role, callback, reason)
-       if role == "none" then role = nil; end
-       if role and role ~= "moderator" and role ~= "participant" and role ~= "visitor" then return nil, "modify", "not-acceptable"; end
-       local allowed, err_type, err_condition = self:can_set_role(actor, occupant_jid, role);
-       if not allowed then return allowed, err_type, err_condition; end
-       local occupant = self._occupants[occupant_jid];
-       local x = st.stanza("x", {xmlns = "http://jabber.org/protocol/muc#user"})
-                       :tag("item", {affiliation=occupant.affiliation or "none", nick=select(3, jid_split(occupant_jid)), role=role or "none"})
-                               :tag("reason"):text(reason or ""):up()
-                       :up();
-       local presence_type = nil;
-       if not role then -- kick
-               presence_type = "unavailable";
-               self._occupants[occupant_jid] = nil;
-               for jid in pairs(occupant.sessions) do -- remove for all sessions of the nick
-                       self._jid_nick[jid] = nil;
-               end
-               x:tag("status", {code = "307"}):up();
+       role = role ~= "none" and role or nil; -- coerces `role == false` to `nil`
+
+       if actor == true then
+               actor = nil -- So we can pass it safely to 'publicise_occupant_status' below
        else
-               occupant.role = role;
-       end
-       local bp;
-       for jid,pres in pairs(occupant.sessions) do -- send to all sessions of the nick
-               local p = st.clone(pres);
-               p.attr.from = occupant_jid;
-               p.attr.type = presence_type;
-               p.attr.to = jid;
-               p:add_child(x);
-               self:_route_stanza(p);
-               if occupant.jid == jid then
-                       bp = p;
+               -- Can't do anything to other owners or admins
+               local occupant_affiliation = self:get_affiliation(occupant.bare_jid);
+               if occupant_affiliation == "owner" or occupant_affiliation == "admin" then
+                       return nil, "cancel", "not-allowed";
                end
-       end
-       if callback then callback(); end
-       if bp then
-               self:broadcast_except_nick(bp, occupant_jid);
-       end
-       return true;
-end
 
-function room_mt:_route_stanza(stanza)
-       local muc_child;
-       local to_occupant = self._occupants[self._jid_nick[stanza.attr.to]];
-       local from_occupant = self._occupants[stanza.attr.from];
-       if stanza.name == "presence" then
-               if to_occupant and from_occupant then
-                       if self._data.whois == 'anyone' then
-                           muc_child = stanza:get_child("x", "http://jabber.org/protocol/muc#user");
-                       else
-                               if to_occupant.role == "moderator" or jid_bare(to_occupant.jid) == jid_bare(from_occupant.jid) then
-                                       muc_child = stanza:get_child("x", "http://jabber.org/protocol/muc#user");
-                               end
+               -- If you are trying to give or take moderator role you need to be an owner or admin
+               if occupant.role == "moderator" or role == "moderator" then
+                       local actor_affiliation = self:get_affiliation(actor);
+                       if actor_affiliation ~= "owner" and actor_affiliation ~= "admin" then
+                               return nil, "cancel", "not-allowed";
                        end
                end
-       end
-       if muc_child then
-               for _, item in pairs(muc_child.tags) do
-                       if item.name == "item" then
-                               if from_occupant == to_occupant then
-                                       item.attr.jid = stanza.attr.to;
-                               else
-                                       item.attr.jid = from_occupant.jid;
-                               end
-                       end
+
+               -- Need to be in the room and a moderator
+               local actor_occupant = self:get_occupant_by_real_jid(actor);
+               if not actor_occupant or actor_occupant.role ~= "moderator" then
+                       return nil, "cancel", "not-allowed";
                end
        end
-       self:route_stanza(stanza);
-       if muc_child then
-               for _, item in pairs(muc_child.tags) do
-                       if item.name == "item" then
-                               item.attr.jid = nil;
-                       end
-               end
+
+       local x = st.stanza("x", {xmlns = "http://jabber.org/protocol/muc#user"});
+       if not role then
+               x:tag("status", {code = "307"}):up();
        end
+       occupant.role = role;
+       self:save_occupant(occupant);
+       self:publicise_occupant_status(occupant, x, nil, actor, reason);
+       if role == nil then
+               module:fire_event("muc-occupant-left", {room = self; nick = occupant.nick; occupant = occupant;});
+       end
+       return true;
 end
 
+local whois = module:require "muc/whois";
+room_mt.get_whois = whois.get;
+room_mt.set_whois = whois.set;
+
 local _M = {}; -- module "muc"
 
-function _M.new_room(jid, config)
+function _M.new_room(jid, config) -- luacheck: ignore 212
+       -- TODO use config?
        return setmetatable({
                jid = jid;
                _jid_nick = {};
                _occupants = {};
                _data = {
-                   whois = 'moderators';
-                   history_length = math.min((config and config.history_length)
-                       or default_history_length, max_history_length);
                };
                _affiliations = {};
        }, room_mt);
 end
 
-function _M.set_max_history_length(_max_history_length)
-       max_history_length = _max_history_length or math.huge;
-end
-
 _M.room_mt = room_mt;
 
 return _M;
diff --git a/plugins/muc/name.lib.lua b/plugins/muc/name.lib.lua
new file mode 100644 (file)
index 0000000..d9bfc4c
--- /dev/null
@@ -0,0 +1,46 @@
+-- Prosody IM
+-- Copyright (C) 2008-2010 Matthew Wild
+-- Copyright (C) 2008-2010 Waqas Hussain
+-- Copyright (C) 2014 Daurnimator
+--
+-- This project is MIT/X11 licensed. Please see the
+-- COPYING file in the source package for more information.
+--
+
+local jid_split = require "util.jid".split;
+
+local function get_name(room)
+       return room._data.name or jid_split(room.jid);
+end
+
+local function set_name(room, name)
+       if name == "" or name == (jid_split(room.jid)) then name = nil; end
+       if room._data.name == name then return false; end
+       room._data.name = name;
+       if room.save then room:save(true); end
+       return true;
+end
+
+module:hook("muc-disco#info", function(event)
+       event.reply:tag("identity", {category="conference", type="text", name=get_name(event.room)}):up();
+end);
+
+module:hook("muc-config-form", function(event)
+       table.insert(event.form, {
+               name = "muc#roomconfig_roomname";
+               type = "text-single";
+               label = "Name";
+               value = get_name(event.room) or "";
+       });
+end);
+
+module:hook("muc-config-submitted/muc#roomconfig_roomname", function(event)
+       if set_name(event.room, event.value) then
+               event.status_codes["104"] = true;
+       end
+end);
+
+return {
+       get = get_name;
+       set = set_name;
+};
diff --git a/plugins/muc/occupant.lib.lua b/plugins/muc/occupant.lib.lua
new file mode 100644 (file)
index 0000000..8fe4bbd
--- /dev/null
@@ -0,0 +1,85 @@
+local pairs = pairs;
+local setmetatable = setmetatable;
+local st = require "util.stanza";
+local util = module:require "muc/util";
+
+local function get_filtered_presence(stanza)
+       return util.filter_muc_x(st.clone(stanza));
+end
+
+local occupant_mt = {};
+occupant_mt.__index = occupant_mt;
+
+local function new_occupant(bare_real_jid, nick)
+       return setmetatable({
+               bare_jid = bare_real_jid;
+               nick = nick; -- in-room jid
+               sessions = {}; -- hash from real_jid to presence stanzas. stanzas should not be modified
+               role = nil;
+               jid = nil; -- Primary session
+       }, occupant_mt);
+end
+
+-- Deep copy an occupant
+local function copy_occupant(occupant)
+       local sessions = {};
+       for full_jid, presence_stanza in pairs(occupant.sessions) do
+               -- Don't keep unavailable presences, as they'll accumulate; unless they're the primary session
+               if presence_stanza.attr.type ~= "unavailable" or full_jid == occupant.jid then
+                       sessions[full_jid] = presence_stanza;
+               end
+       end
+       return setmetatable({
+               bare_jid = occupant.bare_jid;
+               nick = occupant.nick;
+               sessions = sessions;
+               role = occupant.role;
+               jid = occupant.jid;
+       }, occupant_mt);
+end
+
+-- finds another session to be the primary (there might not be one)
+function occupant_mt:choose_new_primary()
+       for jid, pr in self:each_session() do
+               if pr.attr.type == nil then
+                       return jid;
+               end
+       end
+       return nil;
+end
+
+function occupant_mt:set_session(real_jid, presence_stanza, replace_primary)
+       local pr = get_filtered_presence(presence_stanza);
+       pr.attr.from = self.nick;
+       pr.attr.to = real_jid;
+
+       self.sessions[real_jid] = pr;
+       if replace_primary then
+               self.jid = real_jid;
+       elseif self.jid == nil or (pr.attr.type == "unavailable" and self.jid == real_jid) then
+               -- Only leave an unavailable presence as primary when there are no other options
+               self.jid = self:choose_new_primary() or real_jid;
+       end
+end
+
+function occupant_mt:remove_session(real_jid)
+       -- Delete original session
+       self.sessions[real_jid] = nil;
+       if self.jid == real_jid then
+               self.jid = self:choose_new_primary();
+       end
+end
+
+function occupant_mt:each_session()
+       return pairs(self.sessions)
+end
+
+function occupant_mt:get_presence(real_jid)
+       return self.sessions[real_jid or self.jid]
+end
+
+return {
+       new = new_occupant;
+       copy = copy_occupant;
+       mt = occupant_mt;
+}
diff --git a/plugins/muc/password.lib.lua b/plugins/muc/password.lib.lua
new file mode 100644 (file)
index 0000000..8c33aa9
--- /dev/null
@@ -0,0 +1,71 @@
+-- Prosody IM
+-- Copyright (C) 2008-2010 Matthew Wild
+-- Copyright (C) 2008-2010 Waqas Hussain
+-- Copyright (C) 2014 Daurnimator
+--
+-- This project is MIT/X11 licensed. Please see the
+-- COPYING file in the source package for more information.
+--
+
+local st = require "util.stanza";
+
+local function get_password(room)
+       return room._data.password;
+end
+
+local function set_password(room, password)
+       if password == "" then password = nil; end
+       if room._data.password == password then return false; end
+       room._data.password = password;
+       if room.save then room:save(true); end
+       return true;
+end
+
+module:hook("muc-disco#info", function(event)
+       event.reply:tag("feature", {var = get_password(event.room) and "muc_passwordprotected" or "muc_unsecured"}):up();
+end);
+
+module:hook("muc-config-form", function(event)
+       table.insert(event.form, {
+               name = "muc#roomconfig_roomsecret";
+               type = "text-private";
+               label = "Password";
+               value = get_password(event.room) or "";
+       });
+end);
+
+module:hook("muc-config-submitted/muc#roomconfig_roomsecret", function(event)
+       if set_password(event.room, event.value) then
+               event.status_codes["104"] = true;
+       end
+end);
+
+-- Don't allow anyone to join room unless they provide the password
+module:hook("muc-occupant-pre-join", function(event)
+       local room, stanza = event.room, event.stanza;
+       local password = stanza:get_child("x", "http://jabber.org/protocol/muc");
+       password = password and password:get_child_text("password", "http://jabber.org/protocol/muc");
+       if not password or password == "" then password = nil; end
+       if get_password(room) ~= password then
+               local from, to = stanza.attr.from, stanza.attr.to;
+               module:log("debug", "%s couldn't join due to invalid password: %s", from, to);
+               local reply = st.error_reply(stanza, "auth", "not-authorized"):up();
+               reply.tags[1].attr.code = "401";
+               event.origin.send(reply:tag("x", {xmlns = "http://jabber.org/protocol/muc"}));
+               return true;
+       end
+end, -20);
+
+-- Add password to outgoing invite
+module:hook("muc-invite", function(event)
+       local password = get_password(event.room);
+       if password then
+               local x = event.stanza:get_child("x", "http://jabber.org/protocol/muc#user");
+               x:tag("password"):text(password):up();
+       end
+end);
+
+return {
+       get = get_password;
+       set = set_password;
+};
diff --git a/plugins/muc/persistent.lib.lua b/plugins/muc/persistent.lib.lua
new file mode 100644 (file)
index 0000000..a72bcbb
--- /dev/null
@@ -0,0 +1,48 @@
+-- Prosody IM
+-- Copyright (C) 2008-2010 Matthew Wild
+-- Copyright (C) 2008-2010 Waqas Hussain
+-- Copyright (C) 2014 Daurnimator
+--
+-- This project is MIT/X11 licensed. Please see the
+-- COPYING file in the source package for more information.
+--
+
+local function get_persistent(room)
+       return room._data.persistent;
+end
+
+local function set_persistent(room, persistent)
+       persistent = persistent and true or nil;
+       if get_persistent(room) == persistent then return false; end
+       room._data.persistent = persistent;
+       if room.save then room:save(true); end
+       return true;
+end
+
+module:hook("muc-config-form", function(event)
+       table.insert(event.form, {
+               name = "muc#roomconfig_persistentroom";
+               type = "boolean";
+               label = "Make Room Persistent?";
+               value = get_persistent(event.room);
+       });
+end);
+
+module:hook("muc-config-submitted/muc#roomconfig_persistentroom", function(event)
+       if set_persistent(event.room, event.value) then
+               event.status_codes["104"] = true;
+       end
+end);
+
+module:hook("muc-disco#info", function(event)
+       event.reply:tag("feature", {var = get_persistent(event.room) and "muc_persistent" or "muc_temporary"}):up();
+end);
+
+module:hook("muc-room-destroyed", function(event)
+       set_persistent(event.room, false);
+end);
+
+return {
+       get = get_persistent;
+       set = set_persistent;
+};
diff --git a/plugins/muc/subject.lib.lua b/plugins/muc/subject.lib.lua
new file mode 100644 (file)
index 0000000..0b4e6fd
--- /dev/null
@@ -0,0 +1,101 @@
+-- Prosody IM
+-- Copyright (C) 2008-2010 Matthew Wild
+-- Copyright (C) 2008-2010 Waqas Hussain
+-- Copyright (C) 2014 Daurnimator
+--
+-- This project is MIT/X11 licensed. Please see the
+-- COPYING file in the source package for more information.
+--
+
+local st = require "util.stanza";
+
+local muc_util = module:require "muc/util";
+local valid_roles = muc_util.valid_roles;
+
+local function create_subject_message(from, subject)
+       return st.message({from = from; type = "groupchat"})
+               :tag("subject"):text(subject):up();
+end
+
+local function get_changesubject(room)
+       return room._data.changesubject;
+end
+
+local function set_changesubject(room, changesubject)
+       changesubject = changesubject and true or nil;
+       if get_changesubject(room) == changesubject then return false; end
+       room._data.changesubject = changesubject;
+       if room.save then room:save(true); end
+       return true;
+end
+
+module:hook("muc-config-form", function(event)
+       table.insert(event.form, {
+               name = "muc#roomconfig_changesubject";
+               type = "boolean";
+               label = "Allow Occupants to Change Subject?";
+               value = get_changesubject(event.room);
+       });
+end);
+
+module:hook("muc-config-submitted/muc#roomconfig_changesubject", function(event)
+       if set_changesubject(event.room, event.value) then
+               event.status_codes["104"] = true;
+       end
+end);
+
+local function get_subject(room)
+       -- a <message/> stanza from the room JID (or from the occupant JID of the entity that set the subject)
+       return room._data.subject_from or room.jid, room._data.subject;
+end
+
+local function send_subject(room, to)
+       local msg = create_subject_message(get_subject(room));
+       msg.attr.to = to;
+       room:route_stanza(msg);
+end
+
+local function set_subject(room, from, subject)
+       if subject == "" then subject = nil; end
+       local old_from, old_subject = get_subject(room);
+       if old_subject == subject and old_from == from then return false; end
+       room._data.subject_from = from;
+       room._data.subject = subject;
+       if room.save then room:save(); end
+       local msg = create_subject_message(from, subject);
+       room:broadcast_message(msg);
+       return true;
+end
+
+-- Send subject to joining user
+module:hook("muc-occupant-session-new", function(event)
+       send_subject(event.room, event.stanza.attr.from);
+end, 20);
+
+-- Prosody has made the decision that messages with <subject/> are exclusively subject changes
+-- e.g. body will be ignored; even if the subject change was not allowed
+module:hook("muc-occupant-groupchat", function(event)
+       local stanza = event.stanza;
+       local subject = stanza:get_child("subject");
+       if subject then
+               local occupant = event.occupant;
+               -- Role check for subject changes
+               local role_rank = valid_roles[occupant and occupant.role or "none"];
+               if role_rank >= valid_roles.moderator or
+                       ( role_rank >= valid_roles.participant and get_changesubject(event.room) ) then -- and participant
+                       set_subject(event.room, occupant.nick, subject:get_text());
+                       return true;
+               else
+                       event.origin.send(st.error_reply(stanza, "auth", "forbidden"));
+                       return true;
+               end
+       end
+end, 20);
+
+return {
+       get_changesubject = get_changesubject;
+       set_changesubject = set_changesubject;
+       get = get_subject;
+       set = set_subject;
+       send = send_subject;
+};
diff --git a/plugins/muc/util.lib.lua b/plugins/muc/util.lib.lua
new file mode 100644 (file)
index 0000000..16deb54
--- /dev/null
@@ -0,0 +1,58 @@
+-- Prosody IM
+-- Copyright (C) 2008-2010 Matthew Wild
+-- Copyright (C) 2008-2010 Waqas Hussain
+-- Copyright (C) 2014 Daurnimator
+--
+-- This project is MIT/X11 licensed. Please see the
+-- COPYING file in the source package for more information.
+--
+
+local _M = {};
+
+_M.valid_affiliations = {
+       outcast = -1;
+       none = 0;
+       member = 1;
+       admin = 2;
+       owner = 3;
+};
+
+_M.valid_roles = {
+       none = 0;
+       visitor = 1;
+       participant = 2;
+       moderator = 3;
+};
+
+local kickable_error_conditions = {
+       ["gone"] = true;
+       ["internal-server-error"] = true;
+       ["item-not-found"] = true;
+       ["jid-malformed"] = true;
+       ["recipient-unavailable"] = true;
+       ["redirect"] = true;
+       ["remote-server-not-found"] = true;
+       ["remote-server-timeout"] = true;
+       ["service-unavailable"] = true;
+       ["malformed error"] = true;
+};
+function _M.is_kickable_error(stanza)
+       local cond = select(2, stanza:get_error()) or "malformed error";
+       return kickable_error_conditions[cond];
+end
+
+local muc_x_filters = {
+       ["http://jabber.org/protocol/muc"] = true;
+       ["http://jabber.org/protocol/muc#user"] = true;
+}
+local function muc_x_filter(tag)
+       if muc_x_filters[tag.attr.xmlns] then
+               return nil;
+       end
+       return tag;
+end
+function _M.filter_muc_x(stanza)
+       return stanza:maptags(muc_x_filter);
+end
+
+return _M;
diff --git a/plugins/muc/whois.lib.lua b/plugins/muc/whois.lib.lua
new file mode 100644 (file)
index 0000000..2f492c4
--- /dev/null
@@ -0,0 +1,66 @@
+-- Prosody IM
+-- Copyright (C) 2008-2010 Matthew Wild
+-- Copyright (C) 2008-2010 Waqas Hussain
+-- Copyright (C) 2014 Daurnimator
+--
+-- This project is MIT/X11 licensed. Please see the
+-- COPYING file in the source package for more information.
+--
+
+local valid_whois = {
+       moderators = true;
+       anyone = true;
+};
+
+local function get_whois(room)
+       return room._data.whois or "moderators";
+end
+
+local function set_whois(room, whois)
+       assert(valid_whois[whois], "Invalid whois value")
+       if get_whois(room) == whois then return false; end
+       room._data.whois = whois;
+       if room.save then room:save(true); end
+       return true;
+end
+
+module:hook("muc-disco#info", function(event)
+       event.reply:tag("feature", {var = get_whois(event.room) ~= "anyone" and "muc_semianonymous" or "muc_nonanonymous"}):up();
+end);
+
+module:hook("muc-config-form", function(event)
+       local whois = get_whois(event.room);
+       table.insert(event.form, {
+               name = 'muc#roomconfig_whois',
+               type = 'list-single',
+               label = 'Who May Discover Real JIDs?',
+               value = {
+                       { value = 'moderators', label = 'Moderators Only', default = whois == 'moderators' },
+                       { value = 'anyone',     label = 'Anyone',          default = whois == 'anyone' }
+               }
+       });
+end);
+
+module:hook("muc-config-submitted/muc#roomconfig_whois", function(event)
+       if set_whois(event.room, event.value) then
+               local code = (event.value == 'moderators') and "173" or "172";
+               event.status_codes[code] = true;
+       end
+end);
+
+-- Mask 'from' jid as occupant jid if room is anonymous
+module:hook("muc-invite", function(event)
+       local room, stanza = event.room, event.stanza;
+       if get_whois(room) == "moderators" and room:get_default_role(room:get_affiliation(stanza.attr.to)) ~= "moderator" then
+               local invite = stanza:get_child("x", "http://jabber.org/protocol/muc#user"):get_child("invite");
+               local occupant_jid = room:get_occupant_jid(invite.attr.from);
+               if occupant_jid ~= nil then -- FIXME: This will expose real jid if inviter is not in room
+                       invite.attr.from = occupant_jid;
+               end
+       end
+end, 50);
+
+return {
+       get = get_whois;
+       set = set_whois;
+};
index c8366faf9ae68193ccc98767f8ea68fd62a4f047..1fff7eed5a4f0d228c6fe5bc4704f3dd780f7626 100755 (executable)
@@ -365,8 +365,8 @@ function commands.deluser(arg)
        end
        local user, host = jid_split(arg[1]);
        if not user and host then
-               show_message [[Failed to understand JID, please supply the JID you want to set the password for]]
-               show_usage [[passwd user@host]]
+               show_message [[Failed to understand JID, please supply the JID to the user account you want to delete]]
+               show_usage [[deluser user@host]]
                return 1;
        end
        
index ba44da1956e1cbd377dd1d0a3c77e25d14718bd2..56d3f7b96bafc69bb69e9f7f57924bfcbd46902d 100644 (file)
@@ -9,4 +9,5 @@ function parse(parse)
 ]]
        local stanza = parse(x);
        assert_equal(stanza.tags[2].attr.xmlns, "b");
+       assert_equal(stanza.tags[2].namespaces["a"], "b");
 end
diff --git a/util/async.lua b/util/async.lua
new file mode 100644 (file)
index 0000000..968ec80
--- /dev/null
@@ -0,0 +1,158 @@
+local log = require "util.logger".init("util.async");
+
+local function runner_continue(thread)
+       -- ASSUMPTION: runner is in 'waiting' state (but we don't have the runner to know for sure)
+       if coroutine.status(thread) ~= "suspended" then -- This should suffice
+               return false;
+       end
+       local ok, state, runner = coroutine.resume(thread);
+       if not ok then
+               local level = 0;
+               while debug.getinfo(thread, level, "") do level = level + 1; end
+               ok, runner = debug.getlocal(thread, level-1, 1);
+               local error_handler = runner.watchers.error;
+               if error_handler then error_handler(runner, debug.traceback(thread, state)); end
+       elseif state == "ready" then
+               -- If state is 'ready', it is our responsibility to update runner.state from 'waiting'.
+               -- We also have to :run(), because the queue might have further items that will not be
+               -- processed otherwise. FIXME: It's probably best to do this in a nexttick (0 timer).
+               runner.state = "ready";
+               runner:run();
+       end
+       return true;
+end
+
+local function waiter(num)
+       local thread = coroutine.running();
+       if not thread then
+               error("Not running in an async context, see http://prosody.im/doc/developers/async");
+       end
+       num = num or 1;
+       local waiting;
+       return function ()
+               if num == 0 then return; end -- already done
+               waiting = true;
+               coroutine.yield("wait");
+       end, function ()
+               num = num - 1;
+               if num == 0 and waiting then
+                       runner_continue(thread);
+               elseif num < 0 then
+                       error("done() called too many times");
+               end
+       end;
+end
+
+local function guarder()
+       local guards = {};
+       return function (id, func)
+               local thread = coroutine.running();
+               if not thread then
+                       error("Not running in an async context, see http://prosody.im/doc/developers/async");
+               end
+               local guard = guards[id];
+               if not guard then
+                       guard = {};
+                       guards[id] = guard;
+                       log("debug", "New guard!");
+               else
+                       table.insert(guard, thread);
+                       log("debug", "Guarded. %d threads waiting.", #guard)
+                       coroutine.yield("wait");
+               end
+               local function exit()
+                       local next_waiting = table.remove(guard, 1);
+                       if next_waiting then
+                               log("debug", "guard: Executing next waiting thread (%d left)", #guard)
+                               runner_continue(next_waiting);
+                       else
+                               log("debug", "Guard off duty.")
+                               guards[id] = nil;
+                       end
+               end
+               if func then
+                       func();
+                       exit();
+                       return;
+               end
+               return exit;
+       end;
+end
+
+local runner_mt = {};
+runner_mt.__index = runner_mt;
+
+local function runner_create_thread(func, self)
+       local thread = coroutine.create(function (self)
+               while true do
+                       func(coroutine.yield("ready", self));
+               end
+       end);
+       assert(coroutine.resume(thread, self)); -- Start it up, it will return instantly to wait for the first input
+       return thread;
+end
+
+local empty_watchers = {};
+local function runner(func, watchers, data)
+       return setmetatable({ func = func, thread = false, state = "ready", notified_state = "ready",
+               queue = {}, watchers = watchers or empty_watchers, data = data }
+       , runner_mt);
+end
+
+function runner_mt:run(input)
+       if input ~= nil then
+               table.insert(self.queue, input);
+       end
+       if self.state ~= "ready" then
+               return true, self.state, #self.queue;
+       end
+
+       local q, thread = self.queue, self.thread;
+       if not thread or coroutine.status(thread) == "dead" then
+               thread = runner_create_thread(self.func, self);
+               self.thread = thread;
+       end
+
+       local n, state, err = #q, self.state, nil;
+       self.state = "running";
+       while n > 0 and state == "ready" do
+               local consumed;
+               for i = 1,n do
+                       local input = q[i];
+                       local ok, new_state = coroutine.resume(thread, input);
+                       if not ok then
+                               consumed, state, err = i, "ready", debug.traceback(thread, new_state);
+                               self.thread = nil;
+                               break;
+                       elseif new_state == "wait" then
+                               consumed, state = i, "waiting";
+                               break;
+                       end
+               end
+               if not consumed then consumed = n; end
+               if q[n+1] ~= nil then
+                       n = #q;
+               end
+               for i = 1, n do
+                       q[i] = q[consumed+i];
+               end
+               n = #q;
+       end
+       self.state = state;
+       if err or state ~= self.notified_state then
+               if err then
+                       state = "error"
+               else
+                       self.notified_state = state;
+               end
+               local handler = self.watchers[state];
+               if handler then handler(self, err); end
+       end
+       return true, state, n;
+end
+
+function runner_mt:enqueue(input)
+       table.insert(self.queue, input);
+end
+
+return { waiter = waiter, guarder = guarder, runner = runner };
diff --git a/util/indexedbheap.lua b/util/indexedbheap.lua
new file mode 100644 (file)
index 0000000..c60861e
--- /dev/null
@@ -0,0 +1,157 @@
+
+local setmetatable = setmetatable;
+local math_floor = math.floor;
+local t_remove = table.remove;
+
+local function _heap_insert(self, item, sync, item2, index)
+       local pos = #self + 1;
+       while true do
+               local half_pos = math_floor(pos / 2);
+               if half_pos == 0 or item > self[half_pos] then break; end
+               self[pos] = self[half_pos];
+               sync[pos] = sync[half_pos];
+               index[sync[pos]] = pos;
+               pos = half_pos;
+       end
+       self[pos] = item;
+       sync[pos] = item2;
+       index[item2] = pos;
+end
+
+local function _percolate_up(self, k, sync, index)
+       local tmp = self[k];
+       local tmp_sync = sync[k];
+       while k ~= 1 do
+               local parent = math_floor(k/2);
+               if tmp < self[parent] then break; end
+               self[k] = self[parent];
+               sync[k] = sync[parent];
+               index[sync[k]] = k;
+               k = parent;
+       end
+       self[k] = tmp;
+       sync[k] = tmp_sync;
+       index[tmp_sync] = k;
+       return k;
+end
+
+local function _percolate_down(self, k, sync, index)
+       local tmp = self[k];
+       local tmp_sync = sync[k];
+       local size = #self;
+       local child = 2*k;
+       while 2*k <= size do
+               if child ~= size and self[child] > self[child + 1] then
+                       child = child + 1;
+               end
+               if tmp > self[child] then
+                       self[k] = self[child];
+                       sync[k] = sync[child];
+                       index[sync[k]] = k;
+               else
+                       break;
+               end
+
+               k = child;
+               child = 2*k;
+       end
+       self[k] = tmp;
+       sync[k] = tmp_sync;
+       index[tmp_sync] = k;
+       return k;
+end
+
+local function _heap_pop(self, sync, index)
+       local size = #self;
+       if size == 0 then return nil; end
+
+       local result = self[1];
+       local result_sync = sync[1];
+       index[result_sync] = nil;
+       if size == 1 then
+               self[1] = nil;
+               sync[1] = nil;
+               return result, result_sync;
+       end
+       self[1] = t_remove(self);
+       sync[1] = t_remove(sync);
+       index[sync[1]] = 1;
+
+       _percolate_down(self, 1, sync, index);
+
+       return result, result_sync;
+end
+
+local indexed_heap = {};
+
+function indexed_heap:insert(item, priority, id)
+       if id == nil then
+               id = self.current_id;
+               self.current_id = id + 1;
+       end
+       self.items[id] = item;
+       _heap_insert(self.priorities, priority, self.ids, id, self.index);
+       return id;
+end
+function indexed_heap:pop()
+       local priority, id = _heap_pop(self.priorities, self.ids, self.index);
+       if id then
+               local item = self.items[id];
+               self.items[id] = nil;
+               return priority, item, id;
+       end
+end
+function indexed_heap:peek()
+       return self.priorities[1];
+end
+function indexed_heap:reprioritize(id, priority)
+       local k = self.index[id];
+       if k == nil then return; end
+       self.priorities[k] = priority;
+
+       k = _percolate_up(self.priorities, k, self.ids, self.index);
+       k = _percolate_down(self.priorities, k, self.ids, self.index);
+end
+function indexed_heap:remove_index(k)
+       local result = self.priorities[k];
+       if result == nil then return; end
+
+       local result_sync = self.ids[k];
+       local item = self.items[result_sync];
+       local size = #self.priorities;
+
+       self.priorities[k] = self.priorities[size];
+       self.ids[k] = self.ids[size];
+       self.index[self.ids[k]] = k;
+
+       t_remove(self.priorities);
+       t_remove(self.ids);
+
+       self.index[result_sync] = nil;
+       self.items[result_sync] = nil;
+
+       if size > k then
+               k = _percolate_up(self.priorities, k, self.ids, self.index);
+               k = _percolate_down(self.priorities, k, self.ids, self.index);
+       end
+
+       return result, item, result_sync;
+end
+function indexed_heap:remove(id)
+       return self:remove_index(self.index[id]);
+end
+
+local mt = { __index = indexed_heap };
+
+local _M = {
+       create = function()
+               return setmetatable({
+                       ids = {}; -- heap of ids, sync'd with priorities
+                       items = {}; -- map id->items
+                       priorities = {}; -- heap of priorities
+                       index = {}; -- map of id->index of id in ids
+                       current_id = 1.5
+               }, mt);
+       end
+};
+return _M;
index 8bb9ba0545df6e8bc4d7a2eb7a1bf85526d6494b..a598a81ecd1e35c8f18688734194776c2adb5113 100644 (file)
@@ -40,8 +40,8 @@ local _ENV = nil;
 local stanza_mt = { __type = "stanza" };
 stanza_mt.__index = stanza_mt;
 
-local function new_stanza(name, attr)
-       local stanza = { name = name, attr = attr or {}, tags = {} };
+local function new_stanza(name, attr, namespaces)
+       local stanza = { name = name, attr = attr or {}, namespaces = namespaces, tags = {} };
        return setmetatable(stanza, stanza_mt);
 end
 
@@ -53,8 +53,8 @@ function stanza_mt:body(text, attr)
        return self:tag("body", attr):text(text);
 end
 
-function stanza_mt:tag(name, attrs)
-       local s = new_stanza(name, attrs);
+function stanza_mt:tag(name, attr, namespaces)
+       local s = new_stanza(name, attr, namespaces);
        local last_add = self.last_add;
        if not last_add then last_add = {}; self.last_add = last_add; end
        (last_add[#last_add] or self):add_direct_child(s);
@@ -332,7 +332,12 @@ end
 local function clone(stanza)
        local attr, tags = {}, {};
        for k,v in pairs(stanza.attr) do attr[k] = v; end
-       local new = { name = stanza.name, attr = attr, tags = tags };
+       local old_namespaces, namespaces = stanza.namespaces;
+       if old_namespaces then
+               namespaces = {};
+               for k,v in pairs(old_namespaces) do namespaces[k] = v; end
+       end
+       local new = { name = stanza.name, attr = attr, namespaces = namespaces, tags = tags };
        for i=1,#stanza do
                local child = stanza[i];
                if child.name then
index 3713625db3d6cbcb3d2c78fe5ff79c95aff13b79..2277ee77b5025707cb0ce199a3071fa88b7f53bd 100644 (file)
 -- COPYING file in the source package for more information.
 --
 
+local indexedbheap = require "util.indexedbheap";
+local log = require "util.logger".init("timer");
 local server = require "net.server";
-local math_min = math.min
-local math_huge = math.huge
 local get_time = require "socket".gettime;
-local t_insert = table.insert;
-local pairs = pairs;
 local type = type;
-
-local data = {};
-local new_data = {};
+local debug_traceback = debug.traceback;
+local tostring = tostring;
+local xpcall = xpcall;
 
 local _ENV = nil;
 
-local _add_task;
-if not server.event then
-       function _add_task(delay, callback)
-               local current_time = get_time();
-               delay = delay + current_time;
-               if delay >= current_time then
-                       t_insert(new_data, {delay, callback});
-               else
-                       local r = callback(current_time);
-                       if r and type(r) == "number" then
-                               return _add_task(r, callback);
-                       end
+local _add_task = server.add_task;
+
+local _server_timer;
+local _active_timers = 0;
+local h = indexedbheap.create();
+local params = {};
+local next_time = nil;
+local _id, _callback, _now, _param;
+local function _call() return _callback(_now, _id, _param); end
+local function _traceback_handler(err) log("error", "Traceback[timer]: %s", debug_traceback(tostring(err), 2)); end
+local function _on_timer(now)
+       local peek;
+       while true do
+               peek = h:peek();
+               if peek == nil or peek > now then break; end
+               local _;
+               _, _callback, _id = h:pop();
+               _now = now;
+               _param = params[_id];
+               params[_id] = nil;
+               --item(now, id, _param); -- FIXME pcall
+               local success, err = xpcall(_call, _traceback_handler);
+               if success and type(err) == "number" then
+                       h:insert(_callback, err + now, _id); -- re-add
+                       params[_id] = _param;
                end
        end
 
-       server._addtimer(function()
-               local current_time = get_time();
-               if #new_data > 0 then
-                       for _, d in pairs(new_data) do
-                               t_insert(data, d);
-                       end
-                       new_data = {};
-               end
+       if peek ~= nil and _active_timers > 1 and peek == next_time then
+               -- Another instance of _on_timer already set next_time to the same value,
+               -- so it should be safe to not renew this timer event
+               peek = nil;
+       else
+               next_time = peek;
+       end
 
-               local next_time = math_huge;
-               for i, d in pairs(data) do
-                       local t, callback = d[1], d[2];
-                       if t <= current_time then
-                               data[i] = nil;
-                               local r = callback(current_time);
-                               if type(r) == "number" then
-                                       _add_task(r, callback);
-                                       next_time = math_min(next_time, r);
-                               end
-                       else
-                               next_time = math_min(next_time, t - current_time);
-                       end
-               end
-               return next_time;
-       end);
-else
-       local event = server.event;
-       local event_base = server.event_base;
-       local EVENT_LEAVE = (event.core and event.core.LEAVE) or -1;
+       if peek then
+               -- peek is the time of the next event
+               return peek - now;
+       end
+       _active_timers = _active_timers - 1;
+end
+local function add_task(delay, callback, param)
+       local current_time = get_time();
+       local event_time = current_time + delay;
 
-       function _add_task(delay, callback)
-               local event_handle;
-               event_handle = event_base:addevent(nil, 0, function ()
-                       local ret = callback(get_time());
-                       if ret then
-                               return 0, ret;
-                       elseif event_handle then
-                               return EVENT_LEAVE;
-                       end
+       local id = h:insert(callback, event_time);
+       params[id] = param;
+       if next_time == nil or event_time < next_time then
+               next_time = event_time;
+               if _server_timer then
+                       _server_timer:close();
+                       _server_timer = nil;
+               else
+                       _active_timers = _active_timers + 1;
+               end
+               _server_timer = _add_task(next_time - current_time, _on_timer);
+       end
+       return id;
+end
+local function stop(id)
+       params[id] = nil;
+       local result, item, result_sync = h:remove(id);
+       local peek = h:peek();
+       if peek ~= next_time and _server_timer then
+               next_time = peek;
+               _server_timer:close();
+               if next_time ~= nil then
+                       _server_timer = _add_task(next_time - get_time(), _on_timer);
                end
-               , delay);
        end
+       return result, item, result_sync;
+end
+local function reschedule(id, delay)
+       local current_time = get_time();
+       local event_time = current_time + delay;
+       h:reprioritize(id, delay);
+       if next_time == nil or event_time < next_time then
+               next_time = event_time;
+               _add_task(next_time - current_time, _on_timer);
+       end
+       return id;
 end
 
 return {
-       add_task = _add_task;
+       add_task = add_task;
+       stop = stop;
+       reschedule = reschedule;
 };
+
diff --git a/util/vcard.lua b/util/vcard.lua
new file mode 100644 (file)
index 0000000..8aafa24
--- /dev/null
@@ -0,0 +1,582 @@
+-- Copyright (C) 2011-2014 Kim Alvefur
+--
+-- This project is MIT/X11 licensed. Please see the
+-- COPYING file in the source package for more information.
+--
+
+-- TODO
+-- Fix folding.
+
+local st = require "util.stanza";
+local t_insert, t_concat = table.insert, table.concat;
+local type = type;
+local next, pairs, ipairs = next, pairs, ipairs;
+
+local from_text, to_text, from_xep54, to_xep54;
+
+local line_sep = "\n";
+
+local vCard_dtd; -- See end of file
+local vCard4_dtd;
+
+local function fold_line()
+       error "Not implemented" --TODO
+end
+local function unfold_line()
+       error "Not implemented"
+       -- gsub("\r?\n[ \t]([^\r\n])", "%1");
+end
+
+local function vCard_esc(s)
+       return s:gsub("[,:;\\]", "\\%1"):gsub("\n","\\n");
+end
+
+local function vCard_unesc(s)
+       return s:gsub("\\?[\\nt:;,]", {
+               ["\\\\"] = "\\",
+               ["\\n"] = "\n",
+               ["\\r"] = "\r",
+               ["\\t"] = "\t",
+               ["\\:"] = ":", -- FIXME Shouldn't need to espace : in values, just params
+               ["\\;"] = ";",
+               ["\\,"] = ",",
+               [":"] = "\29",
+               [";"] = "\30",
+               [","] = "\31",
+       });
+end
+
+local function item_to_xep54(item)
+       local t = st.stanza(item.name, { xmlns = "vcard-temp" });
+
+       local prop_def = vCard_dtd[item.name];
+       if prop_def == "text" then
+               t:text(item[1]);
+       elseif type(prop_def) == "table" then
+               if prop_def.types and item.TYPE then
+                       if type(item.TYPE) == "table" then
+                               for _,v in pairs(prop_def.types) do
+                                       for _,typ in pairs(item.TYPE) do
+                                               if typ:upper() == v then
+                                                       t:tag(v):up();
+                                                       break;
+                                               end
+                                       end
+                               end
+                       else
+                               t:tag(item.TYPE:upper()):up();
+                       end
+               end
+
+               if prop_def.props then
+                       for _,v in pairs(prop_def.props) do
+                               if item[v] then
+                                       t:tag(v):up();
+                               end
+                       end
+               end
+
+               if prop_def.value then
+                       t:tag(prop_def.value):text(item[1]):up();
+               elseif prop_def.values then
+                       local prop_def_values = prop_def.values;
+                       local repeat_last = prop_def_values.behaviour == "repeat-last" and prop_def_values[#prop_def_values];
+                       for i=1,#item do
+                               t:tag(prop_def.values[i] or repeat_last):text(item[i]):up();
+                       end
+               end
+       end
+
+       return t;
+end
+
+local function vcard_to_xep54(vCard)
+       local t = st.stanza("vCard", { xmlns = "vcard-temp" });
+       for i=1,#vCard do
+               t:add_child(item_to_xep54(vCard[i]));
+       end
+       return t;
+end
+
+function to_xep54(vCards)
+       if not vCards[1] or vCards[1].name then
+               return vcard_to_xep54(vCards)
+       else
+               local t = st.stanza("xCard", { xmlns = "vcard-temp" });
+               for i=1,#vCards do
+                       t:add_child(vcard_to_xep54(vCards[i]));
+               end
+               return t;
+       end
+end
+
+function from_text(data)
+       data = data -- unfold and remove empty lines
+               :gsub("\r\n","\n")
+               :gsub("\n ", "")
+               :gsub("\n\n+","\n");
+       local vCards = {};
+       local c; -- current item
+       for line in data:gmatch("[^\n]+") do
+               local line = vCard_unesc(line);
+               local name, params, value = line:match("^([-%a]+)(\30?[^\29]*)\29(.*)$");
+               value = value:gsub("\29",":");
+               if #params > 0 then
+                       local _params = {};
+                       for k,isval,v in params:gmatch("\30([^=]+)(=?)([^\30]*)") do
+                               k = k:upper();
+                               local _vt = {};
+                               for _p in v:gmatch("[^\31]+") do
+                                       _vt[#_vt+1]=_p
+                                       _vt[_p]=true;
+                               end
+                               if isval == "=" then
+                                       _params[k]=_vt;
+                               else
+                                       _params[k]=true;
+                               end
+                       end
+                       params = _params;
+               end
+               if name == "BEGIN" and value == "VCARD" then
+                       c = {};
+                       vCards[#vCards+1] = c;
+               elseif name == "END" and value == "VCARD" then
+                       c = nil;
+               elseif c and vCard_dtd[name] then
+                       local dtd = vCard_dtd[name];
+                       local p = { name = name };
+                       c[#c+1]=p;
+                       --c[name]=p;
+                       local up = c;
+                       c = p;
+                       if dtd.types then
+                               for _, t in ipairs(dtd.types) do
+                                       local t = t:lower();
+                                       if ( params.TYPE and params.TYPE[t] == true)
+                                                       or params[t] == true then
+                                               c.TYPE=t;
+                                       end
+                               end
+                       end
+                       if dtd.props then
+                               for _, p in ipairs(dtd.props) do
+                                       if params[p] then
+                                               if params[p] == true then
+                                                       c[p]=true;
+                                               else
+                                                       for _, prop in ipairs(params[p]) do
+                                                               c[p]=prop;
+                                                       end
+                                               end
+                                       end
+                               end
+                       end
+                       if dtd == "text" or dtd.value then
+                               t_insert(c, value);
+                       elseif dtd.values then
+                               local value = "\30"..value;
+                               for p in value:gmatch("\30([^\30]*)") do
+                                       t_insert(c, p);
+                               end
+                       end
+                       c = up;
+               end
+       end
+       return vCards;
+end
+
+local function item_to_text(item)
+       local value = {};
+       for i=1,#item do
+               value[i] = vCard_esc(item[i]);
+       end
+       value = t_concat(value, ";");
+
+       local params = "";
+       for k,v in pairs(item) do
+               if type(k) == "string" and k ~= "name" then
+                       params = params .. (";%s=%s"):format(k, type(v) == "table" and t_concat(v,",") or v);
+               end
+       end
+
+       return ("%s%s:%s"):format(item.name, params, value)
+end
+
+local function vcard_to_text(vcard)
+       local t={};
+       t_insert(t, "BEGIN:VCARD")
+       for i=1,#vcard do
+               t_insert(t, item_to_text(vcard[i]));
+       end
+       t_insert(t, "END:VCARD")
+       return t_concat(t, line_sep);
+end
+
+function to_text(vCards)
+       if vCards[1] and vCards[1].name then
+               return vcard_to_text(vCards)
+       else
+               local t = {};
+               for i=1,#vCards do
+                       t[i]=vcard_to_text(vCards[i]);
+               end
+               return t_concat(t, line_sep);
+       end
+end
+
+local function from_xep54_item(item)
+       local prop_name = item.name;
+       local prop_def = vCard_dtd[prop_name];
+
+       local prop = { name = prop_name };
+
+       if prop_def == "text" then
+               prop[1] = item:get_text();
+       elseif type(prop_def) == "table" then
+               if prop_def.value then --single item
+                       prop[1] = item:get_child_text(prop_def.value) or "";
+               elseif prop_def.values then --array
+                       local value_names = prop_def.values;
+                       if value_names.behaviour == "repeat-last" then
+                               for i=1,#item.tags do
+                                       t_insert(prop, item.tags[i]:get_text() or "");
+                               end
+                       else
+                               for i=1,#value_names do
+                                       t_insert(prop, item:get_child_text(value_names[i]) or "");
+                               end
+                       end
+               elseif prop_def.names then
+                       local names = prop_def.names;
+                       for i=1,#names do
+                               if item:get_child(names[i]) then
+                                       prop[1] = names[i];
+                                       break;
+                               end
+                       end
+               end
+
+               if prop_def.props_verbatim then
+                       for k,v in pairs(prop_def.props_verbatim) do
+                               prop[k] = v;
+                       end
+               end
+
+               if prop_def.types then
+                       local types = prop_def.types;
+                       prop.TYPE = {};
+                       for i=1,#types do
+                               if item:get_child(types[i]) then
+                                       t_insert(prop.TYPE, types[i]:lower());
+                               end
+                       end
+                       if #prop.TYPE == 0 then
+                               prop.TYPE = nil;
+                       end
+               end
+
+               -- A key-value pair, within a key-value pair?
+               if prop_def.props then
+                       local params = prop_def.props;
+                       for i=1,#params do
+                               local name = params[i]
+                               local data = item:get_child_text(name);
+                               if data then
+                                       prop[name] = prop[name] or {};
+                                       t_insert(prop[name], data);
+                               end
+                       end
+               end
+       else
+               return nil
+       end
+
+       return prop;
+end
+
+local function from_xep54_vCard(vCard)
+       local tags = vCard.tags;
+       local t = {};
+       for i=1,#tags do
+               t_insert(t, from_xep54_item(tags[i]));
+       end
+       return t
+end
+
+function from_xep54(vCard)
+       if vCard.attr.xmlns ~= "vcard-temp" then
+               return nil, "wrong-xmlns";
+       end
+       if vCard.name == "xCard" then -- A collection of vCards
+               local t = {};
+               local vCards = vCard.tags;
+               for i=1,#vCards do
+                       t[i] = from_xep54_vCard(vCards[i]);
+               end
+               return t
+       elseif vCard.name == "vCard" then -- A single vCard
+               return from_xep54_vCard(vCard)
+       end
+end
+
+local vcard4 = { }
+
+function vcard4:text(node, params, value)
+       self:tag(node:lower())
+       -- FIXME params
+       if type(value) == "string" then
+               self:tag("text"):text(value):up()
+       elseif vcard4[node] then
+               vcard4[node](value);
+       end
+       self:up();
+end
+
+function vcard4.N(value)
+       for i, k in ipairs(vCard_dtd.N.values) do
+               value:tag(k):text(value[i]):up();
+       end
+end
+
+local xmlns_vcard4 = "urn:ietf:params:xml:ns:vcard-4.0"
+
+local function item_to_vcard4(item)
+       local typ = item.name:lower();
+       local t = st.stanza(typ, { xmlns = xmlns_vcard4 });
+
+       local prop_def = vCard4_dtd[typ];
+       if prop_def == "text" then
+               t:tag("text"):text(item[1]):up();
+       elseif prop_def == "uri" then
+               if item.ENCODING and item.ENCODING[1] == 'b' then
+                       t:tag("uri"):text("data:;base64,"):text(item[1]):up();
+               else
+                       t:tag("uri"):text(item[1]):up();
+               end
+       elseif type(prop_def) == "table" then
+               if prop_def.values then
+                       for i, v in ipairs(prop_def.values) do
+                               t:tag(v:lower()):text(item[i] or ""):up();
+                       end
+               else
+                       t:tag("unsupported",{xmlns="http://zash.se/protocol/vcardlib"})
+               end
+       else
+               t:tag("unsupported",{xmlns="http://zash.se/protocol/vcardlib"})
+       end
+       return t;
+end
+
+local function vcard_to_vcard4xml(vCard)
+       local t = st.stanza("vcard", { xmlns = xmlns_vcard4 });
+       for i=1,#vCard do
+               t:add_child(item_to_vcard4(vCard[i]));
+       end
+       return t;
+end
+
+local function vcards_to_vcard4xml(vCards)
+       if not vCards[1] or vCards[1].name then
+               return vcard_to_vcard4xml(vCards)
+       else
+               local t = st.stanza("vcards", { xmlns = xmlns_vcard4 });
+               for i=1,#vCards do
+                       t:add_child(vcard_to_vcard4xml(vCards[i]));
+               end
+               return t;
+       end
+end
+
+-- This was adapted from http://xmpp.org/extensions/xep-0054.html#dtd
+vCard_dtd = {
+       VERSION = "text", --MUST be 3.0, so parsing is redundant
+       FN = "text",
+       N = {
+               values = {
+                       "FAMILY",
+                       "GIVEN",
+                       "MIDDLE",
+                       "PREFIX",
+                       "SUFFIX",
+               },
+       },
+       NICKNAME = "text",
+       PHOTO = {
+               props_verbatim = { ENCODING = { "b" } },
+               props = { "TYPE" },
+               value = "BINVAL", --{ "EXTVAL", },
+       },
+       BDAY = "text",
+       ADR = {
+               types = {
+                       "HOME",
+                       "WORK",
+                       "POSTAL",
+                       "PARCEL",
+                       "DOM",
+                       "INTL",
+                       "PREF",
+               },
+               values = {
+                       "POBOX",
+                       "EXTADD",
+                       "STREET",
+                       "LOCALITY",
+                       "REGION",
+                       "PCODE",
+                       "CTRY",
+               }
+       },
+       LABEL = {
+               types = {
+                       "HOME",
+                       "WORK",
+                       "POSTAL",
+                       "PARCEL",
+                       "DOM",
+                       "INTL",
+                       "PREF",
+               },
+               value = "LINE",
+       },
+       TEL = {
+               types = {
+                       "HOME",
+                       "WORK",
+                       "VOICE",
+                       "FAX",
+                       "PAGER",
+                       "MSG",
+                       "CELL",
+                       "VIDEO",
+                       "BBS",
+                       "MODEM",
+                       "ISDN",
+                       "PCS",
+                       "PREF",
+               },
+               value = "NUMBER",
+       },
+       EMAIL = {
+               types = {
+                       "HOME",
+                       "WORK",
+                       "INTERNET",
+                       "PREF",
+                       "X400",
+               },
+               value = "USERID",
+       },
+       JABBERID = "text",
+       MAILER = "text",
+       TZ = "text",
+       GEO = {
+               values = {
+                       "LAT",
+                       "LON",
+               },
+       },
+       TITLE = "text",
+       ROLE = "text",
+       LOGO = "copy of PHOTO",
+       AGENT = "text",
+       ORG = {
+               values = {
+                       behaviour = "repeat-last",
+                       "ORGNAME",
+                       "ORGUNIT",
+               }
+       },
+       CATEGORIES = {
+               values = "KEYWORD",
+       },
+       NOTE = "text",
+       PRODID = "text",
+       REV = "text",
+       SORTSTRING = "text",
+       SOUND = "copy of PHOTO",
+       UID = "text",
+       URL = "text",
+       CLASS = {
+               names = { -- The item.name is the value if it's one of these.
+                       "PUBLIC",
+                       "PRIVATE",
+                       "CONFIDENTIAL",
+               },
+       },
+       KEY = {
+               props = { "TYPE" },
+               value = "CRED",
+       },
+       DESC = "text",
+};
+vCard_dtd.LOGO = vCard_dtd.PHOTO;
+vCard_dtd.SOUND = vCard_dtd.PHOTO;
+
+vCard4_dtd = {
+       source = "uri",
+       kind = "text",
+       xml = "text",
+       fn = "text",
+       n = {
+               values = {
+                       "family",
+                       "given",
+                       "middle",
+                       "prefix",
+                       "suffix",
+               },
+       },
+       nickname = "text",
+       photo = "uri",
+       bday = "date-and-or-time",
+       anniversary = "date-and-or-time",
+       gender = "text",
+       adr = {
+               values = {
+                       "pobox",
+                       "ext",
+                       "street",
+                       "locality",
+                       "region",
+                       "code",
+                       "country",
+               }
+       },
+       tel = "text",
+       email = "text",
+       impp = "uri",
+       lang = "language-tag",
+       tz = "text",
+       geo = "uri",
+       title = "text",
+       role = "text",
+       logo = "uri",
+       org = "text",
+       member = "uri",
+       related = "uri",
+       categories = "text",
+       note = "text",
+       prodid = "text",
+       rev = "timestamp",
+       sound = "uri",
+       uid = "uri",
+       clientpidmap = "number, uuid",
+       url = "uri",
+       version = "text",
+       key = "uri",
+       fburl = "uri",
+       caladruri = "uri",
+       caluri = "uri",
+};
+
+return {
+       from_text = from_text;
+       to_text = to_text;
+
+       from_xep54 = from_xep54;
+       to_xep54 = to_xep54;
+
+       to_vcard4 = vcards_to_vcard4xml;
+};
index 733d821ad7c8b87dc93d7e4a0b3ab2cfa030fd85..ec06fb0159e22ec6308d79a481fda51669ea5e2d 100644 (file)
@@ -1,6 +1,8 @@
 
 local st = require "util.stanza";
 local lxp = require "lxp";
+local t_insert = table.insert;
+local t_remove = table.remove;
 
 local _ENV = nil;
 
@@ -14,6 +16,21 @@ local parse_xml = (function()
                --luacheck: ignore 212/self
                local handler = {};
                local stanza = st.stanza("root");
+               local namespaces = {};
+               local prefixes = {};
+               function handler:StartNamespaceDecl(prefix, url)
+                       if prefix ~= nil then
+                               t_insert(namespaces, url);
+                               t_insert(prefixes, prefix);
+                       end
+               end
+               function handler:EndNamespaceDecl(prefix)
+                       if prefix ~= nil then
+                               -- we depend on each StartNamespaceDecl having a paired EndNamespaceDecl
+                               t_remove(namespaces);
+                               t_remove(prefixes);
+                       end
+               end
                function handler:StartElement(tagname, attr)
                        local curr_ns,name = tagname:match(ns_pattern);
                        if name == "" then
@@ -34,7 +51,11 @@ local parse_xml = (function()
                                        end
                                end
                        end
-                       stanza:tag(name, attr);
+                       local n = {}
+                       for i=1,#namespaces do
+                               n[prefixes[i]] = namespaces[i];
+                       end
+                       stanza:tag(name, attr, n);
                end
                function handler:CharacterData(data)
                        stanza:text(data);