Merge 0.9->0.10
authorMatthew Wild <mwild1@gmail.com>
Fri, 25 Jul 2014 12:54:27 +0000 (13:54 +0100)
committerMatthew Wild <mwild1@gmail.com>
Fri, 25 Jul 2014 12:54:27 +0000 (13:54 +0100)
1  2 
net/server_event.lua
net/server_select.lua

diff --combined net/server_event.lua
index 5333099776674de86a591e58b582052d77dc6b03,b05d16881d8501b77ec01577af00a14a653b8535..e10606dded0dd079f17ecd176cc40ef585274b4a
@@@ -115,10 -115,10 +115,10 @@@ end )( 
  local interface_mt
  do
        interface_mt = {}; interface_mt.__index = interface_mt;
 -      
 +
        local addevent = base.addevent
        local coroutine_wrap, coroutine_yield = coroutine.wrap,coroutine.yield
 -      
 +
        -- Private methods
        function interface_mt:_position(new_position)
                        self.position = new_position or self.position
        function interface_mt:_close()
                return self:_destroy();
        end
 -      
 +
        function interface_mt:_start_connection(plainssl) -- should be called from addclient
                        local callback = function( event )
                                if EV_TIMEOUT == event then  -- timeout during connection
                        interfacelist( "delete", self )
                        return true
        end
 -      
 +
        function interface_mt:_lock(nointerface, noreading, nowriting)  -- lock or unlock this interface or events
                        self.nointerface, self.noreading, self.nowriting = nointerface, noreading, nowriting
                        return nointerface, noreading, nowriting
        end
 -      
 +
        --TODO: Deprecate
        function interface_mt:lock_read(switch)
                if switch then
                end
                return self._connections
        end
 -      
 +
        -- Public methods
        function interface_mt:write(data)
                if self.nowriting then return nil, "locked" end
                        return true
                end
        end
 -      
 +
        function interface_mt:socket()
                return self.conn
        end
 -      
 +
        function interface_mt:server()
                return self._server or self;
        end
 -      
 +
        function interface_mt:port()
                return self._port
        end
 -      
 +
        function interface_mt:serverport()
                return self._serverport
        end
 -      
 +
        function interface_mt:ip()
                return self._ip
        end
 -      
 +
        function interface_mt:ssl()
                return self._usingssl
        end
        function interface_mt:type()
                return self._type or "client"
        end
 -      
 +
        function interface_mt:connections()
                return self._connections
        end
 -      
 +
        function interface_mt:address()
                return self.addr
        end
 -      
 +
        function interface_mt:set_sslctx(sslctx)
                self._sslctx = sslctx;
                if sslctx then
                end
                return self._pattern;
        end
 -      
 +
        function interface_mt:set_send(new_send)
                -- No-op, we always use the underlying connection's send
        end
 -      
 +
        function interface_mt:starttls(sslctx, call_onconnect)
                debug( "try to start ssl at client id:", self.id )
                local err
                self.starttls = false;
                return true
        end
 -      
 +
        function interface_mt:setoption(option, value)
                if self.conn.setoption then
                        return self.conn:setoption(option, value);
                end
                return false, "setoption not implemented";
        end
 -      
 +
        function interface_mt:setlistener(listener)
 -              self.onconnect, self.ondisconnect, self.onincoming, self.ontimeout, self.onstatus
 -                      = listener.onconnect, listener.ondisconnect, listener.onincoming, listener.ontimeout, listener.onstatus;
 +              self.onconnect, self.ondisconnect, self.onincoming, self.ontimeout, self.onreadtimeout, self.onstatus
 +                      = listener.onconnect, listener.ondisconnect, listener.onincoming,
 +                        listener.ontimeout, listener.onreadtimeout, listener.onstatus;
        end
 -      
 +
        -- Stub handlers
        function interface_mt:onconnect()
        end
        end
        function interface_mt:ontimeout()
        end
 +      function interface_mt:onreadtimeout()
 +              self.fatalerror = "timeout during receiving"
 +              debug( "connection failed:", self.fatalerror )
 +              self:_close()
 +              self.eventread = nil
 +      end
        function interface_mt:ondrain()
        end
        function interface_mt:onstatus()
@@@ -485,7 -478,6 +485,7 @@@ d
                        ondisconnect = listener.ondisconnect;  -- will be called when client disconnects
                        onincoming = listener.onincoming;  -- will be called when client sends data
                        ontimeout = listener.ontimeout; -- called when fatal socket timeout occurs
 +                      onreadtimeout = listener.onreadtimeout; -- called when socket inactivity timeout occurs
                        ondrain = listener.ondrain; -- called when writebuffer is empty
                        onstatus = listener.onstatus; -- called for status changes (e.g. of SSL/TLS)
                        eventread = false, eventwrite = false, eventclose = false,
                        noreading = false, nowriting = false;  -- locks of the read/writecallback
                        startsslcallback = false;  -- starting handshake callback
                        position = false;  -- position of client in interfacelist
 -                      
 +
                        -- Properties
                        _ip = ip, _port = port, _server = server, _pattern = pattern,
                        _serverport = (server and server:port() or nil),
                                end
                        end
                end
 -              
 +
                interface.readcallback = function( event )  -- called on read events
                        --vdebug( "new client read event, id/ip/port:", tostring(interface.id), tostring(ip), tostring(port) )
                        if interface.noreading or interface.fatalerror then  -- leave this event
                                interface.eventread = nil
                                return -1
                        end
 -                      if EV_TIMEOUT == event then  -- took too long to get some data from client -> disconnect
 -                              interface.fatalerror = "timeout during receiving"
 -                              debug( "connection failed:", interface.fatalerror )
 +                      if EV_TIMEOUT == event and interface:onreadtimeout() ~= true then
 +                              return -1 -- took too long to get some data from client -> disconnect
 +                      end
 +                      if interface._usingssl then  -- handle luasec
 +                              if interface.eventwritetimeout then  -- ok, in the past writecallback was regged
 +                                      local ret = interface.writecallback( )  -- call it
 +                                      --vdebug( "tried to write in readcallback, result:", tostring(ret) )
 +                              end
 +                              if interface.eventreadtimeout then
 +                                      interface.eventreadtimeout:close( )
 +                                      interface.eventreadtimeout = nil
 +                              end
 +                      end
 +                      local buffer, err, part = interface.conn:receive( interface._pattern )  -- receive buffer with "pattern"
 +                      --vdebug( "read data:", tostring(buffer), "error:", tostring(err), "part:", tostring(part) )
 +                      buffer = buffer or part
 +                      if buffer and #buffer > cfg.MAX_READ_LENGTH then  -- check buffer length
 +                              interface.fatalerror = "receive buffer exceeded"
 +                              debug( "fatal error:", interface.fatalerror )
                                interface:_close()
                                interface.eventread = nil
                                return -1
 -                      else -- can read
 -                              if interface._usingssl then  -- handle luasec
 -                                      if interface.eventwritetimeout then  -- ok, in the past writecallback was regged
 -                                              local ret = interface.writecallback( )  -- call it
 -                                              --vdebug( "tried to write in readcallback, result:", tostring(ret) )
 -                                      end
 -                                      if interface.eventreadtimeout then
 -                                              interface.eventreadtimeout:close( )
 -                                              interface.eventreadtimeout = nil
 +                      end
 +                      if err and ( err ~= "timeout" and err ~= "wantread" ) then
 +                              if "wantwrite" == err then -- need to read on write event
 +                                      if not interface.eventwrite then  -- register new write event if needed
 +                                              interface.eventwrite = addevent( base, interface.conn, EV_WRITE, interface.writecallback, cfg.WRITE_TIMEOUT )
                                        end
 -                              end
 -                              local buffer, err, part = interface.conn:receive( interface._pattern )  -- receive buffer with "pattern"
 -                              --vdebug( "read data:", tostring(buffer), "error:", tostring(err), "part:", tostring(part) )
 -                              buffer = buffer or part
 -                              if buffer and #buffer > cfg.MAX_READ_LENGTH then  -- check buffer length
 -                                      interface.fatalerror = "receive buffer exceeded"
 -                                      debug( "fatal error:", interface.fatalerror )
 +                                      interface.eventreadtimeout = addevent( base, nil, EV_TIMEOUT,
 +                                              function( )
 +                                                      interface:_close()
 +                                              end, cfg.READ_TIMEOUT
 +                                      )
 +                                      debug( "wantwrite during read attempt, reg it in writecallback but dont know what really happens next..." )
 +                                      -- to be honest i dont know what happens next, if it is allowed to first read, the write etc...
 +                              else  -- connection was closed or fatal error
 +                                      interface.fatalerror = err
 +                                      debug( "connection failed in read event:", interface.fatalerror )
                                        interface:_close()
                                        interface.eventread = nil
                                        return -1
                                end
 -                              if err and ( err ~= "timeout" and err ~= "wantread" ) then
 -                                      if "wantwrite" == err then -- need to read on write event
 -                                              if not interface.eventwrite then  -- register new write event if needed
 -                                                      interface.eventwrite = addevent( base, interface.conn, EV_WRITE, interface.writecallback, cfg.WRITE_TIMEOUT )
 -                                              end
 -                                              interface.eventreadtimeout = addevent( base, nil, EV_TIMEOUT,
 -                                                      function( )
 -                                                              interface:_close()
 -                                                      end, cfg.READ_TIMEOUT
 -                                              )
 -                                              debug( "wantwrite during read attempt, reg it in writecallback but dont know what really happens next..." )
 -                                              -- to be honest i dont know what happens next, if it is allowed to first read, the write etc...
 -                                      else  -- connection was closed or fatal error
 -                                              interface.fatalerror = err
 -                                              debug( "connection failed in read event:", interface.fatalerror )
 -                                              interface:_close()
 -                                              interface.eventread = nil
 -                                              return -1
 -                                      end
 -                              else
 -                                      interface.onincoming( interface, buffer, err )  -- send new data to listener
 -                              end
 -                              if interface.noreading then
 -                                      interface.eventread = nil;
 -                                      return -1;
 -                              end
 -                              return EV_READ, cfg.READ_TIMEOUT
 +                      else
 +                              interface.onincoming( interface, buffer, err )  -- send new data to listener
                        end
 +                      if interface.noreading then
 +                              interface.eventread = nil;
 +                              return -1;
 +                      end
 +                      return EV_READ, cfg.READ_TIMEOUT
                end
  
                client:settimeout( 0 )  -- set non blocking
@@@ -649,7 -646,7 +649,7 @@@ d
                debug "creating server interface..."
                local interface = {
                        _connections = 0;
 -                      
 +
                        conn = server;
                        onconnect = listener.onconnect;  -- will be called when new client connected
                        eventread = false;  -- read event handler
                        readcallback = false; -- read event callback
                        fatalerror = false; -- error message
                        nointerface = true;  -- lock/unlock parameter
 -                      
 +
                        _ip = addr, _port = port, _pattern = pattern,
                        _sslctx = sslctx;
                }
                                        clientinterface:_start_session( true )
                                end
                                debug( "accepted incoming client connection from:", client_ip or "<unknown IP>", client_port or "<unknown port>", "to", port or "<unknown port>");
 -                              
 +
                                client, err = server:accept()    -- try to accept again
                        end
                        return EV_READ
                end
 -              
 +
                server:settimeout( 0 )
                setmetatable(interface, interface_mt)
                interfacelist( "add", interface )
@@@ -744,7 -741,7 +744,7 @@@ d
                return interface, client
                --function handleclient( client, ip, port, server, pattern, listener, _, sslctx )  -- creates an client interface
        end
 -      
 +
        function addclient( addr, serverport, listener, pattern, localaddr, localport, sslcfg, startssl )
                local client, err = socket.tcp()  -- creating new socket
                if not client then
@@@ -835,14 -832,14 +835,14 @@@ en
  
  local function link(sender, receiver, buffersize)
        local sender_locked;
 -      
 +
        function receiver:ondrain()
                if sender_locked then
                        sender:resume();
                        sender_locked = nil;
                end
        end
 -      
 +
        function sender:onincoming(data)
                receiver:write(data);
                if receiver.writebufferlen >= buffersize then
                        sender:pause();
                end
        end
+       sender:set_mode("*a");
  end
  
  return {
diff --combined net/server_select.lua
index daad0f50fb7fd05abcf7f0dd25bb2d985ba643a2,e896451830d3c85c06d8721d8954528bf20f8112..6308e62fa4485b623243ab6d29b24edfce3a831f
@@@ -1,7 -1,7 +1,7 @@@
 --- 
 +--
  -- server.lua by blastbeat of the luadch project
  -- Re-used here under the MIT/X Consortium License
 --- 
 +--
  -- Modifications (C) 2008-2010 Matthew Wild, Waqas Hussain
  --
  
@@@ -145,7 -145,7 +145,7 @@@ _tcpbacklog = 128 -- some kind of hint 
  _maxsendlen = 51000 * 1024 -- max len of send buffer
  _maxreadlen = 25000 * 1024 -- max len of read buffer
  
 -_checkinterval = 1200000 -- interval in secs to check idle clients
 +_checkinterval = 30 -- interval in secs to check idle clients
  _sendtimeout = 60000 -- allowed send idle time in secs
  _readtimeout = 6 * 60 * 60 -- allowed read idle time in secs
  
@@@ -284,7 -284,6 +284,7 @@@ wrapconnection = function( server, list
        local status = listeners.onstatus
        local disconnect = listeners.ondisconnect
        local drain = listeners.ondrain
 +      local onreadtimeout = listeners.onreadtimeout;
  
        local bufferqueue = { } -- buffer array
        local bufferqueuelen = 0        -- end of buffer array
        handler.disconnect = function( )
                return disconnect
        end
 +      handler.onreadtimeout = onreadtimeout;
 +
        handler.setlistener = function( self, listeners )
                dispatch = listeners.onincoming
                disconnect = listeners.ondisconnect
                status = listeners.onstatus
                drain = listeners.ondrain
 +              handler.onreadtimeout = listeners.onreadtimeout
        end
        handler.getstats = function( )
                return readtraffic, sendtraffic
                        shutdown = id
                        _socketlist[ socket ] = handler
                        _readlistlen = addsocket(_readlist, socket, _readlistlen)
 -                      
 +
                        -- remove traces of the old socket
                        _readlistlen = removesocket( _readlist, oldsocket, _readlistlen )
                        _sendlistlen = removesocket( _sendlist, oldsocket, _sendlistlen )
@@@ -700,7 -696,7 +700,7 @@@ local function link(sender, receiver, b
                        sender_locked = nil;
                end
        end
 -      
 +
        local _readbuffer = sender.readbuffer;
        function sender.readbuffer()
                _readbuffer();
                        sender:lock_read(true);
                end
        end
+       sender:set_mode("*a");
  end
  
  ----------------------------------// PUBLIC //--
@@@ -868,16 -865,16 +869,16 @@@ loop = function(once) -- this is the ma
                        _starttime = _currenttime
                        for handler, timestamp in pairs( _writetimes ) do
                                if os_difftime( _currenttime - timestamp ) > _sendtimeout then
 -                                      --_writetimes[ handler ] = nil
                                        handler.disconnect( )( handler, "send timeout" )
                                        handler:force_close()    -- forced disconnect
                                end
                        end
                        for handler, timestamp in pairs( _readtimes ) do
                                if os_difftime( _currenttime - timestamp ) > _readtimeout then
 -                                      --_readtimes[ handler ] = nil
 -                                      handler.disconnect( )( handler, "read timeout" )
 -                                      handler:close( )        -- forced disconnect?
 +                                      if not(handler.onreadtimeout) or handler:onreadtimeout() ~= true then
 +                                              handler.disconnect( )( handler, "read timeout" )
 +                                              handler:close( )        -- forced disconnect?
 +                                      end
                                end
                        end
                end
@@@ -938,9 -935,9 +939,9 @@@ local addclient = function( address, po
        client:settimeout( 0 )
        _, err = client:connect( address, port )
        if err then -- try again
 -              local handler = wrapclient( client, address, port, listeners )
 +              return wrapclient( client, address, port, listeners, pattern, sslctx )
        else
 -              wrapconnection( nil, listeners, client, address, port, "clientport", pattern, sslctx )
 +              return wrapconnection( nil, listeners, client, address, port, "clientport", pattern, sslctx )
        end
  end
  
@@@ -970,7 -967,7 +971,7 @@@ return 
  
        addclient = addclient,
        wrapclient = wrapclient,
 -      
 +
        loop = loop,
        link = link,
        step = step,