certmanager, mod_tls: Return final ssl config as third return value (fix for c6caaa44...
authorKim Alvefur <zash@zash.se>
Sat, 22 Nov 2014 10:51:54 +0000 (11:51 +0100)
committerKim Alvefur <zash@zash.se>
Sat, 22 Nov 2014 10:51:54 +0000 (11:51 +0100)
core/certmanager.lua
plugins/mod_tls.lua

index 3454fcc4e867081bf80cc752df9ea56bd4430798..7ad7b034a61df14b7370c7886656fe2ca51b4810 100644 (file)
@@ -137,10 +137,8 @@ function create_context(host, mode, ...)
                else
                        log("error", "SSL/TLS: Error initialising for %s: %s", host, err);
                end
-       else
-               err = nil;
        end
-       return ctx, err or user_ssl_config;
+       return ctx, err, user_ssl_config;
 end
 
 function reload_ssl_config()
index d9670d7338393bd5c522e4a29a673924314341c4..f9d2cee99af4c40ea574ca968df7c747e3d741c5 100644 (file)
@@ -34,7 +34,7 @@ local host = hosts[module.host];
 local ssl_ctx_c2s, ssl_ctx_s2sout, ssl_ctx_s2sin;
 local ssl_cfg_c2s, ssl_cfg_s2sout, ssl_cfg_s2sin;
 do
-       local NULL = {};
+       local NULL, err = {};
        local global = module:context("*");
        local parent = module:context(module.host:match("%.(.*)$"));
 
@@ -49,14 +49,14 @@ do
        local parent_s2s = parent:get_option("s2s_ssl", NULL);
        local host_s2s   = module:get_option("s2s_ssl", parent_s2s);
 
-       ssl_ctx_c2s, ssl_cfg_c2s = create_context(host.host, "server", host_c2s, host_ssl, global_c2s); -- for incoming client connections
-       if not ssl_ctx_c2s then module:log("error", "Error creating context for c2s: %s", ssl_cfg_c2s); end
+       ssl_ctx_c2s, err, ssl_cfg_c2s = create_context(host.host, "server", host_c2s, host_ssl, global_c2s); -- for incoming client connections
+       if not ssl_ctx_c2s then module:log("error", "Error creating context for c2s: %s", err); end
 
-       ssl_ctx_s2sout, ssl_cfg_s2sout = create_context(host.host, "client", host_s2s, host_ssl, global_s2s); -- for outgoing server connections
-       if not ssl_ctx_s2sout then module:log("error", "Error creating contexts for s2sout: %s", ssl_cfg_s2sin); end
+       ssl_ctx_s2sout, err, ssl_cfg_s2sout = create_context(host.host, "client", host_s2s, host_ssl, global_s2s); -- for outgoing server connections
+       if not ssl_ctx_s2sout then module:log("error", "Error creating contexts for s2sout: %s", err); end
 
-       ssl_ctx_s2sin, ssl_cfg_s2sin = create_context(host.host, "server", host_s2s, host_ssl, global_s2s); -- for incoming server connections
-       if not ssl_ctx_s2sin then module:log("error", "Error creating contexts for s2sin: %s", ssl_cfg_s2sin); end
+       ssl_ctx_s2sin, err, ssl_cfg_s2sin = create_context(host.host, "server", host_s2s, host_ssl, global_s2s); -- for incoming server connections
+       if not ssl_ctx_s2sin then module:log("error", "Error creating contexts for s2sin: %s", err); end
 end
 
 local function can_do_tls(session)