#include <libelfu/libelfu.h>
-static int appendData(ElfuScn *ms, void *buf, size_t len)
+static ElfuScn* cloneScn(ElfuScn *ms)
{
- char *newbuf;
+ ElfuScn *newscn;
assert(ms);
- assert(ms->shdr.sh_type != SHT_NOBITS);
- assert(ms->databuf);
- newbuf = realloc(ms->databuf, ms->shdr.sh_size + len);
- if (!newbuf) {
- ELFU_WARN("appendData: malloc() failed for newbuf.\n");
- return 1;
+ newscn = elfu_mScnAlloc();
+ if (!newscn) {
+ return NULL;
}
- ms->databuf = newbuf;
- memcpy(newbuf + ms->shdr.sh_size, buf, len);
- ms->shdr.sh_size += len;
- assert(ms->shdr.sh_size == ms->shdr.sh_size);
+ newscn->shdr = ms->shdr;
- return 0;
+ if (ms->databuf) {
+ void *newbuf = malloc(ms->shdr.sh_size);
+ if (!newbuf) {
+ ELFU_WARN("cloneScn: Could not allocate memory for new data buffer.\n");
+ free(newscn);
+ return NULL;
+ }
+
+ memcpy(newbuf, ms->databuf, ms->shdr.sh_size);
+ newscn->databuf = newbuf;
+ }
+
+ newscn->oldptr = ms;
+
+ return newscn;
}
+
static ElfuScn* insertSection(ElfuElf *me, ElfuElf *mrel, ElfuScn *oldscn)
{
ElfuScn *newscn = NULL;
GElf_Off injOffset;
ElfuPhdr *injPhdr;
- if (oldscn->shdr.sh_flags & SHF_ALLOC) {
- newscn = elfu_mCloneScn(oldscn);
+ if (!(oldscn->shdr.sh_flags & SHF_ALLOC)) {
+ ELFU_WARN("insertSection: Skipping non-memory section %s (type %d flags %u).\n",
+ elfu_mScnName(mrel, oldscn),
+ oldscn->shdr.sh_type,
+ (unsigned)oldscn->shdr.sh_flags);
+ goto ERROR;
+ } else {
+ newscn = cloneScn(oldscn);
if (!newscn) {
return NULL;
}
newscn->shdr.sh_addr = injAddr;
newscn->shdr.sh_offset = injOffset;
+ /* Insert section in child list, ordered by memory address */
if (CIRCLEQ_EMPTY(&injPhdr->childScnList)
- || CIRCLEQ_LAST(&injPhdr->childScnList)->shdr.sh_offset < injOffset) {
+ || CIRCLEQ_LAST(&injPhdr->childScnList)->shdr.sh_addr < injAddr) {
CIRCLEQ_INSERT_TAIL(&injPhdr->childScnList, newscn, elemChildScn);
} else {
ElfuScn *ms;
CIRCLEQ_FOREACH(ms, &injPhdr->childScnList, elemChildScn) {
- if (injOffset < ms->shdr.sh_offset) {
+ if (injAddr < ms->shdr.sh_addr) {
CIRCLEQ_INSERT_BEFORE(&injPhdr->childScnList, ms, newscn, elemChildScn);
break;
}
/* Inject name */
if (me->shstrtab) {
- char *newname;
size_t newnamelen;
newnamelen = strlen("reladd") + 1;
newnamelen += strlen(elfu_mScnName(mrel, oldscn));
}
- newname = malloc(newnamelen);
+ char newname[newnamelen];
+
strcpy(newname, "reladd");
strcat(newname, elfu_mScnName(mrel, oldscn));
- if (!newname) {
- ELFU_WARN("insertSection: malloc() failed for newname. Leaving section name empty.\n");
- newscn->shdr.sh_name = 0;
- } else {
- size_t offset = me->shstrtab->shdr.sh_size;
+ newscn->shdr.sh_name = me->shstrtab->shdr.sh_size;
- if (!appendData(me->shstrtab, newname, newnamelen)) {
- newscn->shdr.sh_name = offset;
- }
-
- free(newname);
+ if (elfu_mScnAppendData(me->shstrtab, newname, newnamelen)) {
+ newscn->shdr.sh_name = 0;
}
}
return newscn;
- } else {
- ELFU_WARN("insertSection: Skipping non-memory section %s (type %d flags %u).\n",
- elfu_mScnName(mrel, oldscn),
- oldscn->shdr.sh_type,
- (unsigned)oldscn->shdr.sh_flags);
- goto ERROR;
}
ERROR:
switch(ms->shdr.sh_type) {
case SHT_NULL: /* 0 */
case SHT_PROGBITS: /* 1 */
+ case SHT_SYMTAB: /* 2 */
case SHT_STRTAB: /* 3 */
case SHT_NOBITS: /* 8 */
break;
-
+ case SHT_RELA: /* 4 */
case SHT_REL: /* 9 */
/* Relocate. */
- elfu_mRelocate(me, elfu_mScnByOldscn(me, ms->infoptr), ms);
+ if (elfu_mRelocate(me, elfu_mScnByOldscn(me, ms->infoptr), ms)) {
+ return (void*)-1;
+ }
break;
- case SHT_RELA: /* 4 */
- // TODO: Needs a parser
- //elfu_mRelocate(elfu_mScnByOldscn(me, ms->infoptr), ms);
-
- case SHT_SYMTAB: /* 2 */
- /* Merge with the existing table. Take care of string tables also. */
-
/* The next section types either do not occur in .o files, or are
* not strictly necessary to process here. */
case SHT_NOTE: /* 7 */
}
}
- // TODO: Allocate symtab if none present
- assert(me->symtab);
+ /* If we don't have a symbol table, create one so we have somewhere to
+ * write our new symbols to. */
+ elfu_mSymtabAddGlobalDymtabIfNotPresent(me);
/* Allocate memory for the cloned symbol */
newsym = malloc(sizeof(*newsym));
CIRCLEQ_FOREACH(sym, &mrel->symtab->symtab.syms, elem) {
insertSymClone(me, mrel->symtab, sym);
}
+
+ elfu_mSymtabFlatten(me);
}
-void elfu_mReladd(ElfuElf *me, const ElfuElf *mrel)
+int elfu_mReladd(ElfuElf *me, const ElfuElf *mrel)
{
assert(me);
assert(mrel);
mergeSymtab(me, mrel);
/* Do relocations and other stuff */
- elfu_mScnForall((ElfuElf*)mrel, subScnAdd2, me, NULL);
+ if (elfu_mScnForall((ElfuElf*)mrel, subScnAdd2, me, NULL)) {
+ ELFU_WARN("elfu_mReladd: Reladd aborted. Target model is unclean.\n");
+ return -1;
+ }
/* Re-layout to accommodate new contents */
elfu_mLayoutAuto(me);
+
+ return 0;
}