Merge 0.10->trunk
[prosody.git] / plugins / muc / muc.lib.lua
index eb6738aaeabb9ede7b304ba4163ec602c4aeca25..75caa233938f49d627df9aefae1c84d2d67935f7 100644 (file)
@@ -17,6 +17,7 @@ local iterators = require "util.iterators";
 local jid_split = require "util.jid".split;
 local jid_bare = require "util.jid".bare;
 local jid_prep = require "util.jid".prep;
+local jid_join = require "util.jid".join;
 local st = require "util.stanza";
 local log = require "util.logger".init("mod_muc");
 local base64 = require "util.encodings".base64;
@@ -130,10 +131,10 @@ function room_mt:route_to_occupant(occupant, stanza)
 end
 
 -- actor is the attribute table
-local function add_item(x, affiliation, role, jid, nick, actor, reason)
+local function add_item(x, affiliation, role, jid, nick, actor_nick, actor_jid, reason)
        x:tag("item", {affiliation = affiliation; role = role; jid = jid; nick = nick;})
-       if actor then
-               x:tag("actor", actor):up()
+       if actor_nick or actor_jid then
+               x:tag("actor", {nick = actor_nick; jid = actor_jid;}):up()
        end
        if reason then
                x:tag("reason"):text(reason):up()
@@ -143,21 +144,14 @@ local function add_item(x, affiliation, role, jid, nick, actor, reason)
 end
 
 -- actor is (real) jid
-function room_mt:build_item_list(occupant, x, is_anonymous, nick, actor, reason)
+function room_mt:build_item_list(occupant, x, is_anonymous, nick, actor_nick, actor_jid, reason)
        local affiliation = self:get_affiliation(occupant.bare_jid) or "none";
        local role = occupant.role or "none";
-       local actor_attr;
-       if actor then
-               actor_attr = {nick = select(3,jid_split(self:get_occupant_jid(actor)))};
-       end
        if is_anonymous then
-               add_item(x, affiliation, role, nil, nick, actor_attr, reason);
+               add_item(x, affiliation, role, nil, nick, actor_nick, actor_jid, reason);
        else
-               if actor_attr then
-                       actor_attr.jid = actor;
-               end
                for real_jid, session in occupant:each_session() do
-                       add_item(x, affiliation, role, real_jid, nick, actor_attr, reason);
+                       add_item(x, affiliation, role, real_jid, nick, actor_nick, actor_jid, reason);
                end
        end
        return x
@@ -204,37 +198,64 @@ function room_mt:publicise_occupant_status(occupant, base_x, nick, actor, reason
        base_presence = base_presence or st.presence {from = occupant.nick; type = "unavailable";};
 
        -- Fire event (before full_p and anon_p are created)
-       module:fire_event("muc-broadcast-presence", {
+       local event = {
                room = self; stanza = base_presence; x = base_x;
                occupant = occupant; nick = nick; actor = actor;
                reason = reason;
-       });
+       }
+       module:fire_event("muc-broadcast-presence", event);
+
+       -- Allow muc-broadcast-presence listeners to change things
+       nick = event.nick;
+       actor = event.actor;
+       reason = event.reason;
 
-       local function get_presence(is_anonymous)
-               local x = st.clone(base_x);
-               self:build_item_list(occupant, x, is_anonymous, nick, actor, reason);
-               return st.clone(base_presence):add_child(x), x;
+       local whois = self:get_whois();
+
+       local actor_nick;
+       if actor then
+               actor_nick = select(3, jid_split(self:get_occupant_jid(actor)));
        end
 
-       local full_p, full_x = get_presence(false);
+       local full_p, full_x;
+       local function get_full_p()
+               if full_p == nil then
+                       full_x = st.clone(base_x);
+                       self:build_item_list(occupant, full_x, false, nick, actor_nick, actor, reason);
+                       full_p = st.clone(base_presence):add_child(full_x);
+               end
+               return full_p, full_x;
+       end
 
-       -- Create anon_p lazily
        local anon_p, anon_x;
        local function get_anon_p()
                if anon_p == nil then
-                       anon_p, anon_x = get_presence(true);
+                       anon_x = st.clone(base_x);
+                       self:build_item_list(occupant, anon_x, true, nick, actor_nick, nil, reason);
+                       anon_p = st.clone(base_presence):add_child(anon_x);
                end
                return anon_p, anon_x;
        end
 
-       local whois = self:get_whois();
+       local self_p, self_x;
+       if can_see_real_jids(whois, occupant) then
+               self_p, self_x = get_full_p();
+       else
+               -- Can always see your own full jids
+               -- But not allowed to see actor's
+               self_x = st.clone(base_x);
+               self:build_item_list(occupant, self_x, false, nick, actor_nick, nil, reason);
+               self_p = st.clone(base_presence):add_child(self_x);
+       end
 
        -- General populance
        for nick, n_occupant in self:each_occupant() do
                if nick ~= occupant.nick then
                        local pr;
-                       if can_see_real_jids(whois, n_occupant) or occupant.bare_jid == n_occupant.bare_jid then
-                               pr = full_p;
+                       if can_see_real_jids(whois, n_occupant) then
+                               pr = get_full_p();
+                       elseif occupant.bare_jid == n_occupant.bare_jid then
+                               pr = self_p;
                        else
                                pr = get_anon_p();
                        end
@@ -243,17 +264,16 @@ function room_mt:publicise_occupant_status(occupant, base_x, nick, actor, reason
        end
 
        -- Presences for occupant itself
-       full_x:tag("status", {code = "110";}):up();
+       self_x:tag("status", {code = "110";}):up();
        if occupant.role == nil then
                -- They get an unavailable
-               self:route_to_occupant(occupant, full_p);
+               self:route_to_occupant(occupant, self_p);
        else
                -- use their own presences as templates
                for full_jid, pr in occupant:each_session() do
                        pr = st.clone(pr);
                        pr.attr.to = full_jid;
-                       -- You can always see your own full jids
-                       pr:add_child(full_x);
+                       pr:add_child(self_x);
                        self:route_stanza(pr);
                end
        end
@@ -745,10 +765,8 @@ function room_mt:handle_admin_query_get_command(origin, stanza)
                local affiliation_rank = valid_affiliations[affiliation];
                if affiliation_rank >= valid_affiliations.admin and affiliation_rank >= _aff_rank then
                        local reply = st.reply(stanza):query("http://jabber.org/protocol/muc#admin");
-                       for jid, affiliation in pairs(self._affiliations) do
-                               if affiliation == _aff then
-                                       reply:tag("item", {affiliation = _aff, jid = jid}):up();
-                               end
+                       for jid in self:each_affiliation(_aff or "none") do
+                               reply:tag("item", {affiliation = _aff, jid = jid}):up();
                        end
                        origin.send(reply:up());
                        return true;
@@ -987,10 +1005,28 @@ function room_mt:get_affiliation(jid)
        return result;
 end
 
+-- Iterates over jid, affiliation pairs
+function room_mt:each_affiliation(with_affiliation)
+       if not with_affiliation then
+               return pairs(self._affiliations);
+       else
+               return function(_affiliations, jid)
+                       local affiliation;
+                       repeat -- Iterate until we get a match
+                               jid, affiliation = next(_affiliations, jid);
+                       until jid == nil or affiliation == with_affiliation
+                       return jid, affiliation;
+               end, self._affiliations, nil
+       end
+end
+
 function room_mt:set_affiliation(actor, jid, affiliation, reason)
        if not actor then return nil, "modify", "not-acceptable"; end;
 
-       jid = jid_bare(jid);
+       local node, host, resource = jid_split(jid);
+       if not host then return nil, "modify", "not-acceptable"; end
+       jid = jid_join(node, host); -- Bare
+       local is_host_only = node == nil;
 
        if valid_affiliations[affiliation or "none"] == nil then
                return nil, "modify", "not-acceptable";
@@ -1000,13 +1036,17 @@ function room_mt:set_affiliation(actor, jid, affiliation, reason)
        local target_affiliation = self._affiliations[jid]; -- Raw; don't want to check against host
        local is_downgrade = valid_affiliations[target_affiliation or "none"] > valid_affiliations[affiliation or "none"];
 
-       if actor ~= true then
+       if actor == true then
+               actor = nil -- So we can pass it safely to 'publicise_occupant_status' below
+       else
                local actor_affiliation = self:get_affiliation(actor);
                if actor_affiliation == "owner" then
                        if jid_bare(actor) == jid then -- self change
                                -- need at least one owner
                                local is_last = true;
-                               for j, aff in pairs(self._affiliations) do if j ~= jid and aff == "owner" then is_last = false; break; end end
+                               for j in self:each_affiliation("owner") do
+                                       if j ~= jid then is_last = false; break; end
+                               end
                                if is_last then
                                        return nil, "cancel", "conflict";
                                end
@@ -1028,7 +1068,10 @@ function room_mt:set_affiliation(actor, jid, affiliation, reason)
        local role_rank = valid_roles[role or "none"];
        local occupants_updated = {}; -- Filled with old roles
        for nick, occupant in self:each_occupant() do
-               if occupant.bare_jid == jid then
+               if occupant.bare_jid == jid or (
+                       -- Outcast can be by host.
+                       is_host_only and affiliation == "outcast" and select(2, jid_split(occupant.bare_jid)) == host
+               ) then
                        -- need to publcize in all cases; as affiliation in <item/> has changed.
                        occupants_updated[occupant] = occupant.role;
                        if occupant.role ~= role and (
@@ -1098,7 +1141,9 @@ function room_mt:set_role(actor, occupant_jid, role, reason)
        end
        role = role ~= "none" and role or nil; -- coerces `role == false` to `nil`
 
-       if actor ~= true then
+       if actor == true then
+               actor = nil -- So we can pass it safely to 'publicise_occupant_status' below
+       else
                -- Can't do anything to other owners or admins
                local occupant_affiliation = self:get_affiliation(occupant.bare_jid);
                if occupant_affiliation == "owner" and occupant_affiliation == "admin" then