mod_saslauth, mod_tls: minor code cleanup
[prosody.git] / plugins / mod_saslauth.lua
index dd268555d793ae52ac87afb1556654ba01eb4089..df326f7046d55e018148b64e34cadac2256002dd 100644 (file)
@@ -1,12 +1,33 @@
+-- Prosody IM v0.2
+-- Copyright (C) 2008 Matthew Wild
+-- Copyright (C) 2008 Waqas Hussain
+-- 
+-- This program is free software; you can redistribute it and/or
+-- modify it under the terms of the GNU General Public License
+-- as published by the Free Software Foundation; either version 2
+-- of the License, or (at your option) any later version.
+-- 
+-- This program is distributed in the hope that it will be useful,
+-- but WITHOUT ANY WARRANTY; without even the implied warranty of
+-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+-- GNU General Public License for more details.
+-- 
+-- You should have received a copy of the GNU General Public License
+-- along with this program; if not, write to the Free Software
+-- Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+--
+
+
 
 local st = require "util.stanza";
-local send = require "core.sessionmanager".send_to_session;
 local sm_bind_resource = require "core.sessionmanager".bind_resource;
-local jid
+local base64 = require "util.encodings".base64;
 
 local usermanager_validate_credentials = require "core.usermanager".validate_credentials;
 local t_concat, t_insert = table.concat, table.insert;
 local tostring = tostring;
+local jid_split = require "util.jid".split
+local md5 = require "util.hashes".md5;
 
 local log = require "util.logger".init("mod_saslauth");
 
@@ -16,14 +37,17 @@ local xmlns_stanzas ='urn:ietf:params:xml:ns:xmpp-stanzas';
 
 local new_sasl = require "util.sasl".new;
 
-local function build_reply(status, ret)
+local function build_reply(status, ret, err_msg)
        local reply = st.stanza(status, {xmlns = xmlns_sasl});
        if status == "challenge" then
-               reply:text(ret or "");
+               log("challenge", ret or "");
+               reply:text(base64.encode(ret or ""));
        elseif status == "failure" then
                reply:tag(ret):up();
+               if err_msg then reply:tag("text"):text(err_msg); end
        elseif status == "success" then
-               reply:text(ret or "");
+               log("success", ret or "");
+               reply:text(base64.encode(ret or ""));
        else
                error("Unknown sasl status: "..status);
        end
@@ -34,104 +58,78 @@ local function handle_status(session, status)
        if status == "failure" then
                session.sasl_handler = nil;
        elseif status == "success" then
+               if not session.sasl_handler.username then error("SASL succeeded but we didn't get a username!"); end -- TODO move this to sessionmanager
+               sessionmanager.make_authenticated(session, session.sasl_handler.username);
                session.sasl_handler = nil;
                session:reset_stream();
        end
 end
 
-local function password_callback(jid, mechanism)
-       local node, host = jid_split(jid);
+local function password_callback(node, host, mechanism, decoder)
        local password = (datamanager.load(node, host, "accounts") or {}).password; -- FIXME handle hashed passwords
        local func = function(x) return x; end;
        if password then
                if mechanism == "PLAIN" then
                        return func, password;
                elseif mechanism == "DIGEST-MD5" then
-                       return func, require "hashes".md5(node.."::"..password);
+                       if decoder then node, host, password = decoder(node), decoder(host), decoder(password); end
+                       return func, md5(node..":"..host..":"..password);
                end
        end
        return func, nil;
 end
 
-add_handler("c2s_unauthed", "auth", xmlns_sasl,
-               function (session, stanza)
-                       if not session.sasl_handler then
-                               session.sasl_handler = new_sasl(stanza.attr.mechanism, session.host, password_callback);
-                               local status, ret = session.sasl_handler:feed(stanza[1]);
-                               handle_status(session, status);
-                               session.send(build_reply(status, ret));
-                               --[[session.sasl_handler = new_sasl(stanza.attr.mechanism, 
-                                       function (username, password)
-                                               -- onAuth
-                                               require "core.usermanager"
-                                               if usermanager_validate_credentials(session.host, username, password) then
-                                                       return true;
-                                               end
-                                               return false;
-                                       end,
-                                       function (username)
-                                               -- onSuccess
-                                               local success, err = sessionmanager.make_authenticated(session, username);
-                                               if not success then
-                                                       sessionmanager.destroy_session(session);
-                                                       return;
-                                               end
-                                               session.sasl_handler = nil;
-                                               session:reset_stream();
-                                       end,
-                                       function (reason)
-                                               -- onFail
-                                               log("debug", "SASL failure, reason: %s", reason);
-                                       end,
-                                       function (stanza)
-                                               -- onWrite
-                                               log("debug", "SASL writes: %s", tostring(stanza));
-                                               send(session, stanza);
-                                       end
-                               );
-                               session.sasl_handler:feed(stanza);      ]]
+local function sasl_handler(session, stanza)
+       if stanza.name == "auth" then
+               -- FIXME ignoring duplicates because ejabberd does
+               session.sasl_handler = new_sasl(stanza.attr.mechanism, session.host, password_callback);
+       elseif not session.sasl_handler then
+               return; -- FIXME ignoring out of order stanzas because ejabberd does
+       end
+       local text = stanza[1];
+       if text then
+               text = base64.decode(text);
+               log("recieved", text);
+               if not text then
+                       session.sasl_handler = nil;
+                       session.send(build_reply("failure", "incorrect-encoding"));
+                       return;
+               end
+       end
+       local status, ret, err_msg = session.sasl_handler:feed(text);
+       handle_status(session, status);
+       local s = build_reply(status, ret, err_msg); 
+       log("debug", "sasl reply: "..tostring(s));
+       session.send(s);
+end
+
+module:add_handler("c2s_unauthed", "auth", xmlns_sasl, sasl_handler);
+module:add_handler("c2s_unauthed", "abort", xmlns_sasl, sasl_handler);
+module:add_handler("c2s_unauthed", "response", xmlns_sasl, sasl_handler);
+
+local mechanisms_attr = { xmlns='urn:ietf:params:xml:ns:xmpp-sasl' };
+local bind_attr = { xmlns='urn:ietf:params:xml:ns:xmpp-bind' };
+local xmpp_session_attr = { xmlns='urn:ietf:params:xml:ns:xmpp-session' };
+module:add_event_hook("stream-features", 
+               function (session, features)                                                                                            
+                       if not session.username then
+                               features:tag("mechanisms", mechanisms_attr);
+                               -- TODO: Provide PLAIN only if TLS is active, this is a SHOULD from the introduction of RFC 4616. This behavior could be overridden via configuration but will issuing a warning or so.
+                                       features:tag("mechanism"):text("PLAIN"):up();
+                                       features:tag("mechanism"):text("DIGEST-MD5"):up();
+                               features:up();
                        else
-                               error("Client tried to negotiate SASL again", 0);
+                               features:tag("bind", bind_attr):tag("required"):up():up();
+                               features:tag("session", xmpp_session_attr):up();
                        end
                end);
-
-add_handler("c2s_unauthed", "abort", xmlns_sasl,
-       function(session, stanza)
-               if not session.sasl_handler then error("Attempt to abort when sasl has not started"); end
-               local status, ret = session.sasl_handler:feed(stanza[1]);
-               handle_status(session, status);
-               session.send(build_reply(status, ret));
-       end);
-
-add_handler("c2s_unauthed", "response", xmlns_sasl,
-       function(session, stanza)
-               if not session.sasl_handler then error("Attempt to respond when sasl has not started"); end
-               local status, ret = session.sasl_handler:feed(stanza[1]);
-               handle_status(session, status);
-               session.send(build_reply(status, ret));
-       end);
-               
-add_event_hook("stream-features", 
-                                       function (session, features)                                                                                            
-                                               if not session.username then
-                                                       t_insert(features, "<mechanisms xmlns='urn:ietf:params:xml:ns:xmpp-sasl'>");
-                                                               t_insert(features, "<mechanism>PLAIN</mechanism>");
-                                                               t_insert(features, "<mechanism>DIGEST-MD5</mechanism>");
-                                                       t_insert(features, "</mechanisms>");
-                                               else
-                                                       t_insert(features, "<bind xmlns='urn:ietf:params:xml:ns:xmpp-bind'><required/></bind>");
-                                                       t_insert(features, "<session xmlns='urn:ietf:params:xml:ns:xmpp-session'/>");
-                                               end
-                                               --send [[<register xmlns="http://jabber.org/features/iq-register"/> ]]
-                                       end);
                                        
-add_iq_handler("c2s", "urn:ietf:params:xml:ns:xmpp-bind", 
+module:add_iq_handler("c2s", "urn:ietf:params:xml:ns:xmpp-bind", 
                function (session, stanza)
                        log("debug", "Client tried to bind to a resource");
                        local resource;
                        if stanza.attr.type == "set" then
                                local bind = stanza.tags[1];
-                               
                                if bind and bind.attr.xmlns == xmlns_bind then
                                        resource = bind:child_with_name("resource");
                                        if resource then
@@ -139,31 +137,18 @@ add_iq_handler("c2s", "urn:ietf:params:xml:ns:xmpp-bind",
                                        end
                                end
                        end
-                       local success, err = sm_bind_resource(session, resource);
+                       local success, err_type, err, err_msg = sm_bind_resource(session, resource);
                        if not success then
-                               local reply = st.reply(stanza);
-                               reply.attr.type = "error";
-                               if err == "conflict" then
-                                       reply:tag("error", { type = "modify" })
-                                               :tag("conflict", { xmlns = xmlns_stanzas });
-                               elseif err == "constraint" then
-                                       reply:tag("error", { type = "cancel" })
-                                               :tag("resource-constraint", { xmlns = xmlns_stanzas });
-                               elseif err == "auth" then
-                                       reply:tag("error", { type = "cancel" })
-                                               :tag("not-allowed", { xmlns = xmlns_stanzas });
-                               end
-                               send(session, reply);
+                               session.send(st.error_reply(stanza, err_type, err, err_msg));
                        else
-                               local reply = st.reply(stanza);
-                               reply:tag("bind", { xmlns = xmlns_bind})
-                                       :tag("jid"):text(session.full_jid);
-                               send(session, reply);
+                               session.send(st.reply(stanza)
+                                       :tag("bind", { xmlns = xmlns_bind})
+                                       :tag("jid"):text(session.full_jid));
                        end
                end);
                
-add_iq_handler("c2s", "urn:ietf:params:xml:ns:xmpp-session", 
+module:add_iq_handler("c2s", "urn:ietf:params:xml:ns:xmpp-session", 
                function (session, stanza)
                        log("debug", "Client tried to bind to a resource");
-                       send(session, st.reply(stanza));
+                       session.send(st.reply(stanza));
                end);