util.sasl_cyrus: Protect the call to cyrussasl.server_new properly.
[prosody.git] / plugins / mod_saslauth.lua
index 283f5e1db34009ce54d01accd48c413f5171114e..1143549a7e0d30b91fa0e29232b8b7c9db2f014a 100644 (file)
@@ -21,7 +21,7 @@ local usermanager_user_exists = require "core.usermanager".user_exists;
 local usermanager_get_password = require "core.usermanager".get_password;
 local t_concat, t_insert = table.concat, table.insert;
 local tostring = tostring;
-local jid_split = require "util.jid".split
+local jid_split = require "util.jid".split;
 local md5 = require "util.hashes".md5;
 local config = require "core.configmanager";
 
@@ -34,48 +34,59 @@ local xmlns_sasl ='urn:ietf:params:xml:ns:xmpp-sasl';
 local xmlns_bind ='urn:ietf:params:xml:ns:xmpp-bind';
 local xmlns_stanzas ='urn:ietf:params:xml:ns:xmpp-stanzas';
 
-local new_sasl
+local new_sasl;
 if sasl_backend == "cyrus" then
-       cyrus_new = require "util.sasl_cyrus".new;
-       new_sasl = function(realm)
-                       return cyrus_new(realm, module:get_option("cyrus_service_name") or "xmpp")
+       prosody.unlock_globals(); --FIXME: Figure out why this is needed and
+                                 -- why cyrussasl isn't caught by the sandbox
+       local ok, cyrus = pcall(require, "util.sasl_cyrus");
+       prosody.lock_globals();
+       if ok then
+               local cyrus_new = cyrus.new;
+               new_sasl = function(realm)
+                       return cyrus_new(realm, module:get_option("cyrus_service_name") or "xmpp");
                end
-else
-       if sasl_backend ~= "backend" then log("warning", "Unknown SASL backend %s", sasl_backend) end;
+       else
+               sasl_backend = "builtin";
+               module:log("warn", "Failed to load Cyrus SASL, falling back to builtin auth mechanisms");
+               module:log("debug", "Failed to load Cyrus because: %s", cyrus);
+       end
+end
+if not new_sasl then
+       if sasl_backend ~= "builtin" then module:log("warn", "Unknown SASL backend %s", sasl_backend); end;
        new_sasl = require "util.sasl".new;
 end
 
-default_authentication_profile = {
+local default_authentication_profile = {
        plain = function(username, realm)
-                       local prepped_username = nodeprep(username);
-                       if not prepped_username then
-                               log("debug", "NODEprep failed on username: %s", username);
-                               return "", nil;
-                       end
-                       local password = usermanager_get_password(prepped_username, realm);
-                       if not password then
-                               return "", nil;
-                       end
-                       return password, true;
+               local prepped_username = nodeprep(username);
+               if not prepped_username then
+                       log("debug", "NODEprep failed on username: %s", username);
+                       return "", nil;
+               end
+               local password = usermanager_get_password(prepped_username, realm);
+               if not password then
+                       return "", nil;
                end
+               return password, true;
+       end
 };
 
-anonymous_authentication_profile = {
+local anonymous_authentication_profile = {
        anonymous = function(username, realm)
-                       return true; -- for normal usage you should always return true here
-               end
-}
+               return true; -- for normal usage you should always return true here
+       end
+};
 
 local function build_reply(status, ret, err_msg)
        local reply = st.stanza(status, {xmlns = xmlns_sasl});
        if status == "challenge" then
-               log("debug", "%s", ret or "");
+               --log("debug", "CHALLENGE: %s", ret or "");
                reply:text(base64.encode(ret or ""));
        elseif status == "failure" then
                reply:tag(ret):up();
                if err_msg then reply:tag("text"):text(err_msg); end
        elseif status == "success" then
-               log("debug", "%s", ret or "");
+               --log("debug", "SUCCESS: %s", ret or "");
                reply:text(base64.encode(ret or ""));
        else
                module:log("error", "Unknown sasl status: %s", status);
@@ -123,7 +134,7 @@ local function sasl_handler(session, stanza)
        local text = stanza[1];
        if text then
                text = base64.decode(text);
-               log("debug", "%s", text:gsub("[%z\001-\008\011\012\014-\031]", " "));
+               --log("debug", "AUTH: %s", text:gsub("[%z\001-\008\011\012\014-\031]", " "));
                if not text then
                        session.sasl_handler = nil;
                        session.send(build_reply("failure", "incorrect-encoding"));
@@ -144,56 +155,55 @@ module:add_handler("c2s_unauthed", "response", xmlns_sasl, sasl_handler);
 local mechanisms_attr = { xmlns='urn:ietf:params:xml:ns:xmpp-sasl' };
 local bind_attr = { xmlns='urn:ietf:params:xml:ns:xmpp-bind' };
 local xmpp_session_attr = { xmlns='urn:ietf:params:xml:ns:xmpp-session' };
-module:add_event_hook("stream-features",
-               function (session, features)
-                       if not session.username then
-                               if secure_auth_only and not session.secure then
-                                       return;
-                               end
-                               if module:get_option("anonymous_login") then
-                                       session.sasl_handler = new_sasl(session.host, anonymous_authentication_profile);
-                               else
-                                       session.sasl_handler = new_sasl(session.host, default_authentication_profile);
-                                       if not (module:get_option("allow_unencrypted_plain_auth")) and not session.secure then
-                                               session.sasl_handler:forbidden({"PLAIN"});
-                                       end
-                               end
-                               features:tag("mechanisms", mechanisms_attr);
-                               for k, v in pairs(session.sasl_handler:mechanisms()) do
-                                       features:tag("mechanism"):text(v):up();
-                               end
-                               features:up();
-                       else
-                               features:tag("bind", bind_attr):tag("required"):up():up();
-                               features:tag("session", xmpp_session_attr):tag("optional"):up():up();
-                       end
-               end);
-
-module:add_iq_handler("c2s", "urn:ietf:params:xml:ns:xmpp-bind",
-               function (session, stanza)
-                       log("debug", "Client requesting a resource bind");
-                       local resource;
-                       if stanza.attr.type == "set" then
-                               local bind = stanza.tags[1];
-                               if bind and bind.attr.xmlns == xmlns_bind then
-                                       resource = bind:child_with_name("resource");
-                                       if resource then
-                                               resource = resource[1];
-                                       end
-                               end
+module:hook("stream-features", function(event)
+       local origin, features = event.origin, event.features;
+       if not origin.username then
+               if secure_auth_only and not origin.secure then
+                       return;
+               end
+               local realm = module:get_option("sasl_realm") or origin.host;
+               if module:get_option("anonymous_login") then
+                       origin.sasl_handler = new_sasl(realm, anonymous_authentication_profile);
+               else
+                       origin.sasl_handler = new_sasl(realm, default_authentication_profile);
+                       if not (module:get_option("allow_unencrypted_plain_auth")) and not origin.secure then
+                               origin.sasl_handler:forbidden({"PLAIN"});
                        end
-                       local success, err_type, err, err_msg = sm_bind_resource(session, resource);
-                       if not success then
-                               session.send(st.error_reply(stanza, err_type, err, err_msg));
-                       else
-                               session.send(st.reply(stanza)
-                                       :tag("bind", { xmlns = xmlns_bind})
-                                       :tag("jid"):text(session.full_jid));
+               end
+               features:tag("mechanisms", mechanisms_attr);
+               for k, v in pairs(origin.sasl_handler:mechanisms()) do
+                       features:tag("mechanism"):text(v):up();
+               end
+               features:up();
+       else
+               features:tag("bind", bind_attr):tag("required"):up():up();
+               features:tag("session", xmpp_session_attr):tag("optional"):up():up();
+       end
+end);
+
+module:add_iq_handler("c2s", "urn:ietf:params:xml:ns:xmpp-bind", function(session, stanza)
+       log("debug", "Client requesting a resource bind");
+       local resource;
+       if stanza.attr.type == "set" then
+               local bind = stanza.tags[1];
+               if bind and bind.attr.xmlns == xmlns_bind then
+                       resource = bind:child_with_name("resource");
+                       if resource then
+                               resource = resource[1];
                        end
-               end);
+               end
+       end
+       local success, err_type, err, err_msg = sm_bind_resource(session, resource);
+       if not success then
+               session.send(st.error_reply(stanza, err_type, err, err_msg));
+       else
+               session.send(st.reply(stanza)
+                       :tag("bind", { xmlns = xmlns_bind})
+                       :tag("jid"):text(session.full_jid));
+       end
+end);
 
-module:add_iq_handler("c2s", "urn:ietf:params:xml:ns:xmpp-session",
-               function (session, stanza)
-                       log("debug", "Client requesting a session");
-                       session.send(st.reply(stanza));
-               end);
+module:add_iq_handler("c2s", "urn:ietf:params:xml:ns:xmpp-session", function(session, stanza)
+       log("debug", "Client requesting a session");
+       session.send(st.reply(stanza));
+end);