tools/ejabberd2prosody: Disable generating a config, as the format it generates is...
[prosody.git] / plugins / mod_dialback.lua
index e578c4129e55dd688f6d6851a87fc658ad15b729..9dcb0ed53112d73f9e4d4460f1c17260b68be2d0 100644 (file)
@@ -6,18 +6,15 @@
 -- COPYING file in the source package for more information.
 --
 
-local format = string.format;
-
 local hosts = _G.hosts;
-local s2s_make_authenticated = require "core.s2smanager".make_authenticated;
 
 local log = module._log;
 
 local st = require "util.stanza";
 local sha256_hash = require "util.hashes".sha256;
+local nameprep = require "util.encodings".stringprep.nameprep;
 
 local xmlns_stream = "http://etherx.jabber.org/streams";
-local xmlns_dialback = "jabber:server:dialback";
 
 local dialback_requests = setmetatable({}, { __mode = 'v' });
 
@@ -28,7 +25,7 @@ end
 function initiate_dialback(session)
        -- generate dialback key
        session.dialback_key = generate_dialback(session.streamid, session.to_host, session.from_host);
-       session.sends2s(format("<db:result from='%s' to='%s'>%s</db:result>", session.from_host, session.to_host, session.dialback_key));
+       session.sends2s(st.stanza("db:result", { from = session.from_host, to = session.to_host }):text(session.dialback_key));
        session.log("info", "sent dialback key on outgoing s2s stream");
 end
 
@@ -43,6 +40,11 @@ module:hook("stanza/jabber:server:dialback:verify", function(event)
                -- We are being asked to verify the key, to ensure it was generated by us
                origin.log("debug", "verifying that dialback key is ours...");
                local attr = stanza.attr;
+               if attr.type then
+                       module:log("warn", "Ignoring incoming session from %s claiming a dialback key for %s is %s",
+                               origin.from_host or "(unknown)", attr.from or "(unknown)", attr.type);
+                       return true;
+               end
                -- COMPAT: Grr, ejabberd breaks this one too?? it is black and white in XEP-220 example 34
                --if attr.from ~= origin.to_host then error("invalid-from"); end
                local type;
@@ -65,28 +67,35 @@ module:hook("stanza/jabber:server:dialback:result", function(event)
                -- he wants to be identified through dialback
                -- We need to check the key with the Authoritative server
                local attr = stanza.attr;
-               origin.hosts[attr.from] = { dialback_key = stanza[1] };
+               local to, from = nameprep(attr.to), nameprep(attr.from);
                
-               if not hosts[attr.to] then
+               if not hosts[to] then
                        -- Not a host that we serve
-                       origin.log("info", "%s tried to connect to %s, which we don't serve", attr.from, attr.to);
+                       origin.log("info", "%s tried to connect to %s, which we don't serve", from, to);
                        origin:close("host-unknown");
                        return true;
+               elseif not from then
+                       origin:close("improper-addressing");
                end
                
-               dialback_requests[attr.from.."/"..origin.streamid] = origin;
+               origin.hosts[from] = { dialback_key = stanza[1] };
                
+               dialback_requests[from.."/"..origin.streamid] = origin;
+               
+               -- COMPAT: ejabberd, gmail and perhaps others do not always set 'to' and 'from'
+               -- on streams. We fill in the session's to/from here instead.
                if not origin.from_host then
-                       -- Just used for friendlier logging
-                       origin.from_host = attr.from;
+                       origin.from_host = from;
                end
                if not origin.to_host then
-                       -- Just used for friendlier logging
-                       origin.to_host = attr.to;
+                       origin.to_host = to;
                end
-               
-               origin.log("debug", "asking %s if key %s belongs to them", attr.from, stanza[1]);
-               origin.send(st.stanza("db:verify", { from = attr.to, to = attr.from, id = origin.streamid }):text(stanza[1]));
+
+               origin.log("debug", "asking %s if key %s belongs to them", from, stanza[1]);
+               module:fire_event("route/remote", {
+                       from_host = to, to_host = from;
+                       stanza = st.stanza("db:verify", { from = to, to = from, id = origin.streamid }):text(stanza[1]);
+               });
                return true;
        end
 end);
@@ -97,18 +106,17 @@ module:hook("stanza/jabber:server:dialback:verify", function(event)
        if origin.type == "s2sout_unauthed" or origin.type == "s2sout" then
                local attr = stanza.attr;
                local dialback_verifying = dialback_requests[attr.from.."/"..(attr.id or "")];
-               module:log("debug", tostring(dialback_verifying).." "..attr.from.." "..origin.to_host);
                if dialback_verifying and attr.from == origin.to_host then
                        local valid;
                        if attr.type == "valid" then
-                               s2s_make_authenticated(dialback_verifying, attr.from);
+                               module:fire_event("s2s-authenticated", { session = dialback_verifying, host = attr.from });
                                valid = "valid";
                        else
                                -- Warn the original connection that is was not verified successfully
-                               log("warn", "authoritative server for "..(attr.from or "(unknown)").." denied the key");
+                               log("warn", "authoritative server for %s denied the key", attr.from or "(unknown)");
                                valid = "invalid";
                        end
-                       if not dialback_verifying.sends2s then
+                       if dialback_verifying.destroyed then
                                log("warn", "Incoming s2s session %s was closed in the meantime, so we can't notify it of the db result", tostring(dialback_verifying):match("%w+$"));
                        else
                                dialback_verifying.sends2s(
@@ -137,7 +145,7 @@ module:hook("stanza/jabber:server:dialback:result", function(event)
                        return true;
                end
                if stanza.attr.type == "valid" then
-                       s2s_make_authenticated(origin, attr.from);
+                       module:fire_event("s2s-authenticated", { session = origin, host = attr.from });
                else
                        origin:close("not-authorized", "dialback authentication failed");
                end
@@ -161,7 +169,7 @@ module:hook_stanza(xmlns_stream, "features", function (origin, stanza)
        end
 end, 100);
 
-module:hook("s2s-authenticate-legacy", function (event)
+module:hook("s2sout-authenticate-legacy", function (event)
        module:log("debug", "Initiating dialback...");
        initiate_dialback(event.origin);
        return true;