usermanager, mod_auth_internal_hashed, mod_legacyauth: New order of parameters for...

[prosody.git] / plugins / mod_compression.lua

diff --git a/plugins/mod_compression.lua b/plugins/mod_compression.lua
index 533414924af23973fa8b1f4051d024369d217e30..d890931fe8bce1f5e2001208efc3932b31dadb9e 100644 (file)
--- a/plugins/mod_compression.lua
+++ b/plugins/mod_compression.lua
@@ -14,6 +14,7 @@ local xmlns_compression_feature = "http://jabber.org/features/compress"
 local xmlns_compression_protocol = "http://jabber.org/protocol/compress"
 local xmlns_stream = "http://etherx.jabber.org/streams";
 local compression_stream_feature = st.stanza("compression", {xmlns=xmlns_compression_feature}):tag("method"):text("zlib"):up();
+local add_filter = require "util.filters".add_filter;
 
 local compression_level = module:get_option("compression_level");
 -- if not defined assume admin wants best compression
@@ -94,43 +95,36 @@ end
 
 -- setup compression for a stream
 local function setup_compression(session, deflate_stream)
-       local old_send = (session.sends2s or session.send);
-       
-       local new_send = function(t)
-                       --TODO: Better code injection in the sending process
-                       local status, compressed, eof = pcall(deflate_stream, tostring(t), 'sync');
-                       if status == false then
-                               session:close({
-                                       condition = "undefined-condition";
-                                       text = compressed;
-                                       extra = st.stanza("failure", {xmlns="http://jabber.org/protocol/compress"}):tag("processing-failed");
-                               });
-                               module:log("warn", "%s", tostring(compressed));
-                               return;
-                       end
-                       session.conn:write(compressed);
-               end;
-       
-       if session.sends2s then session.sends2s = new_send
-       elseif session.send then session.send = new_send end
+       add_filter(session, "bytes/out", function(t)
+               local status, compressed, eof = pcall(deflate_stream, tostring(t), 'sync');
+               if status == false then
+                       module:log("warn", "%s", tostring(compressed));
+                       session:close({
+                               condition = "undefined-condition";
+                               text = compressed;
+                               extra = st.stanza("failure", {xmlns="http://jabber.org/protocol/compress"}):tag("processing-failed");
+                       });
+                       return;
+               end
+               return compressed;
+       end);   
 end
 
 -- setup decompression for a stream
 local function setup_decompression(session, inflate_stream)
-       local old_data = session.data
-       session.data = function(conn, data)
-                       local status, decompressed, eof = pcall(inflate_stream, data);
-                       if status == false then
-                               session:close({
-                                       condition = "undefined-condition";
-                                       text = decompressed;
-                                       extra = st.stanza("failure", {xmlns="http://jabber.org/protocol/compress"}):tag("processing-failed");
-                               });
-                               module:log("warn", "%s", tostring(decompressed));
-                               return;
-                       end
-                       old_data(conn, decompressed);
-               end;
+       add_filter(session, "bytes/in", function(data)
+               local status, decompressed, eof = pcall(inflate_stream, data);
+               if status == false then
+                       module:log("warn", "%s", tostring(decompressed));
+                       session:close({
+                               condition = "undefined-condition";
+                               text = decompressed;
+                               extra = st.stanza("failure", {xmlns="http://jabber.org/protocol/compress"}):tag("processing-failed");
+                       });
+                       return;
+               end
+               return decompressed;
+       end);
 end
 
 module:add_handler({"s2sout_unauthed", "s2sout"}, "compressed", xmlns_compression_protocol, 
@@ -148,12 +142,6 @@ module:add_handler({"s2sout_unauthed", "s2sout"}, "compressed", xmlns_compressio
                                
                        -- setup decompression for session.data
                        setup_decompression(session, inflate_stream);
-                       local session_reset_stream = session.reset_stream;
-                       session.reset_stream = function(session)
-                                       session_reset_stream(session);
-                                       setup_decompression(session, inflate_stream);
-                                       return true;
-                               end;
                        session:reset_stream();
                        local default_stream_attr = {xmlns = "jabber:server", ["xmlns:stream"] = "http://etherx.jabber.org/streams",
                                                                                ["xmlns:db"] = 'jabber:server:dialback', version = "1.0", to = session.to_host, from = session.from_host};
@@ -195,12 +183,6 @@ module:add_handler({"c2s_unauthed", "c2s", "s2sin_unauthed", "s2sin"}, "compress
                                -- setup decompression for session.data
                                setup_decompression(session, inflate_stream);
                                
-                               local session_reset_stream = session.reset_stream;
-                               session.reset_stream = function(session)
-                                               session_reset_stream(session);
-                                               setup_decompression(session, inflate_stream);
-                                               return true;
-                                       end;
                                session.compressed = true;
                        elseif method then
                                session.log("debug", "%s compression selected, but we don't support it.", tostring(method));