Merge 0.8->trunk
[prosody.git] / plugins / mod_bosh.lua
index 2ea8e0a019f2c231847de2c657a98b63afbc6a90..a6b84367a392703956f2886d6589f1f2a944682d 100644 (file)
@@ -10,7 +10,7 @@ module.host = "*" -- Global module
 
 local hosts = _G.hosts;
 local lxp = require "lxp";
-local init_xmlhandlers = require "core.xmlhandlers"
+local new_xmpp_stream = require "util.xmppstream".new;
 local httpserver = require "net.httpserver";
 local sm = require "core.sessionmanager";
 local sm_destroy_session = sm.destroy_session;
@@ -33,7 +33,6 @@ local BOSH_DEFAULT_HOLD = tonumber(module:get_option("bosh_default_hold")) or 1;
 local BOSH_DEFAULT_INACTIVITY = tonumber(module:get_option("bosh_max_inactivity")) or 60;
 local BOSH_DEFAULT_POLLING = tonumber(module:get_option("bosh_max_polling")) or 5;
 local BOSH_DEFAULT_REQUESTS = tonumber(module:get_option("bosh_max_requests")) or 2;
-local BOSH_DEFAULT_MAXPAUSE = tonumber(module:get_option("bosh_max_pause")) or 300;
 
 local consider_bosh_secure = module:get_option_boolean("consider_bosh_secure");
 
@@ -119,12 +118,19 @@ function handle_request(method, body, request)
        request.log = log;
        request.on_destroy = on_destroy_request;
        
-       local parser = lxp.new(init_xmlhandlers(request, stream_callbacks), "\1");
-       
-       parser:parse(body);
+       local stream = new_xmpp_stream(request, stream_callbacks);
+       -- stream:feed() calls the stream_callbacks, so all stanzas in
+       -- the body are processed in this next line before it returns.
+       stream:feed(body);
        
        local session = sessions[request.sid];
        if session then
+               -- Session was marked as inactive, since we have
+               -- a request open now, unmark it
+               if inactive_sessions[session] and #session.requests > 0 then
+                       inactive_sessions[session] = nil;
+               end
+
                local r = session.requests;
                log("debug", "Session %s has %d out of %d requests open", request.sid, #r, session.bosh_hold);
                log("debug", "and there are %d things in the send_buffer", #session.send_buffer);
@@ -154,14 +160,15 @@ function handle_request(method, body, request)
                                request.reply_before = os_time() + session.bosh_wait;
                                waiting_requests[request] = true;
                        end
-                       if inactive_sessions[session] then
-                               -- Session was marked as inactive, since we have
-                               -- a request open now, unmark it
-                               inactive_sessions[session] = nil;
-                       end
                end
                
-               return true; -- Inform httpserver we shall reply later
+               if session.bosh_terminate then
+                       session.log("debug", "Closing session with %d requests open", #session.requests);
+                       session:close();
+                       return nil;
+               else
+                       return true; -- Inform httpserver we shall reply later
+               end
        end
 end
 
@@ -201,7 +208,6 @@ local function bosh_close_stream(session, reason)
 
        local session_close_response = { headers = default_headers, body = tostring(close_reply) };
 
-       --FIXME: Quite sure we shouldn't reply to all requests with the error
        for _, held_request in ipairs(session.requests) do
                held_request:send(session_close_response);
                held_request:destroy();
@@ -254,7 +260,13 @@ function stream_callbacks.streamopened(request, attr)
                        local oldest_request = r[1];
                        if oldest_request then
                                log("debug", "We have an open request, so sending on that");
-                               response.body = t_concat{"<body xmlns='http://jabber.org/protocol/httpbind' sid='", sid, "' xmlns:stream = 'http://etherx.jabber.org/streams'>", tostring(s), "</body>" };
+                               response.body = t_concat({
+                                       "<body xmlns='http://jabber.org/protocol/httpbind' ",
+                                       session.bosh_terminate and "type='terminate' " or "",
+                                       "sid='", sid, "' xmlns:stream = 'http://etherx.jabber.org/streams'>",
+                                       tostring(s),
+                                       "</body>"
+                               });
                                oldest_request:send(response);
                                --log("debug", "Sent");
                                if oldest_request.stayopen then
@@ -273,6 +285,7 @@ function stream_callbacks.streamopened(request, attr)
                                t_insert(session.send_buffer, tostring(s));
                                log("debug", "There are now %d things in the send_buffer", #session.send_buffer);
                        end
+                       return true;
                end
                
                -- Send creation response
@@ -282,9 +295,17 @@ function stream_callbacks.streamopened(request, attr)
                fire_event("stream-features", session, features);
                --xmpp:version='1.0' xmlns:xmpp='urn:xmpp:xbosh'
                local response = st.stanza("body", { xmlns = xmlns_bosh,
-                                                                       inactivity = tostring(BOSH_DEFAULT_INACTIVITY), polling = tostring(BOSH_DEFAULT_POLLING), requests = tostring(BOSH_DEFAULT_REQUESTS), hold = tostring(session.bosh_hold), maxpause = "120",
-                                                                       sid = sid, authid = sid, ver  = '1.6', from = session.host, secure = 'true', ["xmpp:version"] = "1.0",
-                                                                       ["xmlns:xmpp"] = "urn:xmpp:xbosh", ["xmlns:stream"] = "http://etherx.jabber.org/streams" }):add_child(features);
+                       wait = attr.wait,
+                       inactivity = tostring(BOSH_DEFAULT_INACTIVITY),
+                       polling = tostring(BOSH_DEFAULT_POLLING),
+                       requests = tostring(BOSH_DEFAULT_REQUESTS),
+                       hold = tostring(session.bosh_hold),
+                       sid = sid, authid = sid,
+                       ver  = '1.6', from = session.host,
+                       secure = 'true', ["xmpp:version"] = "1.0",
+                       ["xmlns:xmpp"] = "urn:xmpp:xbosh",
+                       ["xmlns:stream"] = "http://etherx.jabber.org/streams"
+               }):add_child(features);
                request:send{ headers = default_headers, body = tostring(response) };
                
                request.sid = sid;
@@ -317,13 +338,6 @@ function stream_callbacks.streamopened(request, attr)
                session.rid = rid;
        end
        
-       if attr.type == "terminate" then
-               -- Client wants to end this session
-               session:close();
-               request.notopen = nil;
-               return;
-       end
-       
        if session.notopen then
                local features = st.stanza("stream:features");
                hosts[session.host].events.fire_event("stream-features", { origin = session, features = features });
@@ -332,6 +346,12 @@ function stream_callbacks.streamopened(request, attr)
                session.notopen = nil;
        end
        
+       if attr.type == "terminate" then
+               -- Client wants to end this session, which we'll do
+               -- after processing any stanzas in this request
+               session.bosh_terminate = true;
+       end
+
        request.notopen = nil; -- Signals that we accept this opening tag
        t_insert(session.requests, request);
        request.sid = sid;