Merge 0.9->0.10
[prosody.git] / plugins / adhoc / mod_adhoc.lua
index 69b2c8da9903e101afce81f053f4d00d7a0197d6..1c956021aaf19fddb91ad2f8c40b50d14896c8aa 100644 (file)
@@ -6,86 +6,90 @@
 --
 
 local st = require "util.stanza";
+local keys = require "util.iterators".keys;
+local array_collect = require "util.array".collect;
 local is_admin = require "core.usermanager".is_admin;
+local jid_split = require "util.jid".split;
 local adhoc_handle_cmd = module:require "adhoc".handle_cmd;
 local xmlns_cmd = "http://jabber.org/protocol/commands";
-local xmlns_disco = "http://jabber.org/protocol/disco";
 local commands = {};
 
 module:add_feature(xmlns_cmd);
 
-module:hook("iq/host/"..xmlns_disco.."#info:query", function (event)
-       local origin, stanza = event.origin, event.stanza;
-       local node = stanza.tags[1].attr.node;
-       if stanza.attr.type == "get" and node then
-               if commands[node] then
-                       local privileged = is_admin(stanza.attr.from, stanza.attr.to);
-                       if (commands[node].permission == "admin" and privileged)
-                           or (commands[node].permission == "user") then
-                               reply = st.reply(stanza);
-                               reply:tag("query", { xmlns = xmlns_disco.."#info",
-                                   node = node });
-                               reply:tag("identity", { name = commands[node].name,
-                                   category = "automation", type = "command-node" }):up();
-                               reply:tag("feature", { var = xmlns_cmd }):up();
-                               reply:tag("feature", { var = "jabber:x:data" }):up();
-                       else
-                               reply = st.error_reply(stanza, "auth", "forbidden", "This item is not available to you");
-                       end
-                       origin.send(reply);
-                       return true;
-               elseif node == xmlns_cmd then
-                       reply = st.reply(stanza);
-                       reply:tag("query", { xmlns = xmlns_disco.."#info",
-                           node = node });
-                       reply:tag("identity", { name = "Ad-Hoc Commands",
-                           category = "automation", type = "command-list" }):up();
-                       origin.send(reply);
+module:hook("host-disco-info-node", function (event)
+       local stanza, origin, reply, node = event.stanza, event.origin, event.reply, event.node;
+       if commands[node] then
+               local from = stanza.attr.from;
+               local privileged = is_admin(from, stanza.attr.to);
+               local global_admin = is_admin(from);
+               local username, hostname = jid_split(from);
+               local command = commands[node];
+               if (command.permission == "admin" and privileged)
+                   or (command.permission == "global_admin" and global_admin)
+                   or (command.permission == "local_user" and hostname == module.host)
+                   or (command.permission == "user") then
+                       reply:tag("identity", { name = command.name,
+                           category = "automation", type = "command-node" }):up();
+                       reply:tag("feature", { var = xmlns_cmd }):up();
+                       reply:tag("feature", { var = "jabber:x:data" }):up();
+                       event.exists = true;
+               else
+                       origin.send(st.error_reply(stanza, "auth", "forbidden", "This item is not available to you"));
                        return true;
-
                end
+       elseif node == xmlns_cmd then
+               reply:tag("identity", { name = "Ad-Hoc Commands",
+                   category = "automation", type = "command-list" }):up();
+                   event.exists = true;
        end
 end);
 
-module:hook("iq/host/"..xmlns_disco.."#items:query", function (event)
-       local origin, stanza = event.origin, event.stanza;
-       if stanza.attr.type == "get" and stanza.tags[1].attr.node
-           and stanza.tags[1].attr.node == xmlns_cmd then
-               local admin = is_admin(stanza.attr.from, stanza.attr.to);
-               local global_admin = is_admin(stanza.attr.from);
-               reply = st.reply(stanza);
-               reply:tag("query", { xmlns = xmlns_disco.."#items",
-                   node = xmlns_cmd });
-               for node, command in pairs(commands) do
-                       if (command.permission == "admin" and admin)
-                           or (command.permission == "global_admin" and global_admin)
-                           or (command.permission == "user") then
-                               reply:tag("item", { name = command.name,
-                                   node = node, jid = module:get_host() });
-                               reply:up();
-                       end
+module:hook("host-disco-items-node", function (event)
+       local stanza, origin, reply, node = event.stanza, event.origin, event.reply, event.node;
+       if node ~= xmlns_cmd then
+               return;
+       end
+
+       local from = stanza.attr.from;
+       local admin = is_admin(from, stanza.attr.to);
+       local global_admin = is_admin(from);
+       local username, hostname = jid_split(from);
+       local nodes = array_collect(keys(commands)):sort();
+       for _, node in ipairs(nodes) do
+               local command = commands[node];
+               if (command.permission == "admin" and admin)
+                   or (command.permission == "global_admin" and global_admin)
+                   or (command.permission == "local_user" and hostname == module.host)
+                   or (command.permission == "user") then
+                       reply:tag("item", { name = command.name,
+                           node = node, jid = module:get_host() });
+                       reply:up();
                end
-               origin.send(reply);
-               return true;
        end
-end, 500);
+       event.exists = true;
+end);
 
 module:hook("iq/host/"..xmlns_cmd..":command", function (event)
        local origin, stanza = event.origin, event.stanza;
        if stanza.attr.type == "set" then
                local node = stanza.tags[1].attr.node
-               if commands[node] then
-                       local admin = is_admin(stanza.attr.from, stanza.attr.to);
-                       local global_admin = is_admin(stanza.attr.from);
-                       if (commands[node].permission == "admin" and not admin)
-                           or (commands[node].permission == "global_admin" and not global_admin) then
+               local command = commands[node];
+               if command then
+                       local from = stanza.attr.from;
+                       local admin = is_admin(from, stanza.attr.to);
+                       local global_admin = is_admin(from);
+                       local username, hostname = jid_split(from);
+                       if (command.permission == "admin" and not admin)
+                           or (command.permission == "global_admin" and not global_admin)
+                           or (command.permission == "local_user" and hostname ~= module.host) then
                                origin.send(st.error_reply(stanza, "auth", "forbidden", "You don't have permission to execute this command"):up()
                                    :add_child(commands[node]:cmdtag("canceled")
                                        :tag("note", {type="error"}):text("You don't have permission to execute this command")));
                                return true
                        end
                        -- User has permission now execute the command
-                       return adhoc_handle_cmd(commands[node], origin, stanza);
+                       adhoc_handle_cmd(commands[node], origin, stanza);
+                       return true;
                end
        end
 end, 500);