Merge 0.9->0.10

[prosody.git] / plugins / adhoc / adhoc.lib.lua

diff --git a/plugins/adhoc/adhoc.lib.lua b/plugins/adhoc/adhoc.lib.lua
index d4ffd80ceee8b449201cc58a3e9344fbf24d8793..b544ddc8e4ac8ecee986adf2a9a2b94b1748daf0 100644 (file)
--- a/plugins/adhoc/adhoc.lib.lua
+++ b/plugins/adhoc/adhoc.lib.lua
@@ -12,7 +12,7 @@ local states = {}
 
 local _M = {};
 
-function _cmdtag(desc, status, sessionid, action)
+local function _cmdtag(desc, status, sessionid, action)
        local cmd = st.stanza("command", { xmlns = xmlns_cmd, node = desc.node, status = status });
        if sessionid then cmd.attr.sessionid = sessionid; end
        if action then cmd.attr.action = action; end
@@ -34,7 +34,7 @@ function _M.handle_cmd(command, origin, stanza)
 
        local data, state = command:handler(dataIn, states[sessionid]);
        states[sessionid] = state;
-       local stanza = st.reply(stanza);
+       local cmdtag;
        if data.status == "completed" then
                states[sessionid] = nil;
                cmdtag = command:cmdtag("completed", sessionid);
@@ -43,11 +43,12 @@ function _M.handle_cmd(command, origin, stanza)
                cmdtag = command:cmdtag("canceled", sessionid);
        elseif data.status == "error" then
                states[sessionid] = nil;
-               stanza = st.error_reply(stanza, data.error.type, data.error.condition, data.error.message);
-               origin.send(stanza);
+               local reply = st.error_reply(stanza, data.error.type, data.error.condition, data.error.message);
+               origin.send(reply);
                return true;
-       else 
+       else
                cmdtag = command:cmdtag("executing", sessionid);
+               data.actions = data.actions or { "complete" };
        end
 
        for name, content in pairs(data) do
@@ -57,14 +58,14 @@ function _M.handle_cmd(command, origin, stanza)
                        cmdtag:tag("note", {type="warn"}):text(content):up();
                elseif name == "error" then
                        cmdtag:tag("note", {type="error"}):text(content.message):up();
-               elseif name =="actions" then
-                       local actions = st.stanza("actions");
+               elseif name == "actions" then
+                       local actions = st.stanza("actions", { execute = content.default });
                        for _, action in ipairs(content) do
                                if (action == "prev") or (action == "next") or (action == "complete") then
                                        actions:tag(action):up();
                                else
-                                       module:log("error", 'Command "'..command.name..
-                                               '" at node "'..command.node..'" provided an invalid action "'..action..'"');
+                                       module:log("error", "Command %q at node %q provided an invalid action %q",
+                                               command.name, command.node, action);
                                end
                        end
                        cmdtag:add_child(actions);
@@ -76,8 +77,9 @@ function _M.handle_cmd(command, origin, stanza)
                        cmdtag:add_child(content);
                end
        end
-       stanza:add_child(cmdtag);
-       origin.send(stanza);
+       local reply = st.reply(stanza);
+       reply:add_child(cmdtag);
+       origin.send(reply);
 
        return true;
 end