projects / prosody.git / blobdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | inline | side by side
s2smanager: Whitespace
[prosody.git] / net / httpserver.lua
diff --git a/net/httpserver.lua b/net/httpserver.lua
index 699e0324dfcb35565fd5a3e46bd3ad6c61421292..6273bbb9ce690669f37a03848fdc85c2ad72e5d6 100644 (file)
--- a/net/httpserver.lua
+++ b/net/httpserver.lua
@@ -37,6 +37,7 @@ local function send_response(request, response)
        -- Write status line
        local resp;
        if response.body then
+               local body = tostring(response.body);
                log("debug", "Sending response to %s", request.id);
                resp = { "HTTP/1.0 ", response.status or "200 OK", "\r\n"};
                local h = response.headers;
@@ -48,22 +49,23 @@ local function send_response(request, response)
                                t_insert(resp, "\r\n");
                        end
                end
-               if response.body and not (h and h["Content-Length"]) then
+               if not (h and h["Content-Length"]) then
                        t_insert(resp, "Content-Length: ");
-                       t_insert(resp, #response.body);
+                       t_insert(resp, #body);
                        t_insert(resp, "\r\n");
                end
                t_insert(resp, "\r\n");
                
-               if response.body and request.method ~= "HEAD" then
-                       t_insert(resp, response.body);
+               if request.method ~= "HEAD" then
+                       t_insert(resp, body);
                end
        else
                -- Response we have is just a string (the body)
-               log("debug", "Sending response to %s: %s", request.id or "<none>", response or "<none>");
+               log("debug", "Sending 200 response to %s", request.id or "<none>");
                
                resp = { "HTTP/1.0 200 OK\r\n" };
                t_insert(resp, "Connection: close\r\n");
+               t_insert(resp, "Content-Type: text/html\r\n");
                t_insert(resp, "Content-Length: ");
                t_insert(resp, #response);
                t_insert(resp, "\r\n\r\n");
@@ -88,9 +90,6 @@ local function call_callback(request, err)
                end
                
                callback = (request.server and request.server.handlers[base]) or default_handler;
-               if callback == default_handler then
-                       log("debug", "Default callback for this request (base: "..tostring(base)..")")
-               end
        end
        if callback then
                if err then
@@ -184,7 +183,7 @@ local function request_reader(request, data, startpos)
                
                request.url = url_parse(request.path);
                
-               log("debug", method.." request for "..tostring(request.path) .. " on port "..request.handler.serverport());
+               log("debug", method.." request for "..tostring(request.path) .. " on port "..request.handler:serverport());
                
                if request.onlystatus then
                        if not call_callback(request) then
@@ -202,7 +201,7 @@ end
 
 -- The default handler for requests
 default_handler = function (method, body, request)
-       log("debug", method.." request for "..tostring(request.path) .. " on port "..request.handler.serverport());
+       log("debug", method.." request for "..tostring(request.path) .. " on port "..request.handler:serverport());
        return { status = "404 Not Found", 
                        headers = { ["Content-Type"] = "text/html" },
                        body = "<html><head><title>Page Not Found</title></head><body>Not here :(</body></html>" };
@@ -211,8 +210,8 @@ end
 
 function new_request(handler)
        return { handler = handler, conn = handler.socket, 
-                       write = handler.write, state = "request", 
-                       server = http_servers[handler.serverport()],
+                       write = function (...) return handler:write(...); end, state = "request", 
+                       server = http_servers[handler:serverport()],
                        send = send_response,
                        destroy = destroy_request,
                        id = tostring{}:match("%x+$")
@@ -230,9 +229,9 @@ function destroy_request(request)
                else
                        log("debug", "Request has no destroy callback");
                end
-               request.handler.close()
+               request.handler:close()
                if request.conn then
-                       listener.disconnect(request.conn, "closed");
+                       listener.ondisconnect(request.handler, "closed");
                end
        end
 end
@@ -250,13 +249,27 @@ function new(params)
        end
 end
 
-function new_from_config(ports, default_base, handle_request)
+function set_default_handler(handler)
+       default_handler = handler;
+end
+
+function new_from_config(ports, handle_request, default_options)
+       if type(handle_request) == "string" then -- COMPAT with old plugins
+               log("warn", "Old syntax of httpserver.new_from_config being used to register %s", handle_request);
+               handle_request, default_options = default_options, { base = handle_request };
+       end
        for _, options in ipairs(ports) do
-               local port, base, ssl, interface = 5280, default_base, false, nil;
+               local port = default_options.port or 5280;
+               local base = default_options.base;
+               local ssl = default_options.ssl or false;
+               local interface = default_options.interface;
                if type(options) == "number" then
                        port = options;
                elseif type(options) == "table" then
-                       port, base, ssl, interface = options.port or 5280, options.path or default_base, options.ssl or false, options.interface;
+                       port = options.port or port;
+                       base = options.path or base;
+                       ssl = options.ssl or ssl;
+                       interface = options.interface or interface;
                elseif type(options) == "string" then
                        base = options;
                end
@@ -264,9 +277,12 @@ function new_from_config(ports, default_base, handle_request)
                if ssl then
                        ssl.mode = "server";
                        ssl.protocol = "sslv23";
+                       ssl.options = "no_sslv2";
                end
                
-               new{ port = port, base = base, handler = handle_request, ssl = ssl, type = (ssl and "ssl") or "tcp" }
+               new{ port = port, interface = interface, 
+                       base = base, handler = handle_request, 
+                       ssl = ssl, type = (ssl and "ssl") or "tcp" };
        end
 end