// SPDX-License-Identifier: GPL-2.0
-/* elmcan.c - ELM327 based CAN interface driver
- * (tty line discipline)
- *
- * This file is derived from linux/drivers/net/can/slcan.c
- *
- * elmcan.c Author : Max Staudt <max-linux@enpas.org>
- * slcan.c Author : Oliver Hartkopp <socketcan@hartkopp.net>
- * slip.c Authors : Laurence Culhane <loz@holmes.demon.co.uk>
- * Fred N. van Kempen <waltje@uwalt.nl.mugnet.org>
+/* ELM327 based CAN interface driver (tty line discipline)
*
+ * This driver started as a derivative of linux/drivers/net/can/slcan.c
+ * and my thanks go to the original authors for their inspiration, even
+ * after almost none of their code is left.
*/
#define pr_fmt(fmt) "[elmcan] " fmt
#include <linux/spinlock.h>
#include <linux/string.h>
#include <linux/tty.h>
+#include <linux/tty_ldisc.h>
#include <linux/version.h>
#include <linux/workqueue.h>
+#include <uapi/linux/tty.h>
+
#include <linux/can.h>
#include <linux/can/dev.h>
#include <linux/can/error.h>
static inline void elm327_hw_failure(struct elmcan *elm);
- /***********************************************************************
- * ELM327: Transmission *
- * *
- * (all functions assume elm->lock taken) *
- ***********************************************************************/
-
+/* Assumes elm->lock taken. */
static void elm327_send(struct elmcan *elm, const void *buf, size_t len)
{
int actual;
* We send ELM327_MAGIC_CHAR which will either abort any running
* operation, or be echoed back to us in case we're already in command
* mode.
+ *
+ * Assumes elm->lock taken.
*/
static void elm327_kick_into_cmd_mode(struct elmcan *elm)
{
}
}
-/* Schedule a CAN frame and necessary config changes to be sent to the TTY. */
+/* Schedule a CAN frame and necessary config changes to be sent to the TTY.
+ *
+ * Assumes elm->lock taken.
+ */
static void elm327_send_frame(struct elmcan *elm, struct can_frame *frame)
{
/* Schedule any necessary changes in ELM327's CAN configuration */
elm327_kick_into_cmd_mode(elm);
}
- /***********************************************************************
- * ELM327: Initialization sequence *
- * *
- * (assumes elm->lock taken) *
- ***********************************************************************/
-
+/* ELM327 initialization sequence.
+ *
+ * Assumes elm->lock taken.
+ */
static char *elm327_init_script[] = {
"AT WS\r", /* v1.0: Warm Start */
"AT PP FF OFF\r", /* v1.0: All Programmable Parameters Off */
elm327_kick_into_cmd_mode(elm);
}
- /***********************************************************************
- * ELM327: Reception -> netdev glue *
- * *
- * (assumes elm->lock taken) *
- ***********************************************************************/
-
+/* Assumes elm->lock taken. */
static void elm327_feed_frame_to_netdev(struct elmcan *elm,
const struct can_frame *frame)
{
#endif
}
- /***********************************************************************
- * ELM327: "Panic" handler *
- * *
- * (assumes elm->lock taken) *
- ***********************************************************************/
-
-/* Called when we're out of ideas and just want it all to end. */
+/* Called when we're out of ideas and just want it all to end.
+ * Assumes elm->lock taken.
+ */
static inline void elm327_hw_failure(struct elmcan *elm)
{
struct can_frame frame;
can_bus_off(elm->dev);
}
- /***********************************************************************
- * ELM327: Reception parser *
- * *
- * (assumes elm->lock taken) *
- ***********************************************************************/
-
+/* Assumes elm->lock taken. */
static void elm327_parse_error(struct elmcan *elm, int len)
{
struct can_frame frame;
* Instead of a payload, RTR indicates a remote request.
*
* We will use the spaces and line length to guess the format.
+ *
+ * Assumes elm->lock taken.
*/
static int elm327_parse_frame(struct elmcan *elm, int len)
{
return 0;
}
+/* Assumes elm->lock taken. */
static void elm327_parse_line(struct elmcan *elm, int len)
{
/* Skip empty lines */
}
}
+/* Assumes elm->lock taken. */
static void elm327_handle_prompt(struct elmcan *elm)
{
struct can_frame *frame = &elm->can_frame;
return (c & 0x3f) == ELM327_READY_CHAR;
}
+/* Assumes elm->lock taken. */
static void elm327_drop_bytes(struct elmcan *elm, int i)
{
memmove(&elm->rxbuf[0], &elm->rxbuf[i], ELM327_SIZE_RXBUF - i);
elm->rxfill -= i;
}
+/* Assumes elm->lock taken. */
static void elm327_parse_rxbuf(struct elmcan *elm)
{
int len;
}
}
- /***********************************************************************
- * netdev *
- * *
- * (takes elm->lock) *
- ***********************************************************************/
-
/* Dummy needed to use can_rx_offload */
static struct sk_buff *elmcan_mailbox_read(struct can_rx_offload *offload,
unsigned int n, u32 *timestamp,
bool drop)
{
- WARN_ON(1); /* This function is a dummy, so don't call it! */
+ WARN_ON_ONCE(1); /* This function is a dummy, so don't call it! */
return ERR_PTR(-ENOBUFS);
}
/* We shouldn't get here after a hardware fault:
* can_bus_off() calls netif_carrier_off()
*/
- WARN_ON(elm->hw_failure);
+ WARN_ON_ONCE(elm->hw_failure);
if (!elm->tty ||
elm->hw_failure ||
.ndo_change_mtu = can_change_mtu,
};
- /***********************************************************************
- * Line discipline *
- * *
- * (takes elm->lock) *
- ***********************************************************************/
-
/* Get a reference to our struct, taking into account locks/refcounts.
* This is to ensure ordering in case we are shutting down, and to ensure
* there is a refcount at all (otherwise tty->disc_data may be freed and
* This will not be re-entered while running, but other ldisc
* functions may be called in parallel.
*/
+#if LINUX_VERSION_CODE < KERNEL_VERSION(5,14,0)
static void elmcan_ldisc_rx(struct tty_struct *tty,
const unsigned char *cp, char *fp, int count)
+#else
+static void elmcan_ldisc_rx(struct tty_struct *tty,
+ const unsigned char *cp, const char *fp, int count)
+#endif
{
struct elmcan *elm = get_elm(tty);
/* Dummy needed to use bitrate_const */
static int elmcan_do_set_bittiming(struct net_device *netdev)
{
- (void)netdev;
-
return 0;
}
elm->can.do_set_bittiming = elmcan_do_set_bittiming;
elm->can.ctrlmode_supported = CAN_CTRLMODE_LISTENONLY;
- /* Configure netlink interface */
+ /* Configure netdev interface */
elm->dev = dev;
dev->netdev_ops = &elmcan_netdev_ops;
free_candev(elm->dev);
}
+#if LINUX_VERSION_CODE < KERNEL_VERSION(5,16,0)
static int elmcan_ldisc_hangup(struct tty_struct *tty)
+#else
+static void elmcan_ldisc_hangup(struct tty_struct *tty)
+#endif
{
elmcan_ldisc_close(tty);
+#if LINUX_VERSION_CODE < KERNEL_VERSION(5,16,0)
return 0;
+#endif
}
-static int elmcan_ldisc_ioctl(struct tty_struct *tty, struct file *file,
+static int elmcan_ldisc_ioctl(struct tty_struct *tty,
+#if LINUX_VERSION_CODE < KERNEL_VERSION(5,17,0)
+ struct file *file,
+#endif
unsigned int cmd, unsigned long arg)
{
struct elmcan *elm = get_elm(tty);
default:
put_elm(elm);
+#if LINUX_VERSION_CODE < KERNEL_VERSION(5,16,0)
return tty_mode_ioctl(tty, file, cmd, arg);
+#else
+ return tty_mode_ioctl(tty, cmd, arg);
+#endif
}
}
static struct tty_ldisc_ops elmcan_ldisc = {
.owner = THIS_MODULE,
.name = "elmcan",
+ .num = N_ELMCAN,
.receive_buf = elmcan_ldisc_rx,
.write_wakeup = elmcan_ldisc_tx_wakeup,
.open = elmcan_ldisc_open,
{
int status;
- pr_info("ELM327 based best-effort CAN interface driver\n");
- pr_info("This device is severely limited as a CAN interface, see documentation.\n");
-
+#if LINUX_VERSION_CODE < KERNEL_VERSION(5,14,0)
status = tty_register_ldisc(N_ELMCAN, &elmcan_ldisc);
+#else
+ status = tty_register_ldisc(&elmcan_ldisc);
+#endif
if (status)
pr_err("Can't register line discipline\n");
/* This will only be called when all channels have been closed by
* userspace - tty_ldisc.c takes care of the module's refcount.
*/
+#if LINUX_VERSION_CODE < KERNEL_VERSION(5,14,0)
int status;
status = tty_unregister_ldisc(N_ELMCAN);
if (status)
pr_err("Can't unregister line discipline (error: %d)\n",
status);
+#else
+ tty_unregister_ldisc(&elmcan_ldisc);
+#endif
}
module_init(elmcan_init);
projects / elmcan.git / blobdiff