stanza_router: Use stanza.attr.from's host instead of origin.host when routing stanza...
[prosody.git] / core / stanza_router.lua
index bbbb6385033c88604520972807d7f4dfa3b20df7..22064f3f2a0304e2f829a933d6e8f2f08f01abb3 100644 (file)
@@ -10,6 +10,8 @@
 
 local log = require "util.logger".init("stanzarouter")
 
+local hosts = _G.hosts;
+
 local st = require "util.stanza";
 local send_s2s = require "core.s2smanager".send_to_host;
 local user_exists = require "core.usermanager".user_exists;
@@ -18,15 +20,12 @@ local rostermanager = require "core.rostermanager";
 local sessionmanager = require "core.sessionmanager";
 local offlinemanager = require "core.offlinemanager";
 
-local s2s_verify_dialback = require "core.s2smanager".verify_dialback;
-local s2s_make_authenticated = require "core.s2smanager".make_authenticated;
-
 local modules_handle_stanza = require "core.modulemanager".handle_stanza;
 local component_handle_stanza = require "core.componentmanager".handle_stanza;
 
-local handle_outbound_presence_subscriptions_and_probes = require "core.presencemanager".handle_outbound_presence_subscriptions_and_probes;
-local handle_inbound_presence_subscriptions_and_probes = require "core.presencemanager".handle_inbound_presence_subscriptions_and_probes;
-local handle_normal_presence = require "core.presencemanager".handle_normal_presence;
+local handle_outbound_presence_subscriptions_and_probes = function()end;--require "core.presencemanager".handle_outbound_presence_subscriptions_and_probes;
+local handle_inbound_presence_subscriptions_and_probes = function()end;--require "core.presencemanager".handle_inbound_presence_subscriptions_and_probes;
+local handle_normal_presence = function()end;--require "core.presencemanager".handle_normal_presence;
 
 local format = string.format;
 local tostring = tostring;
@@ -40,18 +39,18 @@ local ipairs = ipairs;
 local jid_split = require "util.jid".split;
 local jid_prepped_split = require "util.jid".prepped_split;
 local print = print;
-local function checked_error_reply(origin, stanza)
-       if (stanza.attr.xmlns == "jabber:client" or stanza.attr.xmlns == "jabber:server") and stanza.attr.type ~= "error" and stanza.attr.type ~= "result" then
-               origin.send(st.error_reply(stanza, "cancel", "service-unavailable")); -- FIXME correct error?
-       end
-end
+local fire_event = prosody.events.fire_event;
+
+local select_best_resources;
 
 function core_process_stanza(origin, stanza)
        (origin.log or log)("debug", "Received[%s]: %s", origin.type, stanza:top_tag())
 
-       if not stanza.attr.xmlns then stanza.attr.xmlns = "jabber:client"; end -- FIXME Hack. This should be removed when we fix namespace handling.
+       -- Currently we guarantee every stanza to have an xmlns, should we keep this rule?
+       if not stanza.attr.xmlns then stanza.attr.xmlns = "jabber:client"; end
+       
        -- TODO verify validity of stanza (as well as JID validity)
-       if stanza.attr.xmlns == "error" and #stanza.tags == 0 then return; end -- TODO invalid stanza, log
+       if stanza.attr.type == "error" and #stanza.tags == 0 then return; end -- TODO invalid stanza, log
        if stanza.name == "iq" then
                if (stanza.attr.type == "set" or stanza.attr.type == "get") and #stanza.tags ~= 1 then
                        origin.send(st.error_reply(stanza, "modify", "bad-request"));
@@ -60,9 +59,10 @@ function core_process_stanza(origin, stanza)
        end
 
        if origin.type == "c2s" and not origin.full_jid
-               and not(stanza.name == "iq" and stanza.tags[1].name == "bind"
+               and not(stanza.name == "iq" and stanza.attr.type == "set" and stanza.tags[1] and stanza.tags[1].name == "bind"
                                and stanza.tags[1].attr.xmlns == "urn:ietf:params:xml:ns:xmpp-bind") then
-               error("Client MUST bind resource after auth");
+               -- authenticated client isn't bound and current stanza is not a bind request
+               origin.send(st.error_reply(stanza, "auth", "not-authorized")); -- FIXME maybe allow stanzas to account or server
        end
 
        -- TODO also, stanzas should be returned to their original state before the function ends
@@ -77,16 +77,25 @@ function core_process_stanza(origin, stanza)
        if to then
                node, host, resource = jid_prepped_split(to);
                if not host then
-                       error("Invalid to JID");
+                       log("warn", "Received stanza with invalid destination JID: %s", to);
+                       if stanza.attr.type ~= "error" and stanza.attr.type ~= "result" then
+                               origin.send(st.error_reply(stanza, "modify", "jid-malformed", "The destination address is invalid: "..to));
+                       end
+                       return;
                end
                to_bare = node and (node.."@"..host) or host; -- bare JID
                if resource then to = to_bare.."/"..resource; else to = to_bare; end
                stanza.attr.to = to;
        end
        if from then
+               -- We only stamp the 'from' on c2s stanzas, so we still need to check validity
                from_node, from_host, from_resource = jid_prepped_split(from);
                if not from_host then
-                       error("Invalid from JID");
+                       log("warn", "Received stanza with invalid source JID: %s", from);
+                       if stanza.attr.type ~= "error" and stanza.attr.type ~= "result" then
+                               origin.send(st.error_reply(stanza, "modify", "jid-malformed", "The source address is invalid: "..from));
+                       end
+                       return;
                end
                from_bare = from_node and (from_node.."@"..from_host) or from_host; -- bare JID
                if from_resource then from = from_bare.."/"..from_resource; else from = from_bare; end
@@ -98,69 +107,88 @@ function core_process_stanza(origin, stanza)
                return; -- FIXME what should we do here?
        end]] -- FIXME
 
-       -- FIXME do stanzas not of jabber:client get handled by components?
-       if (origin.type == "s2sin" or origin.type == "c2s" or origin.type == "component") and (not xmlns or xmlns == "jabber:server" or xmlns == "jabber:client") then                  
+       if (origin.type == "s2sin" or origin.type == "c2s" or origin.type == "component") and xmlns == "jabber:client" then
                if origin.type == "s2sin" and not origin.dummy then
                        local host_status = origin.hosts[from_host];
                        if not host_status or not host_status.authed then -- remote server trying to impersonate some other server?
-                               log("warn", "Received a stanza claiming to be from %s, over a conn authed for %s!", from_host, origin.from_host);
+                               log("warn", "Received a stanza claiming to be from %s, over a stream authed for %s!", from_host, origin.from_host);
                                return; -- FIXME what should we do here? does this work with subdomains?
                        end
                end
-               if origin.type == "c2s" and stanza.name == "presence" and to ~= nil and not(origin.roster[to_bare] and (origin.roster[to_bare].subscription == "both" or origin.roster[to_bare].subscription == "from")) then -- directed presence
-                       origin.directed = origin.directed or {};
-                       origin.directed[to] = true;
-                       --t_insert(origin.directed, to); -- FIXME does it make more sense to add to_bare rather than to?
+               core_post_stanza(origin, stanza);
+       else
+               local h = hosts[stanza.attr.to or origin.host or origin.to_host];
+               if h then
+                       local event;
+                       if stanza.attr.xmlns == "jabber:client" then
+                               if stanza.name == "iq" and (stanza.attr.type == "set" or stanza.attr.type == "get") then
+                                       event = "stanza/iq/"..stanza.tags[1].attr.xmlns..":"..stanza.tags[1].name;
+                               else
+                                       event = "stanza/"..stanza.name;
+                               end
+                       else
+                               event = "stanza/"..stanza.attr.xmlns..":"..stanza.name;
+                       end
+                       if h.events.fire_event(event, {origin = origin, stanza = stanza}) then return; end
                end
-               if not to then
-                       core_handle_stanza(origin, stanza);
-               elseif hosts[to] and hosts[to].type == "local" then -- directed at a local server
-                       core_handle_stanza(origin, stanza);
-               elseif stanza.attr.xmlns and stanza.attr.xmlns ~= "jabber:client" and stanza.attr.xmlns ~= "jabber:server" then
-                       modules_handle_stanza(host or origin.host or origin.to_host, origin, stanza);
-               elseif hosts[to] and hosts[to].type == "component" then -- hack to allow components to handle node@server/resource and server/resource
-                       component_handle_stanza(origin, stanza);
-               elseif hosts[to_bare] and hosts[to_bare].type == "component" then -- hack to allow components to handle node@server
-                       component_handle_stanza(origin, stanza);
-               elseif hosts[host] and hosts[host].type == "component" then -- directed at a component
-                       component_handle_stanza(origin, stanza);
-               elseif origin.type == "c2s" and stanza.name == "presence" and stanza.attr.type ~= nil and stanza.attr.type ~= "unavailable" then
-                       handle_outbound_presence_subscriptions_and_probes(origin, stanza, from_bare, to_bare, core_route_stanza);
-               elseif hosts[host] and hosts[host].type == "local" and stanza.name == "iq" and not resource then -- directed at bare JID
-                       core_handle_stanza(origin, stanza);
+               if host and not hosts[host] then host = nil; end -- workaround for a Pidgin bug which sets 'to' to the SRV result
+               modules_handle_stanza(host or origin.host or origin.to_host, origin, stanza);
+       end
+end
+
+function core_post_stanza(origin, stanza)
+       local to = stanza.attr.to;
+       local node, host, resource = jid_split(to);
+       local to_bare = node and (node.."@"..host) or host; -- bare JID
+
+       local to_type;
+       if node then
+               if resource then
+                       to_type = '/full';
                else
-                       core_route_stanza(origin, stanza);
+                       to_type = '/bare';
+                       if node == origin.username and host == origin.host then
+                               stanza.attr.to = nil;
+                       end
                end
        else
-               core_handle_stanza(origin, stanza);
+               if host then
+                       to_type = '/host';
+               else
+                       to_type = '/bare';
+               end
        end
-end
 
--- This function handles stanzas which are not routed any further,
--- that is, they are handled by this server
-function core_handle_stanza(origin, stanza)
-       -- Handlers
-       if modules_handle_stanza(select(2, jid_split(stanza.attr.to)) or origin.host, origin, stanza) then return; end
-       if origin.type == "c2s" or origin.type == "s2sin" then
-               if origin.type == "c2s" then
-                       if stanza.name == "presence" and origin.roster then
-                               if stanza.attr.type == nil or stanza.attr.type == "unavailable" then
-                                       handle_normal_presence(origin, stanza, core_route_stanza);
-                               else
-                                       log("warn", "Unhandled c2s presence: %s", tostring(stanza));
-                                       checked_error_reply(origin, stanza);
-                               end
-                       else
-                               log("warn", "Unhandled c2s stanza: %s", tostring(stanza));
-                               checked_error_reply(origin, stanza);
-                       end
-               else -- s2s stanzas
-                       log("warn", "Unhandled s2s stanza: %s", tostring(stanza));
-                       checked_error_reply(origin, stanza);
+       local event_data = {origin=origin, stanza=stanza};
+       if origin.full_jid then -- c2s connection
+               if hosts[origin.host].events.fire_event('pre-'..stanza.name..to_type, event_data) then return; end -- do preprocessing
+       end
+       local h = hosts[to_bare] or hosts[host or origin.host];
+       if h then
+               if h.type == "component" then
+                       component_handle_stanza(origin, stanza);
+                       return;
+               else
+                       if h.events.fire_event(stanza.name..to_type, event_data) then return; end -- do processing
                end
+       end
+
+       if host and fire_event(host.."/"..stanza.name, event_data) then
+               -- event handled
+       elseif stanza.name == "presence" and origin.host and fire_event(origin.host.."/"..stanza.name, event_data) then
+               -- event handled
+       elseif not to then
+               modules_handle_stanza(host or origin.host or origin.to_host, origin, stanza);
+       elseif hosts[to] and hosts[to].type == "local" then -- directed at a local server
+               modules_handle_stanza(host or origin.host or origin.to_host, origin, stanza);
+       elseif hosts[to_bare] and hosts[to_bare].type == "component" then -- hack to allow components to handle node@server
+               component_handle_stanza(origin, stanza);
+       elseif hosts[host] and hosts[host].type == "component" then -- directed at a component
+               component_handle_stanza(origin, stanza);
+       elseif hosts[host] and hosts[host].type == "local" and stanza.name == "iq" and not resource then -- directed at bare JID
+               modules_handle_stanza(host or origin.host or origin.to_host, origin, stanza);
        else
-               log("warn", "Unhandled %s stanza: %s", origin.type, tostring(stanza));
-               checked_error_reply(origin, stanza);
+               core_route_stanza(origin, stanza);
        end
 end
 
@@ -180,15 +208,13 @@ function core_route_stanza(origin, stanza)
        origin = origin or hosts[from_host];
        if not origin then return false; end
        
-       if hosts[to] and hosts[to].type == "component" then -- hack to allow components to handle node@server/resource and server/resource
-               return component_handle_stanza(origin, stanza);
-       elseif hosts[to_bare] and hosts[to_bare].type == "component" then -- hack to allow components to handle node@server
+       if hosts[to_bare] and hosts[to_bare].type == "component" then -- hack to allow components to handle node@server
                return component_handle_stanza(origin, stanza);
        elseif hosts[host] and hosts[host].type == "component" then -- directed at a component
                return component_handle_stanza(origin, stanza);
        end
 
-       if stanza.name == "presence" and (stanza.attr.type ~= nil and stanza.attr.type ~= "unavailable") then resource = nil; end
+       if stanza.name == "presence" and (stanza.attr.type ~= nil and stanza.attr.type ~= "unavailable" and stanza.attr.type ~= "error") then resource = nil; end
 
        local host_session = hosts[host]
        if host_session and host_session.type == "local" then
@@ -196,12 +222,14 @@ function core_route_stanza(origin, stanza)
                local user = host_session.sessions[node];
                if user then
                        local res = user.sessions[resource];
-                       if not res then
+                       if res then -- resource is online...
+                               res.send(stanza); -- Yay \o/
+                       else
                                -- if we get here, resource was not specified or was unavailable
                                if stanza.name == "presence" then
-                                       if stanza.attr.type ~= nil and stanza.attr.type ~= "unavailable" then
+                                       if stanza.attr.type ~= nil and stanza.attr.type ~= "unavailable" and stanza.attr.type ~= "error" then
                                                handle_inbound_presence_subscriptions_and_probes(origin, stanza, from_bare, to_bare, core_route_stanza);
-                                       else -- sender is available or unavailable
+                                       elseif not resource then -- sender is available or unavailable or error
                                                for _, session in pairs(user.sessions) do -- presence broadcast to all user resources.
                                                        if session.full_jid then -- FIXME should this be just for available resources? Do we need to check subscription?
                                                                stanza.attr.to = session.full_jid; -- reset at the end of function
@@ -217,25 +245,12 @@ function core_route_stanza(origin, stanza)
                                                                session.send(stanza);
                                                        end
                                                end
-                                       elseif resource and stanza.attr.type == 'groupchat' then
+                                       elseif stanza.attr.type == 'groupchat' then
                                                -- Groupchat message sent to offline resource
                                                origin.send(st.error_reply(stanza, "cancel", "service-unavailable"));
                                        else
-                                               local priority = 0;
-                                               local recipients = {};
-                                               for _, session in pairs(user.sessions) do -- find resource with greatest priority
-                                                       if session.presence then
-                                                               local p = session.priority;
-                                                               if p > priority then
-                                                                       priority = p;
-                                                                       recipients = {session};
-                                                               elseif p == priority then
-                                                                       t_insert(recipients, session);
-                                                               end
-                                                       end
-                                               end
                                                local count = 0;
-                                               for _, session in ipairs(recipients) do
+                                               for _, session in ipairs(select_best_resources(user)) do
                                                        session.send(stanza);
                                                        count = count + 1;
                                                end
@@ -244,19 +259,15 @@ function core_route_stanza(origin, stanza)
                                                        -- TODO deal with storage errors
                                                end
                                        end
-                               else
-                                       -- TODO send IQ error
+                               elseif stanza.attr.type == "get" or stanza.attr.type == "set" then
+                                       origin.send(st.error_reply(stanza, "cancel", "service-unavailable"));
                                end
-                       else
-                               -- User + resource is online...
-                               stanza.attr.to = res.full_jid; -- reset at the end of function
-                               res.send(stanza); -- Yay \o/
                        end
                else
                        -- user not online
                        if user_exists(node, host) then
                                if stanza.name == "presence" then
-                                       if stanza.attr.type ~= nil and stanza.attr.type ~= "unavailable" then
+                                       if stanza.attr.type ~= nil and stanza.attr.type ~= "unavailable" and stanza.attr.type ~= "error" then
                                                handle_inbound_presence_subscriptions_and_probes(origin, stanza, from_bare, to_bare, core_route_stanza);
                                        else
                                                -- TODO send unavailable presence or unsubscribed
@@ -299,10 +310,27 @@ function core_route_stanza(origin, stanza)
                stanza.attr.xmlns = xmlns; -- reset
        elseif origin.type == "component" or origin.type == "local" then
                -- Route via s2s for components and modules
-               log("debug", "Routing outgoing stanza for %s to %s", origin.host, host);
-               send_s2s(origin.host, host, stanza);
+               log("debug", "Routing outgoing stanza for %s to %s", from_host, host);
+               send_s2s(from_host, host, stanza);
        else
                log("warn", "received stanza from unhandled connection type: %s", origin.type);
        end
        stanza.attr.to = to; -- reset
 end
+
+function select_best_resources(user)
+       local priority = 0;
+       local recipients = {};
+       for _, session in pairs(user.sessions) do -- find resource with greatest priority
+               if session.presence then
+                       local p = session.priority;
+                       if p > priority then
+                               priority = p;
+                               recipients = {session};
+                       elseif p == priority then
+                               t_insert(recipients, session);
+                       end
+               end
+       end
+       return recipients;
+end