mod_s2s: Log certificate identity validation result
[prosody.git] / core / rostermanager.lua
index 516983a9dfcb934af9f0b8837bb42f7aa41180ea..5e06e3f7a4203ec5c82971f638f4b81322c9e74a 100644 (file)
@@ -1,6 +1,6 @@
 -- Prosody IM
--- Copyright (C) 2008-2009 Matthew Wild
--- Copyright (C) 2008-2009 Waqas Hussain
+-- Copyright (C) 2008-2010 Matthew Wild
+-- Copyright (C) 2008-2010 Waqas Hussain
 -- 
 -- This project is MIT/X11 licensed. Please see the
 -- COPYING file in the source package for more information.
 
 local log = require "util.logger".init("rostermanager");
 
-local setmetatable = setmetatable;
-local format = string.format;
-local loadfile, setfenv, pcall = loadfile, setfenv, pcall;
-local pairs, ipairs = pairs, ipairs;
+local pairs = pairs;
 local tostring = tostring;
 
 local hosts = hosts;
 local bare_sessions = bare_sessions;
 
 local datamanager = require "util.datamanager"
+local um_user_exists = require "core.usermanager".user_exists;
 local st = require "util.stanza";
 
 module "rostermanager"
@@ -83,29 +81,37 @@ end
 
 function load_roster(username, host)
        local jid = username.."@"..host;
-       log("debug", "load_roster: asked for: "..jid);
+       log("debug", "load_roster: asked for: %s", jid);
        local user = bare_sessions[jid];
        local roster;
        if user then
                roster = user.roster;
                if roster then return roster; end
-               log("debug", "load_roster: loading for new user: "..username.."@"..host);
+               log("debug", "load_roster: loading for new user: %s@%s", username, host);
        else -- Attempt to load roster for non-loaded user
-               log("debug", "load_roster: loading for offline user: "..username.."@"..host);
+               log("debug", "load_roster: loading for offline user: %s@%s", username, host);
        end
-       roster = datamanager.load(username, host, "roster") or {};
+       local data, err = datamanager.load(username, host, "roster");
+       roster = data or {};
        if user then user.roster = roster; end
-       if not roster[false] then roster[false] = { }; end
+       if not roster[false] then roster[false] = { broken = err or nil }; end
        if roster[jid] then
                roster[jid] = nil;
-               log("warn", "roster for "..jid.." has a self-contact");
+               log("warn", "roster for %s has a self-contact", jid);
        end
-       hosts[host].events.fire_event("roster-load", username, host, roster);
-       return roster;
+       if not err then
+               hosts[host].events.fire_event("roster-load", username, host, roster);
+       end
+       return roster, err;
 end
 
 function save_roster(username, host, roster)
-       log("debug", "save_roster: saving roster for "..username.."@"..host);
+       if not um_user_exists(username, host) then
+               log("debug", "not saving roster for %s@%s: the user doesn't exist", username, host);
+               return nil;
+       end
+
+       log("debug", "save_roster: saving roster for %s@%s", username, host);
        if not roster then
                roster = hosts[host] and hosts[host].sessions[username] and hosts[host].sessions[username].roster;
                --if not roster then
@@ -114,8 +120,15 @@ function save_roster(username, host, roster)
                --end
        end
        if roster then
-               if not roster[false] then roster[false] = {}; end
-               roster[false].version = (roster[false].version or 0) + 1;
+               local metadata = roster[false];
+               if not metadata then
+                       metadata = {};
+                       roster[false] = metadata;
+               end
+               if metadata.version ~= true then
+                       metadata.version = (metadata.version or 0) + 1;
+               end
+               if roster[false].broken then return nil, "Not saving broken roster" end
                return datamanager.store(username, host, "roster", roster);
        end
        log("warn", "save_roster: user had no roster to save");
@@ -180,10 +193,22 @@ function process_inbound_unsubscribe(username, host, jid)
        end
 end
 
+local function _get_online_roster_subscription(jidA, jidB)
+       local user = bare_sessions[jidA];
+       local item = user and (user.roster[jidB] or { subscription = "none" });
+       return item and item.subscription;
+end
 function is_contact_subscribed(username, host, jid)
-       local roster = load_roster(username, host);
+       do
+               local selfjid = username.."@"..host;
+               local subscription = _get_online_roster_subscription(selfjid, jid);
+               if subscription then return (subscription == "both" or subscription == "from"); end
+               local subscription = _get_online_roster_subscription(jid, selfjid);
+               if subscription then return (subscription == "both" or subscription == "to"); end
+       end
+       local roster, err = load_roster(username, host);
        local item = roster[jid];
-       return item and (item.subscription == "from" or item.subscription == "both");
+       return item and (item.subscription == "from" or item.subscription == "both"), err;
 end
 
 function is_contact_pending_in(username, host, jid)
@@ -216,7 +241,7 @@ function set_contact_pending_out(username, host, jid) -- subscribe
                roster[jid] = item;
        end
        item.ask = "subscribe";
-       log("debug", "set_contact_pending_out: saving roster; set "..username.."@"..host..".roster["..jid.."].ask=subscribe");
+       log("debug", "set_contact_pending_out: saving roster; set %s@%s.roster[%q].ask=subscribe", username, host, jid);
        return save_roster(username, host, roster);
 end
 function unsubscribe(username, host, jid)
@@ -256,23 +281,21 @@ function unsubscribed(username, host, jid)
        local roster = load_roster(username, host);
        local item = roster[jid];
        local pending = is_contact_pending_in(username, host, jid);
-       local changed = nil;
-       if is_contact_pending_in(username, host, jid) then
+       if pending then
                roster.pending[jid] = nil; -- TODO maybe delete roster.pending if empty?
-               changed = true;
        end
+       local subscribed;
        if item then
                if item.subscription == "from" then
                        item.subscription = "none";
-                       changed = true;
+                       subscribed = true;
                elseif item.subscription == "both" then
                        item.subscription = "to";
-                       changed = true;
+                       subscribed = true;
                end
        end
-       if changed then
-               return save_roster(username, host, roster);
-       end
+       local success = (pending or subscribed) and save_roster(username, host, roster);
+       return success, pending, subscribed;
 end
 
 function process_outbound_subscription_request(username, host, jid)