mod_bosh: Return true from send()

[prosody.git] / core / rostermanager.lua

diff --git a/core/rostermanager.lua b/core/rostermanager.lua
index a8eb806c8d1d589e4e3cc66cc85c2a84b56e3797..59ba6579a24af27fe78470de5473bb4ff1347698 100644 (file)
--- a/core/rostermanager.lua
+++ b/core/rostermanager.lua
@@ -96,12 +96,14 @@ function load_roster(username, host)
        local data, err = datamanager.load(username, host, "roster");
        roster = data or {};
        if user then user.roster = roster; end
-       if not roster[false] then roster[false] = { }; end
+       if not roster[false] then roster[false] = { broken = err or nil }; end
        if roster[jid] then
                roster[jid] = nil;
                log("warn", "roster for "..jid.." has a self-contact");
        end
-       hosts[host].events.fire_event("roster-load", username, host, roster);
+       if not err then
+               hosts[host].events.fire_event("roster-load", username, host, roster);
+       end
        return roster, err;
 end
 
@@ -123,6 +125,7 @@ function save_roster(username, host, roster)
                if metadata.version ~= true then
                        metadata.version = (metadata.version or 0) + 1;
                end
+               if roster[false].broken then return nil, "Not saving broken roster" end
                return datamanager.store(username, host, "roster", roster);
        end
        log("warn", "save_roster: user had no roster to save");
@@ -187,10 +190,22 @@ function process_inbound_unsubscribe(username, host, jid)
        end
 end
 
+local function _get_online_roster_subscription(jidA, jidB)
+       local user = bare_sessions[jidA];
+       local item = user and (user.roster[jidB] or { subscription = "none" });
+       return item and item.subscription;
+end
 function is_contact_subscribed(username, host, jid)
-       local roster = load_roster(username, host);
+       do
+               local selfjid = username.."@"..host;
+               local subscription = _get_online_roster_subscription(selfjid, jid);
+               if subscription then return (subscription == "both" or subscription == "from"); end
+               local subscription = _get_online_roster_subscription(jid, selfjid);
+               if subscription then return (subscription == "both" or subscription == "to"); end
+       end
+       local roster, err = load_roster(username, host);
        local item = roster[jid];
-       return item and (item.subscription == "from" or item.subscription == "both");
+       return item and (item.subscription == "from" or item.subscription == "both"), err;
 end
 
 function is_contact_pending_in(username, host, jid)