test_util_cache: remove unused argument c3 [luacheck]
[prosody.git] / core / rostermanager.lua
index b39e53230b2bb97c8ec14de1a819b149917df430..58d1f16e1c5bf67b8dd8eeeef01940a10ed443cf 100644 (file)
@@ -18,17 +18,19 @@ local type = type;
 local hosts = hosts;
 local bare_sessions = prosody.bare_sessions;
 
-local datamanager = require "util.datamanager"
 local um_user_exists = require "core.usermanager".user_exists;
 local st = require "util.stanza";
+local storagemanager = require "core.storagemanager";
 
-module "rostermanager"
+local _ENV = nil;
 
-function add_to_roster(session, jid, item)
+local save_roster; -- forward declaration
+
+local function add_to_roster(session, jid, item)
        if session.roster then
                local old_item = session.roster[jid];
                session.roster[jid] = item;
-               if save_roster(session.username, session.host) then
+               if save_roster(session.username, session.host, nil, jid) then
                        return true;
                else
                        session.roster[jid] = old_item;
@@ -39,11 +41,11 @@ function add_to_roster(session, jid, item)
        end
 end
 
-function remove_from_roster(session, jid)
+local function remove_from_roster(session, jid)
        if session.roster then
                local old_item = session.roster[jid];
                session.roster[jid] = nil;
-               if save_roster(session.username, session.host) then
+               if save_roster(session.username, session.host, nil, jid) then
                        return true;
                else
                        session.roster[jid] = old_item;
@@ -54,7 +56,7 @@ function remove_from_roster(session, jid)
        end
 end
 
-function roster_push(username, host, jid)
+local function roster_push(username, host, jid)
        local roster = jid and hosts[host] and hosts[host].sessions[username] and hosts[host].sessions[username].roster;
        if roster then
                local item = hosts[host].sessions[username].roster[jid];
@@ -73,7 +75,6 @@ function roster_push(username, host, jid)
                -- stanza ready
                for _, session in pairs(hosts[host].sessions[username].sessions) do
                        if session.interested then
-                               -- FIXME do we need to set stanza.attr.to?
                                session.send(stanza);
                        end
                end
@@ -86,17 +87,16 @@ local function roster_metadata(roster, err)
                metadata = { broken = err or nil };
                roster[false] = metadata;
        end
-       if not metadata.pending then
-               if roster.pending and not type(roster.pending.subscription) == "string" then
-                       metadata.pending, roster.pending = roster.pending, nil;
-               else
-                       metadata.pending = {};
-               end
+       if roster.pending and type(roster.pending.subscription) ~= "string" then
+               metadata.pending = roster.pending;
+               roster.pending = nil;
+       elseif not metadata.pending then
+               metadata.pending = {};
        end
        return metadata;
 end
 
-function load_roster(username, host)
+local function load_roster(username, host)
        local jid = username.."@"..host;
        log("debug", "load_roster: asked for: %s", jid);
        local user = bare_sessions[jid];
@@ -108,7 +108,8 @@ function load_roster(username, host)
        else -- Attempt to load roster for non-loaded user
                log("debug", "load_roster: loading for offline user: %s@%s", username, host);
        end
-       local data, err = datamanager.load(username, host, "roster");
+       local roster_store = storagemanager.open(host, "roster", "keyval");
+       local data, err = roster_store:get(username);
        roster = data or {};
        if user then user.roster = roster; end
        roster_metadata(roster, err);
@@ -122,13 +123,13 @@ function load_roster(username, host)
        return roster, err;
 end
 
-function save_roster(username, host, roster)
+function save_roster(username, host, roster, jid)
        if not um_user_exists(username, host) then
                log("debug", "not saving roster for %s@%s: the user doesn't exist", username, host);
                return nil;
        end
 
-       log("debug", "save_roster: saving roster for %s@%s", username, host);
+       log("debug", "save_roster: saving roster for %s@%s, (%s)", username, host, jid or "all contacts");
        if not roster then
                roster = hosts[host] and hosts[host].sessions[username] and hosts[host].sessions[username].roster;
                --if not roster then
@@ -142,13 +143,19 @@ function save_roster(username, host, roster)
                        metadata.version = (metadata.version or 0) + 1;
                end
                if metadata.broken then return nil, "Not saving broken roster" end
-               return datamanager.store(username, host, "roster", roster);
+               if jid == nil then
+                       local roster_store = storagemanager.open(host, "roster", "keyval");
+                       return roster_store:set(username, roster);
+               else
+                       local roster_store = storagemanager.open(host, "roster", "map");
+                       return roster_store:set_keys(username, { [false] = metadata, [jid] = roster[jid] or roster_store.remove });
+               end
        end
        log("warn", "save_roster: user had no roster to save");
        return nil;
 end
 
-function process_inbound_subscription_approval(username, host, jid)
+local function process_inbound_subscription_approval(username, host, jid)
        local roster = load_roster(username, host);
        local item = roster[jid];
        if item and item.ask then
@@ -158,11 +165,13 @@ function process_inbound_subscription_approval(username, host, jid)
                        item.subscription = "both";
                end
                item.ask = nil;
-               return save_roster(username, host, roster);
+               return save_roster(username, host, roster, jid);
        end
 end
 
-function process_inbound_subscription_cancellation(username, host, jid)
+local is_contact_pending_out -- forward declaration
+
+local function process_inbound_subscription_cancellation(username, host, jid)
        local roster = load_roster(username, host);
        local item = roster[jid];
        local changed = nil;
@@ -180,11 +189,13 @@ function process_inbound_subscription_cancellation(username, host, jid)
                end
        end
        if changed then
-               return save_roster(username, host, roster);
+               return save_roster(username, host, roster, jid);
        end
 end
 
-function process_inbound_unsubscribe(username, host, jid)
+local is_contact_pending_in -- forward declaration
+
+local function process_inbound_unsubscribe(username, host, jid)
        local roster = load_roster(username, host);
        local item = roster[jid];
        local changed = nil;
@@ -202,7 +213,7 @@ function process_inbound_unsubscribe(username, host, jid)
                end
        end
        if changed then
-               return save_roster(username, host, roster);
+               return save_roster(username, host, roster, jid);
        end
 end
 
@@ -211,13 +222,13 @@ local function _get_online_roster_subscription(jidA, jidB)
        local item = user and (user.roster[jidB] or { subscription = "none" });
        return item and item.subscription;
 end
-function is_contact_subscribed(username, host, jid)
+local function is_contact_subscribed(username, host, jid)
        do
                local selfjid = username.."@"..host;
-               local subscription = _get_online_roster_subscription(selfjid, jid);
-               if subscription then return (subscription == "both" or subscription == "from"); end
-               local subscription = _get_online_roster_subscription(jid, selfjid);
-               if subscription then return (subscription == "both" or subscription == "to"); end
+               local user_subscription = _get_online_roster_subscription(selfjid, jid);
+               if user_subscription then return (user_subscription == "both" or user_subscription == "from"); end
+               local contact_subscription = _get_online_roster_subscription(jid, selfjid);
+               if contact_subscription then return (contact_subscription == "both" or contact_subscription == "to"); end
        end
        local roster, err = load_roster(username, host);
        local item = roster[jid];
@@ -228,21 +239,21 @@ function is_contact_pending_in(username, host, jid)
        local roster = load_roster(username, host);
        return roster[false].pending[jid];
 end
-function set_contact_pending_in(username, host, jid)
+local function set_contact_pending_in(username, host, jid)
        local roster = load_roster(username, host);
        local item = roster[jid];
        if item and (item.subscription == "from" or item.subscription == "both") then
                return; -- false
        end
        roster[false].pending[jid] = true;
-       return save_roster(username, host, roster);
+       return save_roster(username, host, roster, jid);
 end
 function is_contact_pending_out(username, host, jid)
        local roster = load_roster(username, host);
        local item = roster[jid];
        return item and item.ask;
 end
-function set_contact_pending_out(username, host, jid) -- subscribe
+local function set_contact_pending_out(username, host, jid) -- subscribe
        local roster = load_roster(username, host);
        local item = roster[jid];
        if item and (item.ask or item.subscription == "to" or item.subscription == "both") then
@@ -254,9 +265,9 @@ function set_contact_pending_out(username, host, jid) -- subscribe
        end
        item.ask = "subscribe";
        log("debug", "set_contact_pending_out: saving roster; set %s@%s.roster[%q].ask=subscribe", username, host, jid);
-       return save_roster(username, host, roster);
+       return save_roster(username, host, roster, jid);
 end
-function unsubscribe(username, host, jid)
+local function unsubscribe(username, host, jid)
        local roster = load_roster(username, host);
        local item = roster[jid];
        if not item then return false; end
@@ -269,9 +280,9 @@ function unsubscribe(username, host, jid)
        elseif item.subscription == "to" then
                item.subscription = "none";
        end
-       return save_roster(username, host, roster);
+       return save_roster(username, host, roster, jid);
 end
-function subscribed(username, host, jid)
+local function subscribed(username, host, jid)
        if is_contact_pending_in(username, host, jid) then
                local roster = load_roster(username, host);
                local item = roster[jid];
@@ -285,36 +296,36 @@ function subscribed(username, host, jid)
                        item.subscription = "both";
                end
                roster[false].pending[jid] = nil;
-               return save_roster(username, host, roster);
+               return save_roster(username, host, roster, jid);
        end -- TODO else implement optional feature pre-approval (ask = subscribed)
 end
-function unsubscribed(username, host, jid)
+local function unsubscribed(username, host, jid)
        local roster = load_roster(username, host);
        local item = roster[jid];
        local pending = is_contact_pending_in(username, host, jid);
        if pending then
                roster[false].pending[jid] = nil;
        end
-       local subscribed;
+       local is_subscribed;
        if item then
                if item.subscription == "from" then
                        item.subscription = "none";
-                       subscribed = true;
+                       is_subscribed = true;
                elseif item.subscription == "both" then
                        item.subscription = "to";
-                       subscribed = true;
+                       is_subscribed = true;
                end
        end
-       local success = (pending or subscribed) and save_roster(username, host, roster);
+       local success = (pending or is_subscribed) and save_roster(username, host, roster, jid);
        return success, pending, subscribed;
 end
 
-function process_outbound_subscription_request(username, host, jid)
+local function process_outbound_subscription_request(username, host, jid)
        local roster = load_roster(username, host);
        local item = roster[jid];
        if item and (item.subscription == "none" or item.subscription == "from") then
                item.ask = "subscribe";
-               return save_roster(username, host, roster);
+               return save_roster(username, host, roster, jid);
        end
 end
 
@@ -329,4 +340,22 @@ end]]
 
 
 
-return _M;
+return {
+       add_to_roster = add_to_roster;
+       remove_from_roster = remove_from_roster;
+       roster_push = roster_push;
+       load_roster = load_roster;
+       save_roster = save_roster;
+       process_inbound_subscription_approval = process_inbound_subscription_approval;
+       process_inbound_subscription_cancellation = process_inbound_subscription_cancellation;
+       process_inbound_unsubscribe = process_inbound_unsubscribe;
+       is_contact_subscribed = is_contact_subscribed;
+       is_contact_pending_in = is_contact_pending_in;
+       set_contact_pending_in = set_contact_pending_in;
+       is_contact_pending_out = is_contact_pending_out;
+       set_contact_pending_out = set_contact_pending_out;
+       unsubscribe = unsubscribe;
+       subscribed = subscribed;
+       unsubscribed = unsubscribed;
+       process_outbound_subscription_request = process_outbound_subscription_request;
+};