target/linux/sunxi/patches-3.13/114-clk-sunxi-clean-magic-number.patch

   1 From 33574f94b0d4d8bc8af732fbcb4f911c3dd8c96b Mon Sep 17 00:00:00 2001
   2 From: =?UTF-8?q?Emilio=20L=C3=B3pez?= <emilio@elopez.com.ar>
   3 Date: Mon, 23 Dec 2013 00:32:33 -0300
   4 Subject: [PATCH] clk: sunxi: clean the magic number of mux parents
   5 MIME-Version: 1.0
   6 Content-Type: text/plain; charset=UTF-8
   7 Content-Transfer-Encoding: 8bit
   8
   9 This was pointed out during the review of the factor patches. Let's
  10 indicate what does that magic 5 mean.
  11
  12 Signed-off-by: Emilio López <emilio@elopez.com.ar>
  13 ---
  14  drivers/clk/sunxi/clk-sunxi.c | 5 +++--
  15  1 file changed, 3 insertions(+), 2 deletions(-)
  16
  17 diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
  18 index 7dc39a6..25ebba8 100644
  19 --- a/drivers/clk/sunxi/clk-sunxi.c
  20 +++ b/drivers/clk/sunxi/clk-sunxi.c
  21 @@ -420,13 +420,14 @@ static void __init sunxi_mux_clk_setup(struct device_node *node,
  22  {
  23         struct clk *clk;
  24         const char *clk_name = node->name;
  25 -       const char *parents[5];
  26 +       const char *parents[SUNXI_MAX_PARENTS];
  27         void *reg;
  28         int i = 0;
  29
  30         reg = of_iomap(node, 0);
  31
  32 -       while (i < 5 && (parents[i] = of_clk_get_parent_name(node, i)) != NULL)
  33 +       while (i < SUNXI_MAX_PARENTS &&
  34 +              (parents[i] = of_clk_get_parent_name(node, i)) != NULL)
  35                 i++;
  36
  37         clk = clk_register_mux(NULL, clk_name, parents, i,
  38 --
  39 1.8.5.1
  40