From: norly Date: Sat, 11 Jun 2022 13:02:37 +0000 (+0200) Subject: Remove CAN specific LED code X-Git-Url: https://git.enpas.org/?p=elmcan.git;a=commitdiff_plain;h=754388b00fa9ce9e0e258424e9a309b05b6fea51 Remove CAN specific LED code This is now handled by common netdev LED events instead: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=6c1e423a3c84953edcf91ff03ab97829b287184a --- diff --git a/module/can327.c b/module/can327.c index bd78bc7..7391e9d 100644 --- a/module/can327.c +++ b/module/can327.c @@ -35,7 +35,6 @@ #include #include #include -#include #include /* Line discipline ID number. @@ -825,7 +824,6 @@ static int can327_netdev_open(struct net_device *dev) can_rx_offload_enable(&elm->offload); - can_led_event(dev, CAN_LED_EVENT_OPEN); elm->can.state = CAN_STATE_ERROR_ACTIVE; netif_start_queue(dev); @@ -851,7 +849,6 @@ static int can327_netdev_close(struct net_device *dev) elm->can.state = CAN_STATE_STOPPED; can_rx_offload_del(&elm->offload); close_candev(dev); - can_led_event(dev, CAN_LED_EVENT_STOP); return 0; } @@ -892,8 +889,6 @@ static netdev_tx_t can327_netdev_start_xmit(struct sk_buff *skb, dev->stats.tx_packets++; dev->stats.tx_bytes += frame->len; - can_led_event(dev, CAN_LED_EVENT_TX); - out: kfree_skb(skb); return NETDEV_TX_OK; @@ -1105,8 +1100,6 @@ static int can327_ldisc_open(struct tty_struct *tty) elm->tty = tty; tty->disc_data = elm; - devm_can_led_init(elm->dev); - /* Let 'er rip */ err = register_candev(elm->dev); if (err) {