From: Kim Alvefur <zash@zash.se>
Date: Mon, 18 May 2015 19:43:24 +0000 (+0200)
Subject: mod_tls: Build <starttls/> as a stanza instead of with string concatenation
X-Git-Url: https://git.enpas.org/?a=commitdiff_plain;h=b47d6eb83295d2dbf8025d3685a49220ead14ec7;p=prosody.git

mod_tls: Build <starttls/> as a stanza instead of with string concatenation
---

diff --git a/plugins/mod_tls.lua b/plugins/mod_tls.lua
index f9d2cee9..85fa172a 100644
--- a/plugins/mod_tls.lua
+++ b/plugins/mod_tls.lua
@@ -21,6 +21,7 @@ end
 
 local xmlns_starttls = 'urn:ietf:params:xml:ns:xmpp-tls';
 local starttls_attr = { xmlns = xmlns_starttls };
+local starttls_initiate= st.stanza("starttls", starttls_attr);
 local starttls_proceed = st.stanza("proceed", starttls_attr);
 local starttls_failure = st.stanza("failure", starttls_attr);
 local c2s_feature = st.stanza("starttls", starttls_attr);
@@ -116,7 +117,7 @@ module:hook_stanza("http://etherx.jabber.org/streams", "features", function (ses
 	module:log("debug", "Received features element");
 	if can_do_tls(session) and stanza:get_child("starttls", xmlns_starttls) then
 		module:log("debug", "%s is offering TLS, taking up the offer...", session.to_host);
-		session.sends2s("<starttls xmlns='"..xmlns_starttls.."'/>");
+		session.sends2s(starttls_initiate);
 		return true;
 	end
 end, 500);