From: juhosg Date: Tue, 8 Jun 2010 20:18:05 +0000 (+0000) Subject: ip17xx: Fixed error handling in ip175c_set_val() X-Git-Tag: fast2504n-3.10.28-merged~11854 X-Git-Url: https://git.enpas.org/?a=commitdiff_plain;h=9e494614a15dd3b31cd36cf9d4163f23ff0d1995;p=openwrt.git ip17xx: Fixed error handling in ip175c_set_val() Upon error, ip175c_set_val() returned 0 instead of -EINVAL. Signed-off-by: Martin Mares Signed-off-by: Patrick Horn git-svn-id: svn://svn.openwrt.org/openwrt/trunk@21711 3c298f89-4303-0410-b956-a3cf2f4a3e73 --- diff --git a/target/linux/generic-2.6/files/drivers/net/phy/ip175c.c b/target/linux/generic-2.6/files/drivers/net/phy/ip175c.c index 00144e8864..8e1afcd7c2 100644 --- a/target/linux/generic-2.6/files/drivers/net/phy/ip175c.c +++ b/target/linux/generic-2.6/files/drivers/net/phy/ip175c.c @@ -947,7 +947,7 @@ static int ip175c_get_val(struct switch_dev *dev, const struct switch_attr *attr static int ip175c_set_val(struct switch_dev *dev, const struct switch_attr *attr, struct switch_val *val) { struct ip175c_state *state = dev->priv; - int myval, err = 0; + int myval, err = -EINVAL; myval = val->value.i; if (myval <= 0xffff && myval >= 0 && REG_SUPP(state->proc_mii)) {